[INFO] crate wellington 0.0.1 is already in cache [INFO] extracting crate wellington 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/wellington/0.0.1 [INFO] extracting crate wellington 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wellington/0.0.1 [INFO] validating manifest of wellington-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wellington-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wellington-0.0.1 [INFO] finished frobbing wellington-0.0.1 [INFO] frobbed toml for wellington-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/wellington/0.0.1/Cargo.toml [INFO] started frobbing wellington-0.0.1 [INFO] finished frobbing wellington-0.0.1 [INFO] frobbed toml for wellington-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wellington/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wellington-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wellington/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf884b3d4d47c737461bfc4f69d8d92e15058fda09f5a14d423d60bbd7551fff [INFO] running `"docker" "start" "-a" "cf884b3d4d47c737461bfc4f69d8d92e15058fda09f5a14d423d60bbd7551fff"` [INFO] [stderr] Compiling pest v2.1.0 [INFO] [stderr] Checking csv v1.0.5 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking wellington v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 79 | | if start { [INFO] [stderr] 80 | | Event::Start(Tag::Paragraph) [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | Event::End(Tag::Paragraph) [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if start { [INFO] [stderr] 79 | Event::Start(Tag::Paragraph) [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | Event::End(Tag::Paragraph) [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | return Err(BlogError::InitCoreData(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(BlogError::InitCoreData(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rss.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | Err(e) => { return Err(RSSError{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 176 | | msg: format!("Couldn't write to file: {}", e), [INFO] [stderr] 177 | | kind: ErrorKind::WriteError [INFO] [stderr] 178 | | })} [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 175 | Err(e) => { Err(RSSError{ [INFO] [stderr] 176 | msg: format!("Couldn't write to file: {}", e), [INFO] [stderr] 177 | kind: ErrorKind::WriteError [INFO] [stderr] 178 | })} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/parser.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | fn link_is_relative(link: &Cow) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | !(link.contains("://") || (link.chars().next() == Some('/'))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `link.starts_with('/')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | if self.remaining_text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.remaining_text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / match fs::write(&output_filename, rendered) { [INFO] [stderr] 120 | | Err(_) => { [INFO] [stderr] 121 | | return Err(BlogError::WriteError(output_filename)); [INFO] [stderr] 122 | | }, [INFO] [stderr] 123 | | _ => () [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let Err(_) = fs::write(&output_filename, rendered) { [INFO] [stderr] 120 | return Err(BlogError::WriteError(output_filename)); [INFO] [stderr] 121 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 79 | | if start { [INFO] [stderr] 80 | | Event::Start(Tag::Paragraph) [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | Event::End(Tag::Paragraph) [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if start { [INFO] [stderr] 79 | Event::Start(Tag::Paragraph) [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | Event::End(Tag::Paragraph) [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/toc.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | return Err(BlogError::InitCoreData(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(BlogError::InitCoreData(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rss.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | Err(e) => { return Err(RSSError{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 176 | | msg: format!("Couldn't write to file: {}", e), [INFO] [stderr] 177 | | kind: ErrorKind::WriteError [INFO] [stderr] 178 | | })} [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 175 | Err(e) => { Err(RSSError{ [INFO] [stderr] 176 | msg: format!("Couldn't write to file: {}", e), [INFO] [stderr] 177 | kind: ErrorKind::WriteError [INFO] [stderr] 178 | })} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | / match self.validate_templates() { [INFO] [stderr] 298 | | Err(e) => { [INFO] [stderr] 299 | | return Err(BlogError::InitTemplate(e)); [INFO] [stderr] 300 | | }, [INFO] [stderr] 301 | | _ => () [INFO] [stderr] 302 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 297 | if let Err(e) = self.validate_templates() { [INFO] [stderr] 298 | return Err(BlogError::InitTemplate(e)); [INFO] [stderr] 299 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | match &post { Some(s) => self.install_template(s, PATH_POST)?, _ => () }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Some(s) = &post { self.install_template(s, PATH_POST)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | match &index { Some(s) => self.install_template(s, PATH_INDEX)?, _ => () }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Some(s) = &index { self.install_template(s, PATH_INDEX)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/templates.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | fn as_date(h: &Helper, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/templates.rs:148:35 [INFO] [stderr] | [INFO] [stderr] 148 | let post_path = path_post.unwrap_or(PATH_POST.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PATH_POST.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/templates.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | let index_path = path_index.unwrap_or(PATH_INDEX.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PATH_INDEX.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/parser.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | fn link_is_relative(link: &Cow) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | !(link.contains("://") || (link.chars().next() == Some('/'))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `link.starts_with('/')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | if self.remaining_text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.remaining_text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / match fs::write(&output_filename, rendered) { [INFO] [stderr] 120 | | Err(_) => { [INFO] [stderr] 121 | | return Err(BlogError::WriteError(output_filename)); [INFO] [stderr] 122 | | }, [INFO] [stderr] 123 | | _ => () [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let Err(_) = fs::write(&output_filename, rendered) { [INFO] [stderr] 120 | return Err(BlogError::WriteError(output_filename)); [INFO] [stderr] 121 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | / match self.validate_templates() { [INFO] [stderr] 298 | | Err(e) => { [INFO] [stderr] 299 | | return Err(BlogError::InitTemplate(e)); [INFO] [stderr] 300 | | }, [INFO] [stderr] 301 | | _ => () [INFO] [stderr] 302 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 297 | if let Err(e) = self.validate_templates() { [INFO] [stderr] 298 | return Err(BlogError::InitTemplate(e)); [INFO] [stderr] 299 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | match &post { Some(s) => self.install_template(s, PATH_POST)?, _ => () }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Some(s) = &post { self.install_template(s, PATH_POST)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | match &index { Some(s) => self.install_template(s, PATH_INDEX)?, _ => () }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `if let Some(s) = &index { self.install_template(s, PATH_INDEX)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/toc.rs:524:9 [INFO] [stderr] | [INFO] [stderr] 524 | / match fs::create_dir(&temp_dir) { [INFO] [stderr] 525 | | Err(_) => { [INFO] [stderr] 526 | | println!("Failed to create dir! Temp_dir: {}", [INFO] [stderr] 527 | | temp_dir.to_str().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 530 | | _ => () [INFO] [stderr] 531 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 524 | if let Err(_) = fs::create_dir(&temp_dir) { [INFO] [stderr] 525 | println!("Failed to create dir! Temp_dir: {}", [INFO] [stderr] 526 | temp_dir.to_str().unwrap()); [INFO] [stderr] 527 | assert!(false); [INFO] [stderr] 528 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/toc.rs:662:30 [INFO] [stderr] | [INFO] [stderr] 662 | assert_eq!(rendered, format!("{}", title)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `title.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/templates.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | fn as_date(h: &Helper, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/templates.rs:148:35 [INFO] [stderr] | [INFO] [stderr] 148 | let post_path = path_post.unwrap_or(PATH_POST.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PATH_POST.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/templates.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | let index_path = path_index.unwrap_or(PATH_INDEX.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PATH_INDEX.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.39s [INFO] running `"docker" "inspect" "cf884b3d4d47c737461bfc4f69d8d92e15058fda09f5a14d423d60bbd7551fff"` [INFO] running `"docker" "rm" "-f" "cf884b3d4d47c737461bfc4f69d8d92e15058fda09f5a14d423d60bbd7551fff"` [INFO] [stdout] cf884b3d4d47c737461bfc4f69d8d92e15058fda09f5a14d423d60bbd7551fff