[INFO] crate welle 0.1.0 is already in cache [INFO] extracting crate welle 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/welle/0.1.0 [INFO] extracting crate welle 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/welle/0.1.0 [INFO] validating manifest of welle-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of welle-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing welle-0.1.0 [INFO] finished frobbing welle-0.1.0 [INFO] frobbed toml for welle-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/welle/0.1.0/Cargo.toml [INFO] started frobbing welle-0.1.0 [INFO] finished frobbing welle-0.1.0 [INFO] frobbed toml for welle-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/welle/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting welle-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/welle/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 58dba0aa0f8daedb8ece6cdaff6ec3f16e6aa47c3d581bfe557581668efba7e6 [INFO] running `"docker" "start" "-a" "58dba0aa0f8daedb8ece6cdaff6ec3f16e6aa47c3d581bfe557581668efba7e6"` [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking welle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | let requests = (0..request_count) [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0..request_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / writeln!( [INFO] [stderr] 215 | | f, [INFO] [stderr] 216 | | "Percentage of the requests served within a certain time:" [INFO] [stderr] 217 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | fn percenteil(durations: &Vec, percentage: f64) -> Duration { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Duration]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:239:8 [INFO] [stderr] | [INFO] [stderr] 239 | if i != ceil { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(i - ceil).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:239:8 [INFO] [stderr] | [INFO] [stderr] 239 | if i != ceil { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `welle`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | let requests = (0..request_count) [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0..request_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / writeln!( [INFO] [stderr] 215 | | f, [INFO] [stderr] 216 | | "Percentage of the requests served within a certain time:" [INFO] [stderr] 217 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | fn percenteil(durations: &Vec, percentage: f64) -> Duration { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Duration]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:239:8 [INFO] [stderr] | [INFO] [stderr] 239 | if i != ceil { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(i - ceil).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:239:8 [INFO] [stderr] | [INFO] [stderr] 239 | if i != ceil { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `welle`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "58dba0aa0f8daedb8ece6cdaff6ec3f16e6aa47c3d581bfe557581668efba7e6"` [INFO] running `"docker" "rm" "-f" "58dba0aa0f8daedb8ece6cdaff6ec3f16e6aa47c3d581bfe557581668efba7e6"` [INFO] [stdout] 58dba0aa0f8daedb8ece6cdaff6ec3f16e6aa47c3d581bfe557581668efba7e6