[INFO] crate weft_derive 0.1.0 is already in cache [INFO] extracting crate weft_derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/weft_derive/0.1.0 [INFO] extracting crate weft_derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/weft_derive/0.1.0 [INFO] validating manifest of weft_derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of weft_derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing weft_derive-0.1.0 [INFO] finished frobbing weft_derive-0.1.0 [INFO] frobbed toml for weft_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/weft_derive/0.1.0/Cargo.toml [INFO] started frobbing weft_derive-0.1.0 [INFO] finished frobbing weft_derive-0.1.0 [INFO] frobbed toml for weft_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/weft_derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting weft_derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/weft_derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46c5368ee364d8f1e968cedfd6391e04be6f2ef364b3c993f84a31192b5e9752 [INFO] running `"docker" "start" "-a" "46c5368ee364d8f1e968cedfd6391e04be6f2ef364b3c993f84a31192b5e9752"` [INFO] [stderr] Checking utf-8 v0.7.5 [INFO] [stderr] Checking phf_shared v0.7.24 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Checking tendril v0.4.1 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling serde_json v1.0.37 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling html5ever v0.22.5 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Checking weft_derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/inline_parse.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if previous.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!previous.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/inline_parse.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | if remainder.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remainder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / match node.data { [INFO] [stderr] 100 | | NodeData::Element { ref name, .. } => { [INFO] [stderr] 101 | | if name == &root_name { [INFO] [stderr] 102 | | return Some(node.children.borrow().clone()); [INFO] [stderr] ... | [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let NodeData::Element { ref name, .. } = node.data { [INFO] [stderr] 100 | if name == &root_name { [INFO] [stderr] 101 | return Some(node.children.borrow().clone()); [INFO] [stderr] 102 | } [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/inline_parse.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if previous.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!previous.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/inline_parse.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | if remainder.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remainder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / match node.data { [INFO] [stderr] 100 | | NodeData::Element { ref name, .. } => { [INFO] [stderr] 101 | | if name == &root_name { [INFO] [stderr] 102 | | return Some(node.children.borrow().clone()); [INFO] [stderr] ... | [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let NodeData::Element { ref name, .. } = node.data { [INFO] [stderr] 100 | if name == &root_name { [INFO] [stderr] 101 | return Some(node.children.borrow().clone()); [INFO] [stderr] 102 | } [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "46c5368ee364d8f1e968cedfd6391e04be6f2ef364b3c993f84a31192b5e9752"` [INFO] running `"docker" "rm" "-f" "46c5368ee364d8f1e968cedfd6391e04be6f2ef364b3c993f84a31192b5e9752"` [INFO] [stdout] 46c5368ee364d8f1e968cedfd6391e04be6f2ef364b3c993f84a31192b5e9752