[INFO] crate websocket 0.21.1 is already in cache [INFO] extracting crate websocket 0.21.1 into work/ex/clippy-test-run/sources/stable/reg/websocket/0.21.1 [INFO] extracting crate websocket 0.21.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/websocket/0.21.1 [INFO] validating manifest of websocket-0.21.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of websocket-0.21.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing websocket-0.21.1 [INFO] finished frobbing websocket-0.21.1 [INFO] frobbed toml for websocket-0.21.1 written to work/ex/clippy-test-run/sources/stable/reg/websocket/0.21.1/Cargo.toml [INFO] started frobbing websocket-0.21.1 [INFO] finished frobbing websocket-0.21.1 [INFO] frobbed toml for websocket-0.21.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/websocket/0.21.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting websocket-0.21.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/websocket/0.21.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9357c8ffca56978ecf11ca8067d99b7da61a7d397786bf93c2b11fcb645b24a3 [INFO] running `"docker" "start" "-a" "9357c8ffca56978ecf11ca8067d99b7da61a7d397786bf93c2b11fcb645b24a3"` [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking websocket v0.21.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `write_with_newline` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:8 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::write_with_newline` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_ref_pats` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:45 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::match_ref_pats` [INFO] [stderr] [INFO] [stderr] warning: lint name `write_with_newline` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:8 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::write_with_newline` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_ref_pats` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:45 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::match_ref_pats` [INFO] [stderr] [INFO] [stderr] warning: lint name `write_with_newline` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:8 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::write_with_newline` [INFO] [stderr] [INFO] [stderr] warning: lint name `write_with_newline` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:5:8 [INFO] [stderr] | [INFO] [stderr] 5 | allow(write_with_newline, type_complexity, match_ref_pats) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::write_with_newline` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dataframe.rs:175:44 [INFO] [stderr] | [INFO] [stderr] 175 | #[cfg_attr(feature = "cargo-clippy", warn(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/message.rs:123:45 [INFO] [stderr] | [INFO] [stderr] 123 | #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/builder.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | #[cfg_attr(feature = "cargo-clippy", warn(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dataframe.rs:175:44 [INFO] [stderr] | [INFO] [stderr] 175 | #[cfg_attr(feature = "cargo-clippy", warn(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/message.rs:123:45 [INFO] [stderr] | [INFO] [stderr] 123 | #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/builder.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | #[cfg_attr(feature = "cargo-clippy", warn(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/builder.rs:51:10 [INFO] [stderr] | [INFO] [stderr] 51 | pub use tokio_io::codec::Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/async.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | pub use tokio_io::codec::Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/async.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | pub type Client = Framed>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | use tokio_io::codec::{Framed, FramedParts}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/builder.rs:788:18 [INFO] [stderr] | [INFO] [stderr] 788 | let client = Framed::from_parts(stream.into_parts(), codec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | let duplex = Framed::from_parts( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | let client = Framed::from_parts(s.into_parts(), codec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:121:34 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn reject(self) -> SinkSend> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:129:58 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn reject_with(self, headers: &Headers) -> SinkSend> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | ) -> SinkSend> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | let duplex = Framed::from_parts( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/builder.rs:51:10 [INFO] [stderr] | [INFO] [stderr] 51 | pub use tokio_io::codec::Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/async.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | pub use tokio_io::codec::Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/async.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | pub type Client = Framed>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | use tokio_io::codec::{Framed, FramedParts}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client/builder.rs:788:18 [INFO] [stderr] | [INFO] [stderr] 788 | let client = Framed::from_parts(stream.into_parts(), codec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | let duplex = Framed::from_parts( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | let client = Framed::from_parts(s.into_parts(), codec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:121:34 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn reject(self) -> SinkSend> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:129:58 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn reject_with(self, headers: &Headers) -> SinkSend> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | ) -> SinkSend> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/server/upgrade/async.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | let duplex = Framed::from_parts( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/client/builder.rs:764:23 [INFO] [stderr] | [INFO] [stderr] 764 | let framed = stream.framed(::codec::http::HttpClientCodec); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/codec/http.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | .framed(HttpClientCodec) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/codec/http.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | .framed(HttpServerCodec) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/server/upgrade/async.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | .framed(HttpServerCodec) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/codec/ws.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | .framed(MessageCodec::new(Context::Client)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/codec/ws.rs:393:7 [INFO] [stderr] | [INFO] [stderr] 393 | .framed(MessageCodec::default(Context::Server)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/codec/ws.rs:413:5 [INFO] [stderr] | [INFO] [stderr] 413 | .framed(MessageCodec::new(Context::Server)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/client/builder.rs:764:23 [INFO] [stderr] | [INFO] [stderr] 764 | let framed = stream.framed(::codec::http::HttpClientCodec); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/server/upgrade/async.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | .framed(HttpServerCodec) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/server/sync.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | _ => panic!("unexpected error {}"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/hyper.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | const HTML: &'static str = include_str!("websockets.html"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> examples/async-autobahn-client.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | for case_id in 1..(case_count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=case_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/async-autobahn-client.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | .map(|s| Loop::Continue(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Loop::Continue` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/async-autobahn-client.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | .map(|s| Loop::Continue(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Loop::Continue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/async-autobahn-client.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | .map(|s| Loop::Continue(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Loop::Continue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'websocket::client::async::Framed': Moved to tokio-codec [INFO] [stderr] --> examples/parallel-server.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | type SinkContent = websocket::client::async::Framed< [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | tokio_core::net::TcpStream, [INFO] [stderr] 149 | | websocket::async::MessageCodec, [INFO] [stderr] 150 | | >; [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/ssl-client.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const CONNECTION: &'static str = "wss://echo.websocket.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/async-client.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const CONNECTION: &'static str = "ws://127.0.0.1:2794"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/client.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const CONNECTION: &'static str = "ws://127.0.0.1:2794"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/client.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | match message { [INFO] [stderr] | _____________^ [INFO] [stderr] 40 | | OwnedMessage::Close(_) => { [INFO] [stderr] 41 | | let _ = sender.send_message(&message); [INFO] [stderr] 42 | | // If it's a close message, just send it and then return. [INFO] [stderr] ... | [INFO] [stderr] 45 | | _ => (), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | if let OwnedMessage::Close(_) = message { [INFO] [stderr] 40 | let _ = sender.send_message(&message); [INFO] [stderr] 41 | // If it's a close message, just send it and then return. [INFO] [stderr] 42 | return; [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.20s [INFO] running `"docker" "inspect" "9357c8ffca56978ecf11ca8067d99b7da61a7d397786bf93c2b11fcb645b24a3"` [INFO] running `"docker" "rm" "-f" "9357c8ffca56978ecf11ca8067d99b7da61a7d397786bf93c2b11fcb645b24a3"` [INFO] [stdout] 9357c8ffca56978ecf11ca8067d99b7da61a7d397786bf93c2b11fcb645b24a3