[INFO] crate websession 0.8.2 is already in cache
[INFO] extracting crate websession 0.8.2 into work/ex/clippy-test-run/sources/stable/reg/websession/0.8.2
[INFO] extracting crate websession 0.8.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/websession/0.8.2
[INFO] validating manifest of websession-0.8.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of websession-0.8.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing websession-0.8.2
[INFO] finished frobbing websession-0.8.2
[INFO] frobbed toml for websession-0.8.2 written to work/ex/clippy-test-run/sources/stable/reg/websession/0.8.2/Cargo.toml
[INFO] started frobbing websession-0.8.2
[INFO] finished frobbing websession-0.8.2
[INFO] frobbed toml for websession-0.8.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/websession/0.8.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting websession-0.8.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/websession/0.8.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 490355a7dfbeec4e380a22e7f9f9073b1a05c4f22bfb7b508c85fd7ab95465af
[INFO] running `"docker" "start" "-a" "490355a7dfbeec4e380a22e7f9f9073b1a05c4f22bfb7b508c85fd7ab95465af"`
[INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other binary targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a binary target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/src/bin/simple.rs
[INFO] [stderr] * /opt/crater/workdir/src/bin/emit_pwhashes.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autobins = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr]     Checking rpassword v2.1.0
[INFO] [stderr]     Checking fs2 v0.4.3
[INFO] [stderr]     Checking rust-crypto v0.2.36
[INFO] [stderr]     Checking pwhash v0.2.0
[INFO] [stderr]     Checking websession v0.8.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/sessions.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             expiration: expiration,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expiration`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/sessions.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             policy: policy,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `policy`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             backing_store: backing_store,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backing_store`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/sessions.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             expiration: expiration,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expiration`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/sessions.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             policy: policy,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `policy`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             backing_store: backing_store,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backing_store`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/backingstore.rs:395:13
[INFO] [stderr]     |
[INFO] [stderr] 395 | /             if v.len() > 1 {
[INFO] [stderr] 396 | |                 if v[0] == fixeduser {
[INFO] [stderr] 397 | |                     return match FileBackingStore::hash_is_locked(v[1]) {
[INFO] [stderr] 398 | |                         true => Err(BackingStoreError::Locked),
[INFO] [stderr] ...   |
[INFO] [stderr] 401 | |                 }
[INFO] [stderr] 402 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 395 |             if v.len() > 1 && v[0] == fixeduser {
[INFO] [stderr] 396 |     return match FileBackingStore::hash_is_locked(v[1]) {
[INFO] [stderr] 397 |         true => Err(BackingStoreError::Locked),
[INFO] [stderr] 398 |         false => Ok(true),
[INFO] [stderr] 399 |     };
[INFO] [stderr] 400 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/backingstore.rs:124:35
[INFO] [stderr]     |
[INFO] [stderr] 124 |         self.users_iter().map(|v| v.map(|u| u.clone()).collect())
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/backingstore.rs:395:13
[INFO] [stderr]     |
[INFO] [stderr] 395 | /             if v.len() > 1 {
[INFO] [stderr] 396 | |                 if v[0] == fixeduser {
[INFO] [stderr] 397 | |                     return match FileBackingStore::hash_is_locked(v[1]) {
[INFO] [stderr] 398 | |                         true => Err(BackingStoreError::Locked),
[INFO] [stderr] ...   |
[INFO] [stderr] 401 | |                 }
[INFO] [stderr] 402 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 395 |             if v.len() > 1 && v[0] == fixeduser {
[INFO] [stderr] 396 |     return match FileBackingStore::hash_is_locked(v[1]) {
[INFO] [stderr] 397 |         true => Err(BackingStoreError::Locked),
[INFO] [stderr] 398 |         false => Ok(true),
[INFO] [stderr] 399 |     };
[INFO] [stderr] 400 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/backingstore.rs:196:26
[INFO] [stderr]     |
[INFO] [stderr] 196 |         hash.starts_with("!")
[INFO] [stderr]     |                          ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/backingstore.rs:256:13
[INFO] [stderr]     |
[INFO] [stderr] 256 |             backupf.write(all.as_bytes())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/backingstore.rs:381:16
[INFO] [stderr]     |
[INFO] [stderr] 381 |             if v.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/backingstore.rs:397:28
[INFO] [stderr]     |
[INFO] [stderr] 397 |                       return match FileBackingStore::hash_is_locked(v[1]) {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 398 | |                         true => Err(BackingStoreError::Locked),
[INFO] [stderr] 399 | |                         false => Ok(true),
[INFO] [stderr] 400 | |                     };
[INFO] [stderr]     | |_____________________^ help: consider using an if/else expression: `if FileBackingStore::hash_is_locked(v[1]) { Err(BackingStoreError::Locked) } else { Ok(true) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backingstore::MemoryBackingStore`
[INFO] [stderr]    --> src/backingstore.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     pub fn new() -> MemoryBackingStore {
[INFO] [stderr] 424 | |         MemoryBackingStore {
[INFO] [stderr] 425 | |             users: Mutex::new(HashMap::new()),
[INFO] [stderr] 426 | |         }
[INFO] [stderr] 427 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 417 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/backingstore.rs:477:28
[INFO] [stderr]     |
[INFO] [stderr] 477 |               Some(entry) => match entry.locked {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 478 | |                 true => Err(BackingStoreError::Locked),
[INFO] [stderr] 479 | |                 false => {
[INFO] [stderr] 480 | |                     entry.credentials = enc_cred.to_string();
[INFO] [stderr] 481 | |                     Ok(())
[INFO] [stderr] 482 | |                 },
[INFO] [stderr] 483 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 477 |             Some(entry) => if entry.locked { Err(BackingStoreError::Locked) } else {
[INFO] [stderr] 478 |     entry.credentials = enc_cred.to_string();
[INFO] [stderr] 479 |     Ok(())
[INFO] [stderr] 480 | },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/backingstore.rs:542:12
[INFO] [stderr]     |
[INFO] [stderr] 542 |         Ok(hashmap.keys().map(|k| k.clone()).collect::<Vec<String>>())
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `hashmap.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/backingstore.rs:548:13
[INFO] [stderr]     |
[INFO] [stderr] 548 | /             match u.locked {
[INFO] [stderr] 549 | |                 true => Err(BackingStoreError::Locked),
[INFO] [stderr] 550 | |                 false => Ok(true),
[INFO] [stderr] 551 | |             }
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if u.locked { Err(BackingStoreError::Locked) } else { Ok(true) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:127:62
[INFO] [stderr]     |
[INFO] [stderr] 127 |         self.backing_store.verify(user, credentials).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:150:27
[INFO] [stderr]     |
[INFO] [stderr] 150 |             Err(e) => Err(From::from(e)),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^ help: consider removing `From::from()`: `e`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:170:35
[INFO] [stderr]     |
[INFO] [stderr] 170 |                   Ok(hashmap) => Ok(hashmap.get(&signature.token.to_string())
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 171 | |                     .map(|s| s.clone())), // this is to unborrow the username
[INFO] [stderr]     | |_______________________________________^ help: Consider calling the dedicated `cloned` method: `hashmap.get(&signature.token.to_string()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:187:12
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Ok(self.backing_store.update_credentials(user, enc_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:194:12
[INFO] [stderr]     |
[INFO] [stderr] 194 |         Ok(self.backing_store.update_credentials_plain(user, plain_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 194 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:202:47
[INFO] [stderr]     |
[INFO] [stderr] 202 |         self.backing_store.lock(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:207:52
[INFO] [stderr]     |
[INFO] [stderr] 207 |         self.backing_store.is_locked(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:212:49
[INFO] [stderr]     |
[INFO] [stderr] 212 |         self.backing_store.unlock(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:219:12
[INFO] [stderr]     |
[INFO] [stderr] 219 |         Ok(self.backing_store.create_preencrypted(user, enc_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 219 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:226:12
[INFO] [stderr]     |
[INFO] [stderr] 226 |         Ok(self.backing_store.create_plain(user, plain_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 226 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:232:49
[INFO] [stderr]     |
[INFO] [stderr] 232 |         self.backing_store.delete(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:239:48
[INFO] [stderr]     |
[INFO] [stderr] 239 |         self.sess_mgr.start(signature).map_err(|err| AuthError::from(err))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:239:54
[INFO] [stderr]     |
[INFO] [stderr] 239 |         self.sess_mgr.start(signature).map_err(|err| AuthError::from(err))
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^ help: consider removing `AuthError::from()`: `err`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:244:44
[INFO] [stderr]     |
[INFO] [stderr] 244 |         self.backing_store.users().map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:249:49
[INFO] [stderr]     |
[INFO] [stderr] 249 |         self.backing_store.users_iter().map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:256:53
[INFO] [stderr]     |
[INFO] [stderr] 256 |         self.backing_store.check_user(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `websession`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/backingstore.rs:124:35
[INFO] [stderr]     |
[INFO] [stderr] 124 |         self.users_iter().map(|v| v.map(|u| u.clone()).collect())
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/backingstore.rs:196:26
[INFO] [stderr]     |
[INFO] [stderr] 196 |         hash.starts_with("!")
[INFO] [stderr]     |                          ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/backingstore.rs:256:13
[INFO] [stderr]     |
[INFO] [stderr] 256 |             backupf.write(all.as_bytes())?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/backingstore.rs:381:16
[INFO] [stderr]     |
[INFO] [stderr] 381 |             if v.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/backingstore.rs:397:28
[INFO] [stderr]     |
[INFO] [stderr] 397 |                       return match FileBackingStore::hash_is_locked(v[1]) {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 398 | |                         true => Err(BackingStoreError::Locked),
[INFO] [stderr] 399 | |                         false => Ok(true),
[INFO] [stderr] 400 | |                     };
[INFO] [stderr]     | |_____________________^ help: consider using an if/else expression: `if FileBackingStore::hash_is_locked(v[1]) { Err(BackingStoreError::Locked) } else { Ok(true) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backingstore::MemoryBackingStore`
[INFO] [stderr]    --> src/backingstore.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     pub fn new() -> MemoryBackingStore {
[INFO] [stderr] 424 | |         MemoryBackingStore {
[INFO] [stderr] 425 | |             users: Mutex::new(HashMap::new()),
[INFO] [stderr] 426 | |         }
[INFO] [stderr] 427 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 417 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/backingstore.rs:477:28
[INFO] [stderr]     |
[INFO] [stderr] 477 |               Some(entry) => match entry.locked {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 478 | |                 true => Err(BackingStoreError::Locked),
[INFO] [stderr] 479 | |                 false => {
[INFO] [stderr] 480 | |                     entry.credentials = enc_cred.to_string();
[INFO] [stderr] 481 | |                     Ok(())
[INFO] [stderr] 482 | |                 },
[INFO] [stderr] 483 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 477 |             Some(entry) => if entry.locked { Err(BackingStoreError::Locked) } else {
[INFO] [stderr] 478 |     entry.credentials = enc_cred.to_string();
[INFO] [stderr] 479 |     Ok(())
[INFO] [stderr] 480 | },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/backingstore.rs:542:12
[INFO] [stderr]     |
[INFO] [stderr] 542 |         Ok(hashmap.keys().map(|k| k.clone()).collect::<Vec<String>>())
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `hashmap.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/backingstore.rs:548:13
[INFO] [stderr]     |
[INFO] [stderr] 548 | /             match u.locked {
[INFO] [stderr] 549 | |                 true => Err(BackingStoreError::Locked),
[INFO] [stderr] 550 | |                 false => Ok(true),
[INFO] [stderr] 551 | |             }
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if u.locked { Err(BackingStoreError::Locked) } else { Ok(true) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 34
[INFO] [stderr]    --> src/backingstore.rs:702:5
[INFO] [stderr]     |
[INFO] [stderr] 702 | /     fn fbs_fuzz_users() {
[INFO] [stderr] 703 | |         let (fbs, _temp) = make_filebackingstore();
[INFO] [stderr] 704 | |         let names: Vec<String> = (0 .. 20).map(|_| (0 .. 10).map(|_| rand::random::<char>()).collect()).collect();
[INFO] [stderr] 705 | |         let passwords: Vec<String> = (0 .. 20).map(|_| (0 .. 10).map(|_| rand::random::<char>()).collect()).collect();
[INFO] [stderr] ...   |
[INFO] [stderr] 805 | |         }
[INFO] [stderr] 806 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:127:62
[INFO] [stderr]     |
[INFO] [stderr] 127 |         self.backing_store.verify(user, credentials).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:150:27
[INFO] [stderr]     |
[INFO] [stderr] 150 |             Err(e) => Err(From::from(e)),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^ help: consider removing `From::from()`: `e`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:170:35
[INFO] [stderr]     |
[INFO] [stderr] 170 |                   Ok(hashmap) => Ok(hashmap.get(&signature.token.to_string())
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 171 | |                     .map(|s| s.clone())), // this is to unborrow the username
[INFO] [stderr]     | |_______________________________________^ help: Consider calling the dedicated `cloned` method: `hashmap.get(&signature.token.to_string()).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:187:12
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Ok(self.backing_store.update_credentials(user, enc_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:194:12
[INFO] [stderr]     |
[INFO] [stderr] 194 |         Ok(self.backing_store.update_credentials_plain(user, plain_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 194 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:202:47
[INFO] [stderr]     |
[INFO] [stderr] 202 |         self.backing_store.lock(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:207:52
[INFO] [stderr]     |
[INFO] [stderr] 207 |         self.backing_store.is_locked(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:212:49
[INFO] [stderr]     |
[INFO] [stderr] 212 |         self.backing_store.unlock(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:219:12
[INFO] [stderr]     |
[INFO] [stderr] 219 |         Ok(self.backing_store.create_preencrypted(user, enc_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 219 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:226:12
[INFO] [stderr]     |
[INFO] [stderr] 226 |         Ok(self.backing_store.create_plain(user, plain_creds)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 226 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:232:49
[INFO] [stderr]     |
[INFO] [stderr] 232 |         self.backing_store.delete(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:239:48
[INFO] [stderr]     |
[INFO] [stderr] 239 |         self.sess_mgr.start(signature).map_err(|err| AuthError::from(err))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:239:54
[INFO] [stderr]     |
[INFO] [stderr] 239 |         self.sess_mgr.start(signature).map_err(|err| AuthError::from(err))
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^ help: consider removing `AuthError::from()`: `err`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:244:44
[INFO] [stderr]     |
[INFO] [stderr] 244 |         self.backing_store.users().map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:249:49
[INFO] [stderr]     |
[INFO] [stderr] 249 |         self.backing_store.users_iter().map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:256:53
[INFO] [stderr]     |
[INFO] [stderr] 256 |         self.backing_store.check_user(user).map_err(|e| AuthError::from(e))
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AuthError::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `websession`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "490355a7dfbeec4e380a22e7f9f9073b1a05c4f22bfb7b508c85fd7ab95465af"`
[INFO] running `"docker" "rm" "-f" "490355a7dfbeec4e380a22e7f9f9073b1a05c4f22bfb7b508c85fd7ab95465af"`
[INFO] [stdout] 490355a7dfbeec4e380a22e7f9f9073b1a05c4f22bfb7b508c85fd7ab95465af