[INFO] crate webrender_api 0.57.2 is already in cache [INFO] extracting crate webrender_api 0.57.2 into work/ex/clippy-test-run/sources/stable/reg/webrender_api/0.57.2 [INFO] extracting crate webrender_api 0.57.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webrender_api/0.57.2 [INFO] validating manifest of webrender_api-0.57.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webrender_api-0.57.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webrender_api-0.57.2 [INFO] finished frobbing webrender_api-0.57.2 [INFO] frobbed toml for webrender_api-0.57.2 written to work/ex/clippy-test-run/sources/stable/reg/webrender_api/0.57.2/Cargo.toml [INFO] started frobbing webrender_api-0.57.2 [INFO] finished frobbing webrender_api-0.57.2 [INFO] frobbed toml for webrender_api-0.57.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webrender_api/0.57.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webrender_api-0.57.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webrender_api/0.57.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 920f118cf98b97150be25a1a9aacd184cdd1c4dbe9b95025ff8d04b6e0d20a74 [INFO] running `"docker" "start" "-a" "920f118cf98b97150be25a1a9aacd184cdd1c4dbe9b95025ff8d04b6e0d20a74"` [INFO] [stderr] Compiling serde v1.0.66 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling euclid_macros v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Checking app_units v0.7.1 [INFO] [stderr] Checking serde_bytes v0.10.4 [INFO] [stderr] Checking euclid v0.19.5 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking webrender_api v0.57.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:56 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:76 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:56 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:76 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, too_many_arguments, unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Peeking` [INFO] [stderr] --> src/display_list.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / enum Peek { [INFO] [stderr] 111 | | StartPeeking, [INFO] [stderr] 112 | | IsPeeking, [INFO] [stderr] 113 | | NotPeeking, [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Peeking` [INFO] [stderr] --> src/display_list.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / enum Peek { [INFO] [stderr] 111 | | StartPeeking, [INFO] [stderr] 112 | | IsPeeking, [INFO] [stderr] 113 | | NotPeeking, [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `api::Transaction` [INFO] [stderr] --> src/api.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> Self { [INFO] [stderr] 63 | | Transaction { [INFO] [stderr] 64 | | scene_ops: Vec::new(), [INFO] [stderr] 65 | | frame_ops: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `api::Transaction` [INFO] [stderr] --> src/api.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> Self { [INFO] [stderr] 63 | | Transaction { [INFO] [stderr] 64 | | scene_ops: Vec::new(), [INFO] [stderr] 65 | | frame_ops: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:1032:16 [INFO] [stderr] | [INFO] [stderr] 1032 | pub fn get(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:1062:17 [INFO] [stderr] | [INFO] [stderr] 1062 | pub fn with(&self, value: T) -> PropertyValue { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:1032:16 [INFO] [stderr] | [INFO] [stderr] 1032 | pub fn get(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/color.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / impl Hash for PremultipliedColorF { [INFO] [stderr] 102 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 103 | | // Note: this is inconsistent with the Eq impl for -0.0 (don't care). [INFO] [stderr] 104 | | self.r.to_bits().hash(state); [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/color.rs:16:43 [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Clone, Copy, Debug, Deserialize, PartialEq, PartialOrd, Serialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:1062:17 [INFO] [stderr] | [INFO] [stderr] 1062 | pub fn with(&self, value: T) -> PropertyValue { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | r: color.r as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | g: color.g as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | b: color.b as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | a: color.a as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/color.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | / impl Hash for PremultipliedColorF { [INFO] [stderr] 102 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 103 | | // Note: this is inconsistent with the Eq impl for -0.0 (don't care). [INFO] [stderr] 104 | | self.r.to_bits().hash(state); [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/color.rs:16:43 [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Clone, Copy, Debug, Deserialize, PartialEq, PartialOrd, Serialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | r: color.r as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | g: color.g as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | b: color.b as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | a: color.a as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(color.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:380:22 [INFO] [stderr] | [INFO] [stderr] 380 | pub fn is_hidden(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:380:22 [INFO] [stderr] | [INFO] [stderr] 380 | pub fn is_hidden(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:594:31 [INFO] [stderr] | [INFO] [stderr] 594 | pub fn get_feature_string(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:632:26 [INFO] [stderr] | [INFO] [stderr] 632 | pub fn get_plane_num(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:640:31 [INFO] [stderr] | [INFO] [stderr] 640 | pub fn get_feature_string(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:677:46 [INFO] [stderr] | [INFO] [stderr] 677 | pub fn create_with_offset(&self, offset: &LayoutVector2D) -> LocalClip { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `LayoutVector2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/display_list.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / pub fn next<'b>(&'b mut self) -> Option> { [INFO] [stderr] 232 | | use SpecificDisplayItem::*; [INFO] [stderr] 233 | | [INFO] [stderr] 234 | | match self.peeking { [INFO] [stderr] ... | [INFO] [stderr] 259 | | Some(self.as_ref()) [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_list.rs:357:53 [INFO] [stderr] | [INFO] [stderr] 357 | pub fn get_layout_primitive_info(&self, offset: &LayoutVector2D) -> LayoutPrimitiveInfo { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `LayoutVector2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:650:22 [INFO] [stderr] | [INFO] [stderr] 650 | self.0 = self.0.offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:659:22 [INFO] [stderr] | [INFO] [stderr] 659 | self.0 = self.0.offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:700:24 [INFO] [stderr] | [INFO] [stderr] 700 | let ptr = unsafe { vec.as_mut_ptr().offset(old_len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:740:24 [INFO] [stderr] | [INFO] [stderr] 740 | let ptr = unsafe { vec.as_mut_ptr().offset(old_len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:773:23 [INFO] [stderr] | [INFO] [stderr] 773 | let end = buf.as_ptr().offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_ptr().add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:793:21 [INFO] [stderr] | [INFO] [stderr] 793 | assert!(self.start.offset(buf.len() as isize) <= self.end, "UnsafeReader: read past end of target"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.start.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:795:26 [INFO] [stderr] | [INFO] [stderr] 795 | self.start = self.start.offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.start.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:594:31 [INFO] [stderr] | [INFO] [stderr] 594 | pub fn get_feature_string(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:632:26 [INFO] [stderr] | [INFO] [stderr] 632 | pub fn get_plane_num(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:640:31 [INFO] [stderr] | [INFO] [stderr] 640 | pub fn get_feature_string(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_item.rs:677:46 [INFO] [stderr] | [INFO] [stderr] 677 | pub fn create_with_offset(&self, offset: &LayoutVector2D) -> LocalClip { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `LayoutVector2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn to_degrees(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/font.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | self.angle as f32 / Self::ANGLE_SCALE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.angle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn to_radians(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | pub fn to_skew(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn is_enabled(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/display_list.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / pub fn next<'b>(&'b mut self) -> Option> { [INFO] [stderr] 232 | | use SpecificDisplayItem::*; [INFO] [stderr] 233 | | [INFO] [stderr] 234 | | match self.peeking { [INFO] [stderr] ... | [INFO] [stderr] 259 | | Some(self.as_ref()) [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display_list.rs:357:53 [INFO] [stderr] | [INFO] [stderr] 357 | pub fn get_layout_primitive_info(&self, offset: &LayoutVector2D) -> LayoutPrimitiveInfo { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `LayoutVector2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:650:22 [INFO] [stderr] | [INFO] [stderr] 650 | self.0 = self.0.offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:659:22 [INFO] [stderr] | [INFO] [stderr] 659 | self.0 = self.0.offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:700:24 [INFO] [stderr] | [INFO] [stderr] 700 | let ptr = unsafe { vec.as_mut_ptr().offset(old_len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:740:24 [INFO] [stderr] | [INFO] [stderr] 740 | let ptr = unsafe { vec.as_mut_ptr().offset(old_len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(old_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:773:23 [INFO] [stderr] | [INFO] [stderr] 773 | let end = buf.as_ptr().offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_ptr().add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:793:21 [INFO] [stderr] | [INFO] [stderr] 793 | assert!(self.start.offset(buf.len() as isize) <= self.end, "UnsafeReader: read past end of target"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.start.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/display_list.rs:795:26 [INFO] [stderr] | [INFO] [stderr] 795 | self.start = self.start.offset(buf.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.start.add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/units.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn as_scroll_parent_vector(vector: &LayoutVector2D) -> ScrollLayerVector2D { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `LayoutVector2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | pub fn to_degrees(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/font.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | self.angle as f32 / Self::ANGLE_SCALE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.angle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn to_radians(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | pub fn to_skew(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/font.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn is_enabled(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `webrender_api`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/units.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn as_scroll_parent_vector(vector: &LayoutVector2D) -> ScrollLayerVector2D { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `LayoutVector2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `webrender_api`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "920f118cf98b97150be25a1a9aacd184cdd1c4dbe9b95025ff8d04b6e0d20a74"` [INFO] running `"docker" "rm" "-f" "920f118cf98b97150be25a1a9aacd184cdd1c4dbe9b95025ff8d04b6e0d20a74"` [INFO] [stdout] 920f118cf98b97150be25a1a9aacd184cdd1c4dbe9b95025ff8d04b6e0d20a74