[INFO] crate webpki 0.18.1 is already in cache [INFO] extracting crate webpki 0.18.1 into work/ex/clippy-test-run/sources/stable/reg/webpki/0.18.1 [INFO] extracting crate webpki 0.18.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webpki/0.18.1 [INFO] validating manifest of webpki-0.18.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webpki-0.18.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webpki-0.18.1 [INFO] finished frobbing webpki-0.18.1 [INFO] frobbed toml for webpki-0.18.1 written to work/ex/clippy-test-run/sources/stable/reg/webpki/0.18.1/Cargo.toml [INFO] started frobbing webpki-0.18.1 [INFO] finished frobbing webpki-0.18.1 [INFO] frobbed toml for webpki-0.18.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webpki/0.18.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webpki-0.18.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webpki/0.18.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74473d55c31066962b7d44a3f3b01b385cef9c3de33da98d0076f2898475f7f4 [INFO] running `"docker" "start" "-a" "74473d55c31066962b7d44a3f3b01b385cef9c3de33da98d0076f2898475f7f4"` [INFO] [stderr] Compiling ring v0.13.5 [INFO] [stderr] Checking webpki v0.18.1 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | ee_or_ca: ee_or_ca, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ee_or_ca` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::redundant_field_names)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | signed_data: signed_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signed_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | issuer: issuer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `issuer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | validity: validity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `validity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | subject: subject, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | spki: spki, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spki` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | algorithm_id_value: algorithm_id_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm_id_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | key_value: key_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | signature: signature [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | ee_or_ca: ee_or_ca, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ee_or_ca` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::redundant_field_names)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | signed_data: signed_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signed_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | issuer: issuer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `issuer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | validity: validity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `validity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | subject: subject, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/cert.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | spki: spki, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spki` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | algorithm_id_value: algorithm_id_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm_id_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | key_value: key_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/signed_data.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | signature: signature [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/name.rs:363:5 [INFO] [stderr] | [INFO] [stderr] 363 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::needless_return)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/name.rs:705:5 [INFO] [stderr] | [INFO] [stderr] 705 | return Some(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/calendar.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | const DAYS_BEFORE_UNIX_EPOCH_AD: u64 = 719162; [INFO] [stderr] | ^^^^^^ help: consider: `719_162` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::unreadable_literal)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/name.rs:363:5 [INFO] [stderr] | [INFO] [stderr] 363 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::needless_return)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/name.rs:705:5 [INFO] [stderr] | [INFO] [stderr] 705 | return Some(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/name.rs:870:17 [INFO] [stderr] | [INFO] [stderr] 870 | &[(&'static [u8], &'static [u8], Option)] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::const_static_lifetime)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/name.rs:870:32 [INFO] [stderr] | [INFO] [stderr] 870 | &[(&'static [u8], &'static [u8], Option)] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/calendar.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | const DAYS_BEFORE_UNIX_EPOCH_AD: u64 = 719162; [INFO] [stderr] | ^^^^^^ help: consider: `719_162` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/webpki.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[forbid(clippy::unreadable_literal)] implied by #[forbid(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/calendar.rs:136:56 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(Time::from_seconds_since_unix_epoch(1483228799), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_483_228_799` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/calendar.rs:138:56 [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(Time::from_seconds_since_unix_epoch(1483228800), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_483_228_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/calendar.rs:142:56 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(Time::from_seconds_since_unix_epoch(1492449162), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_492_449_162` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/calendar.rs:146:56 [INFO] [stderr] | [INFO] [stderr] 146 | assert_eq!(Time::from_seconds_since_unix_epoch(1460913162), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_460_913_162` [INFO] [stderr] | [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: Could not compile `webpki`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 19 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `webpki`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "74473d55c31066962b7d44a3f3b01b385cef9c3de33da98d0076f2898475f7f4"` [INFO] running `"docker" "rm" "-f" "74473d55c31066962b7d44a3f3b01b385cef9c3de33da98d0076f2898475f7f4"` [INFO] [stdout] 74473d55c31066962b7d44a3f3b01b385cef9c3de33da98d0076f2898475f7f4