[INFO] crate webm 1.0.0 is already in cache [INFO] extracting crate webm 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/webm/1.0.0 [INFO] extracting crate webm 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webm/1.0.0 [INFO] validating manifest of webm-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webm-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webm-1.0.0 [INFO] finished frobbing webm-1.0.0 [INFO] frobbed toml for webm-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/webm/1.0.0/Cargo.toml [INFO] started frobbing webm-1.0.0 [INFO] finished frobbing webm-1.0.0 [INFO] frobbed toml for webm-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webm/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webm-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webm/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a6e43e15306f455855af6237a70ac8de34db3df3dffc95c8505e64e498a563b [INFO] running `"docker" "start" "-a" "7a6e43e15306f455855af6237a70ac8de34db3df3dffc95c8505e64e498a563b"` [INFO] [stderr] Compiling webm-sys v1.0.0 [INFO] [stderr] Checking webm v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/lib.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | ffi: ffi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ffi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/lib.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | ffi: ffi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ffi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut T`) [INFO] [stderr] --> src/lib/lib.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | let dest: &mut T = unsafe { transmute(dest) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(dest as *mut T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut T`) [INFO] [stderr] --> src/lib/lib.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | let dest: &mut T = unsafe { transmute(dest) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(dest as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut T`) [INFO] [stderr] --> src/lib/lib.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | let dest: &mut T = unsafe { transmute(dest) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(dest as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib/lib.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | transmute(&mut *w.dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *w.dest as *mut T as *mut std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib/lib.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | debug_assert!(w.mkv_writer != 0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/lib.rs:154:19 [INFO] [stderr] | [INFO] [stderr] 154 | fn get_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/lib.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | / match self { [INFO] [stderr] 156 | | &AudioCodecId::Opus => ffi::mux::OPUS_CODEC_ID, [INFO] [stderr] 157 | | &AudioCodecId::Vorbis => ffi::mux::VORBIS_CODEC_ID, [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *self { [INFO] [stderr] 156 | AudioCodecId::Opus => ffi::mux::OPUS_CODEC_ID, [INFO] [stderr] 157 | AudioCodecId::Vorbis => ffi::mux::VORBIS_CODEC_ID, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/lib.rs:167:19 [INFO] [stderr] | [INFO] [stderr] 167 | fn get_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/lib.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | / match self { [INFO] [stderr] 169 | | &VideoCodecId::VP8 => ffi::mux::VP8_CODEC_ID, [INFO] [stderr] 170 | | &VideoCodecId::VP9 => ffi::mux::VP9_CODEC_ID, [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *self { [INFO] [stderr] 169 | VideoCodecId::VP8 => ffi::mux::VP8_CODEC_ID, [INFO] [stderr] 170 | VideoCodecId::VP9 => ffi::mux::VP9_CODEC_ID, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/lib.rs:202:57 [INFO] [stderr] | [INFO] [stderr] 202 | ffi::mux::mux_set_writing_app(self.ffi, CString::new(name).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/lib.rs:202:57 [INFO] [stderr] | [INFO] [stderr] 202 | ffi::mux::mux_set_writing_app(self.ffi, CString::new(name).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `webm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut T`) [INFO] [stderr] --> src/lib/lib.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | let dest: &mut T = unsafe { transmute(dest) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(dest as *mut T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut T`) [INFO] [stderr] --> src/lib/lib.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | let dest: &mut T = unsafe { transmute(dest) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(dest as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut T`) [INFO] [stderr] --> src/lib/lib.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | let dest: &mut T = unsafe { transmute(dest) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(dest as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib/lib.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | transmute(&mut *w.dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *w.dest as *mut T as *mut std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib/lib.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | debug_assert!(w.mkv_writer != 0 as *mut _); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/lib.rs:154:19 [INFO] [stderr] | [INFO] [stderr] 154 | fn get_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/lib.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | / match self { [INFO] [stderr] 156 | | &AudioCodecId::Opus => ffi::mux::OPUS_CODEC_ID, [INFO] [stderr] 157 | | &AudioCodecId::Vorbis => ffi::mux::VORBIS_CODEC_ID, [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *self { [INFO] [stderr] 156 | AudioCodecId::Opus => ffi::mux::OPUS_CODEC_ID, [INFO] [stderr] 157 | AudioCodecId::Vorbis => ffi::mux::VORBIS_CODEC_ID, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/lib.rs:167:19 [INFO] [stderr] | [INFO] [stderr] 167 | fn get_id(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/lib.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | / match self { [INFO] [stderr] 169 | | &VideoCodecId::VP8 => ffi::mux::VP8_CODEC_ID, [INFO] [stderr] 170 | | &VideoCodecId::VP9 => ffi::mux::VP9_CODEC_ID, [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *self { [INFO] [stderr] 169 | VideoCodecId::VP8 => ffi::mux::VP8_CODEC_ID, [INFO] [stderr] 170 | VideoCodecId::VP9 => ffi::mux::VP9_CODEC_ID, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/lib.rs:202:57 [INFO] [stderr] | [INFO] [stderr] 202 | ffi::mux::mux_set_writing_app(self.ffi, CString::new(name).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/lib.rs:202:57 [INFO] [stderr] | [INFO] [stderr] 202 | ffi::mux::mux_set_writing_app(self.ffi, CString::new(name).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `webm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7a6e43e15306f455855af6237a70ac8de34db3df3dffc95c8505e64e498a563b"` [INFO] running `"docker" "rm" "-f" "7a6e43e15306f455855af6237a70ac8de34db3df3dffc95c8505e64e498a563b"` [INFO] [stdout] 7a6e43e15306f455855af6237a70ac8de34db3df3dffc95c8505e64e498a563b