[INFO] crate webframework-derive 0.0.2 is already in cache [INFO] extracting crate webframework-derive 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/webframework-derive/0.0.2 [INFO] extracting crate webframework-derive 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webframework-derive/0.0.2 [INFO] validating manifest of webframework-derive-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webframework-derive-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webframework-derive-0.0.2 [INFO] finished frobbing webframework-derive-0.0.2 [INFO] frobbed toml for webframework-derive-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/webframework-derive/0.0.2/Cargo.toml [INFO] started frobbing webframework-derive-0.0.2 [INFO] finished frobbing webframework-derive-0.0.2 [INFO] frobbed toml for webframework-derive-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webframework-derive/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webframework-derive-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webframework-derive/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6b436de2c6df3b1f2539122bee8d04c71671262623ecab9d257f6bf0919acc5 [INFO] running `"docker" "start" "-a" "b6b436de2c6df3b1f2539122bee8d04c71671262623ecab9d257f6bf0919acc5"` [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Checking quote v0.6.11 [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking webframework-derive v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | return Ok(Route { restrictions, path, kind: InnerRouteKind::Multiple(inner_items) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Route { restrictions, path, kind: InnerRouteKind::Multiple(inner_items) })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | return Ok(Route { restrictions, path, kind: InnerRouteKind::Single(inner_item) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Route { restrictions, path, kind: InnerRouteKind::Single(inner_item) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | return Ok(Route { restrictions, path, kind: InnerRouteKind::Multiple(inner_items) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Route { restrictions, path, kind: InnerRouteKind::Multiple(inner_items) })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | return Ok(Route { restrictions, path, kind: InnerRouteKind::Single(inner_item) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Route { restrictions, path, kind: InnerRouteKind::Single(inner_item) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | .filter(|value| value.ident.to_string() == "params") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*value.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | litstr.value().split(",").map(str::trim).map(str::to_string).collect::>() [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | .filter(|(_ty, input)| params.iter().find(|¶m| *param == input.to_string()).is_none()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | }).expect(&format!("Param '{}' not found in arguments.", param)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Param '{}' not found in arguments.", param))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | ident.to_string() == param [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | .filter(|value| value.ident.to_string() == "params") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*value.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | litstr.value().split(",").map(str::trim).map(str::to_string).collect::>() [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | .filter(|(_ty, input)| params.iter().find(|¶m| *param == input.to_string()).is_none()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | }).expect(&format!("Param '{}' not found in arguments.", param)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Param '{}' not found in arguments.", param))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | ident.to_string() == param [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.04s [INFO] running `"docker" "inspect" "b6b436de2c6df3b1f2539122bee8d04c71671262623ecab9d257f6bf0919acc5"` [INFO] running `"docker" "rm" "-f" "b6b436de2c6df3b1f2539122bee8d04c71671262623ecab9d257f6bf0919acc5"` [INFO] [stdout] b6b436de2c6df3b1f2539122bee8d04c71671262623ecab9d257f6bf0919acc5