[INFO] crate webframework-core 0.0.2 is already in cache [INFO] extracting crate webframework-core 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/webframework-core/0.0.2 [INFO] extracting crate webframework-core 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webframework-core/0.0.2 [INFO] validating manifest of webframework-core-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webframework-core-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webframework-core-0.0.2 [INFO] finished frobbing webframework-core-0.0.2 [INFO] frobbed toml for webframework-core-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/webframework-core/0.0.2/Cargo.toml [INFO] started frobbing webframework-core-0.0.2 [INFO] finished frobbing webframework-core-0.0.2 [INFO] frobbed toml for webframework-core-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webframework-core/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webframework-core-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webframework-core/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9eabd5b43c7c17380e545516eef21e2d3fb500a7549599986d8dd487b2526368 [INFO] running `"docker" "start" "-a" "9eabd5b43c7c17380e545516eef21e2d3fb500a7549599986d8dd487b2526368"` [INFO] [stderr] Checking string v0.1.3 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking http v0.1.15 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking webframework-core v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | fn as_bytes_fut(self) -> impl Future, Error = Error> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn as_response(self) -> WebResult> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn from_str(val: &str) -> WebResult { [INFO] [stderr] 89 | | Ok(Redirect(val.parse()?)) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/router.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Unhandled(Request, HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/router.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Unhandled(Request, HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/form.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .ok_or(FormErrorKind::UnknownContentTypeError.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FormErrorKind::UnknownContentTypeError.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | fn as_bytes_fut(self) -> impl Future, Error = Error> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn as_response(self) -> WebResult> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/response.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn from_str(val: &str) -> WebResult { [INFO] [stderr] 89 | | Ok(Redirect(val.parse()?)) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/router.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Unhandled(Request, HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/router.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Unhandled(Request, HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/form.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .ok_or(FormErrorKind::UnknownContentTypeError.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FormErrorKind::UnknownContentTypeError.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.18s [INFO] running `"docker" "inspect" "9eabd5b43c7c17380e545516eef21e2d3fb500a7549599986d8dd487b2526368"` [INFO] running `"docker" "rm" "-f" "9eabd5b43c7c17380e545516eef21e2d3fb500a7549599986d8dd487b2526368"` [INFO] [stdout] 9eabd5b43c7c17380e545516eef21e2d3fb500a7549599986d8dd487b2526368