[INFO] crate webframework 0.0.2 is already in cache [INFO] extracting crate webframework 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/webframework/0.0.2 [INFO] extracting crate webframework 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webframework/0.0.2 [INFO] validating manifest of webframework-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webframework-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webframework-0.0.2 [INFO] finished frobbing webframework-0.0.2 [INFO] frobbed toml for webframework-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/webframework/0.0.2/Cargo.toml [INFO] started frobbing webframework-0.0.2 [INFO] finished frobbing webframework-0.0.2 [INFO] frobbed toml for webframework-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webframework/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webframework-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webframework/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fe3c0ad6246c1ca9ade05ee55eff8c71b81b75fa40f0b76c6b05ace163f5e1a [INFO] running `"docker" "start" "-a" "1fe3c0ad6246c1ca9ade05ee55eff8c71b81b75fa40f0b76c6b05ace163f5e1a"` [INFO] [stderr] Checking horrorshow v0.6.5 [INFO] [stderr] Checking isatty v0.1.9 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Compiling webframework-derive v0.0.2 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking webframework-core v0.0.2 [INFO] [stderr] Checking webframework v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | ServiceError { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | ServiceError { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | return Either::A(resp.map(Response::as_response).flatten()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Either::A(resp.map(Response::as_response).flatten())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | return Either::B(future::err(error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Either::B(future::err(error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | return Either::A(resp.map(Response::as_response).flatten()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Either::A(resp.map(Response::as_response).flatten())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | return Either::B(future::err(error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Either::B(future::err(error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server.rs:78:65 [INFO] [stderr] | [INFO] [stderr] 78 | let time: f64 = elapsed.as_secs() as f64 * 1000.0 + elapsed.subsec_nanos() as f64 / 1_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match &resp { [INFO] [stderr] 83 | | Ok(resp) => { [INFO] [stderr] 84 | | status = Some(resp.status().as_u16()); [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Ok(resp) = &resp { [INFO] [stderr] 83 | status = Some(resp.status().as_u16()); [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server.rs:78:65 [INFO] [stderr] | [INFO] [stderr] 78 | let time: f64 = elapsed.as_secs() as f64 * 1000.0 + elapsed.subsec_nanos() as f64 / 1_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match &resp { [INFO] [stderr] 83 | | Ok(resp) => { [INFO] [stderr] 84 | | status = Some(resp.status().as_u16()); [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Ok(resp) = &resp { [INFO] [stderr] 83 | status = Some(resp.status().as_u16()); [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.37s [INFO] running `"docker" "inspect" "1fe3c0ad6246c1ca9ade05ee55eff8c71b81b75fa40f0b76c6b05ace163f5e1a"` [INFO] running `"docker" "rm" "-f" "1fe3c0ad6246c1ca9ade05ee55eff8c71b81b75fa40f0b76c6b05ace163f5e1a"` [INFO] [stdout] 1fe3c0ad6246c1ca9ade05ee55eff8c71b81b75fa40f0b76c6b05ace163f5e1a