[INFO] crate webbrowser 0.3.1 is already in cache [INFO] extracting crate webbrowser 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/webbrowser/0.3.1 [INFO] extracting crate webbrowser 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webbrowser/0.3.1 [INFO] validating manifest of webbrowser-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of webbrowser-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing webbrowser-0.3.1 [INFO] finished frobbing webbrowser-0.3.1 [INFO] frobbed toml for webbrowser-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/webbrowser/0.3.1/Cargo.toml [INFO] started frobbing webbrowser-0.3.1 [INFO] finished frobbing webbrowser-0.3.1 [INFO] frobbed toml for webbrowser-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/webbrowser/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting webbrowser-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/webbrowser/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68c3745083af33abd81acedc71da78c46b905fc371417db77486a53bf0bfb7d4 [INFO] running `"docker" "start" "-a" "68c3745083af33abd81acedc71da78c46b905fc371417db77486a53bf0bfb7d4"` [INFO] [stderr] Checking webbrowser v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / return Err(Error::new( [INFO] [stderr] 237 | | ErrorKind::NotFound, [INFO] [stderr] 238 | | "No valid command in $BROWSER", [INFO] [stderr] 239 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | Err(Error::new( [INFO] [stderr] 237 | ErrorKind::NotFound, [INFO] [stderr] 238 | "No valid command in $BROWSER", [INFO] [stderr] 239 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:212:65 [INFO] [stderr] | [INFO] [stderr] 212 | .map_err(|_| -> Error { Error::new(ErrorKind::NotFound, format!("BROWSER env not set")) })?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"BROWSER env not set".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / return Err(Error::new( [INFO] [stderr] 237 | | ErrorKind::NotFound, [INFO] [stderr] 238 | | "No valid command in $BROWSER", [INFO] [stderr] 239 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | Err(Error::new( [INFO] [stderr] 237 | ErrorKind::NotFound, [INFO] [stderr] 238 | "No valid command in $BROWSER", [INFO] [stderr] 239 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:212:65 [INFO] [stderr] | [INFO] [stderr] 212 | .map_err(|_| -> Error { Error::new(ErrorKind::NotFound, format!("BROWSER env not set")) })?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"BROWSER env not set".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "68c3745083af33abd81acedc71da78c46b905fc371417db77486a53bf0bfb7d4"` [INFO] running `"docker" "rm" "-f" "68c3745083af33abd81acedc71da78c46b905fc371417db77486a53bf0bfb7d4"` [INFO] [stdout] 68c3745083af33abd81acedc71da78c46b905fc371417db77486a53bf0bfb7d4