[INFO] crate weave 0.2.0 is already in cache [INFO] extracting crate weave 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/weave/0.2.0 [INFO] extracting crate weave 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/weave/0.2.0 [INFO] validating manifest of weave-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of weave-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing weave-0.2.0 [INFO] finished frobbing weave-0.2.0 [INFO] frobbed toml for weave-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/weave/0.2.0/Cargo.toml [INFO] started frobbing weave-0.2.0 [INFO] finished frobbing weave-0.2.0 [INFO] frobbed toml for weave-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/weave/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting weave-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/weave/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ecae6045cdb18ebe8d8c02ec22a67bb6139589b7d90ea309e0c5934816d9619 [INFO] running `"docker" "start" "-a" "4ecae6045cdb18ebe8d8c02ec22a67bb6139589b7d90ea309e0c5934816d9619"` [INFO] [stderr] Compiling miniz-sys v0.1.11 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking weave v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/naming.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/naming.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/naming.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | compressed: compressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | sink: sink, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:233:25 [INFO] [stderr] | [INFO] [stderr] 233 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | new_delta: new_delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | base_name: base_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut wr, "")` [INFO] [stderr] --> src/header.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | writeln!(&mut wr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut wr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/naming.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/naming.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/naming.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | compressed: compressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | sink: sink, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:233:25 [INFO] [stderr] | [INFO] [stderr] 233 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | new_delta: new_delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | base_name: base_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delta.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut wr, "")` [INFO] [stderr] --> src/header.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | writeln!(&mut wr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut wr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parse.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | Err(_) => panic!("State of pop not present"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/delta.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | / match self.diff_re.captures(&line) { [INFO] [stderr] 129 | | Some(cap) => { [INFO] [stderr] 130 | | // If adding, this completes the add. [INFO] [stderr] 131 | | if is_adding { [INFO] [stderr] ... | [INFO] [stderr] 174 | | None => (), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(cap) = self.diff_re.captures(&line) { [INFO] [stderr] 129 | // If adding, this completes the add. [INFO] [stderr] 130 | if is_adding { [INFO] [stderr] 131 | weave_write.borrow_mut().end(self.new_delta)?; [INFO] [stderr] 132 | is_adding = false; [INFO] [stderr] 133 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `header::Header` [INFO] [stderr] --> src/header.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Header { [INFO] [stderr] 38 | | Header { [INFO] [stderr] 39 | | version: THIS_VERSION, [INFO] [stderr] 40 | | deltas: vec![], [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/header.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn from_str(line: &str) -> Result
{ [INFO] [stderr] 46 | | if line.starts_with("\x01t") { [INFO] [stderr] 47 | | Ok(serde_json::from_str(&line[2..])?) [INFO] [stderr] 48 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parse.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | Err(_) => panic!("State of pop not present"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/delta.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | / match self.diff_re.captures(&line) { [INFO] [stderr] 129 | | Some(cap) => { [INFO] [stderr] 130 | | // If adding, this completes the add. [INFO] [stderr] 131 | | if is_adding { [INFO] [stderr] ... | [INFO] [stderr] 174 | | None => (), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(cap) = self.diff_re.captures(&line) { [INFO] [stderr] 129 | // If adding, this completes the add. [INFO] [stderr] 130 | if is_adding { [INFO] [stderr] 131 | weave_write.borrow_mut().end(self.new_delta)?; [INFO] [stderr] 132 | is_adding = false; [INFO] [stderr] 133 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/sccs.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | use_sccs: use_sccs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `use_sccs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `header::Header` [INFO] [stderr] --> src/header.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Header { [INFO] [stderr] 38 | | Header { [INFO] [stderr] 39 | | version: THIS_VERSION, [INFO] [stderr] 40 | | deltas: vec![], [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/header.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn from_str(line: &str) -> Result
{ [INFO] [stderr] 46 | | if line.starts_with("\x01t") { [INFO] [stderr] 47 | | Ok(serde_json::from_str(&line[2..])?) [INFO] [stderr] 48 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/sccs.rs:108:19 [INFO] [stderr] | [INFO] [stderr] 108 | nums: (1..FILE_SIZE + 1).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `(1..=FILE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.06s [INFO] running `"docker" "inspect" "4ecae6045cdb18ebe8d8c02ec22a67bb6139589b7d90ea309e0c5934816d9619"` [INFO] running `"docker" "rm" "-f" "4ecae6045cdb18ebe8d8c02ec22a67bb6139589b7d90ea309e0c5934816d9619"` [INFO] [stdout] 4ecae6045cdb18ebe8d8c02ec22a67bb6139589b7d90ea309e0c5934816d9619