[INFO] crate weak-table 0.2.3 is already in cache [INFO] extracting crate weak-table 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/weak-table/0.2.3 [INFO] extracting crate weak-table 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/weak-table/0.2.3 [INFO] validating manifest of weak-table-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of weak-table-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing weak-table-0.2.3 [INFO] finished frobbing weak-table-0.2.3 [INFO] frobbed toml for weak-table-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/weak-table/0.2.3/Cargo.toml [INFO] started frobbing weak-table-0.2.3 [INFO] finished frobbing weak-table-0.2.3 [INFO] frobbed toml for weak-table-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/weak-table/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting weak-table-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/weak-table/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 941eabfe31c97e9418b0c91b7b752150d21e09776bb13bb4f4bddbb0486aad67 [INFO] running `"docker" "start" "-a" "941eabfe31c97e9418b0c91b7b752150d21e09776bb13bb4f4bddbb0486aad67"` [INFO] [stderr] Checking weak-table v0.2.3 (/opt/crater/workdir) [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/weak_value_hash_map.rs:790:13 [INFO] [stderr] | [INFO] [stderr] 790 | / if let &Some((ref k, ref v, _)) = bucket { [INFO] [stderr] 791 | | write!(f, "[{}] {:?} => {:?}, ", i, *k, v.view())?; [INFO] [stderr] 792 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 790 | if let Some((ref k, ref v, _)) = *bucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/weak_weak_hash_map.rs:802:13 [INFO] [stderr] | [INFO] [stderr] 802 | / if let &Some((ref k, ref v, _)) = bucket { [INFO] [stderr] 803 | | write!(f, "[{}] {:?} => {:?}, ", i, k.view(), v.view())?; [INFO] [stderr] 804 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 802 | if let Some((ref k, ref v, _)) = *bucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `PtrWeakWeakHashMap` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ptr_weak_weak_hash_map.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl PtrWeakWeakHashMap [INFO] [stderr] 32 | | where K::Strong: Deref [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | /// Creates an empty `PtrWeakWeakHashMap` with the given capacity and hasher. [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `WeakHashSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/weak_hash_set.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / impl WeakHashSet { [INFO] [stderr] 27 | | /// Creates an empty `WeakHashSet` with the given capacity and hasher. [INFO] [stderr] 28 | | pub fn with_hasher(hash_builder: S) -> Self { [INFO] [stderr] 29 | | WeakHashSet(base::WeakKeyHashMap::with_hasher(hash_builder)) [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Tester` [INFO] [stderr] --> tests/weak_key_hash_map.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | Tester::with_capacity(8) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/weak_key_hash_map.rs:165:38 [INFO] [stderr] | [INFO] [stderr] 165 | Box::new(self.0.shrink().map(|v| Script(v))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Script` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/weak_value_hash_map.rs:790:13 [INFO] [stderr] | [INFO] [stderr] 790 | / if let &Some((ref k, ref v, _)) = bucket { [INFO] [stderr] 791 | | write!(f, "[{}] {:?} => {:?}, ", i, *k, v.view())?; [INFO] [stderr] 792 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 790 | if let Some((ref k, ref v, _)) = *bucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/weak_weak_hash_map.rs:802:13 [INFO] [stderr] | [INFO] [stderr] 802 | / if let &Some((ref k, ref v, _)) = bucket { [INFO] [stderr] 803 | | write!(f, "[{}] {:?} => {:?}, ", i, k.view(), v.view())?; [INFO] [stderr] 804 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 802 | if let Some((ref k, ref v, _)) = *bucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `PtrWeakWeakHashMap` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ptr_weak_weak_hash_map.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl PtrWeakWeakHashMap [INFO] [stderr] 32 | | where K::Strong: Deref [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | /// Creates an empty `PtrWeakWeakHashMap` with the given capacity and hasher. [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `WeakHashSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/weak_hash_set.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / impl WeakHashSet { [INFO] [stderr] 27 | | /// Creates an empty `WeakHashSet` with the given capacity and hasher. [INFO] [stderr] 28 | | pub fn with_hasher(hash_builder: S) -> Self { [INFO] [stderr] 29 | | WeakHashSet(base::WeakKeyHashMap::with_hasher(hash_builder)) [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.31s [INFO] running `"docker" "inspect" "941eabfe31c97e9418b0c91b7b752150d21e09776bb13bb4f4bddbb0486aad67"` [INFO] running `"docker" "rm" "-f" "941eabfe31c97e9418b0c91b7b752150d21e09776bb13bb4f4bddbb0486aad67"` [INFO] [stdout] 941eabfe31c97e9418b0c91b7b752150d21e09776bb13bb4f4bddbb0486aad67