[INFO] crate wc-bg 0.3.0 is already in cache [INFO] extracting crate wc-bg 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/wc-bg/0.3.0 [INFO] extracting crate wc-bg 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wc-bg/0.3.0 [INFO] validating manifest of wc-bg-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wc-bg-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wc-bg-0.3.0 [INFO] finished frobbing wc-bg-0.3.0 [INFO] frobbed toml for wc-bg-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/wc-bg/0.3.0/Cargo.toml [INFO] started frobbing wc-bg-0.3.0 [INFO] finished frobbing wc-bg-0.3.0 [INFO] frobbed toml for wc-bg-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wc-bg/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wc-bg-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wc-bg/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6181cf8f265eeba146a0d11c5d7200e5851ae1140c08fdda1589ccb737f288c [INFO] running `"docker" "start" "-a" "a6181cf8f265eeba146a0d11c5d7200e5851ae1140c08fdda1589ccb737f288c"` [INFO] [stderr] Compiling phf v0.7.24 [INFO] [stderr] Compiling wc-bg v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking way-cooler-client-helpers v0.1.0 [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | DesktopShell { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:53:53 [INFO] [stderr] | [INFO] [stderr] 53 | DesktopShell { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:214:115 [INFO] [stderr] | [INFO] [stderr] 214 | pub fn set_background(&self, output: &super::wl_output::WlOutput, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:217:110 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn set_panel(&self, output: &super::wl_output::WlOutput, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:220:80 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn set_lock_surface(&self, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn unlock(&self) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:232:80 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn set_grab_surface(&self, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:245:37 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn desktop_ready(&self) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:255:57 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn set_panel_position(&self, position: u32) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:297:48 [INFO] [stderr] | [INFO] [stderr] 297 | Screensaver { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:306:52 [INFO] [stderr] | [INFO] [stderr] 306 | Screensaver { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:352:112 [INFO] [stderr] | [INFO] [stderr] 352 | pub fn set_surface(&self, surface: &super::wl_surface::WlSurface, output: &super::wl_output::WlOutput) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | const CURSOR: &'static [u8; 656] = include_bytes!("../assets/arrow.png"); [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 656]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | DesktopShell { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:53:53 [INFO] [stderr] | [INFO] [stderr] 53 | DesktopShell { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:214:115 [INFO] [stderr] | [INFO] [stderr] 214 | pub fn set_background(&self, output: &super::wl_output::WlOutput, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:217:110 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn set_panel(&self, output: &super::wl_output::WlOutput, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:220:80 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn set_lock_surface(&self, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:223:30 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn unlock(&self) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:232:80 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn set_grab_surface(&self, surface: &super::wl_surface::WlSurface) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:245:37 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn desktop_ready(&self) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:255:57 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn set_panel_position(&self, position: u32) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:297:48 [INFO] [stderr] | [INFO] [stderr] 297 | Screensaver { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:306:52 [INFO] [stderr] | [INFO] [stderr] 306 | Screensaver { ptr: ptr, data: Some((&*data).2.clone()) } [INFO] [stderr] | ^^^^^^^^ help: try this: `*data.2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:352:112 [INFO] [stderr] | [INFO] [stderr] 352 | pub fn set_surface(&self, surface: &super::wl_surface::WlSurface, output: &super::wl_output::WlOutput) ->() { [INFO] [stderr] | ^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | const CURSOR: &'static [u8; 656] = include_bytes!("../assets/arrow.png"); [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 656]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn to_raw(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn to_raw(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:165:23 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn to_raw(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn to_raw(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | / fn main() { [INFO] [stderr] 108 | | let matches = App::new("WayCooler Background Service") [INFO] [stderr] 109 | | .version("0.1.0") [INFO] [stderr] 110 | | .author("Timidger ") [INFO] [stderr] ... | [INFO] [stderr] 228 | | } [INFO] [stderr] 229 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn to_raw(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wc-bg-603eee09fdc110b0/out/desktop-shell_api.rs:165:23 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn to_raw(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | / fn main() { [INFO] [stderr] 108 | | let matches = App::new("WayCooler Background Service") [INFO] [stderr] 109 | | .version("0.1.0") [INFO] [stderr] 110 | | .author("Timidger ") [INFO] [stderr] ... | [INFO] [stderr] 228 | | } [INFO] [stderr] 229 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:232:19 [INFO] [stderr] | [INFO] [stderr] 232 | let big_num = num as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | let mut tmp = tempfile::tempfile().ok().expect("Unable to create a tempfile."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u32`) to itself [INFO] [stderr] --> src/main.rs:257:43 [INFO] [stderr] | [INFO] [stderr] 257 | tmp.write_u32::(transmute(color.to_u32())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:321:34 [INFO] [stderr] | [INFO] [stderr] 321 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:321:53 [INFO] [stderr] | [INFO] [stderr] 321 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:34 [INFO] [stderr] | [INFO] [stderr] 322 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:54 [INFO] [stderr] | [INFO] [stderr] 322 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:328:44 [INFO] [stderr] | [INFO] [stderr] 328 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:329:45 [INFO] [stderr] | [INFO] [stderr] 329 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:34 [INFO] [stderr] | [INFO] [stderr] 339 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:53 [INFO] [stderr] | [INFO] [stderr] 339 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:340:54 [INFO] [stderr] | [INFO] [stderr] 340 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:346:44 [INFO] [stderr] | [INFO] [stderr] 346 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:347:45 [INFO] [stderr] | [INFO] [stderr] 347 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:380:40 [INFO] [stderr] | [INFO] [stderr] 380 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:380:59 [INFO] [stderr] | [INFO] [stderr] 380 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:381:40 [INFO] [stderr] | [INFO] [stderr] 381 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:381:60 [INFO] [stderr] | [INFO] [stderr] 381 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | / let tmp = pixel[2]; [INFO] [stderr] 410 | | pixel[2] = pixel[0]; [INFO] [stderr] 411 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | tmp.set_len(img_size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(img_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | / let tmp = pixel[2]; [INFO] [stderr] 459 | | pixel[2] = pixel[0]; [INFO] [stderr] 460 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:453:25 [INFO] [stderr] | [INFO] [stderr] 453 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:465:17 [INFO] [stderr] | [INFO] [stderr] 465 | tmp.set_len(size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:479:43 [INFO] [stderr] | [INFO] [stderr] 479 | assert_eq!(rgba_conversion(255, 500), 500); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:232:19 [INFO] [stderr] | [INFO] [stderr] 232 | let big_num = num as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | let mut tmp = tempfile::tempfile().ok().expect("Unable to create a tempfile."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u32`) to itself [INFO] [stderr] --> src/main.rs:257:43 [INFO] [stderr] | [INFO] [stderr] 257 | tmp.write_u32::(transmute(color.to_u32())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:321:34 [INFO] [stderr] | [INFO] [stderr] 321 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:321:53 [INFO] [stderr] | [INFO] [stderr] 321 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:34 [INFO] [stderr] | [INFO] [stderr] 322 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:54 [INFO] [stderr] | [INFO] [stderr] 322 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:328:44 [INFO] [stderr] | [INFO] [stderr] 328 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:329:45 [INFO] [stderr] | [INFO] [stderr] 329 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:34 [INFO] [stderr] | [INFO] [stderr] 339 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:53 [INFO] [stderr] | [INFO] [stderr] 339 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:340:54 [INFO] [stderr] | [INFO] [stderr] 340 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:346:44 [INFO] [stderr] | [INFO] [stderr] 346 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:347:45 [INFO] [stderr] | [INFO] [stderr] 347 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:380:40 [INFO] [stderr] | [INFO] [stderr] 380 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:380:59 [INFO] [stderr] | [INFO] [stderr] 380 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:381:40 [INFO] [stderr] | [INFO] [stderr] 381 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:381:60 [INFO] [stderr] | [INFO] [stderr] 381 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | / let tmp = pixel[2]; [INFO] [stderr] 410 | | pixel[2] = pixel[0]; [INFO] [stderr] 411 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | tmp.set_len(img_size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(img_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | / let tmp = pixel[2]; [INFO] [stderr] 459 | | pixel[2] = pixel[0]; [INFO] [stderr] 460 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:453:25 [INFO] [stderr] | [INFO] [stderr] 453 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:465:17 [INFO] [stderr] | [INFO] [stderr] 465 | tmp.set_len(size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.86s [INFO] running `"docker" "inspect" "a6181cf8f265eeba146a0d11c5d7200e5851ae1140c08fdda1589ccb737f288c"` [INFO] running `"docker" "rm" "-f" "a6181cf8f265eeba146a0d11c5d7200e5851ae1140c08fdda1589ccb737f288c"` [INFO] [stdout] a6181cf8f265eeba146a0d11c5d7200e5851ae1140c08fdda1589ccb737f288c