[INFO] crate wbs-backup-daemon 1.1.15 is already in cache [INFO] extracting crate wbs-backup-daemon 1.1.15 into work/ex/clippy-test-run/sources/stable/reg/wbs-backup-daemon/1.1.15 [INFO] extracting crate wbs-backup-daemon 1.1.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wbs-backup-daemon/1.1.15 [INFO] validating manifest of wbs-backup-daemon-1.1.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wbs-backup-daemon-1.1.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wbs-backup-daemon-1.1.15 [INFO] finished frobbing wbs-backup-daemon-1.1.15 [INFO] frobbed toml for wbs-backup-daemon-1.1.15 written to work/ex/clippy-test-run/sources/stable/reg/wbs-backup-daemon/1.1.15/Cargo.toml [INFO] started frobbing wbs-backup-daemon-1.1.15 [INFO] finished frobbing wbs-backup-daemon-1.1.15 [INFO] frobbed toml for wbs-backup-daemon-1.1.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wbs-backup-daemon/1.1.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wbs-backup-daemon-1.1.15 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wbs-backup-daemon/1.1.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b90a9d81d5300679a0d09d98176c741652d2d3650ff745173f235de9ecc0566 [INFO] running `"docker" "start" "-a" "8b90a9d81d5300679a0d09d98176c741652d2d3650ff745173f235de9ecc0566"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/backup-daemon.rs` was erroneously implicitly accepted for binary `backup-daemon`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking wbs-backup-daemon v1.1.15 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wbs/backup/run.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | snapshot_time: snapshot_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snapshot_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wbs/backup/run.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | snapshot_time: snapshot_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snapshot_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wbs/backup/run.rs:85:2 [INFO] [stderr] | [INFO] [stderr] 85 | try! (output_file.write ( [INFO] [stderr] | _____^ [INFO] [stderr] 86 | | & process_output.stdout)); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wbs/backup/run.rs:92:2 [INFO] [stderr] | [INFO] [stderr] 92 | try! (output_file.write ( [INFO] [stderr] | _____^ [INFO] [stderr] 93 | | & process_output.stderr)); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wbs/backup/run.rs:264:4 [INFO] [stderr] | [INFO] [stderr] 264 | match snapshot.state { [INFO] [stderr] | _____________^ [INFO] [stderr] 265 | | [INFO] [stderr] 266 | | SnapshotState::Snapshotted => { [INFO] [stderr] 267 | | [INFO] [stderr] ... | [INFO] [stderr] 273 | | [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let SnapshotState::Snapshotted = snapshot.state { [INFO] [stderr] 265 | [INFO] [stderr] 266 | snapshot_indexes.push (snapshot_index) [INFO] [stderr] 267 | [INFO] [stderr] 268 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/wbs/backup/run.rs:384:3 [INFO] [stderr] | [INFO] [stderr] 384 | format! ( [INFO] [stderr] | _________^ [INFO] [stderr] 385 | | "ended successfully") [INFO] [stderr] | |_________________________________^ help: consider using .to_string(): `"ended successfully".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/wbs/backup/run.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | format! ( [INFO] [stderr] | _________________^ [INFO] [stderr] 402 | | "terminated by signal") [INFO] [stderr] | |___________________________________________^ help: consider using .to_string(): `"terminated by signal".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wbs/backup/state.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | snapshots: match & disk_job.snapshots { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | & Some (ref disk_snapshots) => { [INFO] [stderr] 226 | | [INFO] [stderr] ... | [INFO] [stderr] 238 | | [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 223 | snapshots: match disk_job.snapshots { [INFO] [stderr] 224 | [INFO] [stderr] 225 | Some (ref disk_snapshots) => { [INFO] [stderr] 226 | [INFO] [stderr] 227 | disk_snapshots.iter ().map ( [INFO] [stderr] 228 | |disk_snapshot| [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/wbs/backup/time.rs:90:2 [INFO] [stderr] | [INFO] [stderr] 90 | match opt_str { [INFO] [stderr] | _____^ [INFO] [stderr] 91 | | & None => { None }, [INFO] [stderr] 92 | | & Some (ref val) => { Some (time_parse (& val)) }, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | match *opt_str { [INFO] [stderr] 91 | None => { None }, [INFO] [stderr] 92 | Some (ref val) => { Some (time_parse (& val)) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wbs-backup-daemon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wbs/backup/run.rs:85:2 [INFO] [stderr] | [INFO] [stderr] 85 | try! (output_file.write ( [INFO] [stderr] | _____^ [INFO] [stderr] 86 | | & process_output.stdout)); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wbs/backup/run.rs:92:2 [INFO] [stderr] | [INFO] [stderr] 92 | try! (output_file.write ( [INFO] [stderr] | _____^ [INFO] [stderr] 93 | | & process_output.stderr)); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wbs/backup/run.rs:264:4 [INFO] [stderr] | [INFO] [stderr] 264 | match snapshot.state { [INFO] [stderr] | _____________^ [INFO] [stderr] 265 | | [INFO] [stderr] 266 | | SnapshotState::Snapshotted => { [INFO] [stderr] 267 | | [INFO] [stderr] ... | [INFO] [stderr] 273 | | [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let SnapshotState::Snapshotted = snapshot.state { [INFO] [stderr] 265 | [INFO] [stderr] 266 | snapshot_indexes.push (snapshot_index) [INFO] [stderr] 267 | [INFO] [stderr] 268 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/wbs/backup/run.rs:384:3 [INFO] [stderr] | [INFO] [stderr] 384 | format! ( [INFO] [stderr] | _________^ [INFO] [stderr] 385 | | "ended successfully") [INFO] [stderr] | |_________________________________^ help: consider using .to_string(): `"ended successfully".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/wbs/backup/run.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | format! ( [INFO] [stderr] | _________________^ [INFO] [stderr] 402 | | "terminated by signal") [INFO] [stderr] | |___________________________________________^ help: consider using .to_string(): `"terminated by signal".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wbs/backup/state.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | snapshots: match & disk_job.snapshots { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | & Some (ref disk_snapshots) => { [INFO] [stderr] 226 | | [INFO] [stderr] ... | [INFO] [stderr] 238 | | [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 223 | snapshots: match disk_job.snapshots { [INFO] [stderr] 224 | [INFO] [stderr] 225 | Some (ref disk_snapshots) => { [INFO] [stderr] 226 | [INFO] [stderr] 227 | disk_snapshots.iter ().map ( [INFO] [stderr] 228 | |disk_snapshot| [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/wbs/backup/time.rs:90:2 [INFO] [stderr] | [INFO] [stderr] 90 | match opt_str { [INFO] [stderr] | _____^ [INFO] [stderr] 91 | | & None => { None }, [INFO] [stderr] 92 | | & Some (ref val) => { Some (time_parse (& val)) }, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | match *opt_str { [INFO] [stderr] 91 | None => { None }, [INFO] [stderr] 92 | Some (ref val) => { Some (time_parse (& val)) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wbs-backup-daemon`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8b90a9d81d5300679a0d09d98176c741652d2d3650ff745173f235de9ecc0566"` [INFO] running `"docker" "rm" "-f" "8b90a9d81d5300679a0d09d98176c741652d2d3650ff745173f235de9ecc0566"` [INFO] [stdout] 8b90a9d81d5300679a0d09d98176c741652d2d3650ff745173f235de9ecc0566