[INFO] crate wayland-window 0.13.3 is already in cache [INFO] extracting crate wayland-window 0.13.3 into work/ex/clippy-test-run/sources/stable/reg/wayland-window/0.13.3 [INFO] extracting crate wayland-window 0.13.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-window/0.13.3 [INFO] validating manifest of wayland-window-0.13.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wayland-window-0.13.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wayland-window-0.13.3 [INFO] finished frobbing wayland-window-0.13.3 [INFO] frobbed toml for wayland-window-0.13.3 written to work/ex/clippy-test-run/sources/stable/reg/wayland-window/0.13.3/Cargo.toml [INFO] started frobbing wayland-window-0.13.3 [INFO] finished frobbing wayland-window-0.13.3 [INFO] frobbed toml for wayland-window-0.13.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-window/0.13.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wayland-window-0.13.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wayland-window/0.13.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cde3a5e2412a10f1f1e52d294444f2b62ff0526ff4afbd314c93e79af051ace1 [INFO] running `"docker" "start" "-a" "cde3a5e2412a10f1f1e52d294444f2b62ff0526ff4afbd314c93e79af051ace1"` [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-window v0.13.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | shell_surface: shell_surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shell_surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | tempfile: tempfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tempfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | frame_surface: frame_surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | shell_surface: shell_surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shell_surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | seat: seat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/themed_pointer.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/themed_pointer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/themed_pointer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | theme: theme, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shell/mod.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | toplevel: toplevel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `toplevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | implementation: implementation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implementation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | implementation: implementation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implementation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | pstate: pstate, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pstate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | shell_surface: shell_surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shell_surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | tempfile: tempfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tempfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | frame_surface: frame_surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | shell_surface: shell_surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shell_surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pointer.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | seat: seat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/themed_pointer.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/themed_pointer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/themed_pointer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | theme: theme, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shell/mod.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | toplevel: toplevel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `toplevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | implementation: implementation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implementation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | implementation: implementation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implementation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | pstate: pstate, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pstate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pointer.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return meta.need_redraw; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `meta.need_redraw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/theme.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 74 | | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] 75 | | Location::BottomLeft [INFO] [stderr] 76 | | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | } else if x <= DECORATION_SIZE as f64 { [INFO] [stderr] 74 | Location::BottomLeft [INFO] [stderr] 75 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] 76 | Location::Bottom [INFO] [stderr] 77 | } else { [INFO] [stderr] 78 | Location::BottomRight [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pointer.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return meta.need_redraw; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `meta.need_redraw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/theme.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 74 | | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] 75 | | Location::BottomLeft [INFO] [stderr] 76 | | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | } else if x <= DECORATION_SIZE as f64 { [INFO] [stderr] 74 | Location::BottomLeft [INFO] [stderr] 75 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] 76 | Location::Bottom [INFO] [stderr] 77 | } else { [INFO] [stderr] 78 | Location::BottomRight [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/frame.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let _ = self.tempfile.write_all(&[0, 0, 0, 0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/frame.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / let _ = ::theme::draw_contents( [INFO] [stderr] 183 | | &mut *mmap, [INFO] [stderr] 184 | | w as u32, [INFO] [stderr] 185 | | h as u32, [INFO] [stderr] ... | [INFO] [stderr] 189 | | meta.ptr_location, [INFO] [stderr] 190 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | if y <= DECORATION_TOP_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_TOP_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | if y <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | if (w >= 24) && (x > (w + DECORATION_SIZE - 24) as f64) && (x <= (w + DECORATION_SIZE) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 24)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:42:82 [INFO] [stderr] | [INFO] [stderr] 42 | if (w >= 24) && (x > (w + DECORATION_SIZE - 24) as f64) && (x <= (w + DECORATION_SIZE) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | && (y > DECORATION_SIZE as f64) && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:43:62 [INFO] [stderr] | [INFO] [stderr] 43 | && (y > DECORATION_SIZE as f64) && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE + 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | } else if (w >= 56) && (x > (w + DECORATION_SIZE - 56) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 56)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | && (x <= (w + DECORATION_SIZE - 32) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | && (y > DECORATION_SIZE as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE + 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | } else if (w >= 88) && (x > (w + DECORATION_SIZE - 88) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 88)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | && (x <= (w + DECORATION_SIZE - 64) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | && (y > DECORATION_SIZE as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE + 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | } else if y <= (DECORATION_TOP_SIZE + h) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_TOP_SIZE + h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `idx` [INFO] [stderr] --> src/theme.rs:208:23 [INFO] [stderr] | [INFO] [stderr] 208 | self.contents[idx + 0] = val[0]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/shell/xdg.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | unsafe { ::std::slice::from_raw_parts(states.as_ptr() as *const _, states.len() / 4) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | implementation: self.implementation.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.implementation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:223:1 [INFO] [stderr] | [INFO] [stderr] 223 | / pub fn create_frame(evqh: &mut EventQueueHandle, implementation: FrameImplementation, [INFO] [stderr] 224 | | idata: ID, surface: &wl_surface::WlSurface, width: i32, height: i32, [INFO] [stderr] 225 | | compositor: &wl_compositor::WlCompositor, [INFO] [stderr] 226 | | subcompositor: &wl_subcompositor::WlSubcompositor, shm: &wl_shm::WlShm, [INFO] [stderr] ... | [INFO] [stderr] 274 | | Ok(frame) [INFO] [stderr] 275 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wayland-window`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/frame.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let _ = self.tempfile.write_all(&[0, 0, 0, 0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/frame.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / let _ = ::theme::draw_contents( [INFO] [stderr] 183 | | &mut *mmap, [INFO] [stderr] 184 | | w as u32, [INFO] [stderr] 185 | | h as u32, [INFO] [stderr] ... | [INFO] [stderr] 189 | | meta.ptr_location, [INFO] [stderr] 190 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | if y <= DECORATION_TOP_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_TOP_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | if y <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | if (w >= 24) && (x > (w + DECORATION_SIZE - 24) as f64) && (x <= (w + DECORATION_SIZE) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 24)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:42:82 [INFO] [stderr] | [INFO] [stderr] 42 | if (w >= 24) && (x > (w + DECORATION_SIZE - 24) as f64) && (x <= (w + DECORATION_SIZE) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | && (y > DECORATION_SIZE as f64) && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:43:62 [INFO] [stderr] | [INFO] [stderr] 43 | && (y > DECORATION_SIZE as f64) && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE + 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | } else if (w >= 56) && (x > (w + DECORATION_SIZE - 56) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 56)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | && (x <= (w + DECORATION_SIZE - 32) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | && (y > DECORATION_SIZE as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE + 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | } else if (w >= 88) && (x > (w + DECORATION_SIZE - 88) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 88)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | && (x <= (w + DECORATION_SIZE - 64) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE - 64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | && (y > DECORATION_SIZE as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | && (y <= (DECORATION_SIZE + 16) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE + 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | } else if y <= (DECORATION_TOP_SIZE + h) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_TOP_SIZE + h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | if x <= DECORATION_SIZE as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/theme.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | } else if x <= (w + DECORATION_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(w + DECORATION_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `idx` [INFO] [stderr] --> src/theme.rs:208:23 [INFO] [stderr] | [INFO] [stderr] 208 | self.contents[idx + 0] = val[0]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/shell/xdg.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | unsafe { ::std::slice::from_raw_parts(states.as_ptr() as *const _, states.len() / 4) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | implementation: self.implementation.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.implementation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:223:1 [INFO] [stderr] | [INFO] [stderr] 223 | / pub fn create_frame(evqh: &mut EventQueueHandle, implementation: FrameImplementation, [INFO] [stderr] 224 | | idata: ID, surface: &wl_surface::WlSurface, width: i32, height: i32, [INFO] [stderr] 225 | | compositor: &wl_compositor::WlCompositor, [INFO] [stderr] 226 | | subcompositor: &wl_subcompositor::WlSubcompositor, shm: &wl_shm::WlShm, [INFO] [stderr] ... | [INFO] [stderr] 274 | | Ok(frame) [INFO] [stderr] 275 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wayland-window`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cde3a5e2412a10f1f1e52d294444f2b62ff0526ff4afbd314c93e79af051ace1"` [INFO] running `"docker" "rm" "-f" "cde3a5e2412a10f1f1e52d294444f2b62ff0526ff4afbd314c93e79af051ace1"` [INFO] [stdout] cde3a5e2412a10f1f1e52d294444f2b62ff0526ff4afbd314c93e79af051ace1