[INFO] crate wayland-commons 0.21.7 is already in cache
[INFO] extracting crate wayland-commons 0.21.7 into work/ex/clippy-test-run/sources/stable/reg/wayland-commons/0.21.7
[INFO] extracting crate wayland-commons 0.21.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-commons/0.21.7
[INFO] validating manifest of wayland-commons-0.21.7 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wayland-commons-0.21.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wayland-commons-0.21.7
[INFO] finished frobbing wayland-commons-0.21.7
[INFO] frobbed toml for wayland-commons-0.21.7 written to work/ex/clippy-test-run/sources/stable/reg/wayland-commons/0.21.7/Cargo.toml
[INFO] started frobbing wayland-commons-0.21.7
[INFO] finished frobbing wayland-commons-0.21.7
[INFO] frobbed toml for wayland-commons-0.21.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-commons/0.21.7/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wayland-commons-0.21.7 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wayland-commons/0.21.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 26364954f75666d57027b70ff9d6bc5b40a627ed4a1c41c8d2eeef4feaf8df09
[INFO] running `"docker" "start" "-a" "26364954f75666d57027b70ff9d6bc5b40a627ed4a1c41c8d2eeef4feaf8df09"`
[INFO] [stderr]     Checking wayland-commons v0.21.7 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             version: version,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             meta: meta,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `meta`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             meta: meta,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `meta`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/socket.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/utils.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 value: value,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/wire.rs:286:13
[INFO] [stderr]     |
[INFO] [stderr] 286 |             sender_id: sender_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/wire.rs:287:13
[INFO] [stderr]     |
[INFO] [stderr] 287 |             opcode: opcode,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `opcode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             version: version,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             meta: meta,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `meta`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             meta: meta,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `meta`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/socket.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/utils.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 value: value,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/wire.rs:286:13
[INFO] [stderr]     |
[INFO] [stderr] 286 |             sender_id: sender_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/wire.rs:287:13
[INFO] [stderr]     |
[INFO] [stderr] 287 |             opcode: opcode,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `opcode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/map.rs:6:34
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub const SERVER_ID_LIMIT: u32 = 0xFF000000;
[INFO] [stderr]   |                                  ^^^^^^^^^^ help: consider: `0xFF00_0000`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/map.rs:18:21
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn child(&self) -> () {
[INFO] [stderr]    |                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/map.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         ()
[INFO] [stderr]    |         ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/map.rs:135:16
[INFO] [stderr]     |
[INFO] [stderr] 135 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 136 | |             if let Some(place) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 137 | |                 *place = None;
[INFO] [stderr] 138 | |             }
[INFO] [stderr] 139 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 135 |         } else if let Some(place) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 136 |     *place = None;
[INFO] [stderr] 137 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/map.rs:174:16
[INFO] [stderr]     |
[INFO] [stderr] 174 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 175 | |             if let Some(&mut Some(ref mut obj)) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 176 | |                 Ok(f(obj))
[INFO] [stderr] 177 | |             } else {
[INFO] [stderr] 178 | |                 Err(())
[INFO] [stderr] 179 | |             }
[INFO] [stderr] 180 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 174 |         } else if let Some(&mut Some(ref mut obj)) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 175 |     Ok(f(obj))
[INFO] [stderr] 176 | } else {
[INFO] [stderr] 177 |     Err(())
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/socket.rs:248:37
[INFO] [stderr]     |
[INFO] [stderr] 248 |             let opcode = (data[1] & 0x0000FFFF) as u16;
[INFO] [stderr]     |                                     ^^^^^^^^^^ help: consider: `0x0000_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/wire.rs:232:32
[INFO] [stderr]     |
[INFO] [stderr] 232 |         let opcode = (word_2 & 0x0000FFFF) as u16;
[INFO] [stderr]     |                                ^^^^^^^^^^ help: consider: `0x0000_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/wire.rs:311:21
[INFO] [stderr]     |
[INFO] [stderr] 311 |                     return Ok(newfd);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(newfd)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/wire.rs:316:21
[INFO] [stderr]     |
[INFO] [stderr] 316 |                     return Err(e);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/map.rs:6:34
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub const SERVER_ID_LIMIT: u32 = 0xFF000000;
[INFO] [stderr]   |                                  ^^^^^^^^^^ help: consider: `0xFF00_0000`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/map.rs:18:21
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn child(&self) -> () {
[INFO] [stderr]    |                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/map.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         ()
[INFO] [stderr]    |         ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/map.rs:135:16
[INFO] [stderr]     |
[INFO] [stderr] 135 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 136 | |             if let Some(place) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 137 | |                 *place = None;
[INFO] [stderr] 138 | |             }
[INFO] [stderr] 139 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 135 |         } else if let Some(place) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 136 |     *place = None;
[INFO] [stderr] 137 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/map.rs:174:16
[INFO] [stderr]     |
[INFO] [stderr] 174 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 175 | |             if let Some(&mut Some(ref mut obj)) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 176 | |                 Ok(f(obj))
[INFO] [stderr] 177 | |             } else {
[INFO] [stderr] 178 | |                 Err(())
[INFO] [stderr] 179 | |             }
[INFO] [stderr] 180 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 174 |         } else if let Some(&mut Some(ref mut obj)) = self.client_objects.get_mut((id - 1) as usize) {
[INFO] [stderr] 175 |     Ok(f(obj))
[INFO] [stderr] 176 | } else {
[INFO] [stderr] 177 |     Err(())
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/socket.rs:248:37
[INFO] [stderr]     |
[INFO] [stderr] 248 |             let opcode = (data[1] & 0x0000FFFF) as u16;
[INFO] [stderr]     |                                     ^^^^^^^^^^ help: consider: `0x0000_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/wire.rs:232:32
[INFO] [stderr]     |
[INFO] [stderr] 232 |         let opcode = (word_2 & 0x0000FFFF) as u16;
[INFO] [stderr]     |                                ^^^^^^^^^^ help: consider: `0x0000_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/wire.rs:311:21
[INFO] [stderr]     |
[INFO] [stderr] 311 |                     return Ok(newfd);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(newfd)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/wire.rs:316:21
[INFO] [stderr]     |
[INFO] [stderr] 316 |                     return Err(e);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::ObjectMap<Meta>`
[INFO] [stderr]    --> src/map.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 | /     pub fn new() -> ObjectMap<Meta> {
[INFO] [stderr] 110 | |         ObjectMap {
[INFO] [stderr] 111 | |             client_objects: Vec::new(),
[INFO] [stderr] 112 | |             server_objects: Vec::new(),
[INFO] [stderr] 113 | |         }
[INFO] [stderr] 114 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 102 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/socket.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if fds.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fds.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::ObjectMap<Meta>`
[INFO] [stderr]    --> src/map.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 | /     pub fn new() -> ObjectMap<Meta> {
[INFO] [stderr] 110 | |         ObjectMap {
[INFO] [stderr] 111 | |             client_objects: Vec::new(),
[INFO] [stderr] 112 | |             server_objects: Vec::new(),
[INFO] [stderr] 113 | |         }
[INFO] [stderr] 114 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 102 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/socket.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if fds.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fds.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utils::UserDataMap`
[INFO] [stderr]   --> src/utils.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 | /     pub fn new() -> UserDataMap {
[INFO] [stderr] 84 | |         UserDataMap {
[INFO] [stderr] 85 | |             list: AppendList::new(),
[INFO] [stderr] 86 | |         }
[INFO] [stderr] 87 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 | impl Default for utils::UserDataMap {
[INFO] [stderr] 82 |     fn default() -> Self {
[INFO] [stderr] 83 |         Self::new()
[INFO] [stderr] 84 |     }
[INFO] [stderr] 85 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utils::UserDataMap`
[INFO] [stderr]   --> src/utils.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 | /     pub fn new() -> UserDataMap {
[INFO] [stderr] 84 | |         UserDataMap {
[INFO] [stderr] 85 | |             list: AppendList::new(),
[INFO] [stderr] 86 | |         }
[INFO] [stderr] 87 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 | impl Default for utils::UserDataMap {
[INFO] [stderr] 82 |     fn default() -> Self {
[INFO] [stderr] 83 |         Self::new()
[INFO] [stderr] 84 |     }
[INFO] [stderr] 85 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/utils.rs:160:21
[INFO] [stderr]     |
[INFO] [stderr] 160 |         fn into_raw(ptr: NodePtr<T>) -> *mut Node<T> {
[INFO] [stderr]     |                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/utils.rs:160:21
[INFO] [stderr]     |
[INFO] [stderr] 160 |         fn into_raw(ptr: NodePtr<T>) -> *mut Node<T> {
[INFO] [stderr]     |                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]    --> src/utils.rs:167:16
[INFO] [stderr]     |
[INFO] [stderr] 167 |             if ptr == ptr::null_mut() {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_null)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]    --> src/utils.rs:167:16
[INFO] [stderr]     |
[INFO] [stderr] 167 |             if ptr == ptr::null_mut() {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_null)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/wire.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 | /         fn write_buf<'a, T>(u: T, payload: &'a mut [T]) -> Result<&'a mut [T], MessageWriteError> {
[INFO] [stderr] 124 | |             if let Some((head, tail)) = payload.split_first_mut() {
[INFO] [stderr] 125 | |                 *head = u;
[INFO] [stderr] 126 | |                 Ok(tail)
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |             }
[INFO] [stderr] 130 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/wire.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 | /         fn write_buf<'a, T>(u: T, payload: &'a mut [T]) -> Result<&'a mut [T], MessageWriteError> {
[INFO] [stderr] 124 | |             if let Some((head, tail)) = payload.split_first_mut() {
[INFO] [stderr] 125 | |                 *head = u;
[INFO] [stderr] 126 | |                 Ok(tail)
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |             }
[INFO] [stderr] 130 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/wire.rs:195:51
[INFO] [stderr]     |
[INFO] [stderr] 195 |         header[1] = ((wrote_size as u32) << 16) | self.opcode as u32;
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.opcode)`
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/wire.rs:195:51
[INFO] [stderr]     |
[INFO] [stderr] 195 |         header[1] = ((wrote_size as u32) << 16) | self.opcode as u32;
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.opcode)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.50s
[INFO] running `"docker" "inspect" "26364954f75666d57027b70ff9d6bc5b40a627ed4a1c41c8d2eeef4feaf8df09"`
[INFO] running `"docker" "rm" "-f" "26364954f75666d57027b70ff9d6bc5b40a627ed4a1c41c8d2eeef4feaf8df09"`
[INFO] [stdout] 26364954f75666d57027b70ff9d6bc5b40a627ed4a1c41c8d2eeef4feaf8df09