[INFO] crate way-cooler-ipc 0.0.0 is already in cache [INFO] extracting crate way-cooler-ipc 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/way-cooler-ipc/0.0.0 [INFO] extracting crate way-cooler-ipc 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/way-cooler-ipc/0.0.0 [INFO] validating manifest of way-cooler-ipc-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of way-cooler-ipc-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing way-cooler-ipc-0.0.0 [INFO] finished frobbing way-cooler-ipc-0.0.0 [INFO] frobbed toml for way-cooler-ipc-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/way-cooler-ipc/0.0.0/Cargo.toml [INFO] started frobbing way-cooler-ipc-0.0.0 [INFO] finished frobbing way-cooler-ipc-0.0.0 [INFO] frobbed toml for way-cooler-ipc-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/way-cooler-ipc/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting way-cooler-ipc-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/way-cooler-ipc/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50d3660119d5c33e4f618c1141b7ab9a87798c049ff292c6bf1d7cc5cee457d4 [INFO] running `"docker" "start" "-a" "50d3660119d5c33e4f618c1141b7ab9a87798c049ff292c6bf1d7cc5cee457d4"` [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Checking way-cooler-ipc v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Json::from_reader(&mut stream_json).map_err(ReceiveError::Parse); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Json::from_reader(&mut stream_json).map_err(ReceiveError::Parse)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToJson` [INFO] [stderr] --> src/message.rs:5:35 [INFO] [stderr] | [INFO] [stderr] 5 | use rustc_serialize::json::{Json, ToJson}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Write` [INFO] [stderr] --> src/command.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Error as IOError` [INFO] [stderr] --> src/command.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::Error as IOError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Json::from_reader(&mut stream_json).map_err(ReceiveError::Parse); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Json::from_reader(&mut stream_json).map_err(ReceiveError::Parse)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToJson` [INFO] [stderr] --> src/message.rs:5:35 [INFO] [stderr] | [INFO] [stderr] 5 | use rustc_serialize::json::{Json, ToJson}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Write` [INFO] [stderr] --> src/command.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Error as IOError` [INFO] [stderr] --> src/command.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::Error as IOError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/command.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn send(command: Command) -> CommandResult { [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `SendError` [INFO] [stderr] --> src/client.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub enum SendError { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ReceiveError` [INFO] [stderr] --> src/client.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub enum ReceiveError { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stream` [INFO] [stderr] --> src/client.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | stream: UnixStream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `u32_to_bytes` [INFO] [stderr] --> src/client.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | fn u32_to_bytes(input: u32) -> [u8; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `u32_from_bytes` [INFO] [stderr] --> src/client.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | fn u32_from_bytes(bytes: [u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `stream` [INFO] [stderr] --> src/client.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn stream(&self) -> &UnixStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `stream_mut` [INFO] [stderr] --> src/client.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn stream_mut(&mut self) -> &mut UnixStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_stream` [INFO] [stderr] --> src/client.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn into_stream(self) -> UnixStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_message` [INFO] [stderr] --> src/client.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn read_message(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `send_message` [INFO] [stderr] --> src/client.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn send_message(&mut self, message: &Json) -> Result<(), SendError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:73:55 [INFO] [stderr] | [INFO] [stderr] 73 | let mut stream_json = (&mut self.stream).take(len as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | SocketClient::connect(path).map(|s| CommandClient(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CommandClient` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/command.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn send(command: Command) -> CommandResult { [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `SendError` [INFO] [stderr] --> src/client.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub enum SendError { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ReceiveError` [INFO] [stderr] --> src/client.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub enum ReceiveError { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stream` [INFO] [stderr] --> src/client.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | stream: UnixStream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `u32_to_bytes` [INFO] [stderr] --> src/client.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | fn u32_to_bytes(input: u32) -> [u8; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `u32_from_bytes` [INFO] [stderr] --> src/client.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | fn u32_from_bytes(bytes: [u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `stream` [INFO] [stderr] --> src/client.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn stream(&self) -> &UnixStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `stream_mut` [INFO] [stderr] --> src/client.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn stream_mut(&mut self) -> &mut UnixStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_stream` [INFO] [stderr] --> src/client.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn into_stream(self) -> UnixStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_message` [INFO] [stderr] --> src/client.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn read_message(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `send_message` [INFO] [stderr] --> src/client.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn send_message(&mut self, message: &Json) -> Result<(), SendError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:73:55 [INFO] [stderr] | [INFO] [stderr] 73 | let mut stream_json = (&mut self.stream).take(len as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | SocketClient::connect(path).map(|s| CommandClient(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CommandClient` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.74s [INFO] running `"docker" "inspect" "50d3660119d5c33e4f618c1141b7ab9a87798c049ff292c6bf1d7cc5cee457d4"` [INFO] running `"docker" "rm" "-f" "50d3660119d5c33e4f618c1141b7ab9a87798c049ff292c6bf1d7cc5cee457d4"` [INFO] [stdout] 50d3660119d5c33e4f618c1141b7ab9a87798c049ff292c6bf1d7cc5cee457d4