[INFO] crate way-cooler-bg 0.2.1 is already in cache [INFO] extracting crate way-cooler-bg 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/way-cooler-bg/0.2.1 [INFO] extracting crate way-cooler-bg 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/way-cooler-bg/0.2.1 [INFO] validating manifest of way-cooler-bg-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of way-cooler-bg-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing way-cooler-bg-0.2.1 [INFO] finished frobbing way-cooler-bg-0.2.1 [INFO] frobbed toml for way-cooler-bg-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/way-cooler-bg/0.2.1/Cargo.toml [INFO] started frobbing way-cooler-bg-0.2.1 [INFO] finished frobbing way-cooler-bg-0.2.1 [INFO] frobbed toml for way-cooler-bg-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/way-cooler-bg/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting way-cooler-bg-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/way-cooler-bg/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f359e970661546822f07248f3e81e1fe92c648131c51b9d56f22961b6e90d80 [INFO] running `"docker" "start" "-a" "1f359e970661546822f07248f3e81e1fe92c648131c51b9d56f22961b6e90d80"` [INFO] [stderr] Compiling libdbus-sys v0.1.5 [INFO] [stderr] Compiling phf v0.7.24 [INFO] [stderr] Compiling wayland-scanner v0.6.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking dbus v0.5.4 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Compiling wayland-client v0.6.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.6.0 [INFO] [stderr] Checking way-cooler-bg v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | let blue = ((val & 0xff0000) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | let green = ((val & 0x00ff00) >> 8) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | let red = (val & 0x0000ff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | const CURSOR: &'static [u8; 656] = include_bytes!("../assets/arrow.png"); [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 656]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | let blue = ((val & 0xff0000) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | let green = ((val & 0x00ff00) >> 8) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | let red = (val & 0x0000ff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | const CURSOR: &'static [u8; 656] = include_bytes!("../assets/arrow.png"); [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 656]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | let big_num = num as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | let output_id = match screen_r { [INFO] [stderr] | _____________________^ [INFO] [stderr] 173 | | &MessageItem::Array(ref items, _) => { [INFO] [stderr] 174 | | match items[0] { [INFO] [stderr] 175 | | MessageItem::Str(ref string) => string.clone(), [INFO] [stderr] ... | [INFO] [stderr] 179 | | _ => panic!("Wrong type from Screen") [INFO] [stderr] 180 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 172 | let output_id = match *screen_r { [INFO] [stderr] 173 | MessageItem::Array(ref items, _) => { [INFO] [stderr] --> src/main.rs:159:19 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 159 | let big_num = num as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | let output_id = match screen_r { [INFO] [stderr] | _____________________^ [INFO] [stderr] 173 | | &MessageItem::Array(ref items, _) => { [INFO] [stderr] 174 | | match items[0] { [INFO] [stderr] 175 | | MessageItem::Str(ref string) => string.clone(), [INFO] [stderr] ... | [INFO] [stderr] 179 | | _ => panic!("Wrong type from Screen") [INFO] [stderr] 180 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] | [INFO] [stderr] --> src/main.rs:213:19 [INFO] [stderr] | [INFO] [stderr] 213 | let mut tmp = tempfile::tempfile().ok().expect("Unable to create a tempfile."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 172 | let output_id = match *screen_r { [INFO] [stderr] 173 | MessageItem::Array(ref items, _) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u32`) to itself [INFO] [stderr] --> src/main.rs:223:43 [INFO] [stderr] | [INFO] [stderr] 223 | tmp.write_u32::(transmute(color.to_u32())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:213:19 [INFO] [stderr] | [INFO] [stderr] 213 | let mut tmp = tempfile::tempfile().ok().expect("Unable to create a tempfile."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u32`) to itself [INFO] [stderr] --> src/main.rs:223:43 [INFO] [stderr] | [INFO] [stderr] 223 | tmp.write_u32::(transmute(color.to_u32())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:279:34 [INFO] [stderr] | [INFO] [stderr] 279 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:279:53 [INFO] [stderr] --> src/main.rs:279:34 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 279 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] 279 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:279:53 [INFO] [stderr] | [INFO] [stderr] 279 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:34 [INFO] [stderr] | [INFO] [stderr] 280 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:54 [INFO] [stderr] | [INFO] [stderr] 280 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:34 [INFO] [stderr] | [INFO] [stderr] 280 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:54 [INFO] [stderr] | [INFO] [stderr] 280 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:286:44 [INFO] [stderr] | [INFO] [stderr] 286 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:287:45 [INFO] [stderr] | [INFO] [stderr] 287 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:286:44 [INFO] [stderr] | [INFO] [stderr] 286 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:297:34 [INFO] [stderr] | [INFO] [stderr] 297 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:287:45 [INFO] [stderr] | [INFO] [stderr] 287 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:297:53 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] 297 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:34 [INFO] [stderr] | [INFO] [stderr] 298 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:54 [INFO] [stderr] | [INFO] [stderr] 298 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:304:44 [INFO] [stderr] | [INFO] [stderr] 304 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:297:34 [INFO] [stderr] | [INFO] [stderr] 297 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:305:45 [INFO] [stderr] | [INFO] [stderr] 305 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:297:53 [INFO] [stderr] | [INFO] [stderr] 297 | let width_sr: f64 = scr_width as f64 / img_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:34 [INFO] [stderr] | [INFO] [stderr] 298 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:54 [INFO] [stderr] | [INFO] [stderr] 298 | let height_sr: f64 = scr_height as f64 / img_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:304:44 [INFO] [stderr] | [INFO] [stderr] 304 | let img_width = (scale_ratio * img_width as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:305:45 [INFO] [stderr] | [INFO] [stderr] 305 | let img_height = (scale_ratio * img_height as f64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:338:40 [INFO] [stderr] | [INFO] [stderr] 338 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:338:59 [INFO] [stderr] | [INFO] [stderr] 338 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:40 [INFO] [stderr] | [INFO] [stderr] 339 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:60 [INFO] [stderr] | [INFO] [stderr] 339 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | / let tmp = pixel[2]; [INFO] [stderr] 368 | | pixel[2] = pixel[0]; [INFO] [stderr] 369 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:362:25 [INFO] [stderr] | [INFO] [stderr] 362 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:375:17 [INFO] [stderr] | [INFO] [stderr] 375 | tmp.set_len(img_size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(img_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:338:40 [INFO] [stderr] | [INFO] [stderr] 338 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:338:59 [INFO] [stderr] | [INFO] [stderr] 338 | let repeat_x_count: u32 = (scr_width as f64 / img_width as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:40 [INFO] [stderr] | [INFO] [stderr] 339 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scr_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:60 [INFO] [stderr] | [INFO] [stderr] 339 | let repeat_y_count: u32 = (scr_height as f64 / img_height as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(img_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | / let tmp = pixel[2]; [INFO] [stderr] 409 | | pixel[2] = pixel[0]; [INFO] [stderr] 410 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | / let tmp = pixel[2]; [INFO] [stderr] 368 | | pixel[2] = pixel[0]; [INFO] [stderr] 369 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:362:25 [INFO] [stderr] | [INFO] [stderr] 362 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:415:17 [INFO] [stderr] | [INFO] [stderr] 415 | tmp.set_len(size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:375:17 [INFO] [stderr] | [INFO] [stderr] 375 | tmp.set_len(img_size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(img_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | / match event { [INFO] [stderr] 440 | | Event::Wayland(wayland_event) => { [INFO] [stderr] 441 | | match wayland_event { [INFO] [stderr] 442 | | WaylandProtocolEvent::WlPointer(id, pointer_event) => { [INFO] [stderr] ... | [INFO] [stderr] 454 | | _ => { /* unhandled events */ } [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 439 | if let Event::Wayland(wayland_event) = event { [INFO] [stderr] 440 | match wayland_event { [INFO] [stderr] 441 | WaylandProtocolEvent::WlPointer(id, pointer_event) => { [INFO] [stderr] 442 | match pointer_event { [INFO] [stderr] 443 | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] 444 | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | / match wayland_event { [INFO] [stderr] 442 | | WaylandProtocolEvent::WlPointer(id, pointer_event) => { [INFO] [stderr] 443 | | match pointer_event { [INFO] [stderr] 444 | | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] ... | [INFO] [stderr] 451 | | _ => {/* unhandled events */} [INFO] [stderr] 452 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 441 | if let WaylandProtocolEvent::WlPointer(id, pointer_event) = wayland_event { [INFO] [stderr] 442 | match pointer_event { [INFO] [stderr] 443 | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] 444 | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] 445 | }, [INFO] [stderr] 446 | _ => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:443:29 [INFO] [stderr] | [INFO] [stderr] 443 | / match pointer_event { [INFO] [stderr] 444 | | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] 445 | | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] 446 | | }, [INFO] [stderr] 447 | | _ => { [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 443 | if let WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) = pointer_event { [INFO] [stderr] 444 | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] 445 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pixel[2]` and `pixel[0]` manually [INFO] [stderr] --> src/main.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | / let tmp = pixel[2]; [INFO] [stderr] 409 | | pixel[2] = pixel[0]; [INFO] [stderr] 410 | | pixel[0] = tmp; [INFO] [stderr] | |__________________________^ help: try: `std::mem::swap(&mut pixel[2], &mut pixel[0])` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | let alpha = pixel[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(pixel[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:415:17 [INFO] [stderr] | [INFO] [stderr] 415 | tmp.set_len(size as u64).expect("Could not truncate length of file"); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:466:43 [INFO] [stderr] | [INFO] [stderr] 466 | assert_eq!(rgba_conversion(255, 500), 500); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | / match event { [INFO] [stderr] 440 | | Event::Wayland(wayland_event) => { [INFO] [stderr] 441 | | match wayland_event { [INFO] [stderr] 442 | | WaylandProtocolEvent::WlPointer(id, pointer_event) => { [INFO] [stderr] ... | [INFO] [stderr] 454 | | _ => { /* unhandled events */ } [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 439 | if let Event::Wayland(wayland_event) = event { [INFO] [stderr] 440 | match wayland_event { [INFO] [stderr] 441 | WaylandProtocolEvent::WlPointer(id, pointer_event) => { [INFO] [stderr] 442 | match pointer_event { [INFO] [stderr] 443 | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] 444 | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | / match wayland_event { [INFO] [stderr] 442 | | WaylandProtocolEvent::WlPointer(id, pointer_event) => { [INFO] [stderr] 443 | | match pointer_event { [INFO] [stderr] 444 | | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] ... | [INFO] [stderr] 451 | | _ => {/* unhandled events */} [INFO] [stderr] 452 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 441 | if let WaylandProtocolEvent::WlPointer(id, pointer_event) = wayland_event { [INFO] [stderr] 442 | match pointer_event { [INFO] [stderr] 443 | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] 444 | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] 445 | }, [INFO] [stderr] 446 | _ => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:443:29 [INFO] [stderr] | [INFO] [stderr] 443 | / match pointer_event { [INFO] [stderr] 444 | | WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) => { [INFO] [stderr] 445 | | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] 446 | | }, [INFO] [stderr] 447 | | _ => { [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 443 | if let WlPointerEvent::Enter(serial, background_surface, surface_x, surface_y) = pointer_event { [INFO] [stderr] 444 | pointer.set_cursor(0, Some(&cursor_surface), 0, 0); [INFO] [stderr] 445 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.35s [INFO] running `"docker" "inspect" "1f359e970661546822f07248f3e81e1fe92c648131c51b9d56f22961b6e90d80"` [INFO] running `"docker" "rm" "-f" "1f359e970661546822f07248f3e81e1fe92c648131c51b9d56f22961b6e90d80"` [INFO] [stdout] 1f359e970661546822f07248f3e81e1fe92c648131c51b9d56f22961b6e90d80