[INFO] crate wavefile 0.2.0 is already in cache [INFO] extracting crate wavefile 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/wavefile/0.2.0 [INFO] extracting crate wavefile 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wavefile/0.2.0 [INFO] validating manifest of wavefile-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wavefile-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wavefile-0.2.0 [INFO] finished frobbing wavefile-0.2.0 [INFO] frobbed toml for wavefile-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/wavefile/0.2.0/Cargo.toml [INFO] started frobbing wavefile-0.2.0 [INFO] finished frobbing wavefile-0.2.0 [INFO] frobbed toml for wavefile-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wavefile/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wavefile-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wavefile/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc4e6289bd717ef15ed30e791199ccfea9903722cb6bef00b41879c65141b17c [INFO] running `"docker" "start" "-a" "fc4e6289bd717ef15ed30e791199ccfea9903722cb6bef00b41879c65141b17c"` [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking wavefile v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | let mut file = WaveFile { mmap: mmap, data_offset: 0, data_size: 0, info: info }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:31 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:73 [INFO] [stderr] | [INFO] [stderr] 151 | let mut file = WaveFile { mmap: mmap, data_offset: 0, data_size: 0, info: info }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] 151 | let mut file = WaveFile { mmap: mmap, data_offset: 0, data_size: 0, info: info }; [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mmap` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:73 [INFO] [stderr] | [INFO] [stderr] 151 | let mut file = WaveFile { mmap: mmap, data_offset: 0, data_size: 0, info: info }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:251:7 [INFO] [stderr] | [INFO] [stderr] 251 | bytes_per_sample: bytes_per_sample [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_per_sample` [INFO] [stderr] | [INFO] [stderr] --> src/lib.rs:251:7 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 251 | bytes_per_sample: bytes_per_sample [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | const RIFF : u32 = 0x46464952; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4646_4952` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | const WAVE : u32 = 0x45564157; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4556_4157` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const FMT_ : u32 = 0x20746d66; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2074_6d66` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | const DATA : u32 = 0x61746164; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6174_6164` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | const LIST : u32 = 0x5453494c; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5453_494c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const FACT : u32 = 0x74636166; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7463_6166` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:403:34 [INFO] [stderr] | [INFO] [stderr] 403 | let scaled = (sample * 2147483647.0) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `2_147_483_647.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | const RIFF : u32 = 0x46464952; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4646_4952` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | const WAVE : u32 = 0x45564157; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4556_4157` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const FMT_ : u32 = 0x20746d66; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2074_6d66` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | const DATA : u32 = 0x61746164; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6174_6164` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | const LIST : u32 = 0x5453494c; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5453_494c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const FACT : u32 = 0x74636166; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7463_6166` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:403:34 [INFO] [stderr] | [INFO] [stderr] 403 | let scaled = (sample * 2147483647.0) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `2_147_483_647.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:426:36 [INFO] [stderr] | [INFO] [stderr] 426 | assert_eq!(info.byte_rate, 288000); [INFO] [stderr] | ^^^^^^ help: consider: `288_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:429:36 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(info.total_frames, 501888); [INFO] [stderr] | ^^^^^^ help: consider: `501_888` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:443:36 [INFO] [stderr] | [INFO] [stderr] 443 | assert_eq!(info.total_frames, 501888); [INFO] [stderr] | ^^^^^^ help: consider: `501_888` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:477:34 [INFO] [stderr] | [INFO] [stderr] 477 | assert_eq!(file.len(), 501888); [INFO] [stderr] | ^^^^^^ help: consider: `501_888` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:483:6 [INFO] [stderr] | [INFO] [stderr] 483 | [5012736, 5012736], [INFO] [stderr] | ^^^^^^^ help: consider: `5_012_736` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:483:15 [INFO] [stderr] | [INFO] [stderr] 483 | [5012736, 5012736], [INFO] [stderr] | ^^^^^^^ help: consider: `5_012_736` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:484:6 [INFO] [stderr] | [INFO] [stderr] 484 | [6230272, 6230272] [INFO] [stderr] | ^^^^^^^ help: consider: `6_230_272` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:484:15 [INFO] [stderr] | [INFO] [stderr] 484 | [6230272, 6230272] [INFO] [stderr] | ^^^^^^^ help: consider: `6_230_272` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &WaveError::ParseError(ref s) => &s, [INFO] [stderr] 34 | | &WaveError::Unsupported(ref s) => &s, [INFO] [stderr] 35 | | &WaveError::IoError(ref e) => e.description() [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | WaveError::ParseError(ref s) => &s, [INFO] [stderr] 34 | WaveError::Unsupported(ref s) => &s, [INFO] [stderr] 35 | WaveError::IoError(ref e) => e.description() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / match self { [INFO] [stderr] 41 | | &WaveError::IoError(ref e) => Some(e), [INFO] [stderr] 42 | | _ => None [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *self { [INFO] [stderr] 41 | WaveError::IoError(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &WaveError::IoError(ref e) => write!(f, "IO Error: {}", e), [INFO] [stderr] 51 | | &WaveError::ParseError(ref s) => write!(f, "Parse Error: {}", s), [INFO] [stderr] 52 | | &WaveError::Unsupported(ref s) => write!(f, "Unsupported Format Error: {}", s) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | WaveError::IoError(ref e) => write!(f, "IO Error: {}", e), [INFO] [stderr] 51 | WaveError::ParseError(ref s) => write!(f, "Parse Error: {}", s), [INFO] [stderr] 52 | WaveError::Unsupported(ref s) => write!(f, "Unsupported Format Error: {}", s) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:24:47 [INFO] [stderr] | [INFO] [stderr] 24 | const SPEAKER_FRONT_LEFT : isize = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/lib.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | Reserved = SPEAKER_RESERVED, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: item `WaveFile` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | / impl WaveFile { [INFO] [stderr] 124 | | /// Constructs a new `WaveFile`. [INFO] [stderr] 125 | | /// [INFO] [stderr] 126 | | /// # Example [INFO] [stderr] ... | [INFO] [stderr] 345 | | } [INFO] [stderr] 346 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:321:55 [INFO] [stderr] | [INFO] [stderr] 321 | LIST => { try!(cursor.seek(SeekFrom::Current(chunk_size as i64))); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:322:55 [INFO] [stderr] | [INFO] [stderr] 322 | FACT => { try!(cursor.seek(SeekFrom::Current(chunk_size as i64))); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:55 [INFO] [stderr] | [INFO] [stderr] 341 | self.info.total_frames = self.data_size as u32 / (self.info.channels as u32 * self.info.bits_per_sample as u32 / 8 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.info.channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:83 [INFO] [stderr] | [INFO] [stderr] 341 | self.info.total_frames = self.data_size as u32 / (self.info.channels as u32 * self.info.bits_per_sample as u32 / 8 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.info.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:354:12 [INFO] [stderr] | [INFO] [stderr] 354 | if let Err(_) = cursor.seek(SeekFrom::Start((self.base + self.pos) as u64)) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 355 | | return None; [INFO] [stderr] 356 | | }; [INFO] [stderr] | |_____- help: try this: `if cursor.seek(SeekFrom::Start((self.base + self.pos) as u64)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wavefile`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &WaveError::ParseError(ref s) => &s, [INFO] [stderr] 34 | | &WaveError::Unsupported(ref s) => &s, [INFO] [stderr] 35 | | &WaveError::IoError(ref e) => e.description() [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | WaveError::ParseError(ref s) => &s, [INFO] [stderr] 34 | WaveError::Unsupported(ref s) => &s, [INFO] [stderr] 35 | WaveError::IoError(ref e) => e.description() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / match self { [INFO] [stderr] 41 | | &WaveError::IoError(ref e) => Some(e), [INFO] [stderr] 42 | | _ => None [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *self { [INFO] [stderr] 41 | WaveError::IoError(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &WaveError::IoError(ref e) => write!(f, "IO Error: {}", e), [INFO] [stderr] 51 | | &WaveError::ParseError(ref s) => write!(f, "Parse Error: {}", s), [INFO] [stderr] 52 | | &WaveError::Unsupported(ref s) => write!(f, "Unsupported Format Error: {}", s) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | WaveError::IoError(ref e) => write!(f, "IO Error: {}", e), [INFO] [stderr] 51 | WaveError::ParseError(ref s) => write!(f, "Parse Error: {}", s), [INFO] [stderr] 52 | WaveError::Unsupported(ref s) => write!(f, "Unsupported Format Error: {}", s) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:24:47 [INFO] [stderr] | [INFO] [stderr] 24 | const SPEAKER_FRONT_LEFT : isize = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/lib.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | Reserved = SPEAKER_RESERVED, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: item `WaveFile` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | / impl WaveFile { [INFO] [stderr] 124 | | /// Constructs a new `WaveFile`. [INFO] [stderr] 125 | | /// [INFO] [stderr] 126 | | /// # Example [INFO] [stderr] ... | [INFO] [stderr] 345 | | } [INFO] [stderr] 346 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:321:55 [INFO] [stderr] | [INFO] [stderr] 321 | LIST => { try!(cursor.seek(SeekFrom::Current(chunk_size as i64))); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:322:55 [INFO] [stderr] | [INFO] [stderr] 322 | FACT => { try!(cursor.seek(SeekFrom::Current(chunk_size as i64))); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:55 [INFO] [stderr] | [INFO] [stderr] 341 | self.info.total_frames = self.data_size as u32 / (self.info.channels as u32 * self.info.bits_per_sample as u32 / 8 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.info.channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:83 [INFO] [stderr] | [INFO] [stderr] 341 | self.info.total_frames = self.data_size as u32 / (self.info.channels as u32 * self.info.bits_per_sample as u32 / 8 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.info.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:354:12 [INFO] [stderr] | [INFO] [stderr] 354 | if let Err(_) = cursor.seek(SeekFrom::Start((self.base + self.pos) as u64)) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 355 | | return None; [INFO] [stderr] 356 | | }; [INFO] [stderr] | |_____- help: try this: `if cursor.seek(SeekFrom::Start((self.base + self.pos) as u64)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wavefile`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fc4e6289bd717ef15ed30e791199ccfea9903722cb6bef00b41879c65141b17c"` [INFO] running `"docker" "rm" "-f" "fc4e6289bd717ef15ed30e791199ccfea9903722cb6bef00b41879c65141b17c"` [INFO] [stdout] fc4e6289bd717ef15ed30e791199ccfea9903722cb6bef00b41879c65141b17c