[INFO] crate waterbear-instruction-derive 0.1.0 is already in cache [INFO] extracting crate waterbear-instruction-derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/waterbear-instruction-derive/0.1.0 [INFO] extracting crate waterbear-instruction-derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/waterbear-instruction-derive/0.1.0 [INFO] validating manifest of waterbear-instruction-derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of waterbear-instruction-derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing waterbear-instruction-derive-0.1.0 [INFO] finished frobbing waterbear-instruction-derive-0.1.0 [INFO] frobbed toml for waterbear-instruction-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/waterbear-instruction-derive/0.1.0/Cargo.toml [INFO] started frobbing waterbear-instruction-derive-0.1.0 [INFO] finished frobbing waterbear-instruction-derive-0.1.0 [INFO] frobbed toml for waterbear-instruction-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/waterbear-instruction-derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting waterbear-instruction-derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/waterbear-instruction-derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 941f91c839019f1a1b1589006611f32e22e14b420b94aeab0574f2facfc751c8 [INFO] running `"docker" "start" "-a" "941f91c839019f1a1b1589006611f32e22e14b420b94aeab0574f2facfc751c8"` [INFO] [stderr] Checking waterbear-instruction-derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | name [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:128:33 [INFO] [stderr] | [INFO] [stderr] 128 | let name = NAME.captures_iter(&name_str).next().unwrap()[1].to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 302 | | if let Bit::Ref(name, idx) = &chunk[0] { [INFO] [stderr] 303 | | if let Bit::Ref(_, end) = chunk[chunk.len() - 1] { [INFO] [stderr] 304 | | BitRange::Ref { name: name.to_owned(), high: *idx, low: end } [INFO] [stderr] ... | [INFO] [stderr] 310 | | } [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 301 | } else if let Bit::Ref(name, idx) = &chunk[0] { [INFO] [stderr] 302 | if let Bit::Ref(_, end) = chunk[chunk.len() - 1] { [INFO] [stderr] 303 | BitRange::Ref { name: name.to_owned(), high: *idx, low: end } [INFO] [stderr] 304 | } else { [INFO] [stderr] 305 | panic!("Found literal in non-literal chunk. Should never happen."); [INFO] [stderr] 306 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:582:17 [INFO] [stderr] | [INFO] [stderr] 582 | const LETTERS: &'static [&'static str] = &["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:582:27 [INFO] [stderr] | [INFO] [stderr] 582 | const LETTERS: &'static [&'static str] = &["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | / return match value { [INFO] [stderr] 622 | | Lit::Str(pattern, _) => pattern.clone(), [INFO] [stderr] 623 | | _ => panic!("Expected string for bit pattern, found: {:?}", attr) [INFO] [stderr] 624 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 621 | match value { [INFO] [stderr] 622 | Lit::Str(pattern, _) => pattern.clone(), [INFO] [stderr] 623 | _ => panic!("Expected string for bit pattern, found: {:?}", attr) [INFO] [stderr] 624 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | name [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:128:33 [INFO] [stderr] | [INFO] [stderr] 128 | let name = NAME.captures_iter(&name_str).next().unwrap()[1].to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 302 | | if let Bit::Ref(name, idx) = &chunk[0] { [INFO] [stderr] 303 | | if let Bit::Ref(_, end) = chunk[chunk.len() - 1] { [INFO] [stderr] 304 | | BitRange::Ref { name: name.to_owned(), high: *idx, low: end } [INFO] [stderr] ... | [INFO] [stderr] 310 | | } [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 301 | } else if let Bit::Ref(name, idx) = &chunk[0] { [INFO] [stderr] 302 | if let Bit::Ref(_, end) = chunk[chunk.len() - 1] { [INFO] [stderr] 303 | BitRange::Ref { name: name.to_owned(), high: *idx, low: end } [INFO] [stderr] 304 | } else { [INFO] [stderr] 305 | panic!("Found literal in non-literal chunk. Should never happen."); [INFO] [stderr] 306 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:582:17 [INFO] [stderr] | [INFO] [stderr] 582 | const LETTERS: &'static [&'static str] = &["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:582:27 [INFO] [stderr] | [INFO] [stderr] 582 | const LETTERS: &'static [&'static str] = &["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | / return match value { [INFO] [stderr] 622 | | Lit::Str(pattern, _) => pattern.clone(), [INFO] [stderr] 623 | | _ => panic!("Expected string for bit pattern, found: {:?}", attr) [INFO] [stderr] 624 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 621 | match value { [INFO] [stderr] 622 | Lit::Str(pattern, _) => pattern.clone(), [INFO] [stderr] 623 | _ => panic!("Expected string for bit pattern, found: {:?}", attr) [INFO] [stderr] 624 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:664:36 [INFO] [stderr] | [INFO] [stderr] 664 | vec![BitRange::Literal(0b10000001, 8)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:675:35 [INFO] [stderr] | [INFO] [stderr] 675 | BitRange::Literal(0b1000001, 7), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:707:13 [INFO] [stderr] | [INFO] [stderr] 707 | 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:708:13 [INFO] [stderr] | [INFO] [stderr] 708 | 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:709:13 [INFO] [stderr] | [INFO] [stderr] 709 | 0b00011011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:710:13 [INFO] [stderr] | [INFO] [stderr] 710 | 0b00001011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:711:13 [INFO] [stderr] | [INFO] [stderr] 711 | 0b00011101, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:712:13 [INFO] [stderr] | [INFO] [stderr] 712 | 0b00001101, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:713:13 [INFO] [stderr] | [INFO] [stderr] 713 | 0b00011001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:714:13 [INFO] [stderr] | [INFO] [stderr] 714 | 0b00001001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:715:13 [INFO] [stderr] | [INFO] [stderr] 715 | 0b00011110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:716:13 [INFO] [stderr] | [INFO] [stderr] 716 | 0b00001110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:717:13 [INFO] [stderr] | [INFO] [stderr] 717 | 0b00011010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:718:13 [INFO] [stderr] | [INFO] [stderr] 718 | 0b00001010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | 0b00011100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:720:13 [INFO] [stderr] | [INFO] [stderr] 720 | 0b00001100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:721:13 [INFO] [stderr] | [INFO] [stderr] 721 | 0b00011000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:722:13 [INFO] [stderr] | [INFO] [stderr] 722 | 0b00001000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:740:13 [INFO] [stderr] | [INFO] [stderr] 740 | 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:741:13 [INFO] [stderr] | [INFO] [stderr] 741 | 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | 0b00011011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:743:13 [INFO] [stderr] | [INFO] [stderr] 743 | 0b00001011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:744:13 [INFO] [stderr] | [INFO] [stderr] 744 | 0b00011101, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:745:13 [INFO] [stderr] | [INFO] [stderr] 745 | 0b00001101, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:746:13 [INFO] [stderr] | [INFO] [stderr] 746 | 0b00011001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:747:13 [INFO] [stderr] | [INFO] [stderr] 747 | 0b00001001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:748:13 [INFO] [stderr] | [INFO] [stderr] 748 | 0b00011110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:749:13 [INFO] [stderr] | [INFO] [stderr] 749 | 0b00001110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:750:13 [INFO] [stderr] | [INFO] [stderr] 750 | 0b00011010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | 0b00001010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:752:13 [INFO] [stderr] | [INFO] [stderr] 752 | 0b00011100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | 0b00001100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:754:13 [INFO] [stderr] | [INFO] [stderr] 754 | 0b00011000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:755:13 [INFO] [stderr] | [INFO] [stderr] 755 | 0b00001000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | if extracted.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `extracted.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:252:29 [INFO] [stderr] | [INFO] [stderr] 252 | if text.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:276:11 [INFO] [stderr] | [INFO] [stderr] 276 | while text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | pos = pos + size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pos += size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | value = value | (data << idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value |= (data << idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | val = val | (1 << idx) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (1 << idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:475:38 [INFO] [stderr] | [INFO] [stderr] 475 | let mut names: Vec = name_map.keys().map(|text| text.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `name_map.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:489:21 [INFO] [stderr] | [INFO] [stderr] 489 | bit = bit - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:501:21 [INFO] [stderr] | [INFO] [stderr] 501 | bit = bit - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:525:17 [INFO] [stderr] | [INFO] [stderr] 525 | pos = pos - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pos -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:548:17 [INFO] [stderr] | [INFO] [stderr] 548 | pos = pos - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pos -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:599:29 [INFO] [stderr] | [INFO] [stderr] 599 | syn::Ident::new(format!("{}", LETTERS[idx])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `LETTERS[idx].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:618:10 [INFO] [stderr] | [INFO] [stderr] 618 | .expect(&format!("No instr attribute with bit pattern on variant: {}", variant.ident)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No instr attribute with bit pattern on variant: {}", variant.ident))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:615:16 [INFO] [stderr] | [INFO] [stderr] 615 | let attr = variant.attrs.iter() [INFO] [stderr] | ________________^ [INFO] [stderr] 616 | | .filter(|attr| attr.name() == "instr") [INFO] [stderr] 617 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|attr| attr.name() == "instr").next()` with `find(|attr| attr.name() == "instr")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | if extracted.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `extracted.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:252:29 [INFO] [stderr] | [INFO] [stderr] 252 | if text.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:276:11 [INFO] [stderr] | [INFO] [stderr] 276 | while text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | pos = pos + size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pos += size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | value = value | (data << idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value |= (data << idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | val = val | (1 << idx) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (1 << idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:475:38 [INFO] [stderr] | [INFO] [stderr] 475 | let mut names: Vec = name_map.keys().map(|text| text.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `name_map.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:489:21 [INFO] [stderr] | [INFO] [stderr] 489 | bit = bit - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:501:21 [INFO] [stderr] | [INFO] [stderr] 501 | bit = bit - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:525:17 [INFO] [stderr] | [INFO] [stderr] 525 | pos = pos - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pos -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:548:17 [INFO] [stderr] | [INFO] [stderr] 548 | pos = pos - size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pos -= size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:599:29 [INFO] [stderr] | [INFO] [stderr] 599 | syn::Ident::new(format!("{}", LETTERS[idx])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `LETTERS[idx].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:618:10 [INFO] [stderr] | [INFO] [stderr] 618 | .expect(&format!("No instr attribute with bit pattern on variant: {}", variant.ident)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No instr attribute with bit pattern on variant: {}", variant.ident))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:615:16 [INFO] [stderr] | [INFO] [stderr] 615 | let attr = variant.attrs.iter() [INFO] [stderr] | ________________^ [INFO] [stderr] 616 | | .filter(|attr| attr.name() == "instr") [INFO] [stderr] 617 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|attr| attr.name() == "instr").next()` with `find(|attr| attr.name() == "instr")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.37s [INFO] running `"docker" "inspect" "941f91c839019f1a1b1589006611f32e22e14b420b94aeab0574f2facfc751c8"` [INFO] running `"docker" "rm" "-f" "941f91c839019f1a1b1589006611f32e22e14b420b94aeab0574f2facfc751c8"` [INFO] [stdout] 941f91c839019f1a1b1589006611f32e22e14b420b94aeab0574f2facfc751c8