[INFO] crate wasmblock 0.0.15 is already in cache [INFO] extracting crate wasmblock 0.0.15 into work/ex/clippy-test-run/sources/stable/reg/wasmblock/0.0.15 [INFO] extracting crate wasmblock 0.0.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasmblock/0.0.15 [INFO] validating manifest of wasmblock-0.0.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasmblock-0.0.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasmblock-0.0.15 [INFO] finished frobbing wasmblock-0.0.15 [INFO] frobbed toml for wasmblock-0.0.15 written to work/ex/clippy-test-run/sources/stable/reg/wasmblock/0.0.15/Cargo.toml [INFO] started frobbing wasmblock-0.0.15 [INFO] finished frobbing wasmblock-0.0.15 [INFO] frobbed toml for wasmblock-0.0.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasmblock/0.0.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasmblock-0.0.15 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasmblock/0.0.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 077891cdee32568eab134514dcb198de01348783a61cd504bc4acafac6b5a091 [INFO] running `"docker" "start" "-a" "077891cdee32568eab134514dcb198de01348783a61cd504bc4acafac6b5a091"` [INFO] [stderr] Checking wasmblock v0.0.15 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/console.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dom.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timing.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/canvas.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/canvas.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return wasmblock_canvas_get_context(export_string(target)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `wasmblock_canvas_get_context(export_string(target))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return wasmblock_random_get_seed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `wasmblock_random_get_seed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/canvas.rs:49:40 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn put_image_data(ctx: u32, pixel: &Vec, x:i32,y:i32,width:i32,height:i32) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 49 | pub fn put_image_data(ctx: u32, pixel: &[u8], x:i32,y:i32,width:i32,height:i32) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `pixel.clone()` to [INFO] [stderr] | [INFO] [stderr] 51 | let pix = pixel.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | CStr::from_ptr(data).to_string_lossy().into_owned() [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasmblock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/console.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dom.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timing.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/canvas.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/canvas.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return wasmblock_canvas_get_context(export_string(target)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `wasmblock_canvas_get_context(export_string(target))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return wasmblock_random_get_seed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `wasmblock_random_get_seed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/canvas.rs:49:40 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn put_image_data(ctx: u32, pixel: &Vec, x:i32,y:i32,width:i32,height:i32) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 49 | pub fn put_image_data(ctx: u32, pixel: &[u8], x:i32,y:i32,width:i32,height:i32) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `pixel.clone()` to [INFO] [stderr] | [INFO] [stderr] 51 | let pix = pixel.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | CStr::from_ptr(data).to_string_lossy().into_owned() [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasmblock`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "077891cdee32568eab134514dcb198de01348783a61cd504bc4acafac6b5a091"` [INFO] running `"docker" "rm" "-f" "077891cdee32568eab134514dcb198de01348783a61cd504bc4acafac6b5a091"` [INFO] [stdout] 077891cdee32568eab134514dcb198de01348783a61cd504bc4acafac6b5a091