[INFO] crate wasm_val 0.3.2 is already in cache [INFO] extracting crate wasm_val 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/wasm_val/0.3.2 [INFO] extracting crate wasm_val 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm_val/0.3.2 [INFO] validating manifest of wasm_val-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm_val-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm_val-0.3.2 [INFO] finished frobbing wasm_val-0.3.2 [INFO] frobbed toml for wasm_val-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/wasm_val/0.3.2/Cargo.toml [INFO] started frobbing wasm_val-0.3.2 [INFO] finished frobbing wasm_val-0.3.2 [INFO] frobbed toml for wasm_val-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm_val/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm_val-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm_val/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8535f48727b7cfd73d6b43b82150e8423b855564f7a166bb1b3274d11fb1f05c [INFO] running `"docker" "start" "-a" "8535f48727b7cfd73d6b43b82150e8423b855564f7a166bb1b3274d11fb1f05c"` [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking wasm_val v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/wasm_ffi/mod.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn set_val(ref_id: u32, name: &str, val: Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/wasm_ffi/mod.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn drop_var(ref_id: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/js_val.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/mod.rs:39:49 [INFO] [stderr] | [INFO] [stderr] 39 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/mod.rs:49:49 [INFO] [stderr] | [INFO] [stderr] 49 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/mod.rs:59:49 [INFO] [stderr] | [INFO] [stderr] 59 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:46:63 [INFO] [stderr] | [INFO] [stderr] 46 | pub extern "C" fn wasm_val_call_registered_callback(key: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:53:81 [INFO] [stderr] | [INFO] [stderr] 53 | pub extern "C" fn wasm_val_call_registered_callback_arg(key: u32, ptr: *mut u8) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:156:50 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn set_val(&self, name: &str, val: S) -> () where S: JsSerializable { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/wasm_ffi/mod.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn set_val(ref_id: u32, name: &str, val: Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_ffi/mod.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/wasm_ffi/mod.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn drop_var(ref_id: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/js_val.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/mod.rs:39:49 [INFO] [stderr] | [INFO] [stderr] 39 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/mod.rs:49:49 [INFO] [stderr] | [INFO] [stderr] 49 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/js_ser/mod.rs:59:49 [INFO] [stderr] | [INFO] [stderr] 59 | fn ser(&self, cursor: &mut Cursor>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:46:63 [INFO] [stderr] | [INFO] [stderr] 46 | pub extern "C" fn wasm_val_call_registered_callback(key: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:53:81 [INFO] [stderr] | [INFO] [stderr] 53 | pub extern "C" fn wasm_val_call_registered_callback_arg(key: u32, ptr: *mut u8) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:156:50 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn set_val(&self, name: &str, val: S) -> () where S: JsSerializable { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/ser_constants.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(FromPrimitive,)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | static CALLBACKS_ARG_KEY: RefCell>> = RefCell::new(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:54:44 [INFO] [stderr] | [INFO] [stderr] 54 | let vec = unsafe { Vec::from_raw_parts(ptr, wasm_ffi::SINGLE_VAL_VEC_LEN, wasm_ffi::SINGLE_VAL_VEC_LEN) }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.val { [INFO] [stderr] 98 | | Val::Ref(ref_id) => wasm_ffi::drop_var(ref_id), [INFO] [stderr] 99 | | _ => (), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: try this: `if let Val::Ref(ref_id) = self.val { wasm_ffi::drop_var(ref_id) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self.val { [INFO] [stderr] 158 | | Val::Ref(ref_id) => { [INFO] [stderr] 159 | | let mut vec = Vec::with_capacity(wasm_ffi::SINGLE_VAL_VEC_LEN); [INFO] [stderr] 160 | | let mut cursor = Cursor::new(vec); [INFO] [stderr] ... | [INFO] [stderr] 167 | | _ => () [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Val::Ref(ref_id) = self.val { [INFO] [stderr] 158 | let mut vec = Vec::with_capacity(wasm_ffi::SINGLE_VAL_VEC_LEN); [INFO] [stderr] 159 | let mut cursor = Cursor::new(vec); [INFO] [stderr] 160 | [INFO] [stderr] 161 | val.ser(&mut cursor); [INFO] [stderr] 162 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:263:16 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn new(&self) -> Option { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm_val`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/ser_constants.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(FromPrimitive,)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | static CALLBACKS_ARG_KEY: RefCell>> = RefCell::new(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:54:44 [INFO] [stderr] | [INFO] [stderr] 54 | let vec = unsafe { Vec::from_raw_parts(ptr, wasm_ffi::SINGLE_VAL_VEC_LEN, wasm_ffi::SINGLE_VAL_VEC_LEN) }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.val { [INFO] [stderr] 98 | | Val::Ref(ref_id) => wasm_ffi::drop_var(ref_id), [INFO] [stderr] 99 | | _ => (), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: try this: `if let Val::Ref(ref_id) = self.val { wasm_ffi::drop_var(ref_id) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self.val { [INFO] [stderr] 158 | | Val::Ref(ref_id) => { [INFO] [stderr] 159 | | let mut vec = Vec::with_capacity(wasm_ffi::SINGLE_VAL_VEC_LEN); [INFO] [stderr] 160 | | let mut cursor = Cursor::new(vec); [INFO] [stderr] ... | [INFO] [stderr] 167 | | _ => () [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Val::Ref(ref_id) = self.val { [INFO] [stderr] 158 | let mut vec = Vec::with_capacity(wasm_ffi::SINGLE_VAL_VEC_LEN); [INFO] [stderr] 159 | let mut cursor = Cursor::new(vec); [INFO] [stderr] 160 | [INFO] [stderr] 161 | val.ser(&mut cursor); [INFO] [stderr] 162 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:263:16 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn new(&self) -> Option { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm_val`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8535f48727b7cfd73d6b43b82150e8423b855564f7a166bb1b3274d11fb1f05c"` [INFO] running `"docker" "rm" "-f" "8535f48727b7cfd73d6b43b82150e8423b855564f7a166bb1b3274d11fb1f05c"` [INFO] [stdout] 8535f48727b7cfd73d6b43b82150e8423b855564f7a166bb1b3274d11fb1f05c