[INFO] crate wasm-typescript-definition 0.1.2 is already in cache [INFO] extracting crate wasm-typescript-definition 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/wasm-typescript-definition/0.1.2 [INFO] extracting crate wasm-typescript-definition 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-typescript-definition/0.1.2 [INFO] validating manifest of wasm-typescript-definition-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-typescript-definition-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-typescript-definition-0.1.2 [INFO] finished frobbing wasm-typescript-definition-0.1.2 [INFO] frobbed toml for wasm-typescript-definition-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/wasm-typescript-definition/0.1.2/Cargo.toml [INFO] started frobbing wasm-typescript-definition-0.1.2 [INFO] finished frobbing wasm-typescript-definition-0.1.2 [INFO] frobbed toml for wasm-typescript-definition-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-typescript-definition/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-typescript-definition-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-typescript-definition/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5567dd43f10828c15c74a1dd197e5ca1e0d9013e503f7adec02f4010c393bf9d [INFO] running `"docker" "start" "-a" "5567dd43f10828c15c74a1dd197e5ca1e0d9013e503f7adec02f4010c393bf9d"` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.33 [INFO] [stderr] Compiling wasm-bindgen v0.2.33 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking serde_derive_internals v0.24.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.33 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.33 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.33 [INFO] [stderr] Compiling wasm-typescript-definition v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/derive_enum.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/derive_enum.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let tokens = variants.into_iter().enumerate() [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | .map(|(variant_idx, variant)| { [INFO] [stderr] 15 | | let variant_name = variant.attrs.name().serialize_name(); [INFO] [stderr] 16 | | match variant.style { [INFO] [stderr] ... | [INFO] [stderr] 24 | | }) [INFO] [stderr] 25 | | .fold(quote!{}, |mut agg, tokens| { agg.append_all(tokens); agg }); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/derive_struct.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/derive_struct.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let tokens = match style { [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | ast::Style::Struct => derive_struct_named_fields(fields, attr_container), [INFO] [stderr] 15 | | ast::Style::Newtype => derive_struct_newtype(fields, attr_container), [INFO] [stderr] 16 | | ast::Style::Tuple => derive_struct_tuple(fields, attr_container), [INFO] [stderr] 17 | | ast::Style::Unit => derive_struct_unit(attr_container), [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/derive_enum.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | fn derive_unit_variant<'a>(variant_name: &str) -> TokenStream { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/derive_enum.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | fields: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ast::Field<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/derive_enum.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | let contents = collapse_list_brace(fields.into_iter().enumerate() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/derive_enum.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fields: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ast::Field<'a>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/derive_enum.rs:64:49 [INFO] [stderr] | [INFO] [stderr] 64 | let contents = collapse_list_bracket(fields.into_iter().enumerate() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/derive_enum.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/derive_enum.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let tokens = variants.into_iter().enumerate() [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | .map(|(variant_idx, variant)| { [INFO] [stderr] 15 | | let variant_name = variant.attrs.name().serialize_name(); [INFO] [stderr] 16 | | match variant.style { [INFO] [stderr] ... | [INFO] [stderr] 24 | | }) [INFO] [stderr] 25 | | .fold(quote!{}, |mut agg, tokens| { agg.append_all(tokens); agg }); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/derive_struct.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | tokens [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/derive_struct.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let tokens = match style { [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | ast::Style::Struct => derive_struct_named_fields(fields, attr_container), [INFO] [stderr] 15 | | ast::Style::Newtype => derive_struct_newtype(fields, attr_container), [INFO] [stderr] 16 | | ast::Style::Tuple => derive_struct_tuple(fields, attr_container), [INFO] [stderr] 17 | | ast::Style::Unit => derive_struct_unit(attr_container), [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/derive_enum.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | fn derive_unit_variant<'a>(variant_name: &str) -> TokenStream { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/derive_enum.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | fields: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ast::Field<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/derive_enum.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | let contents = collapse_list_brace(fields.into_iter().enumerate() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/derive_enum.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | fields: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ast::Field<'a>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/derive_enum.rs:64:49 [INFO] [stderr] | [INFO] [stderr] 64 | let contents = collapse_list_bracket(fields.into_iter().enumerate() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/typescript.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | foo: bool, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/typescript.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | bar: i64, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> tests/typescript.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | baz: u64, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `quux` [INFO] [stderr] --> tests/typescript.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | quux: String, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.24s [INFO] running `"docker" "inspect" "5567dd43f10828c15c74a1dd197e5ca1e0d9013e503f7adec02f4010c393bf9d"` [INFO] running `"docker" "rm" "-f" "5567dd43f10828c15c74a1dd197e5ca1e0d9013e503f7adec02f4010c393bf9d"` [INFO] [stdout] 5567dd43f10828c15c74a1dd197e5ca1e0d9013e503f7adec02f4010c393bf9d