[INFO] crate wasm-snip 0.1.3 is already in cache [INFO] extracting crate wasm-snip 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/wasm-snip/0.1.3 [INFO] extracting crate wasm-snip 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-snip/0.1.3 [INFO] validating manifest of wasm-snip-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-snip-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-snip-0.1.3 [INFO] finished frobbing wasm-snip-0.1.3 [INFO] frobbed toml for wasm-snip-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/wasm-snip/0.1.3/Cargo.toml [INFO] started frobbing wasm-snip-0.1.3 [INFO] finished frobbing wasm-snip-0.1.3 [INFO] frobbed toml for wasm-snip-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-snip/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-snip-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-snip/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba22cab5022cd74cba791aee34123bda135b9700e58e7c66e4be640c1e1ee29b [INFO] running `"docker" "start" "-a" "ba22cab5022cd74cba791aee34123bda135b9700e58e7c66e4be640c1e1ee29b"` [INFO] [stderr] Checking parity-wasm v0.27.6 [INFO] [stderr] Checking wasm-snip v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:144:10 [INFO] [stderr] | [INFO] [stderr] 144 | .ok_or(failure::err_msg( [INFO] [stderr] | __________^ [INFO] [stderr] 145 | | "missing \"name\" section; did you build with debug symbols?", [INFO] [stderr] 146 | | ))? [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | .ok_or_else(|| failure::err_msg( [INFO] [stderr] 145 | "missing \"name\" section; did you build with debug symbols?", [INFO] [stderr] 146 | ))? [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | .ok_or(failure::err_msg("missing code section"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("missing code section"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:166:42 [INFO] [stderr] | [INFO] [stderr] 166 | let idx = names.get(to_snip).ok_or(format_err!( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 167 | | "asked to snip '{}', but it isn't present", [INFO] [stderr] 168 | | to_snip [INFO] [stderr] 169 | | ))?; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | let idx = names.get(to_snip).ok_or_else(|| format_err!( [INFO] [stderr] 167 | "asked to snip '{}', but it isn't present", [INFO] [stderr] 168 | to_snip [INFO] [stderr] 169 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or(failure::err_msg(format!( [INFO] [stderr] | __________^ [INFO] [stderr] 229 | | "index {} is out of bounds of the code section", [INFO] [stderr] 230 | | n - num_imports [INFO] [stderr] 231 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or_else(|| failure::err_msg(format!( [INFO] [stderr] 229 | "index {} is out of bounds of the code section", [INFO] [stderr] 230 | n - num_imports [INFO] [stderr] 231 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | / if let &elements::Section::Name(elements::NameSection::Function(ref name_section)) = [INFO] [stderr] 246 | | section [INFO] [stderr] 247 | | { [INFO] [stderr] 248 | | return Some(name_section.names().clone()); [INFO] [stderr] 249 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 245 | if let elements::Section::Name(elements::NameSection::Function(ref name_section)) = [INFO] [stderr] 246 | *section [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:144:10 [INFO] [stderr] | [INFO] [stderr] 144 | .ok_or(failure::err_msg( [INFO] [stderr] | __________^ [INFO] [stderr] 145 | | "missing \"name\" section; did you build with debug symbols?", [INFO] [stderr] 146 | | ))? [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | .ok_or_else(|| failure::err_msg( [INFO] [stderr] 145 | "missing \"name\" section; did you build with debug symbols?", [INFO] [stderr] 146 | ))? [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | .ok_or(failure::err_msg("missing code section"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("missing code section"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:166:42 [INFO] [stderr] | [INFO] [stderr] 166 | let idx = names.get(to_snip).ok_or(format_err!( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 167 | | "asked to snip '{}', but it isn't present", [INFO] [stderr] 168 | | to_snip [INFO] [stderr] 169 | | ))?; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | let idx = names.get(to_snip).ok_or_else(|| format_err!( [INFO] [stderr] 167 | "asked to snip '{}', but it isn't present", [INFO] [stderr] 168 | to_snip [INFO] [stderr] 169 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or(failure::err_msg(format!( [INFO] [stderr] | __________^ [INFO] [stderr] 229 | | "index {} is out of bounds of the code section", [INFO] [stderr] 230 | | n - num_imports [INFO] [stderr] 231 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or_else(|| failure::err_msg(format!( [INFO] [stderr] 229 | "index {} is out of bounds of the code section", [INFO] [stderr] 230 | n - num_imports [INFO] [stderr] 231 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | / if let &elements::Section::Name(elements::NameSection::Function(ref name_section)) = [INFO] [stderr] 246 | | section [INFO] [stderr] 247 | | { [INFO] [stderr] 248 | | return Some(name_section.names().clone()); [INFO] [stderr] 249 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 245 | if let elements::Section::Name(elements::NameSection::Function(ref name_section)) = [INFO] [stderr] 246 | *section [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/bin/wasm-snip.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | for c in e.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/bin/wasm-snip.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | for c in e.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/wasm-snip.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/wasm-snip.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/wasm-snip.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/wasm-snip.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.42s [INFO] running `"docker" "inspect" "ba22cab5022cd74cba791aee34123bda135b9700e58e7c66e4be640c1e1ee29b"` [INFO] running `"docker" "rm" "-f" "ba22cab5022cd74cba791aee34123bda135b9700e58e7c66e4be640c1e1ee29b"` [INFO] [stdout] ba22cab5022cd74cba791aee34123bda135b9700e58e7c66e4be640c1e1ee29b