[INFO] crate wasm-pack 0.5.1 is already in cache [INFO] extracting crate wasm-pack 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/wasm-pack/0.5.1 [INFO] extracting crate wasm-pack 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-pack/0.5.1 [INFO] validating manifest of wasm-pack-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-pack-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-pack-0.5.1 [INFO] finished frobbing wasm-pack-0.5.1 [INFO] frobbed toml for wasm-pack-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/wasm-pack/0.5.1/Cargo.toml [INFO] started frobbing wasm-pack-0.5.1 [INFO] finished frobbing wasm-pack-0.5.1 [INFO] frobbed toml for wasm-pack-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-pack/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-pack-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-pack/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7201f376d96844267de4677131eb9e0bc6b5f8e7bed895de02db6e1768179300 [INFO] running `"docker" "start" "-a" "7201f376d96844267de4677131eb9e0bc6b5f8e7bed895de02db6e1768179300"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking clicolors-control v1.0.0 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking isatty v0.1.9 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking os_type v2.2.0 [INFO] [stderr] Checking which v2.0.1 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking human-panic v1.0.1 [INFO] [stderr] Checking cargo_metadata v0.6.4 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking console v0.7.5 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking wasm-pack v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifest/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifest/mod.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifest/mod.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifest/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifest/mod.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifest/mod.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/build.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | / return Err(Error::RustcVersion { [INFO] [stderr] 23 | | message: format!( [INFO] [stderr] 24 | | "Your version of Rust, '1.{}', is not supported. Please install Rust version 1.30.0 or higher.", [INFO] [stderr] 25 | | mv.to_string() [INFO] [stderr] 26 | | ), [INFO] [stderr] 27 | | local_minor_version: mv.to_string(), [INFO] [stderr] 28 | | }.into()) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | Err(Error::RustcVersion { [INFO] [stderr] 23 | message: format!( [INFO] [stderr] 24 | "Your version of Rust, '1.{}', is not supported. Please install Rust version 1.30.0 or higher.", [INFO] [stderr] 25 | mv.to_string() [INFO] [stderr] 26 | ), [INFO] [stderr] 27 | local_minor_version: mv.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/child.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | return Ok(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/child.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return Err(Error::cli(&msg, stdout.into(), stderr.into(), exit).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::cli(&msg, stdout.into(), stderr.into(), exit).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/build.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | / return Err(Error::RustcVersion { [INFO] [stderr] 23 | | message: format!( [INFO] [stderr] 24 | | "Your version of Rust, '1.{}', is not supported. Please install Rust version 1.30.0 or higher.", [INFO] [stderr] 25 | | mv.to_string() [INFO] [stderr] 26 | | ), [INFO] [stderr] 27 | | local_minor_version: mv.to_string(), [INFO] [stderr] 28 | | }.into()) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | Err(Error::RustcVersion { [INFO] [stderr] 23 | message: format!( [INFO] [stderr] 24 | "Your version of Rust, '1.{}', is not supported. Please install Rust version 1.30.0 or higher.", [INFO] [stderr] 25 | mv.to_string() [INFO] [stderr] 26 | ), [INFO] [stderr] 27 | local_minor_version: mv.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/child.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | return Ok(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/child.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | return Err(Error::cli(&msg, stdout.into(), stderr.into(), exit).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::cli(&msg, stdout.into(), stderr.into(), exit).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / Error::RustcMissing { [INFO] [stderr] 160 | | message: _, [INFO] [stderr] 161 | | } => "We can't figure out what your Rust version is- which means you might not have Rust installed. Please install Rust version 1.30.0 or higher.", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `RustcMissing { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / Error::RustcVersion { [INFO] [stderr] 163 | | message: _, [INFO] [stderr] 164 | | local_minor_version: _, [INFO] [stderr] 165 | | } => "Your rustc version is not supported. Please install version 1.30.0 or higher.", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `RustcVersion { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | / Error::Cli { [INFO] [stderr] 167 | | message: _, [INFO] [stderr] 168 | | stdout: _, [INFO] [stderr] 169 | | stderr: _, [INFO] [stderr] 170 | | exit_status: _, [INFO] [stderr] 171 | | } => "There was an error while calling another CLI tool. Details:\n\n", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cli { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | Error::CrateConfig { message: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CrateConfig { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / Error::PkgNotFound { [INFO] [stderr] 176 | | message: _, [INFO] [stderr] 177 | | } => "Unable to find the 'pkg' directory at the path, set the path as the parent of the 'pkg' directory \n\n", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `PkgNotFound { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/logger.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | Command::Publish { path, access: _ } => path, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Publish { path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/npm.rs:10:34 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DEFAULT_NPM_REGISTRY: &'static str = "https://registry.npmjs.org/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / Error::RustcMissing { [INFO] [stderr] 160 | | message: _, [INFO] [stderr] 161 | | } => "We can't figure out what your Rust version is- which means you might not have Rust installed. Please install Rust version 1.30.0 or higher.", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `RustcMissing { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / Error::RustcVersion { [INFO] [stderr] 163 | | message: _, [INFO] [stderr] 164 | | local_minor_version: _, [INFO] [stderr] 165 | | } => "Your rustc version is not supported. Please install version 1.30.0 or higher.", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `RustcVersion { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | / Error::Cli { [INFO] [stderr] 167 | | message: _, [INFO] [stderr] 168 | | stdout: _, [INFO] [stderr] 169 | | stderr: _, [INFO] [stderr] 170 | | exit_status: _, [INFO] [stderr] 171 | | } => "There was an error while calling another CLI tool. Details:\n\n", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cli { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | Error::CrateConfig { message: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CrateConfig { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / Error::PkgNotFound { [INFO] [stderr] 176 | | message: _, [INFO] [stderr] 177 | | } => "Unable to find the 'pkg' directory at the path, set the path as the parent of the 'pkg' directory \n\n", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `PkgNotFound { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/logger.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | Command::Publish { path, access: _ } => path, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Publish { path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/npm.rs:10:34 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DEFAULT_NPM_REGISTRY: &'static str = "https://registry.npmjs.org/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bindgen.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn wasm_bindgen_build( [INFO] [stderr] 112 | | path: &Path, [INFO] [stderr] 113 | | out_dir: &Path, [INFO] [stderr] 114 | | name: &str, [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/child.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | let next_in_progress: Vec = self.in_progress[last_newline + 1..] [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 91 | | .iter() [INFO] [stderr] 92 | | .cloned() [INFO] [stderr] 93 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/build.rs:144:41 [INFO] [stderr] | [INFO] [stderr] 144 | self.out_dir.canonicalize().unwrap_or(self.out_dir.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.out_dir.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command/build.rs:149:32 [INFO] [stderr] | [INFO] [stderr] 149 | fn get_process_steps(mode: &BuildMode) -> Vec<(&'static str, BuildStep)> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BuildMode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/login.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | let registry = registry.unwrap_or(npm::DEFAULT_NPM_REGISTRY.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| npm::DEFAULT_NPM_REGISTRY.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/login.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | PBAR.message(&format!("👋 logged you in!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"👋 logged you in!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/manifest/mod.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | let dts_file = if disable_dts == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!disable_dts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/manifest/mod.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | &self.package.check_optional_fields(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.package.check_optional_fields();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/manifest/mod.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | let dts_file = if disable_dts == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!disable_dts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/manifest/mod.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | &self.package.check_optional_fields(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.package.check_optional_fields();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/manifest/mod.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | let dts_file = if disable_dts == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!disable_dts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/manifest/mod.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | &self.package.check_optional_fields(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.package.check_optional_fields();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/manifest/mod.rs:253:55 [INFO] [stderr] | [INFO] [stderr] 253 | if read_cargo_toml(path)?.lib.map_or(false, |lib| { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 254 | | lib.crate_type [INFO] [stderr] 255 | | .map_or(false, |types| types.iter().any(|s| s == "cdylib")) [INFO] [stderr] 256 | | }) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/npm.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | .arg(&format!("{}", a.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `a.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/npm.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | registry: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/npm.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | if always_auth == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `always_auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `progressbar::ProgressOutput` [INFO] [stderr] --> src/progressbar.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Self { [INFO] [stderr] 19 | | spinner: RwLock::new(ProgressBar::new_spinner()), [INFO] [stderr] 20 | | messages: RwLock::new(String::from("")), [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for progressbar::ProgressOutput { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/readme.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(_) = fs::copy(&crate_readme_path, &new_readme_path) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 27 | | PBAR.warn("origin crate has no README"); [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____- help: try this: `if fs::copy(&crate_readme_path, &new_readme_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bindgen.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn wasm_bindgen_build( [INFO] [stderr] 112 | | path: &Path, [INFO] [stderr] 113 | | out_dir: &Path, [INFO] [stderr] 114 | | name: &str, [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/child.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | let next_in_progress: Vec = self.in_progress[last_newline + 1..] [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 91 | | .iter() [INFO] [stderr] 92 | | .cloned() [INFO] [stderr] 93 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/build.rs:144:41 [INFO] [stderr] | [INFO] [stderr] 144 | self.out_dir.canonicalize().unwrap_or(self.out_dir.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.out_dir.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command/build.rs:149:32 [INFO] [stderr] | [INFO] [stderr] 149 | fn get_process_steps(mode: &BuildMode) -> Vec<(&'static str, BuildStep)> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BuildMode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/login.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | let registry = registry.unwrap_or(npm::DEFAULT_NPM_REGISTRY.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| npm::DEFAULT_NPM_REGISTRY.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/login.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | PBAR.message(&format!("👋 logged you in!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"👋 logged you in!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/manifest/mod.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | let dts_file = if disable_dts == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!disable_dts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/manifest/mod.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | &self.package.check_optional_fields(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.package.check_optional_fields();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/manifest/mod.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | let dts_file = if disable_dts == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!disable_dts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/manifest/mod.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | &self.package.check_optional_fields(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.package.check_optional_fields();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/manifest/mod.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | let dts_file = if disable_dts == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!disable_dts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/manifest/mod.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | &self.package.check_optional_fields(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.package.check_optional_fields();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/manifest/mod.rs:253:55 [INFO] [stderr] | [INFO] [stderr] 253 | if read_cargo_toml(path)?.lib.map_or(false, |lib| { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 254 | | lib.crate_type [INFO] [stderr] 255 | | .map_or(false, |types| types.iter().any(|s| s == "cdylib")) [INFO] [stderr] 256 | | }) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/npm.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | .arg(&format!("{}", a.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `a.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/npm.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | registry: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/npm.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | if always_auth == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `always_auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `progressbar::ProgressOutput` [INFO] [stderr] --> src/progressbar.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Self { [INFO] [stderr] 19 | | spinner: RwLock::new(ProgressBar::new_spinner()), [INFO] [stderr] 20 | | messages: RwLock::new(String::from("")), [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for progressbar::ProgressOutput { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/readme.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(_) = fs::copy(&crate_readme_path, &new_readme_path) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 27 | | PBAR.warn("origin crate has no README"); [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____- help: try this: `if fs::copy(&crate_readme_path, &new_readme_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'y'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'Y'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'y'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'Y'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.10s [INFO] running `"docker" "inspect" "7201f376d96844267de4677131eb9e0bc6b5f8e7bed895de02db6e1768179300"` [INFO] running `"docker" "rm" "-f" "7201f376d96844267de4677131eb9e0bc6b5f8e7bed895de02db6e1768179300"` [INFO] [stdout] 7201f376d96844267de4677131eb9e0bc6b5f8e7bed895de02db6e1768179300