[INFO] crate wasm-nm 0.2.1 is already in cache [INFO] extracting crate wasm-nm 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/wasm-nm/0.2.1 [INFO] extracting crate wasm-nm 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-nm/0.2.1 [INFO] validating manifest of wasm-nm-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-nm-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-nm-0.2.1 [INFO] finished frobbing wasm-nm-0.2.1 [INFO] frobbed toml for wasm-nm-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/wasm-nm/0.2.1/Cargo.toml [INFO] started frobbing wasm-nm-0.2.1 [INFO] finished frobbing wasm-nm-0.2.1 [INFO] frobbed toml for wasm-nm-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-nm/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-nm-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-nm/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b3eecf7a331844c093743784d69844b4114f364adadb4806dce5627bd017079 [INFO] running `"docker" "start" "-a" "8b3eecf7a331844c093743784d69844b4114f364adadb4806dce5627bd017079"` [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking parity-wasm v0.19.3 [INFO] [stderr] Checking wasm-nm v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | return Ok(Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Default::default())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | return Ok(Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Default::default())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:271:20 [INFO] [stderr] | [INFO] [stderr] 271 | if let Err(_) = body.code().clone().serialize(&mut encoded) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 272 | | return None; [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________- help: try this: `if body.code().clone().serialize(&mut encoded).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:271:20 [INFO] [stderr] | [INFO] [stderr] 271 | if let Err(_) = body.code().clone().serialize(&mut encoded) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 272 | | return None; [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________- help: try this: `if body.code().clone().serialize(&mut encoded).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.73s [INFO] running `"docker" "inspect" "8b3eecf7a331844c093743784d69844b4114f364adadb4806dce5627bd017079"` [INFO] running `"docker" "rm" "-f" "8b3eecf7a331844c093743784d69844b4114f364adadb4806dce5627bd017079"` [INFO] [stdout] 8b3eecf7a331844c093743784d69844b4114f364adadb4806dce5627bd017079