[INFO] crate wasm-gc-api 0.1.11 is already in cache [INFO] extracting crate wasm-gc-api 0.1.11 into work/ex/clippy-test-run/sources/stable/reg/wasm-gc-api/0.1.11 [INFO] extracting crate wasm-gc-api 0.1.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-gc-api/0.1.11 [INFO] validating manifest of wasm-gc-api-0.1.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-gc-api-0.1.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-gc-api-0.1.11 [INFO] finished frobbing wasm-gc-api-0.1.11 [INFO] frobbed toml for wasm-gc-api-0.1.11 written to work/ex/clippy-test-run/sources/stable/reg/wasm-gc-api/0.1.11/Cargo.toml [INFO] started frobbing wasm-gc-api-0.1.11 [INFO] finished frobbing wasm-gc-api-0.1.11 [INFO] frobbed toml for wasm-gc-api-0.1.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-gc-api/0.1.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-gc-api-0.1.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-gc-api/0.1.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4314c96019b96bd1e0a18719e9f467e89cab0260c1d1c1bb469eb6502f69af4e [INFO] running `"docker" "start" "-a" "4314c96019b96bd1e0a18719e9f467e89cab0260c1d1c1bb469eb6502f69af4e"` [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking parity-wasm v0.32.0 [INFO] [stderr] Checking wasm-gc-api v0.1.11 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gc.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | memories: memories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `memories` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gc.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | memories: memories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `memories` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/gc.rs:251:31 [INFO] [stderr] | [INFO] [stderr] 251 | let (i, import) = imports.entries() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 252 | | .iter() [INFO] [stderr] 253 | | .enumerate() [INFO] [stderr] 254 | | .filter(|&(_, i)| { [INFO] [stderr] ... | [INFO] [stderr] 260 | | .skip(idx as usize) [INFO] [stderr] 261 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/gc.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | let (i, import) = imports.entries() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 295 | | .iter() [INFO] [stderr] 296 | | .enumerate() [INFO] [stderr] 297 | | .filter(|&(_, i)| { [INFO] [stderr] ... | [INFO] [stderr] 303 | | .skip(idx as usize) [INFO] [stderr] 304 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | drop(table); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &parity_wasm::elements::TableType [INFO] [stderr] --> src/gc.rs:317:14 [INFO] [stderr] | [INFO] [stderr] 317 | drop(table); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/gc.rs:336:31 [INFO] [stderr] | [INFO] [stderr] 336 | let (i, import) = imports.entries() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 337 | | .iter() [INFO] [stderr] 338 | | .enumerate() [INFO] [stderr] 339 | | .filter(|&(_, i)| { [INFO] [stderr] ... | [INFO] [stderr] 345 | | .skip(idx as usize) [INFO] [stderr] 346 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gc.rs:363:38 [INFO] [stderr] | [INFO] [stderr] 363 | fn add_global_type(&mut self, t: &GlobalType) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `GlobalType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gc.rs:390:41 [INFO] [stderr] | [INFO] [stderr] 390 | fn add_value_type(&mut self, value: &ValueType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ValueType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gc.rs:425:38 [INFO] [stderr] | [INFO] [stderr] 425 | fn add_block_type(&mut self, bt: &BlockType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BlockType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/gc.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | / fn new(m: &Module, analysis: &'a Analysis, config: &'a Config) -> RemapContext<'a> { [INFO] [stderr] 483 | | let mut nfunctions = 0; [INFO] [stderr] 484 | | let mut functions = Vec::new(); [INFO] [stderr] 485 | | let mut nglobals = 0; [INFO] [stderr] ... | [INFO] [stderr] 575 | | } [INFO] [stderr] 576 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:592:9 [INFO] [stderr] | [INFO] [stderr] 592 | s.types().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | drop(t); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::ValueType [INFO] [stderr] --> src/gc.rs:611:14 [INFO] [stderr] | [INFO] [stderr] 611 | drop(t); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:619:9 [INFO] [stderr] | [INFO] [stderr] 619 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:637:9 [INFO] [stderr] | [INFO] [stderr] 637 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:647:13 [INFO] [stderr] | [INFO] [stderr] 647 | drop(t); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::TableType [INFO] [stderr] --> src/gc.rs:647:18 [INFO] [stderr] | [INFO] [stderr] 647 | drop(t); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:655:13 [INFO] [stderr] | [INFO] [stderr] 655 | drop(m); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::MemoryType [INFO] [stderr] --> src/gc.rs:655:18 [INFO] [stderr] | [INFO] [stderr] 655 | drop(m); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:657:9 [INFO] [stderr] | [INFO] [stderr] 657 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:665:9 [INFO] [stderr] | [INFO] [stderr] 665 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:674:9 [INFO] [stderr] | [INFO] [stderr] 674 | drop(s); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::GlobalType [INFO] [stderr] --> src/gc.rs:674:14 [INFO] [stderr] | [INFO] [stderr] 674 | drop(s); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:688:9 [INFO] [stderr] | [INFO] [stderr] 688 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:722:9 [INFO] [stderr] | [INFO] [stderr] 722 | s.bodies().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitvec.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn contains(&self, i: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Config { [INFO] [stderr] 32 | | Config { [INFO] [stderr] 33 | | demangle: true, [INFO] [stderr] 34 | | keep_debug: false, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-gc-api`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/gc.rs:251:31 [INFO] [stderr] | [INFO] [stderr] 251 | let (i, import) = imports.entries() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 252 | | .iter() [INFO] [stderr] 253 | | .enumerate() [INFO] [stderr] 254 | | .filter(|&(_, i)| { [INFO] [stderr] ... | [INFO] [stderr] 260 | | .skip(idx as usize) [INFO] [stderr] 261 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/gc.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | let (i, import) = imports.entries() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 295 | | .iter() [INFO] [stderr] 296 | | .enumerate() [INFO] [stderr] 297 | | .filter(|&(_, i)| { [INFO] [stderr] ... | [INFO] [stderr] 303 | | .skip(idx as usize) [INFO] [stderr] 304 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | drop(table); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &parity_wasm::elements::TableType [INFO] [stderr] --> src/gc.rs:317:14 [INFO] [stderr] | [INFO] [stderr] 317 | drop(table); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/gc.rs:336:31 [INFO] [stderr] | [INFO] [stderr] 336 | let (i, import) = imports.entries() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 337 | | .iter() [INFO] [stderr] 338 | | .enumerate() [INFO] [stderr] 339 | | .filter(|&(_, i)| { [INFO] [stderr] ... | [INFO] [stderr] 345 | | .skip(idx as usize) [INFO] [stderr] 346 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gc.rs:363:38 [INFO] [stderr] | [INFO] [stderr] 363 | fn add_global_type(&mut self, t: &GlobalType) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `GlobalType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gc.rs:390:41 [INFO] [stderr] | [INFO] [stderr] 390 | fn add_value_type(&mut self, value: &ValueType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ValueType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gc.rs:425:38 [INFO] [stderr] | [INFO] [stderr] 425 | fn add_block_type(&mut self, bt: &BlockType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BlockType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/gc.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | / fn new(m: &Module, analysis: &'a Analysis, config: &'a Config) -> RemapContext<'a> { [INFO] [stderr] 483 | | let mut nfunctions = 0; [INFO] [stderr] 484 | | let mut functions = Vec::new(); [INFO] [stderr] 485 | | let mut nglobals = 0; [INFO] [stderr] ... | [INFO] [stderr] 575 | | } [INFO] [stderr] 576 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:592:9 [INFO] [stderr] | [INFO] [stderr] 592 | s.types().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | drop(t); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::ValueType [INFO] [stderr] --> src/gc.rs:611:14 [INFO] [stderr] | [INFO] [stderr] 611 | drop(t); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:619:9 [INFO] [stderr] | [INFO] [stderr] 619 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:637:9 [INFO] [stderr] | [INFO] [stderr] 637 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:647:13 [INFO] [stderr] | [INFO] [stderr] 647 | drop(t); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::TableType [INFO] [stderr] --> src/gc.rs:647:18 [INFO] [stderr] | [INFO] [stderr] 647 | drop(t); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:655:13 [INFO] [stderr] | [INFO] [stderr] 655 | drop(m); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::MemoryType [INFO] [stderr] --> src/gc.rs:655:18 [INFO] [stderr] | [INFO] [stderr] 655 | drop(m); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:657:9 [INFO] [stderr] | [INFO] [stderr] 657 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:665:9 [INFO] [stderr] | [INFO] [stderr] 665 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/gc.rs:674:9 [INFO] [stderr] | [INFO] [stderr] 674 | drop(s); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::GlobalType [INFO] [stderr] --> src/gc.rs:674:14 [INFO] [stderr] | [INFO] [stderr] 674 | drop(s); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:688:9 [INFO] [stderr] | [INFO] [stderr] 688 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/gc.rs:722:9 [INFO] [stderr] | [INFO] [stderr] 722 | s.bodies().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitvec.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn contains(&self, i: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Config { [INFO] [stderr] 32 | | Config { [INFO] [stderr] 33 | | demangle: true, [INFO] [stderr] 34 | | keep_debug: false, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-gc-api`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4314c96019b96bd1e0a18719e9f467e89cab0260c1d1c1bb469eb6502f69af4e"` [INFO] running `"docker" "rm" "-f" "4314c96019b96bd1e0a18719e9f467e89cab0260c1d1c1bb469eb6502f69af4e"` [INFO] [stdout] 4314c96019b96bd1e0a18719e9f467e89cab0260c1d1c1bb469eb6502f69af4e