[INFO] crate wasm-bindgen-threads-xform 0.2.29 is already in cache [INFO] extracting crate wasm-bindgen-threads-xform 0.2.29 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-threads-xform/0.2.29 [INFO] extracting crate wasm-bindgen-threads-xform 0.2.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-threads-xform/0.2.29 [INFO] validating manifest of wasm-bindgen-threads-xform-0.2.29 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-bindgen-threads-xform-0.2.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-bindgen-threads-xform-0.2.29 [INFO] finished frobbing wasm-bindgen-threads-xform-0.2.29 [INFO] frobbed toml for wasm-bindgen-threads-xform-0.2.29 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-threads-xform/0.2.29/Cargo.toml [INFO] started frobbing wasm-bindgen-threads-xform-0.2.29 [INFO] finished frobbing wasm-bindgen-threads-xform-0.2.29 [INFO] frobbed toml for wasm-bindgen-threads-xform-0.2.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-threads-xform/0.2.29/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-bindgen-threads-xform-0.2.29 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-threads-xform/0.2.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5747d448a6439604949d1f20931208f97d6b43642f0c004fd5f07e77448aa1f [INFO] running `"docker" "start" "-a" "c5747d448a6439604949d1f20931208f97d6b43642f0c004fd5f07e77448aa1f"` [INFO] [stderr] Checking parity-wasm v0.35.7 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking wasm-bindgen-threads-xform v0.2.29 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return pos; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | return pos; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return pos; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | return pos; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config` [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Config { [INFO] [stderr] 23 | | Config { [INFO] [stderr] 24 | | maximum_memory: 1 << 30, // 1GB [INFO] [stderr] 25 | | thread_stack_size: 1 << 20, // 1MB [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:161:12 [INFO] [stderr] | [INFO] [stderr] 161 | if section.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!section.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:418:8 [INFO] [stderr] | [INFO] [stderr] 418 | if candidates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/lib.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | / let fty = match &types.types()[type_idx as usize] { [INFO] [stderr] 613 | | Type::Function(f) => f, [INFO] [stderr] 614 | | }; [INFO] [stderr] | |______________^ help: try this: `let Type::Function(fty) = &types.types()[type_idx as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config` [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Config { [INFO] [stderr] 23 | | Config { [INFO] [stderr] 24 | | maximum_memory: 1 << 30, // 1GB [INFO] [stderr] 25 | | thread_stack_size: 1 << 20, // 1MB [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:161:12 [INFO] [stderr] | [INFO] [stderr] 161 | if section.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!section.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:418:8 [INFO] [stderr] | [INFO] [stderr] 418 | if candidates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/lib.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | / let fty = match &types.types()[type_idx as usize] { [INFO] [stderr] 613 | | Type::Function(f) => f, [INFO] [stderr] 614 | | }; [INFO] [stderr] | |______________^ help: try this: `let Type::Function(fty) = &types.types()[type_idx as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.63s [INFO] running `"docker" "inspect" "c5747d448a6439604949d1f20931208f97d6b43642f0c004fd5f07e77448aa1f"` [INFO] running `"docker" "rm" "-f" "c5747d448a6439604949d1f20931208f97d6b43642f0c004fd5f07e77448aa1f"` [INFO] [stdout] c5747d448a6439604949d1f20931208f97d6b43642f0c004fd5f07e77448aa1f