[INFO] crate wasm-bindgen-test-project-builder 0.2.15 is already in cache [INFO] extracting crate wasm-bindgen-test-project-builder 0.2.15 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-test-project-builder/0.2.15 [INFO] extracting crate wasm-bindgen-test-project-builder 0.2.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-test-project-builder/0.2.15 [INFO] validating manifest of wasm-bindgen-test-project-builder-0.2.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-bindgen-test-project-builder-0.2.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-bindgen-test-project-builder-0.2.15 [INFO] finished frobbing wasm-bindgen-test-project-builder-0.2.15 [INFO] frobbed toml for wasm-bindgen-test-project-builder-0.2.15 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-test-project-builder/0.2.15/Cargo.toml [INFO] started frobbing wasm-bindgen-test-project-builder-0.2.15 [INFO] finished frobbing wasm-bindgen-test-project-builder-0.2.15 [INFO] frobbed toml for wasm-bindgen-test-project-builder-0.2.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-test-project-builder/0.2.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-bindgen-test-project-builder-0.2.15 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-test-project-builder/0.2.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9897fb4f22a50978530c2d935093759a9903165beb10acce1cc5d4801f5ede11 [INFO] running `"docker" "start" "-a" "9897fb4f22a50978530c2d935093759a9903165beb10acce1cc5d4801f5ede11"` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.15 [INFO] [stderr] Checking nan-preserving-float v0.1.0 [INFO] [stderr] Checking memory_units v0.3.0 [INFO] [stderr] Checking parity-wasm v0.31.3 [INFO] [stderr] Checking parity-wasm v0.32.0 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking wasmi v0.3.0 [INFO] [stderr] Checking wasm-gc-api v0.1.11 [INFO] [stderr] Checking wasm-bindgen-cli-support v0.2.15 [INFO] [stderr] Checking wasm-bindgen-test-project-builder v0.2.15 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return me; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `me` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | 1 => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | 2 => return Some("--harmony-bigint"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some("--harmony-bigint")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::error::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/lib.rs:599:24 [INFO] [stderr] | [INFO] [stderr] 599 | for e in e.causes() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:277:30 [INFO] [stderr] | [INFO] [stderr] 277 | let mut extensions = format!("'.js', '.wasm'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"'.js', '.wasm'".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:771:13 [INFO] [stderr] | [INFO] [stderr] 771 | dur.subsec_nanos() / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:783:8 [INFO] [stderr] | [INFO] [stderr] 783 | if output.stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:786:8 [INFO] [stderr] | [INFO] [stderr] 786 | if output.stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:837:33 [INFO] [stderr] | [INFO] [stderr] 837 | let mut child = cmd.spawn().expect(&format!("should spawn {} OK", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("should spawn {} OK", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return me; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `me` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | 1 => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | 2 => return Some("--harmony-bigint"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some("--harmony-bigint")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::error::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/lib.rs:599:24 [INFO] [stderr] | [INFO] [stderr] 599 | for e in e.causes() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:277:30 [INFO] [stderr] | [INFO] [stderr] 277 | let mut extensions = format!("'.js', '.wasm'"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"'.js', '.wasm'".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:771:13 [INFO] [stderr] | [INFO] [stderr] 771 | dur.subsec_nanos() / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:783:8 [INFO] [stderr] | [INFO] [stderr] 783 | if output.stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:786:8 [INFO] [stderr] | [INFO] [stderr] 786 | if output.stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:837:33 [INFO] [stderr] | [INFO] [stderr] 837 | let mut child = cmd.spawn().expect(&format!("should spawn {} OK", name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("should spawn {} OK", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.25s [INFO] running `"docker" "inspect" "9897fb4f22a50978530c2d935093759a9903165beb10acce1cc5d4801f5ede11"` [INFO] running `"docker" "rm" "-f" "9897fb4f22a50978530c2d935093759a9903165beb10acce1cc5d4801f5ede11"` [INFO] [stdout] 9897fb4f22a50978530c2d935093759a9903165beb10acce1cc5d4801f5ede11