[INFO] crate wasm-bindgen-test 0.2.29 is already in cache [INFO] extracting crate wasm-bindgen-test 0.2.29 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-test/0.2.29 [INFO] extracting crate wasm-bindgen-test 0.2.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-test/0.2.29 [INFO] validating manifest of wasm-bindgen-test-0.2.29 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-bindgen-test-0.2.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-bindgen-test-0.2.29 [INFO] finished frobbing wasm-bindgen-test-0.2.29 [INFO] frobbed toml for wasm-bindgen-test-0.2.29 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-test/0.2.29/Cargo.toml [INFO] started frobbing wasm-bindgen-test-0.2.29 [INFO] finished frobbing wasm-bindgen-test-0.2.29 [INFO] frobbed toml for wasm-bindgen-test-0.2.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-test/0.2.29/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-bindgen-test-0.2.29 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-test/0.2.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4fdd71bfb6410382fd8715165681ee95a6eaa0c0331044f3fa7e9de4bb30532 [INFO] running `"docker" "start" "-a" "e4fdd71bfb6410382fd8715165681ee95a6eaa0c0331044f3fa7e9de4bb30532"` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.33 [INFO] [stderr] Compiling wasm-bindgen v0.2.33 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.2.29 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.33 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.33 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.33 [INFO] [stderr] Checking js-sys v0.3.10 [INFO] [stderr] Checking console_error_panic_hook v0.1.5 [INFO] [stderr] Checking wasm-bindgen-futures v0.3.10 [INFO] [stderr] Checking wasm-bindgen-test v0.2.29 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rt/mod.rs:562:5 [INFO] [stderr] | [INFO] [stderr] 562 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rt/mod.rs:562:5 [INFO] [stderr] | [INFO] [stderr] 562 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/browser.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/browser.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `__rt::browser::Browser` [INFO] [stderr] --> src/rt/browser.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Browser { [INFO] [stderr] 39 | | let pre = document.getElementById("output"); [INFO] [stderr] 40 | | pre.set_inner_html(""); [INFO] [stderr] 41 | | Browser { pre } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | impl Default for __rt::browser::Browser { [INFO] [stderr] 36 | fn default() -> Self { [INFO] [stderr] 37 | Self::new() [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/detect.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/node.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `__rt::Context` [INFO] [stderr] --> src/rt/mod.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / pub fn new() -> Context { [INFO] [stderr] 208 | | console_error_panic_hook::set_once(); [INFO] [stderr] 209 | | [INFO] [stderr] 210 | | let formatter = match node::Node::new() { [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | impl Default for __rt::Context { [INFO] [stderr] 201 | fn default() -> Self { [INFO] [stderr] 202 | Self::new() [INFO] [stderr] 203 | } [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rt/mod.rs:241:32 [INFO] [stderr] | [INFO] [stderr] 241 | if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rt/mod.rs:343:47 [INFO] [stderr] | [INFO] [stderr] 343 | self.execute(name, future::lazy(|| Ok(f()))); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 343 | self.execute(name, future::lazy(|| Ok(()))); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rt/mod.rs:484:12 [INFO] [stderr] | [INFO] [stderr] 484 | if output.log.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.log.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rt/mod.rs:489:12 [INFO] [stderr] | [INFO] [stderr] 489 | if output.error.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.error.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-bindgen-test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/browser.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/browser.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `__rt::browser::Browser` [INFO] [stderr] --> src/rt/browser.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Browser { [INFO] [stderr] 39 | | let pre = document.getElementById("output"); [INFO] [stderr] 40 | | pre.set_inner_html(""); [INFO] [stderr] 41 | | Browser { pre } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | impl Default for __rt::browser::Browser { [INFO] [stderr] 36 | fn default() -> Self { [INFO] [stderr] 37 | Self::new() [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/detect.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/rt/node.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[wasm_bindgen] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: argument has type &wasm_bindgen::JsValue [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `__rt::Context` [INFO] [stderr] --> src/rt/mod.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / pub fn new() -> Context { [INFO] [stderr] 208 | | console_error_panic_hook::set_once(); [INFO] [stderr] 209 | | [INFO] [stderr] 210 | | let formatter = match node::Node::new() { [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | impl Default for __rt::Context { [INFO] [stderr] 201 | fn default() -> Self { [INFO] [stderr] 202 | Self::new() [INFO] [stderr] 203 | } [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rt/mod.rs:241:32 [INFO] [stderr] | [INFO] [stderr] 241 | if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rt/mod.rs:343:47 [INFO] [stderr] | [INFO] [stderr] 343 | self.execute(name, future::lazy(|| Ok(f()))); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 343 | self.execute(name, future::lazy(|| Ok(()))); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rt/mod.rs:484:12 [INFO] [stderr] | [INFO] [stderr] 484 | if output.log.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.log.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rt/mod.rs:489:12 [INFO] [stderr] | [INFO] [stderr] 489 | if output.error.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.error.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-bindgen-test`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e4fdd71bfb6410382fd8715165681ee95a6eaa0c0331044f3fa7e9de4bb30532"` [INFO] running `"docker" "rm" "-f" "e4fdd71bfb6410382fd8715165681ee95a6eaa0c0331044f3fa7e9de4bb30532"` [INFO] [stdout] e4fdd71bfb6410382fd8715165681ee95a6eaa0c0331044f3fa7e9de4bb30532