[INFO] crate wasm-bindgen-gc 0.2.29 is already in cache [INFO] extracting crate wasm-bindgen-gc 0.2.29 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-gc/0.2.29 [INFO] extracting crate wasm-bindgen-gc 0.2.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-gc/0.2.29 [INFO] validating manifest of wasm-bindgen-gc-0.2.29 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-bindgen-gc-0.2.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-bindgen-gc-0.2.29 [INFO] removed 1 missing tests [INFO] finished frobbing wasm-bindgen-gc-0.2.29 [INFO] frobbed toml for wasm-bindgen-gc-0.2.29 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-gc/0.2.29/Cargo.toml [INFO] started frobbing wasm-bindgen-gc-0.2.29 [INFO] removed 1 missing tests [INFO] finished frobbing wasm-bindgen-gc-0.2.29 [INFO] frobbed toml for wasm-bindgen-gc-0.2.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-gc/0.2.29/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-bindgen-gc-0.2.29 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-gc/0.2.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0926e6e80ecb369efa27dfa8e77cba89ecac0aaa0e088d8f4ffca9c6b5f0488d [INFO] running `"docker" "start" "-a" "0926e6e80ecb369efa27dfa8e77cba89ecac0aaa0e088d8f4ffca9c6b5f0488d"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/all.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking parity-wasm v0.35.7 [INFO] [stderr] Checking wasm-bindgen-gc v0.2.29 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitvec.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn remove(&mut self, i: &u32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitvec.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn contains(&self, i: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config` [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Config { [INFO] [stderr] 29 | | Config { [INFO] [stderr] 30 | | demangle: true, [INFO] [stderr] 31 | | keep_debug: false, [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 203 | | .entries() [INFO] [stderr] 204 | | .iter() [INFO] [stderr] 205 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 210 | | .skip(idx as usize) [INFO] [stderr] 211 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:243:31 [INFO] [stderr] | [INFO] [stderr] 243 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 244 | | .entries() [INFO] [stderr] 245 | | .iter() [INFO] [stderr] 246 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 251 | | .skip(idx as usize) [INFO] [stderr] 252 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | drop(table); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &parity_wasm::elements::TableType [INFO] [stderr] --> src/lib.rs:260:14 [INFO] [stderr] | [INFO] [stderr] 260 | drop(table); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:284:31 [INFO] [stderr] | [INFO] [stderr] 284 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 285 | | .entries() [INFO] [stderr] 286 | | .iter() [INFO] [stderr] 287 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 292 | | .skip(idx as usize) [INFO] [stderr] 293 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:310:31 [INFO] [stderr] | [INFO] [stderr] 310 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 311 | | .entries() [INFO] [stderr] 312 | | .iter() [INFO] [stderr] 313 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 318 | | .skip(idx as usize) [INFO] [stderr] 319 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:332:38 [INFO] [stderr] | [INFO] [stderr] 332 | fn add_global_type(&mut self, t: &GlobalType) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `GlobalType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:359:41 [INFO] [stderr] | [INFO] [stderr] 359 | fn add_value_type(&mut self, value: &ValueType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ValueType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:405:38 [INFO] [stderr] | [INFO] [stderr] 405 | fn add_block_type(&mut self, bt: &BlockType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BlockType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:480:5 [INFO] [stderr] | [INFO] [stderr] 480 | / fn new(m: &Module, analysis: &'a mut Analysis, config: &'a Config) -> RemapContext<'a> { [INFO] [stderr] 481 | | let mut nfunctions = 0; [INFO] [stderr] 482 | | let mut functions = Vec::new(); [INFO] [stderr] 483 | | let mut nglobals = 0; [INFO] [stderr] ... | [INFO] [stderr] 616 | | } [INFO] [stderr] 617 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:633:9 [INFO] [stderr] | [INFO] [stderr] 633 | s.types().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:666:9 [INFO] [stderr] | [INFO] [stderr] 666 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:689:9 [INFO] [stderr] | [INFO] [stderr] 689 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | drop(t); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::TableType [INFO] [stderr] --> src/lib.rs:704:18 [INFO] [stderr] | [INFO] [stderr] 704 | drop(t); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:706:9 [INFO] [stderr] | [INFO] [stderr] 706 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:717:13 [INFO] [stderr] | [INFO] [stderr] 717 | drop(m); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::MemoryType [INFO] [stderr] --> src/lib.rs:717:18 [INFO] [stderr] | [INFO] [stderr] 717 | drop(m); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:719:9 [INFO] [stderr] | [INFO] [stderr] 719 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:732:9 [INFO] [stderr] | [INFO] [stderr] 732 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | drop(s); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::GlobalType [INFO] [stderr] --> src/lib.rs:741:14 [INFO] [stderr] | [INFO] [stderr] 741 | drop(s); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:755:9 [INFO] [stderr] | [INFO] [stderr] 755 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:799:9 [INFO] [stderr] | [INFO] [stderr] 799 | s.bodies().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/lib.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | / let ty = match &types.types()[ty_idx as usize] { [INFO] [stderr] 951 | | Type::Function(f) => f, [INFO] [stderr] 952 | | }; [INFO] [stderr] | |__________^ help: try this: `let Type::Function(ty) = &types.types()[ty_idx as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `map` [INFO] [stderr] --> src/lib.rs:991:14 [INFO] [stderr] | [INFO] [stderr] 991 | for i in 0..ty.params().len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 991 | for (i, ) in map.iter_mut().enumerate().take(ty.params().len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-bindgen-gc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitvec.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn remove(&mut self, i: &u32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitvec.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn contains(&self, i: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config` [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Config { [INFO] [stderr] 29 | | Config { [INFO] [stderr] 30 | | demangle: true, [INFO] [stderr] 31 | | keep_debug: false, [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 203 | | .entries() [INFO] [stderr] 204 | | .iter() [INFO] [stderr] 205 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 210 | | .skip(idx as usize) [INFO] [stderr] 211 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:243:31 [INFO] [stderr] | [INFO] [stderr] 243 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 244 | | .entries() [INFO] [stderr] 245 | | .iter() [INFO] [stderr] 246 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 251 | | .skip(idx as usize) [INFO] [stderr] 252 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | drop(table); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &parity_wasm::elements::TableType [INFO] [stderr] --> src/lib.rs:260:14 [INFO] [stderr] | [INFO] [stderr] 260 | drop(table); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:284:31 [INFO] [stderr] | [INFO] [stderr] 284 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 285 | | .entries() [INFO] [stderr] 286 | | .iter() [INFO] [stderr] 287 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 292 | | .skip(idx as usize) [INFO] [stderr] 293 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/lib.rs:310:31 [INFO] [stderr] | [INFO] [stderr] 310 | let (i, import) = imports [INFO] [stderr] | _______________________________^ [INFO] [stderr] 311 | | .entries() [INFO] [stderr] 312 | | .iter() [INFO] [stderr] 313 | | .enumerate() [INFO] [stderr] ... | [INFO] [stderr] 318 | | .skip(idx as usize) [INFO] [stderr] 319 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:332:38 [INFO] [stderr] | [INFO] [stderr] 332 | fn add_global_type(&mut self, t: &GlobalType) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `GlobalType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:359:41 [INFO] [stderr] | [INFO] [stderr] 359 | fn add_value_type(&mut self, value: &ValueType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ValueType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:405:38 [INFO] [stderr] | [INFO] [stderr] 405 | fn add_block_type(&mut self, bt: &BlockType) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BlockType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:480:5 [INFO] [stderr] | [INFO] [stderr] 480 | / fn new(m: &Module, analysis: &'a mut Analysis, config: &'a Config) -> RemapContext<'a> { [INFO] [stderr] 481 | | let mut nfunctions = 0; [INFO] [stderr] 482 | | let mut functions = Vec::new(); [INFO] [stderr] 483 | | let mut nglobals = 0; [INFO] [stderr] ... | [INFO] [stderr] 616 | | } [INFO] [stderr] 617 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:633:9 [INFO] [stderr] | [INFO] [stderr] 633 | s.types().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:666:9 [INFO] [stderr] | [INFO] [stderr] 666 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:689:9 [INFO] [stderr] | [INFO] [stderr] 689 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | drop(t); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::TableType [INFO] [stderr] --> src/lib.rs:704:18 [INFO] [stderr] | [INFO] [stderr] 704 | drop(t); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:706:9 [INFO] [stderr] | [INFO] [stderr] 706 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:717:13 [INFO] [stderr] | [INFO] [stderr] 717 | drop(m); // TODO [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::MemoryType [INFO] [stderr] --> src/lib.rs:717:18 [INFO] [stderr] | [INFO] [stderr] 717 | drop(m); // TODO [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:719:9 [INFO] [stderr] | [INFO] [stderr] 719 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:732:9 [INFO] [stderr] | [INFO] [stderr] 732 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | drop(s); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut parity_wasm::elements::GlobalType [INFO] [stderr] --> src/lib.rs:741:14 [INFO] [stderr] | [INFO] [stderr] 741 | drop(s); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:755:9 [INFO] [stderr] | [INFO] [stderr] 755 | s.entries().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:799:9 [INFO] [stderr] | [INFO] [stderr] 799 | s.bodies().len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/lib.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | / let ty = match &types.types()[ty_idx as usize] { [INFO] [stderr] 951 | | Type::Function(f) => f, [INFO] [stderr] 952 | | }; [INFO] [stderr] | |__________^ help: try this: `let Type::Function(ty) = &types.types()[ty_idx as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `map` [INFO] [stderr] --> src/lib.rs:991:14 [INFO] [stderr] | [INFO] [stderr] 991 | for i in 0..ty.params().len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 991 | for (i, ) in map.iter_mut().enumerate().take(ty.params().len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-bindgen-gc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0926e6e80ecb369efa27dfa8e77cba89ecac0aaa0e088d8f4ffca9c6b5f0488d"` [INFO] running `"docker" "rm" "-f" "0926e6e80ecb369efa27dfa8e77cba89ecac0aaa0e088d8f4ffca9c6b5f0488d"` [INFO] [stdout] 0926e6e80ecb369efa27dfa8e77cba89ecac0aaa0e088d8f4ffca9c6b5f0488d