[INFO] crate wasm-bindgen-cli-support 0.2.29 is already in cache
[INFO] extracting crate wasm-bindgen-cli-support 0.2.29 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-cli-support/0.2.29
[INFO] extracting crate wasm-bindgen-cli-support 0.2.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-cli-support/0.2.29
[INFO] validating manifest of wasm-bindgen-cli-support-0.2.29 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wasm-bindgen-cli-support-0.2.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wasm-bindgen-cli-support-0.2.29
[INFO] finished frobbing wasm-bindgen-cli-support-0.2.29
[INFO] frobbed toml for wasm-bindgen-cli-support-0.2.29 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-cli-support/0.2.29/Cargo.toml
[INFO] started frobbing wasm-bindgen-cli-support-0.2.29
[INFO] finished frobbing wasm-bindgen-cli-support-0.2.29
[INFO] frobbed toml for wasm-bindgen-cli-support-0.2.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-cli-support/0.2.29/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wasm-bindgen-cli-support-0.2.29 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-cli-support/0.2.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bbad5a7d2b094fce76d3ca54431407116d05e2908bb4da0c65f9c5d350f5b604
[INFO] running `"docker" "start" "-a" "bbad5a7d2b094fce76d3ca54431407116d05e2908bb4da0c65f9c5d350f5b604"`
[INFO] [stderr] Checking parity-wasm v0.35.7
[INFO] [stderr] Checking wasm-bindgen-wasm-interpreter v0.2.29
[INFO] [stderr] Checking wasm-bindgen-threads-xform v0.2.29
[INFO] [stderr] Checking wasm-bindgen-gc v0.2.29
[INFO] [stderr] Checking wasm-bindgen-cli-support v0.2.29 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/decode.rs:9:9
[INFO] [stderr] |
[INFO] [stderr] 9 | return ret;
[INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/decode.rs:16:5
[INFO] [stderr] |
[INFO] [stderr] 16 | return r;
[INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:163:18
[INFO] [stderr] |
[INFO] [stderr] 163 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:170:18
[INFO] [stderr] |
[INFO] [stderr] 170 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:177:18
[INFO] [stderr] |
[INFO] [stderr] 177 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:192:18
[INFO] [stderr] |
[INFO] [stderr] 192 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr] --> src/js/rust2js.rs:517:13
[INFO] [stderr] |
[INFO] [stderr] 517 | arg_idx: _,
[INFO] [stderr] | ^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr]
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr] --> src/js/rust2js.rs:518:13
[INFO] [stderr] |
[INFO] [stderr] 518 | cx: _,
[INFO] [stderr] | ^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr]
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr] --> src/js/rust2js.rs:519:13
[INFO] [stderr] |
[INFO] [stderr] 519 | global_idx: _,
[INFO] [stderr] | ^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: Try with `Rust2Js { catch, finally, js_arguments, prelude, ret_expr, variadic, shim_arguments, .. }`
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/js/closures.rs:142:9
[INFO] [stderr] |
[INFO] [stderr] 142 | return ret;
[INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr] --> src/js/mod.rs:139:16
[INFO] [stderr] |
[INFO] [stderr] 139 | } else {
[INFO] [stderr] | ________________^
[INFO] [stderr] 140 | | if contents.starts_with("function") {
[INFO] [stderr] 141 | | format!("export function {}{}\n", name, &contents[8..])
[INFO] [stderr] 142 | | } else if contents.starts_with("class") {
[INFO] [stderr] ... |
[INFO] [stderr] 146 | | }
[INFO] [stderr] 147 | | };
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr] |
[INFO] [stderr] 139 | } else if contents.starts_with("function") {
[INFO] [stderr] 140 | format!("export function {}{}\n", name, &contents[8..])
[INFO] [stderr] 141 | } else if contents.starts_with("class") {
[INFO] [stderr] 142 | format!("export {}\n", contents)
[INFO] [stderr] 143 | } else {
[INFO] [stderr] 144 | format!("export const {} = {};\n", name, contents)
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/wasm2es6js.rs:122:5
[INFO] [stderr] |
[INFO] [stderr] 122 | return exports;
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `exports`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/wasm2es6js.rs:131:9
[INFO] [stderr] |
[INFO] [stderr] 131 | return ts;
[INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ts`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/lib.rs:84:9
[INFO] [stderr] |
[INFO] [stderr] 84 | return self;
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/lib.rs:485:5
[INFO] [stderr] |
[INFO] [stderr] 485 | return dst;
[INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/decode.rs:9:9
[INFO] [stderr] |
[INFO] [stderr] 9 | return ret;
[INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/decode.rs:16:5
[INFO] [stderr] |
[INFO] [stderr] 16 | return r;
[INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:163:18
[INFO] [stderr] |
[INFO] [stderr] 163 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:170:18
[INFO] [stderr] |
[INFO] [stderr] 170 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:177:18
[INFO] [stderr] |
[INFO] [stderr] 177 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/descriptor.rs:192:18
[INFO] [stderr] |
[INFO] [stderr] 192 | _ => return false,
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr] --> src/js/rust2js.rs:517:13
[INFO] [stderr] |
[INFO] [stderr] 517 | arg_idx: _,
[INFO] [stderr] | ^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr]
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr] --> src/js/rust2js.rs:518:13
[INFO] [stderr] |
[INFO] [stderr] 518 | cx: _,
[INFO] [stderr] | ^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr]
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr] --> src/js/rust2js.rs:519:13
[INFO] [stderr] |
[INFO] [stderr] 519 | global_idx: _,
[INFO] [stderr] | ^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: Try with `Rust2Js { catch, finally, js_arguments, prelude, ret_expr, variadic, shim_arguments, .. }`
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/js/closures.rs:142:9
[INFO] [stderr] |
[INFO] [stderr] 142 | return ret;
[INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr] --> src/js/mod.rs:139:16
[INFO] [stderr] |
[INFO] [stderr] 139 | } else {
[INFO] [stderr] | ________________^
[INFO] [stderr] 140 | | if contents.starts_with("function") {
[INFO] [stderr] 141 | | format!("export function {}{}\n", name, &contents[8..])
[INFO] [stderr] 142 | | } else if contents.starts_with("class") {
[INFO] [stderr] ... |
[INFO] [stderr] 146 | | }
[INFO] [stderr] 147 | | };
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr] |
[INFO] [stderr] 139 | } else if contents.starts_with("function") {
[INFO] [stderr] 140 | format!("export function {}{}\n", name, &contents[8..])
[INFO] [stderr] 141 | } else if contents.starts_with("class") {
[INFO] [stderr] 142 | format!("export {}\n", contents)
[INFO] [stderr] 143 | } else {
[INFO] [stderr] 144 | format!("export const {} = {};\n", name, contents)
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/wasm2es6js.rs:122:5
[INFO] [stderr] |
[INFO] [stderr] 122 | return exports;
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `exports`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/wasm2es6js.rs:131:9
[INFO] [stderr] |
[INFO] [stderr] 131 | return ts;
[INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ts`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/lib.rs:84:9
[INFO] [stderr] |
[INFO] [stderr] 84 | return self;
[INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/lib.rs:485:5
[INFO] [stderr] |
[INFO] [stderr] 485 | return dst;
[INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/decode.rs:8:17
[INFO] [stderr] |
[INFO] [stderr] 8 | assert!(data.len() == 0);
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/decode.rs:31:20
[INFO] [stderr] |
[INFO] [stderr] 31 | cur |= ((byte & 0x7f) as u32) << offset;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte & 0x7f)`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr] --> src/descriptor.rs:345:17
[INFO] [stderr] |
[INFO] [stderr] 345 | pub fn size(&self) -> usize {
[INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:271:42
[INFO] [stderr] |
[INFO] [stderr] 271 | self.rust_arguments.push(format!("0"));
[INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"0".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:418:42
[INFO] [stderr] |
[INFO] [stderr] 418 | self.rust_arguments.push(format!("{}", name));
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:436:37
[INFO] [stderr] |
[INFO] [stderr] 436 | self.ret_expr = format!("this.ptr = RET;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"this.ptr = RET;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:462:29
[INFO] [stderr] |
[INFO] [stderr] 462 | self.ret_expr = format!("return RET;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return RET;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:506:29
[INFO] [stderr] |
[INFO] [stderr] 506 | self.ret_expr = format!("return takeObject(RET);");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return takeObject(RET);".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:618:29
[INFO] [stderr] |
[INFO] [stderr] 618 | self.ret_expr = format!("return getObject(RET);");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return getObject(RET);".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:635:29
[INFO] [stderr] |
[INFO] [stderr] 635 | self.ret_expr = format!("return RET;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return RET;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:664:33
[INFO] [stderr] |
[INFO] [stderr] 664 | self.ret_expr = format!("return (RET) !== 0;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return (RET) !== 0;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:668:33
[INFO] [stderr] |
[INFO] [stderr] 668 | self.ret_expr = format!("return String.fromCodePoint(RET);")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return String.fromCodePoint(RET);".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/js2rust.rs:711:24
[INFO] [stderr] |
[INFO] [stderr] 711 | let invoc = if self.finally.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.finally.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/rust2js.rs:540:16
[INFO] [stderr] |
[INFO] [stderr] 540 | if self.shim_arguments.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.shim_arguments.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/rust2js.rs:557:20
[INFO] [stderr] |
[INFO] [stderr] 557 | if args.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/rust2js.rs:644:12
[INFO] [stderr] |
[INFO] [stderr] 644 | if self.finally.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.finally.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/closures.rs:32:8
[INFO] [stderr] |
[INFO] [stderr] 32 | if info.element_removal_list.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `info.element_removal_list.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr] --> src/js/closures.rs:157:33
[INFO] [stderr] |
[INFO] [stderr] 157 | remove.entry(entry).or_insert(HashSet::new()).insert(idx);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/closures.rs:182:20
[INFO] [stderr] |
[INFO] [stderr] 182 | if current.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/closures.rs:192:16
[INFO] [stderr] |
[INFO] [stderr] 192 | if current.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/decode.rs:8:17
[INFO] [stderr] |
[INFO] [stderr] 8 | assert!(data.len() == 0);
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/decode.rs:31:20
[INFO] [stderr] |
[INFO] [stderr] 31 | cur |= ((byte & 0x7f) as u32) << offset;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte & 0x7f)`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/mod.rs:413:16
[INFO] [stderr] |
[INFO] [stderr] 413 | Ok(format!(
[INFO] [stderr] | ________________^
[INFO] [stderr] 414 | | "
[INFO] [stderr] 415 | | function() {{
[INFO] [stderr] 416 | | return addHeapObject(init.__wbindgen_wasm_module);
[INFO] [stderr] 417 | | }}
[INFO] [stderr] 418 | | ",
[INFO] [stderr] 419 | | ))
[INFO] [stderr] | |_____________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] help: consider using .to_string()
[INFO] [stderr] |
[INFO] [stderr] 413 | Ok("
[INFO] [stderr] 414 | function() {{
[INFO] [stderr] 415 | return addHeapObject(init.__wbindgen_wasm_module);
[INFO] [stderr] 416 | }}
[INFO] [stderr] 417 | ".to_string())
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/js/mod.rs:491:42
[INFO] [stderr] |
[INFO] [stderr] 491 | Some(l) if l.shared() => l.clone(),
[INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*l`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/mod.rs:604:34
[INFO] [stderr] |
[INFO] [stderr] 604 | let import_wasm = if self.globals.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.globals.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/mod.rs:609:17
[INFO] [stderr] |
[INFO] [stderr] 609 | format!("var wasm;")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"var wasm;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/mod.rs:937:22
[INFO] [stderr] |
[INFO] [stderr] 937 | self.global(&format!(
[INFO] [stderr] | ______________________^
[INFO] [stderr] 938 | | "
[INFO] [stderr] 939 | | function _assertNum(n) {{
[INFO] [stderr] 940 | | if (typeof(n) !== 'number') throw new Error('expected a number argument');
[INFO] [stderr] 941 | | }}
[INFO] [stderr] 942 | | "
[INFO] [stderr] 943 | | ));
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] help: consider using .to_string()
[INFO] [stderr] |
[INFO] [stderr] 937 | self.global(&"
[INFO] [stderr] 938 | function _assertNum(n) {{
[INFO] [stderr] 939 | if (typeof(n) !== 'number') throw new Error('expected a number argument');
[INFO] [stderr] 940 | }}
[INFO] [stderr] 941 | ".to_string());
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/mod.rs:950:22
[INFO] [stderr] |
[INFO] [stderr] 950 | self.global(&format!(
[INFO] [stderr] | ______________________^
[INFO] [stderr] 951 | | "
[INFO] [stderr] 952 | | function _assertBoolean(n) {{
[INFO] [stderr] 953 | | if (typeof(n) !== 'boolean') {{
[INFO] [stderr] ... |
[INFO] [stderr] 957 | | "
[INFO] [stderr] 958 | | ));
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] help: consider using .to_string()
[INFO] [stderr] |
[INFO] [stderr] 950 | self.global(&"
[INFO] [stderr] 951 | function _assertBoolean(n) {{
[INFO] [stderr] 952 | if (typeof(n) !== 'boolean') {{
[INFO] [stderr] 953 | throw new Error('expected a boolean argument');
[INFO] [stderr] 954 | }}
[INFO] [stderr] 955 | }}
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr] --> src/descriptor.rs:345:17
[INFO] [stderr] |
[INFO] [stderr] 345 | pub fn size(&self) -> usize {
[INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/js/mod.rs:1740:33
[INFO] [stderr] |
[INFO] [stderr] 1740 | self.memory_init = Some(mem.limits().clone());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mem.limits()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/mod.rs:1805:32
[INFO] [stderr] |
[INFO] [stderr] 1805 | if left.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:271:42
[INFO] [stderr] |
[INFO] [stderr] 271 | self.rust_arguments.push(format!("0"));
[INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"0".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/js/mod.rs:1849:56
[INFO] [stderr] |
[INFO] [stderr] 1849 | if import.structural || !name.contains(".") {
[INFO] [stderr] | ^^^ help: try using a char instead: `'.'`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:418:42
[INFO] [stderr] |
[INFO] [stderr] 418 | self.rust_arguments.push(format!("{}", name));
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:436:37
[INFO] [stderr] |
[INFO] [stderr] 436 | self.ret_expr = format!("this.ptr = RET;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"this.ptr = RET;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:462:29
[INFO] [stderr] |
[INFO] [stderr] 462 | self.ret_expr = format!("return RET;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return RET;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/mod.rs:2034:20
[INFO] [stderr] |
[INFO] [stderr] 2034 | if data.len() != 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:506:29
[INFO] [stderr] |
[INFO] [stderr] 506 | self.ret_expr = format!("return takeObject(RET);");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return takeObject(RET);".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:618:29
[INFO] [stderr] |
[INFO] [stderr] 618 | self.ret_expr = format!("return getObject(RET);");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return getObject(RET);".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:635:29
[INFO] [stderr] |
[INFO] [stderr] 635 | self.ret_expr = format!("return RET;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return RET;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:664:33
[INFO] [stderr] |
[INFO] [stderr] 664 | self.ret_expr = format!("return (RET) !== 0;");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return (RET) !== 0;".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/js/js2rust.rs:668:33
[INFO] [stderr] |
[INFO] [stderr] 668 | self.ret_expr = format!("return String.fromCodePoint(RET);")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"return String.fromCodePoint(RET);".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/js2rust.rs:711:24
[INFO] [stderr] |
[INFO] [stderr] 711 | let invoc = if self.finally.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.finally.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr] --> src/js/mod.rs:2307:14
[INFO] [stderr] |
[INFO] [stderr] 2307 | .or_insert(ExportedClass::default());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(ExportedClass::default)`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/js/mod.rs:2517:31
[INFO] [stderr] |
[INFO] [stderr] 2517 | if !dst.ends_with("\n") {
[INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/mod.rs:2546:12
[INFO] [stderr] |
[INFO] [stderr] 2546 | if info.vendor_prefixes.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `info.vendor_prefixes.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr] --> src/js/mod.rs:2551:14
[INFO] [stderr] |
[INFO] [stderr] 2551 | .or_insert(Vec::new())
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/mod.rs:2577:21
[INFO] [stderr] |
[INFO] [stderr] 2577 | assert!(vendor_prefixes.len() > 0);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vendor_prefixes.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `wasm2es6js::Config`
[INFO] [stderr] --> src/wasm2es6js.rs:21:5
[INFO] [stderr] |
[INFO] [stderr] 21 | / pub fn new() -> Config {
[INFO] [stderr] 22 | | Config {
[INFO] [stderr] 23 | | base64: false,
[INFO] [stderr] 24 | | fetch_path: None,
[INFO] [stderr] 25 | | }
[INFO] [stderr] 26 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 9 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr] --> src/wasm2es6js.rs:39:12
[INFO] [stderr] |
[INFO] [stderr] 39 | if !self.base64 && !self.fetch_path.is_some() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.base64 && self.fetch_path.is_none()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/wasm2es6js.rs:52:23
[INFO] [stderr] |
[INFO] [stderr] 52 | let mut exports = format!("/* tslint:disable */\n");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/* tslint:disable */\n".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let`
[INFO] [stderr] --> src/wasm2es6js.rs:97:13
[INFO] [stderr] |
[INFO] [stderr] 97 | / let ty = match types.types()[idx as usize] {
[INFO] [stderr] 98 | | Type::Function(ref f) => f,
[INFO] [stderr] 99 | | };
[INFO] [stderr] | |______________^ help: try this: `let Type::Function(ty) = types.types()[idx as usize];`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/rust2js.rs:540:16
[INFO] [stderr] |
[INFO] [stderr] 540 | if self.shim_arguments.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.shim_arguments.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/rust2js.rs:557:20
[INFO] [stderr] |
[INFO] [stderr] 557 | if args.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/rust2js.rs:644:12
[INFO] [stderr] |
[INFO] [stderr] 644 | if self.finally.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.finally.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/wasm_utils.rs:33:9
[INFO] [stderr] |
[INFO] [stderr] 33 | / match entry.internal_mut() {
[INFO] [stderr] 34 | | Internal::Function(i) => {
[INFO] [stderr] 35 | | self.remap_idx(i);
[INFO] [stderr] 36 | | }
[INFO] [stderr] 37 | | _ => {}
[INFO] [stderr] 38 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 33 | if let Internal::Function(i) = entry.internal_mut() {
[INFO] [stderr] 34 | self.remap_idx(i);
[INFO] [stderr] 35 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/closures.rs:32:8
[INFO] [stderr] |
[INFO] [stderr] 32 | if info.element_removal_list.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `info.element_removal_list.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/wasm_utils.rs:70:9
[INFO] [stderr] |
[INFO] [stderr] 70 | / match instr {
[INFO] [stderr] 71 | | Instruction::Call(i) => {
[INFO] [stderr] 72 | | self.remap_idx(i);
[INFO] [stderr] 73 | | }
[INFO] [stderr] 74 | | _ => {}
[INFO] [stderr] 75 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 70 | if let Instruction::Call(i) = instr {
[INFO] [stderr] 71 | self.remap_idx(i);
[INFO] [stderr] 72 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Bindgen`
[INFO] [stderr] --> src/lib.rs:56:5
[INFO] [stderr] |
[INFO] [stderr] 56 | / pub fn new() -> Bindgen {
[INFO] [stderr] 57 | | Bindgen {
[INFO] [stderr] 58 | | input: Input::None,
[INFO] [stderr] 59 | | nodejs: false,
[INFO] [stderr] ... |
[INFO] [stderr] 72 | | }
[INFO] [stderr] 73 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 55 | impl Default for Bindgen {
[INFO] [stderr] 56 | fn default() -> Self {
[INFO] [stderr] 57 | Self::new()
[INFO] [stderr] 58 | }
[INFO] [stderr] 59 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr] --> src/js/closures.rs:157:33
[INFO] [stderr] |
[INFO] [stderr] 157 | remove.entry(entry).or_insert(HashSet::new()).insert(idx);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/closures.rs:182:20
[INFO] [stderr] |
[INFO] [stderr] 182 | if current.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/js/closures.rs:192:16
[INFO] [stderr] |
[INFO] [stderr] 192 | if current.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/lib.rs:192:29
[INFO] [stderr] |
[INFO] [stderr] 192 | typescript: format!("/* tslint:disable */\n"),
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/* tslint:disable */\n".to_string()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] --> src/lib.rs:307:24
[INFO] [stderr] |
[INFO] [stderr] 307 | shim.push_str(&format!(
[INFO] [stderr] | ________________________^
[INFO] [stderr] 308 | | "
[INFO] [stderr] 309 | | const wasmModule = new WebAssembly.Module(bytes);
[INFO] [stderr] 310 | | const wasmInstance = new WebAssembly.Instance(wasmModule, imports);
[INFO] [stderr] 311 | | ",
[INFO] [stderr] 312 | | ));
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] help: consider using .to_string()
[INFO] [stderr] |
[INFO] [stderr] 307 | shim.push_str(&"
[INFO] [stderr] 308 | const wasmModule = new WebAssembly.Module(bytes);
[INFO] [stderr] 309 | const wasmInstance = new WebAssembly.Instance(wasmModule, imports);
[INFO] [stderr] 310 | ".to_string());
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/lib.rs:411:8
[INFO] [stderr] |
[INFO] [stderr] 411 | if data.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(data[0] as usize)`
[INFO] [stderr] --> src/lib.rs:414:15
[INFO] [stderr] |
[INFO] [stderr] 414 | let len = ((data[0] as usize) << 0)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr] --> src/lib.rs:423:1
[INFO] [stderr] |
[INFO] [stderr] 423 | / fn verify_schema_matches<'a>(data: &'a [u8]) -> Result