[INFO] crate wasm-bindgen-cli 0.2.29 is already in cache [INFO] extracting crate wasm-bindgen-cli 0.2.29 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-cli/0.2.29 [INFO] extracting crate wasm-bindgen-cli 0.2.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-cli/0.2.29 [INFO] validating manifest of wasm-bindgen-cli-0.2.29 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-bindgen-cli-0.2.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-bindgen-cli-0.2.29 [INFO] finished frobbing wasm-bindgen-cli-0.2.29 [INFO] frobbed toml for wasm-bindgen-cli-0.2.29 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-cli/0.2.29/Cargo.toml [INFO] started frobbing wasm-bindgen-cli-0.2.29 [INFO] finished frobbing wasm-bindgen-cli-0.2.29 [INFO] frobbed toml for wasm-bindgen-cli-0.2.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-cli/0.2.29/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-bindgen-cli-0.2.29 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-cli/0.2.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccbf5eccbb0c257ba4be394f8b5bd51220d7e6ebdfab973bca9ef9f882a9a3c8 [INFO] running `"docker" "start" "-a" "ccbf5eccbb0c257ba4be394f8b5bd51220d7e6ebdfab973bca9ef9f882a9a3c8"` [INFO] [stderr] Checking wasm-bindgen-shared v0.2.29 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking parity-wasm v0.35.7 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking tiny_http v0.6.2 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking wasm-bindgen-threads-xform v0.2.29 [INFO] [stderr] Checking wasm-bindgen-gc v0.2.29 [INFO] [stderr] Checking wasm-bindgen-wasm-interpreter v0.2.29 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking wasm-bindgen-cli-support v0.2.29 [INFO] [stderr] Checking rouille v2.2.0 [INFO] [stderr] Checking wasm-bindgen-cli v0.2.29 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/wasm2es6js.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/wasm2es6js.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/wasm-bindgen.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/wasm-bindgen.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/server.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return response; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/server.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return response; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if output.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:126:8 [INFO] [stderr] | [INFO] [stderr] 126 | if logs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!logs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:129:8 [INFO] [stderr] | [INFO] [stderr] 129 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:307:33 [INFO] [stderr] | [INFO] [stderr] 307 | Ok(x.session_id.or(x.value.map(|v| v.session_id)).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| x.value.map(|v| v.session_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:385:14 [INFO] [stderr] | [INFO] [stderr] 385 | .ok_or(format_err!("failed to find element reference in response"))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to find element reference in response"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:534:12 [INFO] [stderr] | [INFO] [stderr] 534 | if stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:538:12 [INFO] [stderr] | [INFO] [stderr] 538 | if stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/node.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/server.rs:119:31 [INFO] [stderr] | [INFO] [stderr] 119 | if !part.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/main.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | if tests.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tests.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/main.rs:174:19 [INFO] [stderr] | [INFO] [stderr] 174 | return Ok(srv.run()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 174 | return Ok(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if output.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:126:8 [INFO] [stderr] | [INFO] [stderr] 126 | if logs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!logs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:129:8 [INFO] [stderr] | [INFO] [stderr] 129 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:307:33 [INFO] [stderr] | [INFO] [stderr] 307 | Ok(x.session_id.or(x.value.map(|v| v.session_id)).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| x.value.map(|v| v.session_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:385:14 [INFO] [stderr] | [INFO] [stderr] 385 | .ok_or(format_err!("failed to find element reference in response"))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to find element reference in response"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:534:12 [INFO] [stderr] | [INFO] [stderr] 534 | if stdout.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/headless.rs:538:12 [INFO] [stderr] | [INFO] [stderr] 538 | if stderr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stderr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/node.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/server.rs:119:31 [INFO] [stderr] | [INFO] [stderr] 119 | if !part.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/main.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | if tests.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tests.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/wasm-bindgen-test-runner/main.rs:174:19 [INFO] [stderr] | [INFO] [stderr] 174 | return Ok(srv.run()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 174 | return Ok(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.13s [INFO] running `"docker" "inspect" "ccbf5eccbb0c257ba4be394f8b5bd51220d7e6ebdfab973bca9ef9f882a9a3c8"` [INFO] running `"docker" "rm" "-f" "ccbf5eccbb0c257ba4be394f8b5bd51220d7e6ebdfab973bca9ef9f882a9a3c8"` [INFO] [stdout] ccbf5eccbb0c257ba4be394f8b5bd51220d7e6ebdfab973bca9ef9f882a9a3c8