[INFO] crate wasm-bindgen-backend 0.2.29 is already in cache [INFO] extracting crate wasm-bindgen-backend 0.2.29 into work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-backend/0.2.29 [INFO] extracting crate wasm-bindgen-backend 0.2.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-backend/0.2.29 [INFO] validating manifest of wasm-bindgen-backend-0.2.29 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wasm-bindgen-backend-0.2.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wasm-bindgen-backend-0.2.29 [INFO] finished frobbing wasm-bindgen-backend-0.2.29 [INFO] frobbed toml for wasm-bindgen-backend-0.2.29 written to work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-backend/0.2.29/Cargo.toml [INFO] started frobbing wasm-bindgen-backend-0.2.29 [INFO] finished frobbing wasm-bindgen-backend-0.2.29 [INFO] frobbed toml for wasm-bindgen-backend-0.2.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wasm-bindgen-backend/0.2.29/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wasm-bindgen-backend-0.2.29 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wasm-bindgen-backend/0.2.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe5fbcaa3c3e3abdba561330db8fdfaeafb86a6feb92da6d9a4a9517932d8480 [INFO] running `"docker" "start" "-a" "fe5fbcaa3c3e3abdba561330db8fdfaeafb86a6feb92da6d9a4a9517932d8480"` [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking wasm-bindgen-backend v0.2.29 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/defined.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | / if all_defined { [INFO] [stderr] 386 | | if !is_defined(id) { [INFO] [stderr] 387 | | info!("removing due to {} not being defined", id); [INFO] [stderr] 388 | | all_defined = false; [INFO] [stderr] 389 | | } [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 385 | if all_defined && !is_defined(id) { [INFO] [stderr] 386 | info!("removing due to {} not being defined", id); [INFO] [stderr] 387 | all_defined = false; [INFO] [stderr] 388 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/defined.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | / if all_defined { [INFO] [stderr] 386 | | if !is_defined(id) { [INFO] [stderr] 387 | | info!("removing due to {} not being defined", id); [INFO] [stderr] 388 | | all_defined = false; [INFO] [stderr] 389 | | } [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 385 | if all_defined && !is_defined(id) { [INFO] [stderr] 386 | info!("removing due to {} not being defined", id); [INFO] [stderr] 387 | all_defined = false; [INFO] [stderr] 388 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/error.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | if diagnostics.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `diagnostics.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ast.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | Function(ImportFunction), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 77 | Function(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ast.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / Method { [INFO] [stderr] 101 | | class: String, [INFO] [stderr] 102 | | ty: syn::Type, [INFO] [stderr] 103 | | kind: MethodKind, [INFO] [stderr] 104 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/ast.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / Method { [INFO] [stderr] 101 | | class: String, [INFO] [stderr] 102 | | ty: syn::Type, [INFO] [stderr] 103 | | kind: MethodKind, [INFO] [stderr] 104 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `prefix_json.len()` [INFO] [stderr] --> src/codegen.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | bytes.push((prefix_json.len() >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/error.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | if diagnostics.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `diagnostics.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ast.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | Function(ImportFunction), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 77 | Function(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ast.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / Method { [INFO] [stderr] 101 | | class: String, [INFO] [stderr] 102 | | ty: syn::Type, [INFO] [stderr] 103 | | kind: MethodKind, [INFO] [stderr] 104 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/ast.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / Method { [INFO] [stderr] 101 | | class: String, [INFO] [stderr] 102 | | ty: syn::Type, [INFO] [stderr] 103 | | kind: MethodKind, [INFO] [stderr] 104 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `prefix_json.len()` [INFO] [stderr] --> src/codegen.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | bytes.push((prefix_json.len() >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/defined.rs:369:20 [INFO] [stderr] | [INFO] [stderr] 369 | changed || dictionaries_to_remove.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dictionaries_to_remove.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len` [INFO] [stderr] --> src/encode.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | self.dst[0] = (len >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/defined.rs:369:20 [INFO] [stderr] | [INFO] [stderr] 369 | changed || dictionaries_to_remove.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dictionaries_to_remove.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len` [INFO] [stderr] --> src/encode.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | self.dst[0] = (len >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.60s [INFO] running `"docker" "inspect" "fe5fbcaa3c3e3abdba561330db8fdfaeafb86a6feb92da6d9a4a9517932d8480"` [INFO] running `"docker" "rm" "-f" "fe5fbcaa3c3e3abdba561330db8fdfaeafb86a6feb92da6d9a4a9517932d8480"` [INFO] [stdout] fe5fbcaa3c3e3abdba561330db8fdfaeafb86a6feb92da6d9a4a9517932d8480