[INFO] crate warp 0.1.9 is already in cache [INFO] extracting crate warp 0.1.9 into work/ex/clippy-test-run/sources/stable/reg/warp/0.1.9 [INFO] extracting crate warp 0.1.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/warp/0.1.9 [INFO] validating manifest of warp-0.1.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of warp-0.1.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing warp-0.1.9 [INFO] finished frobbing warp-0.1.9 [INFO] frobbed toml for warp-0.1.9 written to work/ex/clippy-test-run/sources/stable/reg/warp/0.1.9/Cargo.toml [INFO] started frobbing warp-0.1.9 [INFO] finished frobbing warp-0.1.9 [INFO] frobbed toml for warp-0.1.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/warp/0.1.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting warp-0.1.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/warp/0.1.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 477e545f8bbe845029f46a9f3bf3a687c9546b0a456d421b8abe48ea5b9434d1 [INFO] running `"docker" "start" "-a" "477e545f8bbe845029f46a9f3bf3a687c9546b0a456d421b8abe48ea5b9434d1"` [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Compiling pest v2.1.0 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Compiling headers-derive v0.0.1 [INFO] [stderr] Checking headers-core v0.0.1 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking block-padding v0.1.3 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking block-buffer v0.7.2 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking headers-ext v0.0.3 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking warp v0.1.9 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter/service.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | route: route, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `route` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/filter/service.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | route: route, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `route` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter/or.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(e.combine(err1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.combine(err1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters/fs.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters/fs.rs:338:15 [INFO] [stderr] | [INFO] [stderr] 338 | let ret = range [INFO] [stderr] | _______________^ [INFO] [stderr] 339 | | .iter() [INFO] [stderr] 340 | | .map(|(start, end)| { [INFO] [stderr] 341 | | let start = match start { [INFO] [stderr] ... | [INFO] [stderr] 360 | | .next() [INFO] [stderr] 361 | | .unwrap_or(Ok((0, max_len))); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/generic.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/generic.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/test.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/filter/or.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(e.combine(err1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.combine(err1))` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filters/fs.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::let_and_return)] implied by #[deny(warnings)] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filters/fs.rs:338:15 [INFO] [stderr] | [INFO] [stderr] 338 | let ret = range [INFO] [stderr] | _______________^ [INFO] [stderr] 339 | | .iter() [INFO] [stderr] 340 | | .map(|(start, end)| { [INFO] [stderr] 341 | | let start = match start { [INFO] [stderr] ... | [INFO] [stderr] 360 | | .next() [INFO] [stderr] 361 | | .unwrap_or(Ok((0, max_len))); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/generic.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unused_unit)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/generic.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/test.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `warp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/filter/and.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | type Extract = <<::HList as Combine<::HList>>::Output as HList>::Tuple; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/filter/and.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | type Item = <<::HList as Combine<::HList>>::Output as HList>::Tuple; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/filter/recover.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | type Extract = (Either< [INFO] [stderr] | ____________________^ [INFO] [stderr] 23 | | T::Extract, [INFO] [stderr] 24 | | (::Item,), [INFO] [stderr] 25 | | >,); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/filter/recover.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | type Item = (Either< [INFO] [stderr] | _________________^ [INFO] [stderr] 80 | | T::Extract, [INFO] [stderr] 81 | | (::Item,), [INFO] [stderr] 82 | | >,); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filters/fs.rs:361:10 [INFO] [stderr] | [INFO] [stderr] 361 | .unwrap_or(Ok((0, max_len))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok((0, max_len)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/filters/ws.rs:170:33 [INFO] [stderr] | [INFO] [stderr] 170 | .get_or_insert_with(|| WebSocketConfig::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `WebSocketConfig::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filters/ws.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / match item.inner { [INFO] [stderr] 268 | | protocol::Message::Ping(..) => { [INFO] [stderr] 269 | | // warp doesn't yet expose a way to construct a `Ping` message, [INFO] [stderr] 270 | | // so the only way this could is if the user is forwarding the [INFO] [stderr] ... | [INFO] [stderr] 277 | | _ => () [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 267 | if let protocol::Message::Ping(..) = item.inner { [INFO] [stderr] 268 | // warp doesn't yet expose a way to construct a `Ping` message, [INFO] [stderr] 269 | // so the only way this could is if the user is forwarding the [INFO] [stderr] 270 | // received `Ping`s straight back. [INFO] [stderr] 271 | // [INFO] [stderr] 272 | // tungstenite already auto-reponds to `Ping`s with a `Pong`, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/reject.rs:368:61 [INFO] [stderr] | [INFO] [stderr] 368 | } else if e.is::<::header::MissingHeader>() { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 369 | | StatusCode::BAD_REQUEST [INFO] [stderr] 370 | | } else if e.is::<::cookie::MissingCookie>() { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/reject.rs:366:61 [INFO] [stderr] | [INFO] [stderr] 366 | } else if e.is::<::header::InvalidHeader>() { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 367 | | StatusCode::BAD_REQUEST [INFO] [stderr] 368 | | } else if e.is::<::header::MissingHeader>() { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/reject.rs:411:22 [INFO] [stderr] | [INFO] [stderr] 411 | fn into_response(&self) -> ::reply::Response { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `warp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "477e545f8bbe845029f46a9f3bf3a687c9546b0a456d421b8abe48ea5b9434d1"` [INFO] running `"docker" "rm" "-f" "477e545f8bbe845029f46a9f3bf3a687c9546b0a456d421b8abe48ea5b9434d1"` [INFO] [stdout] 477e545f8bbe845029f46a9f3bf3a687c9546b0a456d421b8abe48ea5b9434d1