[INFO] crate warmy 0.11.0 is already in cache [INFO] extracting crate warmy 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/warmy/0.11.0 [INFO] extracting crate warmy 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/warmy/0.11.0 [INFO] validating manifest of warmy-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of warmy-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing warmy-0.11.0 [INFO] finished frobbing warmy-0.11.0 [INFO] frobbed toml for warmy-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/warmy/0.11.0/Cargo.toml [INFO] started frobbing warmy-0.11.0 [INFO] finished frobbing warmy-0.11.0 [INFO] frobbed toml for warmy-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/warmy/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting warmy-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/warmy/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a06b27a93dafcc8c8130622aa80a6016fa6126610b12836c72daa791251ff7c3 [INFO] running `"docker" "start" "-a" "a06b27a93dafcc8c8130622aa80a6016fa6126610b12836c72daa791251ff7c3"` [INFO] [stderr] Checking any-cache v0.2.3 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking notify v4.0.7 [INFO] [stderr] Checking warmy v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/context.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | fn inspect(_: &'a mut C) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/context.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/context.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | fn inspect(_: &'a mut C) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/context.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | on_reload: Box, &mut C) -> Result<(), Box>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/load.rs:186:10 [INFO] [stderr] | [INFO] [stderr] 186 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/load.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | .or_else(|_| self.inject::(key.clone().into(), proxy(), Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/load.rs:266:40 [INFO] [stderr] | [INFO] [stderr] 266 | .or_else(|_| self.inject::(key.clone().into(), proxy(), Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load.rs:589:12 [INFO] [stderr] | [INFO] [stderr] 589 | closure: Box, &mut C)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | on_reload: Box, &mut C) -> Result<(), Box>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/load.rs:186:10 [INFO] [stderr] | [INFO] [stderr] 186 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/load.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | .or_else(|_| self.inject::(key.clone().into(), proxy(), Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/load.rs:266:40 [INFO] [stderr] | [INFO] [stderr] 266 | .or_else(|_| self.inject::(key.clone().into(), proxy(), Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load.rs:589:12 [INFO] [stderr] | [INFO] [stderr] 589 | closure: Box, &mut C)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/lib.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | let foo = Foo(s); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/lib.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | let foo = Foo("stupid".to_owned()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | let bar = Bar("bar".to_owned()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/lib.rs:128:11 [INFO] [stderr] | [INFO] [stderr] 128 | let foo: Res = storage.get(&fs_key, ctx).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/lib.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | let foo: Res = store.get(&foo_key, ctx).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/lib.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | let bar: Result, _> = store.get(&bar_key, ctx); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.20s [INFO] running `"docker" "inspect" "a06b27a93dafcc8c8130622aa80a6016fa6126610b12836c72daa791251ff7c3"` [INFO] running `"docker" "rm" "-f" "a06b27a93dafcc8c8130622aa80a6016fa6126610b12836c72daa791251ff7c3"` [INFO] [stdout] a06b27a93dafcc8c8130622aa80a6016fa6126610b12836c72daa791251ff7c3