[INFO] crate wamp 0.1.0 is already in cache [INFO] extracting crate wamp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wamp/0.1.0 [INFO] extracting crate wamp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wamp/0.1.0 [INFO] validating manifest of wamp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wamp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wamp-0.1.0 [INFO] removed path dependency rmp from wamp-0.1.0 [INFO] removed path dependency rmp-serde from wamp-0.1.0 [INFO] finished frobbing wamp-0.1.0 [INFO] frobbed toml for wamp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wamp/0.1.0/Cargo.toml [INFO] started frobbing wamp-0.1.0 [INFO] removed path dependency rmp from wamp-0.1.0 [INFO] removed path dependency rmp-serde from wamp-0.1.0 [INFO] finished frobbing wamp-0.1.0 [INFO] frobbed toml for wamp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wamp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wamp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wamp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab9051278c8571a40db9d1913edc0420dda7406fadb1dfe4c60646096b8b7072 [INFO] running `"docker" "start" "-a" "ab9051278c8571a40db9d1913edc0420dda7406fadb1dfe4c60646096b8b7072"` [INFO] [stderr] Compiling syntex_pos v0.39.0 [INFO] [stderr] Checking rmp v0.7.5 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking syncbox v0.2.4 [INFO] [stderr] Checking serde_json v0.7.4 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking eventual v0.1.7 [INFO] [stderr] Compiling syntex_errors v0.39.0 [INFO] [stderr] Checking rmp-serde v0.9.6 [INFO] [stderr] Compiling syntex_syntax v0.39.0 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking ws v0.5.3 [INFO] [stderr] Compiling syntex v0.39.0 [INFO] [stderr] Compiling aster v0.22.1 [INFO] [stderr] Compiling quasi v0.16.0 [INFO] [stderr] Compiling serde_codegen_internals v0.4.0 [INFO] [stderr] Compiling quasi_codegen v0.16.0 [INFO] [stderr] Compiling serde_codegen v0.7.15 [INFO] [stderr] Compiling wamp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:415:49 [INFO] [stderr] | [INFO] [stderr] 415 | let subscription = Subscription{topic: topic, subscription_id: subscription_id}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `topic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:415:63 [INFO] [stderr] | [INFO] [stderr] 415 | let subscription = Subscription{topic: topic, subscription_id: subscription_id}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscription_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:472:49 [INFO] [stderr] | [INFO] [stderr] 472 | let registration = Registration{procedure: procedure, registration_id: registration_id}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `procedure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:472:71 [INFO] [stderr] | [INFO] [stderr] 472 | let registration = Registration{procedure: procedure, registration_id: registration_id}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registration_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:655:53 [INFO] [stderr] | [INFO] [stderr] 655 | let callback = SubscriptionCallbackWrapper {callback: callback}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:674:53 [INFO] [stderr] | [INFO] [stderr] 674 | let callback = RegistrationCallbackWrapper {callback: callback}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | reason: reason [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | subscriber: subscriber, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscriber` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | subscriber: subscriber, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscriber` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/rpc/patterns.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | reason: reason [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/rpc/patterns.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | registrant: registrant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registrant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/rpc/patterns.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/mod.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | kind: kind [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:415:49 [INFO] [stderr] | [INFO] [stderr] 415 | let subscription = Subscription{topic: topic, subscription_id: subscription_id}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `topic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:415:63 [INFO] [stderr] | [INFO] [stderr] 415 | let subscription = Subscription{topic: topic, subscription_id: subscription_id}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscription_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:472:49 [INFO] [stderr] | [INFO] [stderr] 472 | let registration = Registration{procedure: procedure, registration_id: registration_id}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `procedure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:472:71 [INFO] [stderr] | [INFO] [stderr] 472 | let registration = Registration{procedure: procedure, registration_id: registration_id}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registration_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:655:53 [INFO] [stderr] | [INFO] [stderr] 655 | let callback = SubscriptionCallbackWrapper {callback: callback}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:674:53 [INFO] [stderr] | [INFO] [stderr] 674 | let callback = RegistrationCallbackWrapper {callback: callback}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | reason: reason [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | subscriber: subscriber, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscriber` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | subscriber: subscriber, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscriber` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/pubsub/patterns.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/rpc/patterns.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | reason: reason [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/rpc/patterns.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | registrant: registrant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registrant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/rpc/patterns.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/router/mod.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | kind: kind [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:244:40 [INFO] [stderr] | [INFO] [stderr] 244 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:244:50 [INFO] [stderr] | [INFO] [stderr] 244 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:502:40 [INFO] [stderr] | [INFO] [stderr] 502 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:502:50 [INFO] [stderr] | [INFO] [stderr] 502 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:716:40 [INFO] [stderr] | [INFO] [stderr] 716 | const FIELDS: &'static [&'static str] = &["message"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:716:50 [INFO] [stderr] | [INFO] [stderr] 716 | const FIELDS: &'static [&'static str] = &["message"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:924:40 [INFO] [stderr] | [INFO] [stderr] 924 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:924:50 [INFO] [stderr] | [INFO] [stderr] 924 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1128:40 [INFO] [stderr] | [INFO] [stderr] 1128 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1128:50 [INFO] [stderr] | [INFO] [stderr] 1128 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1384:40 [INFO] [stderr] | [INFO] [stderr] 1384 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1384:50 [INFO] [stderr] | [INFO] [stderr] 1384 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1707:40 [INFO] [stderr] | [INFO] [stderr] 1707 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1707:50 [INFO] [stderr] | [INFO] [stderr] 1707 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1946:40 [INFO] [stderr] | [INFO] [stderr] 1946 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1946:50 [INFO] [stderr] | [INFO] [stderr] 1946 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2804:40 [INFO] [stderr] | [INFO] [stderr] 2804 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2804:50 [INFO] [stderr] | [INFO] [stderr] 2804 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3061:40 [INFO] [stderr] | [INFO] [stderr] 3061 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3061:50 [INFO] [stderr] | [INFO] [stderr] 3061 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3272:40 [INFO] [stderr] | [INFO] [stderr] 3272 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3272:50 [INFO] [stderr] | [INFO] [stderr] 3272 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3485:40 [INFO] [stderr] | [INFO] [stderr] 3485 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3485:50 [INFO] [stderr] | [INFO] [stderr] 3485 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3697:40 [INFO] [stderr] | [INFO] [stderr] 3697 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3697:50 [INFO] [stderr] | [INFO] [stderr] 3697 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3908:40 [INFO] [stderr] | [INFO] [stderr] 3908 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3908:50 [INFO] [stderr] | [INFO] [stderr] 3908 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4114:40 [INFO] [stderr] | [INFO] [stderr] 4114 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4114:50 [INFO] [stderr] | [INFO] [stderr] 4114 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4321:40 [INFO] [stderr] | [INFO] [stderr] 4321 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4321:50 [INFO] [stderr] | [INFO] [stderr] 4321 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4526:40 [INFO] [stderr] | [INFO] [stderr] 4526 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4526:50 [INFO] [stderr] | [INFO] [stderr] 4526 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4731:40 [INFO] [stderr] | [INFO] [stderr] 4731 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4731:50 [INFO] [stderr] | [INFO] [stderr] 4731 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4938:40 [INFO] [stderr] | [INFO] [stderr] 4938 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4938:50 [INFO] [stderr] | [INFO] [stderr] 4938 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/client.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / macro_rules! try_websocket { [INFO] [stderr] 34 | | ($e: expr) => ( [INFO] [stderr] 35 | | match $e { [INFO] [stderr] 36 | | Ok(result) => result, [INFO] [stderr] ... | [INFO] [stderr] 39 | | ); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/client.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | handler [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/client.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | let handler = ConnectionHandler { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 192 | | state_transmission: tx.clone(), [INFO] [stderr] 193 | | connection_info: info, [INFO] [stderr] 194 | | realm: realm.clone() [INFO] [stderr] 195 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | / if uri_bit.len() == 0 { [INFO] [stderr] 165 | | if matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 166 | | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | if uri_bit.len() == 0 && matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 165 | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/pubsub/patterns.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/pubsub/patterns.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/pubsub/patterns.rs:206:24 [INFO] [stderr] | [INFO] [stderr] 206 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/pubsub/patterns.rs:206:24 [INFO] [stderr] | [INFO] [stderr] 206 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:265:24 [INFO] [stderr] | [INFO] [stderr] 265 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 266 | | if let Some(child) = self.current.node.edges.get("") { [INFO] [stderr] 267 | | self.current.state = IterState::Wildcard; [INFO] [stderr] 268 | | self.push(child); [INFO] [stderr] ... | [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 265 | } else if let Some(child) = self.current.node.edges.get("") { [INFO] [stderr] 266 | self.current.state = IterState::Wildcard; [INFO] [stderr] 267 | self.push(child); [INFO] [stderr] 268 | } else { [INFO] [stderr] 269 | if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 270 | self.current.state = IterState::Strict; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:269:28 [INFO] [stderr] | [INFO] [stderr] 269 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 270 | | if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 271 | | self.current.state = IterState::Strict; [INFO] [stderr] 272 | | self.push(child); [INFO] [stderr] ... | [INFO] [stderr] 276 | | } [INFO] [stderr] 277 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 269 | } else if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 270 | self.current.state = IterState::Strict; [INFO] [stderr] 271 | self.push(child); [INFO] [stderr] 272 | } [INFO] [stderr] 273 | else { [INFO] [stderr] 274 | self.current.state = IterState::AllComplete; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:283:23 [INFO] [stderr] | [INFO] [stderr] 283 | } else { [INFO] [stderr] | _______________________^ [INFO] [stderr] 284 | | if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 285 | | self.current.state = IterState::Strict; [INFO] [stderr] 286 | | self.push(child); [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 283 | } else if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 284 | self.current.state = IterState::Strict; [INFO] [stderr] 285 | self.push(child); [INFO] [stderr] 286 | } else { [INFO] [stderr] 287 | self.current.state = IterState::AllComplete; [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/router/rpc/patterns.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | / if uri_bit.len() == 0 { [INFO] [stderr] 192 | | if matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 193 | | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | if uri_bit.len() == 0 && matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 192 | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 193 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/rpc/patterns.rs:224:24 [INFO] [stderr] | [INFO] [stderr] 224 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/rpc/patterns.rs:224:24 [INFO] [stderr] | [INFO] [stderr] 224 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/rpc/patterns.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/rpc/patterns.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/rpc/patterns.rs:242:16 [INFO] [stderr] | [INFO] [stderr] 242 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 243 | | if let Some((registrant, id)) = self.recurse(uri_bits, depth) { [INFO] [stderr] 244 | | Some((registrant, id)) [INFO] [stderr] 245 | | } else if let Some(registrant) = self.prefix_connections.get_entry() { [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | } else if let Some((registrant, id)) = self.recurse(uri_bits, depth) { [INFO] [stderr] 243 | Some((registrant, id)) [INFO] [stderr] 244 | } else if let Some(registrant) = self.prefix_connections.get_entry() { [INFO] [stderr] 245 | Some((registrant, self.prefix_id)) [INFO] [stderr] 246 | } else { [INFO] [stderr] 247 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:244:40 [INFO] [stderr] | [INFO] [stderr] 244 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:244:50 [INFO] [stderr] | [INFO] [stderr] 244 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:502:40 [INFO] [stderr] | [INFO] [stderr] 502 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:502:50 [INFO] [stderr] | [INFO] [stderr] 502 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:716:40 [INFO] [stderr] | [INFO] [stderr] 716 | const FIELDS: &'static [&'static str] = &["message"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:716:50 [INFO] [stderr] | [INFO] [stderr] 716 | const FIELDS: &'static [&'static str] = &["message"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:924:40 [INFO] [stderr] | [INFO] [stderr] 924 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:924:50 [INFO] [stderr] | [INFO] [stderr] 924 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1128:40 [INFO] [stderr] | [INFO] [stderr] 1128 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1128:50 [INFO] [stderr] | [INFO] [stderr] 1128 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1384:40 [INFO] [stderr] | [INFO] [stderr] 1384 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1384:50 [INFO] [stderr] | [INFO] [stderr] 1384 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1707:40 [INFO] [stderr] | [INFO] [stderr] 1707 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1707:50 [INFO] [stderr] | [INFO] [stderr] 1707 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1946:40 [INFO] [stderr] | [INFO] [stderr] 1946 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1946:50 [INFO] [stderr] | [INFO] [stderr] 1946 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2804:40 [INFO] [stderr] | [INFO] [stderr] 2804 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2804:50 [INFO] [stderr] | [INFO] [stderr] 2804 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3061:40 [INFO] [stderr] | [INFO] [stderr] 3061 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3061:50 [INFO] [stderr] | [INFO] [stderr] 3061 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3272:40 [INFO] [stderr] | [INFO] [stderr] 3272 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3272:50 [INFO] [stderr] | [INFO] [stderr] 3272 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3485:40 [INFO] [stderr] | [INFO] [stderr] 3485 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3485:50 [INFO] [stderr] | [INFO] [stderr] 3485 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3697:40 [INFO] [stderr] | [INFO] [stderr] 3697 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3697:50 [INFO] [stderr] | [INFO] [stderr] 3697 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3908:40 [INFO] [stderr] | [INFO] [stderr] 3908 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3908:50 [INFO] [stderr] | [INFO] [stderr] 3908 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4114:40 [INFO] [stderr] | [INFO] [stderr] 4114 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4114:50 [INFO] [stderr] | [INFO] [stderr] 4114 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4321:40 [INFO] [stderr] | [INFO] [stderr] 4321 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4321:50 [INFO] [stderr] | [INFO] [stderr] 4321 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4526:40 [INFO] [stderr] | [INFO] [stderr] 4526 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4526:50 [INFO] [stderr] | [INFO] [stderr] 4526 | const FIELDS: &'static [&'static str] = &["features"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4731:40 [INFO] [stderr] | [INFO] [stderr] 4731 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4731:50 [INFO] [stderr] | [INFO] [stderr] 4731 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4938:40 [INFO] [stderr] | [INFO] [stderr] 4938 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4938:50 [INFO] [stderr] | [INFO] [stderr] 4938 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:392:30 [INFO] [stderr] | [INFO] [stderr] 392 | Message::Welcome(493782, WelcomeDetails::new(RouterRoles::new_basic())), [INFO] [stderr] | ^^^^^^ help: consider: `493_782` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:396:30 [INFO] [stderr] | [INFO] [stderr] 396 | Message::Welcome(493782, WelcomeDetails::new_with_agent(RouterRoles::new(), "dal_wamp")), [INFO] [stderr] | ^^^^^^ help: consider: `493_782` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:430:50 [INFO] [stderr] | [INFO] [stderr] 430 | Message::Error(ErrorType::Subscribe, 713845233, HashMap::new(), Reason::NotAuthorized, None, None), [INFO] [stderr] | ^^^^^^^^^ help: consider: `713_845_233` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:435:52 [INFO] [stderr] | [INFO] [stderr] 435 | Message::Error(ErrorType::Unsubscribe, 3746383, HashMap::new(), Reason::InvalidURI, Some(Vec::new()), None), [INFO] [stderr] | ^^^^^^^ help: consider: `3_746_383` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:440:49 [INFO] [stderr] | [INFO] [stderr] 440 | Message::Error(ErrorType::Register, 8534533, HashMap::new(), Reason::InvalidArgument, Some(Vec::new()), Some(HashMap::new())), [INFO] [stderr] | ^^^^^^^ help: consider: `8_534_533` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:456:40 [INFO] [stderr] | [INFO] [stderr] 456 | Message::Subscribed(47853, 48975938), [INFO] [stderr] | ^^^^^^^^ help: consider: `48_975_938` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:472:35 [INFO] [stderr] | [INFO] [stderr] 472 | Message::Unsubscribed(675343), [INFO] [stderr] | ^^^^^^ help: consider: `675_343` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:480:30 [INFO] [stderr] | [INFO] [stderr] 480 | Message::Publish(453453, PublishOptions::new(false), URI::new("ca.dal.test.topic1"), None, None), [INFO] [stderr] | ^^^^^^ help: consider: `453_453` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:485:30 [INFO] [stderr] | [INFO] [stderr] 485 | Message::Publish(23934583, PublishOptions::new(true), URI::new("ca.dal.test.topic2"), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^^^ help: consider: `23_934_583` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:491:30 [INFO] [stderr] | [INFO] [stderr] 491 | Message::Publish(3243542, PublishOptions::new(true), URI::new("ca.dal.test.topic3"), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^^ help: consider: `3_243_542` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:499:39 [INFO] [stderr] | [INFO] [stderr] 499 | Message::Published(23443, 564564), [INFO] [stderr] | ^^^^^^ help: consider: `564_564` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:507:28 [INFO] [stderr] | [INFO] [stderr] 507 | Message::Event(4353453, 298173, EventDetails::new(), None, None), [INFO] [stderr] | ^^^^^^^ help: consider: `4_353_453` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:507:37 [INFO] [stderr] | [INFO] [stderr] 507 | Message::Event(4353453, 298173, EventDetails::new(), None, None), [INFO] [stderr] | ^^^^^^ help: consider: `298_173` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:512:28 [INFO] [stderr] | [INFO] [stderr] 512 | Message::Event(764346, 3895494, EventDetails::new(), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:512:36 [INFO] [stderr] | [INFO] [stderr] 512 | Message::Event(764346, 3895494, EventDetails::new(), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^^ help: consider: `3_895_494` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:518:35 [INFO] [stderr] | [INFO] [stderr] 518 | Message::Event(65675, 587495, EventDetails::new(), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^ help: consider: `587_495` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:526:31 [INFO] [stderr] | [INFO] [stderr] 526 | Message::Register(25349185, RegisterOptions::new(), URI::new("ca.test.proc")), [INFO] [stderr] | ^^^^^^^^ help: consider: `25_349_185` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:534:33 [INFO] [stderr] | [INFO] [stderr] 534 | Message::Registered(25349185, 2103333224), [INFO] [stderr] | ^^^^^^^^ help: consider: `25_349_185` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:534:43 [INFO] [stderr] | [INFO] [stderr] 534 | Message::Registered(25349185, 2103333224), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_103_333_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:542:33 [INFO] [stderr] | [INFO] [stderr] 542 | Message::Unregister(788923562, 2103333224), [INFO] [stderr] | ^^^^^^^^^ help: consider: `788_923_562` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:542:44 [INFO] [stderr] | [INFO] [stderr] 542 | Message::Unregister(788923562, 2103333224), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_103_333_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:550:35 [INFO] [stderr] | [INFO] [stderr] 550 | Message::Unregistered(788923562), [INFO] [stderr] | ^^^^^^^^^ help: consider: `788_923_562` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:558:27 [INFO] [stderr] | [INFO] [stderr] 558 | Message::Call(7814135, CallOptions::new(), URI::new("com.myapp.ping"), None, None), [INFO] [stderr] | ^^^^^^^ help: consider: `7_814_135` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:563:27 [INFO] [stderr] | [INFO] [stderr] 563 | Message::Call(764346, CallOptions::new(), URI::new("com.myapp.echo"), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:569:27 [INFO] [stderr] | [INFO] [stderr] 569 | Message::Call(764346, CallOptions::new(), URI::new("com.myapp.compute"), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:577:33 [INFO] [stderr] | [INFO] [stderr] 577 | Message::Invocation(7814135, 9823526, InvocationDetails::new(), None, None), [INFO] [stderr] | ^^^^^^^ help: consider: `7_814_135` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:577:42 [INFO] [stderr] | [INFO] [stderr] 577 | Message::Invocation(7814135, 9823526, InvocationDetails::new(), None, None), [INFO] [stderr] | ^^^^^^^ help: consider: `9_823_526` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:582:33 [INFO] [stderr] | [INFO] [stderr] 582 | Message::Invocation(764346, 9823526, InvocationDetails::new(), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:582:41 [INFO] [stderr] | [INFO] [stderr] 582 | Message::Invocation(764346, 9823526, InvocationDetails::new(), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^^ help: consider: `9_823_526` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:588:33 [INFO] [stderr] | [INFO] [stderr] 588 | Message::Invocation(764346, 9823526, InvocationDetails::new(), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:588:41 [INFO] [stderr] | [INFO] [stderr] 588 | Message::Invocation(764346, 9823526, InvocationDetails::new(), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^^ help: consider: `9_823_526` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:596:28 [INFO] [stderr] | [INFO] [stderr] 596 | Message::Yield(6131533, YieldOptions::new(), None, None), [INFO] [stderr] | ^^^^^^^ help: consider: `6_131_533` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:601:28 [INFO] [stderr] | [INFO] [stderr] 601 | Message::Yield(6131533, YieldOptions::new(), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^^ help: consider: `6_131_533` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:607:28 [INFO] [stderr] | [INFO] [stderr] 607 | Message::Yield(6131533, YieldOptions::new(), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^^ help: consider: `6_131_533` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:615:29 [INFO] [stderr] | [INFO] [stderr] 615 | Message::Result(7814135, ResultDetails::new(), None, None), [INFO] [stderr] | ^^^^^^^ help: consider: `7_814_135` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:620:29 [INFO] [stderr] | [INFO] [stderr] 620 | Message::Result(764346, ResultDetails::new(), Some(vec![Value::String("a value".to_string())]), None), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/messages/mod.rs:626:29 [INFO] [stderr] | [INFO] [stderr] 626 | Message::Result(764346, ResultDetails::new(), Some(Vec::new()), Some(kwargs)), [INFO] [stderr] | ^^^^^^ help: consider: `764_346` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/client.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / macro_rules! try_websocket { [INFO] [stderr] 34 | | ($e: expr) => ( [INFO] [stderr] 35 | | match $e { [INFO] [stderr] 36 | | Ok(result) => result, [INFO] [stderr] ... | [INFO] [stderr] 39 | | ); [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/client.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | handler [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/client.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | let handler = ConnectionHandler { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 192 | | state_transmission: tx.clone(), [INFO] [stderr] 193 | | connection_info: info, [INFO] [stderr] 194 | | realm: realm.clone() [INFO] [stderr] 195 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | / if uri_bit.len() == 0 { [INFO] [stderr] 165 | | if matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 166 | | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | if uri_bit.len() == 0 && matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 165 | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/pubsub/patterns.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/pubsub/patterns.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/pubsub/patterns.rs:206:24 [INFO] [stderr] | [INFO] [stderr] 206 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/pubsub/patterns.rs:206:24 [INFO] [stderr] | [INFO] [stderr] 206 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:265:24 [INFO] [stderr] | [INFO] [stderr] 265 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 266 | | if let Some(child) = self.current.node.edges.get("") { [INFO] [stderr] 267 | | self.current.state = IterState::Wildcard; [INFO] [stderr] 268 | | self.push(child); [INFO] [stderr] ... | [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 265 | } else if let Some(child) = self.current.node.edges.get("") { [INFO] [stderr] 266 | self.current.state = IterState::Wildcard; [INFO] [stderr] 267 | self.push(child); [INFO] [stderr] 268 | } else { [INFO] [stderr] 269 | if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 270 | self.current.state = IterState::Strict; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:269:28 [INFO] [stderr] | [INFO] [stderr] 269 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 270 | | if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 271 | | self.current.state = IterState::Strict; [INFO] [stderr] 272 | | self.push(child); [INFO] [stderr] ... | [INFO] [stderr] 276 | | } [INFO] [stderr] 277 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 269 | } else if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 270 | self.current.state = IterState::Strict; [INFO] [stderr] 271 | self.push(child); [INFO] [stderr] 272 | } [INFO] [stderr] 273 | else { [INFO] [stderr] 274 | self.current.state = IterState::AllComplete; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/pubsub/patterns.rs:283:23 [INFO] [stderr] | [INFO] [stderr] 283 | } else { [INFO] [stderr] | _______________________^ [INFO] [stderr] 284 | | if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 285 | | self.current.state = IterState::Strict; [INFO] [stderr] 286 | | self.push(child); [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 283 | } else if let Some(child) = self.current.node.edges.get(&self.uri[self.current.depth]) { [INFO] [stderr] 284 | self.current.state = IterState::Strict; [INFO] [stderr] 285 | self.push(child); [INFO] [stderr] 286 | } else { [INFO] [stderr] 287 | self.current.state = IterState::AllComplete; [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/router/rpc/patterns.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | / if uri_bit.len() == 0 { [INFO] [stderr] 192 | | if matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 193 | | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | if uri_bit.len() == 0 && matching_policy != MatchingPolicy::Wildcard { [INFO] [stderr] 192 | return Err(PatternError::new(Reason::InvalidURI)); [INFO] [stderr] 193 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/rpc/patterns.rs:224:24 [INFO] [stderr] | [INFO] [stderr] 224 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/rpc/patterns.rs:224:24 [INFO] [stderr] | [INFO] [stderr] 224 | Ok((self.prefix_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/router/rpc/patterns.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/router/rpc/patterns.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | Ok((self.id)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router/rpc/patterns.rs:242:16 [INFO] [stderr] | [INFO] [stderr] 242 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 243 | | if let Some((registrant, id)) = self.recurse(uri_bits, depth) { [INFO] [stderr] 244 | | Some((registrant, id)) [INFO] [stderr] 245 | | } else if let Some(registrant) = self.prefix_connections.get_entry() { [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | } else if let Some((registrant, id)) = self.recurse(uri_bits, depth) { [INFO] [stderr] 243 | Some((registrant, id)) [INFO] [stderr] 244 | } else if let Some(registrant) = self.prefix_connections.get_entry() { [INFO] [stderr] 245 | Some((registrant, self.prefix_id)) [INFO] [stderr] 246 | } else { [INFO] [stderr] 247 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:287:60 [INFO] [stderr] | [INFO] [stderr] 287 | return Ok(Some(try!(_serializer.serialize_struct_elt("agent", &self.value.agent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:291:60 [INFO] [stderr] | [INFO] [stderr] 291 | return Ok(Some(try!(_serializer.serialize_struct_elt("roles", &self.value.roles)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.agent) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:299:38 [INFO] [stderr] | [INFO] [stderr] 299 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 300 | | if Option::is_none(&self.value.agent) [INFO] [stderr] 301 | | { [INFO] [stderr] 302 | | 0 [INFO] [stderr] 303 | | } else { 1 } + 1) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:545:60 [INFO] [stderr] | [INFO] [stderr] 545 | return Ok(Some(try!(_serializer.serialize_struct_elt("agent", &self.value.agent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:549:60 [INFO] [stderr] | [INFO] [stderr] 549 | return Ok(Some(try!(_serializer.serialize_struct_elt("roles", &self.value.roles)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.agent) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:557:38 [INFO] [stderr] | [INFO] [stderr] 557 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 558 | | if Option::is_none(&self.value.agent) [INFO] [stderr] 559 | | { [INFO] [stderr] 560 | | 0 [INFO] [stderr] 561 | | } else { 1 } + 1) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:755:60 [INFO] [stderr] | [INFO] [stderr] 755 | return Ok(Some(try!(_serializer.serialize_struct_elt("message", &self.value.message)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.message) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:763:38 [INFO] [stderr] | [INFO] [stderr] 763 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 764 | | if Option::is_none(&self.value.message) [INFO] [stderr] 765 | | { [INFO] [stderr] 766 | | 0 [INFO] [stderr] 767 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:964:60 [INFO] [stderr] | [INFO] [stderr] 964 | return Ok(Some(try!(_serializer.serialize_struct_elt("match", &self.value.pattern_match)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:972:38 [INFO] [stderr] | [INFO] [stderr] 972 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 973 | | if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] 974 | | { [INFO] [stderr] 975 | | 0 [INFO] [stderr] 976 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1168:60 [INFO] [stderr] | [INFO] [stderr] 1168 | return Ok(Some(try!(_serializer.serialize_struct_elt("acknowledge", &self.value.acknowledge)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.acknowledge) { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1176:38 [INFO] [stderr] | [INFO] [stderr] 1176 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1177 | | if is_not(&self.value.acknowledge) { [INFO] [stderr] 1178 | | 0 [INFO] [stderr] 1179 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1427:60 [INFO] [stderr] | [INFO] [stderr] 1427 | return Ok(Some(try!(_serializer.serialize_struct_elt("match", &self.value.pattern_match)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1435:60 [INFO] [stderr] | [INFO] [stderr] 1435 | return Ok(Some(try!(_serializer.serialize_struct_elt("invoke", &self.value.invocation_policy)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1443:38 [INFO] [stderr] | [INFO] [stderr] 1443 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1444 | | if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] 1445 | | { [INFO] [stderr] 1446 | | 0 [INFO] [stderr] 1447 | | } else { 1 } + [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1753:60 [INFO] [stderr] | [INFO] [stderr] 1753 | return Ok(Some(try!(_serializer.serialize_struct_elt("publisher", &self.value.publisher)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1761:60 [INFO] [stderr] | [INFO] [stderr] 1761 | return Ok(Some(try!(_serializer.serialize_struct_elt("trustlevel", &self.value.trustlevel)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1769:60 [INFO] [stderr] | [INFO] [stderr] 1769 | return Ok(Some(try!(_serializer.serialize_struct_elt("topic", &self.value.topic)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.publisher) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1777:38 [INFO] [stderr] | [INFO] [stderr] 1777 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1778 | | if Option::is_none(&self.value.publisher) [INFO] [stderr] 1779 | | { [INFO] [stderr] 1780 | | 0 [INFO] [stderr] 1781 | | } else { 1 } + [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1986:60 [INFO] [stderr] | [INFO] [stderr] 1986 | return Ok(Some(try!(_serializer.serialize_struct_elt("procedure", &self.value.procedure)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.procedure) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1994:38 [INFO] [stderr] | [INFO] [stderr] 1994 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1995 | | if Option::is_none(&self.value.procedure) [INFO] [stderr] 1996 | | { [INFO] [stderr] 1997 | | 0 [INFO] [stderr] 1998 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::ErrorDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2031:9 [INFO] [stderr] | [INFO] [stderr] 2031 | pub fn new() -> ErrorDetails { ErrorDetails{message: None,} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 574 | #[derive(Default)] [INFO] [stderr] 575 | pub struct ErrorDetails { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::SubscribeOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2037:9 [INFO] [stderr] | [INFO] [stderr] 2037 | / pub fn new() -> SubscribeOptions { [INFO] [stderr] 2038 | | SubscribeOptions{pattern_match: MatchingPolicy::Strict,} [INFO] [stderr] 2039 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 780 | #[derive(Default)] [INFO] [stderr] 781 | pub struct SubscribeOptions { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::RegisterOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2048:9 [INFO] [stderr] | [INFO] [stderr] 2048 | / pub fn new() -> RegisterOptions { [INFO] [stderr] 2049 | | RegisterOptions{pattern_match: MatchingPolicy::Strict, [INFO] [stderr] 2050 | | invocation_policy: InvocationPolicy::Single,} [INFO] [stderr] 2051 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1192 | #[derive(Default)] [INFO] [stderr] 1193 | pub struct RegisterOptions { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::CallOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2054:9 [INFO] [stderr] | [INFO] [stderr] 2054 | pub fn new() -> CallOptions { CallOptions{} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1464 | #[derive(Default)] [INFO] [stderr] 1465 | pub struct CallOptions; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::YieldOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2057:9 [INFO] [stderr] | [INFO] [stderr] 2057 | pub fn new() -> YieldOptions { YieldOptions{} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1466 | #[derive(Default)] [INFO] [stderr] 1467 | pub struct YieldOptions; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::EventDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2060:9 [INFO] [stderr] | [INFO] [stderr] 2060 | / pub fn new() -> EventDetails { [INFO] [stderr] 2061 | | EventDetails{publisher: None, trustlevel: None, topic: None,} [INFO] [stderr] 2062 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1468 | #[derive(Default)] [INFO] [stderr] 1469 | pub struct EventDetails { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::InvocationDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2070:9 [INFO] [stderr] | [INFO] [stderr] 2070 | / pub fn new() -> InvocationDetails { [INFO] [stderr] 2071 | | InvocationDetails{procedure: None,} [INFO] [stderr] 2072 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1802 | #[derive(Default)] [INFO] [stderr] 1803 | pub struct InvocationDetails { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::ResultDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2075:9 [INFO] [stderr] | [INFO] [stderr] 2075 | pub fn new() -> ResultDetails { ResultDetails{} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2011 | #[derive(Default)] [INFO] [stderr] 2012 | pub struct ResultDetails; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2124:21 [INFO] [stderr] | [INFO] [stderr] 2124 | / if let &Value::Integer(value) = value { [INFO] [stderr] 2125 | | Ok(Some(value)) [INFO] [stderr] 2126 | | } else { [INFO] [stderr] 2127 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2132 | | ) ))), None)) [INFO] [stderr] 2133 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2124 | if let Value::Integer(value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2143:21 [INFO] [stderr] | [INFO] [stderr] 2143 | / if let &Value::String(ref value) = value { [INFO] [stderr] 2144 | | Ok(Some(value)) [INFO] [stderr] 2145 | | } else { [INFO] [stderr] 2146 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2151 | | ) ))), None)) [INFO] [stderr] 2152 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2143 | if let Value::String(ref value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2175:21 [INFO] [stderr] | [INFO] [stderr] 2175 | / if let &Value::Integer(value) = value { [INFO] [stderr] 2176 | | Ok(Some(value)) [INFO] [stderr] 2177 | | } else { [INFO] [stderr] 2178 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2183 | | ) ))), None)) [INFO] [stderr] 2184 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2175 | if let Value::Integer(value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2194:21 [INFO] [stderr] | [INFO] [stderr] 2194 | / if let &Value::String(ref value) = value { [INFO] [stderr] 2195 | | Ok(Some(value)) [INFO] [stderr] 2196 | | } else { [INFO] [stderr] 2197 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2202 | | ) ))), None)) [INFO] [stderr] 2203 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2194 | if let Value::String(ref value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2211:13 [INFO] [stderr] | [INFO] [stderr] 2211 | / match self { [INFO] [stderr] 2212 | | &Value::Dict(ref d) => { [INFO] [stderr] 2213 | | let mut result = String::new(); [INFO] [stderr] 2214 | | result.push('{'); [INFO] [stderr] ... | [INFO] [stderr] 2237 | | &Value::Boolean(b) => { b.to_string() } [INFO] [stderr] 2238 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2211 | match *self { [INFO] [stderr] 2212 | Value::Dict(ref d) => { [INFO] [stderr] 2213 | let mut result = String::new(); [INFO] [stderr] 2214 | result.push('{'); [INFO] [stderr] 2215 | result.push_str(&d.iter().take(50).map(|(key, value)| [INFO] [stderr] 2216 | format!("{}:{}" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2381:25 [INFO] [stderr] | [INFO] [stderr] 2381 | pub fn to_tuple(self) -> (Reason, Option, Option) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2844:33 [INFO] [stderr] | [INFO] [stderr] 2844 | / loop { [INFO] [stderr] 2845 | | match self.state { [INFO] [stderr] 2846 | | 0usize => { [INFO] [stderr] 2847 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 2863 | | } [INFO] [stderr] 2864 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2848:60 [INFO] [stderr] | [INFO] [stderr] 2848 | return Ok(Some(try!(_serializer.serialize_struct_elt("publisher", &self.value.publisher)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2852:60 [INFO] [stderr] | [INFO] [stderr] 2852 | return Ok(Some(try!(_serializer.serialize_struct_elt("subscriber", &self.value.subscriber)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2856:60 [INFO] [stderr] | [INFO] [stderr] 2856 | return Ok(Some(try!(_serializer.serialize_struct_elt("caller", &self.value.caller)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2860:60 [INFO] [stderr] | [INFO] [stderr] 2860 | return Ok(Some(try!(_serializer.serialize_struct_elt("callee", &self.value.callee)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2868:38 [INFO] [stderr] | [INFO] [stderr] 2868 | Some(0 + 1 + 1 + 1 + 1) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3095:33 [INFO] [stderr] | [INFO] [stderr] 3095 | / loop { [INFO] [stderr] 3096 | | match self.state { [INFO] [stderr] 3097 | | 0usize => { [INFO] [stderr] 3098 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 3106 | | } [INFO] [stderr] 3107 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3099:60 [INFO] [stderr] | [INFO] [stderr] 3099 | return Ok(Some(try!(_serializer.serialize_struct_elt("dealer", &self.value.dealer)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3103:60 [INFO] [stderr] | [INFO] [stderr] 3103 | return Ok(Some(try!(_serializer.serialize_struct_elt("broker", &self.value.broker)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3110:67 [INFO] [stderr] | [INFO] [stderr] 3110 | fn len(&self) -> Option { Some(0 + 1 + 1) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3314:60 [INFO] [stderr] | [INFO] [stderr] 3314 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3322:38 [INFO] [stderr] | [INFO] [stderr] 3322 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3323 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3324 | | { [INFO] [stderr] 3325 | | 0 [INFO] [stderr] 3326 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3526:60 [INFO] [stderr] | [INFO] [stderr] 3526 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3534:38 [INFO] [stderr] | [INFO] [stderr] 3534 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3535 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3536 | | { [INFO] [stderr] 3537 | | 0 [INFO] [stderr] 3538 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3738:60 [INFO] [stderr] | [INFO] [stderr] 3738 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3746:38 [INFO] [stderr] | [INFO] [stderr] 3746 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3747 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3748 | | { [INFO] [stderr] 3749 | | 0 [INFO] [stderr] 3750 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3948:60 [INFO] [stderr] | [INFO] [stderr] 3948 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3956:38 [INFO] [stderr] | [INFO] [stderr] 3956 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3957 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3958 | | { [INFO] [stderr] 3959 | | 0 [INFO] [stderr] 3960 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4154:60 [INFO] [stderr] | [INFO] [stderr] 4154 | return Ok(Some(try!(_serializer.serialize_struct_elt("pattern_based_subscription", [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 4155 | | &self.value.pattern_based_subscription)))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4163:38 [INFO] [stderr] | [INFO] [stderr] 4163 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4164 | | if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] 4165 | | { [INFO] [stderr] 4166 | | 0 [INFO] [stderr] 4167 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4360:60 [INFO] [stderr] | [INFO] [stderr] 4360 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4368:38 [INFO] [stderr] | [INFO] [stderr] 4368 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4369 | | if Option::is_none(&self.value.features) [INFO] [stderr] 4370 | | { [INFO] [stderr] 4371 | | 0 [INFO] [stderr] 4372 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4565:60 [INFO] [stderr] | [INFO] [stderr] 4565 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4573:38 [INFO] [stderr] | [INFO] [stderr] 4573 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4574 | | if Option::is_none(&self.value.features) [INFO] [stderr] 4575 | | { [INFO] [stderr] 4576 | | 0 [INFO] [stderr] 4577 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4771:60 [INFO] [stderr] | [INFO] [stderr] 4771 | return Ok(Some(try!(_serializer.serialize_struct_elt("pattern_based_registration", [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 4772 | | &self.value.pattern_based_registration)))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.pattern_based_registration) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4780:38 [INFO] [stderr] | [INFO] [stderr] 4780 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4781 | | if is_not(&self.value.pattern_based_registration) [INFO] [stderr] 4782 | | { [INFO] [stderr] 4783 | | 0 [INFO] [stderr] 4784 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4978:60 [INFO] [stderr] | [INFO] [stderr] 4978 | return Ok(Some(try!(_serializer.serialize_struct_elt("pattern_based_subscription", [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 4979 | | &self.value.pattern_based_subscription)))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4987:38 [INFO] [stderr] | [INFO] [stderr] 4987 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4988 | | if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] 4989 | | { [INFO] [stderr] 4990 | | 0 [INFO] [stderr] 4991 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `messages::types::roles::RouterRoles` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5005:9 [INFO] [stderr] | [INFO] [stderr] 5005 | / pub fn new() -> RouterRoles { [INFO] [stderr] 5006 | | RouterRoles{broker: [INFO] [stderr] 5007 | | BrokerRole{features: [INFO] [stderr] 5008 | | Some(BrokerFeatures{pattern_based_subscription: [INFO] [stderr] ... | [INFO] [stderr] 5013 | | true,}),},} [INFO] [stderr] 5014 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5003 | impl Default for messages::types::roles::RouterRoles { [INFO] [stderr] 5004 | fn default() -> Self { [INFO] [stderr] 5005 | Self::new() [INFO] [stderr] 5006 | } [INFO] [stderr] 5007 | } [INFO] [stderr] 5008 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `messages::types::roles::ClientRoles` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5023:9 [INFO] [stderr] | [INFO] [stderr] 5023 | / pub fn new() -> ClientRoles { [INFO] [stderr] 5024 | | ClientRoles{publisher: [INFO] [stderr] 5025 | | PublisherRole{features: Some(HashMap::new()),}, [INFO] [stderr] 5026 | | subscriber: [INFO] [stderr] ... | [INFO] [stderr] 5031 | | callee: CalleeRole{features: Some(HashMap::new()),},} [INFO] [stderr] 5032 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5021 | impl Default for messages::types::roles::ClientRoles { [INFO] [stderr] 5022 | fn default() -> Self { [INFO] [stderr] 5023 | Self::new() [INFO] [stderr] 5024 | } [INFO] [stderr] 5025 | } [INFO] [stderr] 5026 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5051:14 [INFO] [stderr] | [INFO] [stderr] 5051 | fn is_not(b: &bool) -> bool { !*b } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5073:18 [INFO] [stderr] | [INFO] [stderr] 5073 | fn is_strict(&self) -> bool { self == &MatchingPolicy::Strict } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5077:18 [INFO] [stderr] | [INFO] [stderr] 5077 | fn is_single(&self) -> bool { self == &InvocationPolicy::Single } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 76 | serialize_with_args!(args, kwargs, serializer, 8, ty, id, details, reason) [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 76 | serialize_with_args!(args, kwargs, serializer, 8, ty, id, details, reason) [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 76 | serialize_with_args!(args, kwargs, serializer, 8, ty, id, details, reason) [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 91 | serialize_with_args!(args, kwargs, serializer, 16, id, details, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 91 | serialize_with_args!(args, kwargs, serializer, 16, id, details, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 91 | serialize_with_args!(args, kwargs, serializer, 16, id, details, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 97 | serialize_with_args!(args, kwargs, serializer, 36, subscription_id, publication_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 97 | serialize_with_args!(args, kwargs, serializer, 36, subscription_id, publication_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 97 | serialize_with_args!(args, kwargs, serializer, 36, subscription_id, publication_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 112 | serialize_with_args!(args, kwargs, serializer, 48, id, options, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 112 | serialize_with_args!(args, kwargs, serializer, 48, id, options, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 112 | serialize_with_args!(args, kwargs, serializer, 48, id, options, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 115 | serialize_with_args!(args, kwargs, serializer, 68, id, registration_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | serialize_with_args!(args, kwargs, serializer, 68, id, registration_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | serialize_with_args!(args, kwargs, serializer, 68, id, registration_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 118 | serialize_with_args!(args, kwargs, serializer, 70, id, options) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 118 | serialize_with_args!(args, kwargs, serializer, 70, id, options) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 118 | serialize_with_args!(args, kwargs, serializer, 70, id, options) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 121 | serialize_with_args!(args, kwargs, serializer, 50, id, details) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 121 | serialize_with_args!(args, kwargs, serializer, 50, id, details) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 121 | serialize_with_args!(args, kwargs, serializer, 50, id, details) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | callback: Box CallResult<(Option, Option)>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/client.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn connect<'a>(&self) -> WampResult { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | / match info.shutdown_complete.take() { [INFO] [stderr] 308 | | Some(promise) => { [INFO] [stderr] 309 | | promise.complete(()); [INFO] [stderr] 310 | | }, [INFO] [stderr] 311 | | None => {} [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | if let Some(promise) = info.shutdown_complete.take() { [INFO] [stderr] 308 | promise.complete(()); [INFO] [stderr] 309 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:392:21 [INFO] [stderr] | [INFO] [stderr] 392 | / match info.shutdown_complete.take() { [INFO] [stderr] 393 | | Some(promise) => promise.complete(()), [INFO] [stderr] 394 | | None => {} [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(promise) = info.shutdown_complete.take() { promise.complete(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:548:20 [INFO] [stderr] | [INFO] [stderr] 548 | let args = args.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:549:22 [INFO] [stderr] | [INFO] [stderr] 549 | let kwargs = kwargs.unwrap_or(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `kwargs.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/client.rs:552:21 [INFO] [stderr] | [INFO] [stderr] 552 | let ref mut callback = subscription.callback; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let callback = &mut subscription.callback;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:562:20 [INFO] [stderr] | [INFO] [stderr] 562 | let args = args.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:563:22 [INFO] [stderr] | [INFO] [stderr] 563 | let kwargs = kwargs.unwrap_or(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `kwargs.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/client.rs:566:21 [INFO] [stderr] | [INFO] [stderr] 566 | let ref mut callback = registration.callback; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let callback = &mut registration.callback;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:585:20 [INFO] [stderr] | [INFO] [stderr] 585 | let args = args.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:586:22 [INFO] [stderr] | [INFO] [stderr] 586 | let kwargs = kwargs.unwrap_or(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `kwargs.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/client.rs:616:5 [INFO] [stderr] | [INFO] [stderr] 616 | / fn handle_error(&self, info: MutexGuard, e_type: ErrorType, request_id: ID, _details: Dict, reason: Reason, args: Option, kwargs: Option) { [INFO] [stderr] 617 | | match e_type { [INFO] [stderr] 618 | | ErrorType::Subscribe => { [INFO] [stderr] 619 | | self.handle_subscribe_error(info, request_id, reason, args, kwargs) [INFO] [stderr] ... | [INFO] [stderr] 639 | | } [INFO] [stderr] 640 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client.rs:670:79 [INFO] [stderr] | [INFO] [stderr] 670 | pub fn register_with_pattern(&mut self, procedure_pattern: URI, callback: Box CallResult<(Option, Option)> >, policy: MatchingPolicy) -> WampResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client.rs:687:58 [INFO] [stderr] | [INFO] [stderr] 687 | pub fn register(&mut self, procedure: URI, callback: Box CallResult<(Option, Option)> >) -> WampResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/router/pubsub/patterns.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 98 | | &IterState::None => "None", [INFO] [stderr] 99 | | &IterState::Wildcard => "Wildcard", [INFO] [stderr] 100 | | &IterState::Strict => "Strict", [INFO] [stderr] ... | [INFO] [stderr] 104 | | &IterState::AllComplete => "AllComplete" [INFO] [stderr] 105 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | write!(f, "{}", match *self { [INFO] [stderr] 98 | IterState::None => "None", [INFO] [stderr] 99 | IterState::Wildcard => "Wildcard", [INFO] [stderr] 100 | IterState::Strict => "Strict", [INFO] [stderr] 101 | IterState::Prefix(_) => "Prefix", [INFO] [stderr] 102 | IterState::PrefixComplete => "PrefixComplete", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/pubsub/patterns.rs:134:44 [INFO] [stderr] | [INFO] [stderr] 134 | let mut uri_bits = topic.uri.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/pubsub/patterns.rs:139:58 [INFO] [stderr] | [INFO] [stderr] 139 | let edge = self.edges.entry(initial.to_string()).or_insert(SubscriptionPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(SubscriptionPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/pubsub/patterns.rs:145:36 [INFO] [stderr] | [INFO] [stderr] 145 | let uri_bits = topic.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router/pubsub/patterns.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if uri_bit.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `uri_bit.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/pubsub/patterns.rs:169:66 [INFO] [stderr] | [INFO] [stderr] 169 | let edge = self.edges.entry(uri_bit.to_string()).or_insert(SubscriptionPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(SubscriptionPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/router/pubsub/patterns.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn filter<'a>(&'a self, topic: URI) -> MatchIterator<'a, P> { [INFO] [stderr] 218 | | MatchIterator { [INFO] [stderr] 219 | | current: Box::new(StackFrame { [INFO] [stderr] 220 | | node: self, [INFO] [stderr] ... | [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/patterns.rs:322:53 [INFO] [stderr] | [INFO] [stderr] 322 | return Some((&next.subscriber, self.current.node.prefix_id.clone(), next.policy)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.current.node.prefix_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/patterns.rs:328:52 [INFO] [stderr] | [INFO] [stderr] 328 | return Some((&next.subscriber, self.current.node.id.clone(), next.policy)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.current.node.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/mod.rs:17:106 [INFO] [stderr] | [INFO] [stderr] 17 | let topic_id = match manager.subscriptions.subscribe_with(&topic, self.info.clone(), options.pattern_match.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.pattern_match` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/mod.rs:39:70 [INFO] [stderr] | [INFO] [stderr] 39 | Some(&(ref uri, ref is_prefix)) => (uri.clone(), is_prefix.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*is_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/mod.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | self.info.lock().unwrap().id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.info.lock().unwrap().id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router/rpc/patterns.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if self.procedures.len() == 0 || (invocation_policy == self.invocation_policy && invocation_policy != InvocationPolicy::Single) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.procedures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/rpc/patterns.rs:140:44 [INFO] [stderr] | [INFO] [stderr] 140 | let mut uri_bits = topic.uri.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/rpc/patterns.rs:145:58 [INFO] [stderr] | [INFO] [stderr] 145 | let edge = self.edges.entry(initial.to_string()).or_insert(RegistrationPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(RegistrationPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/rpc/patterns.rs:151:36 [INFO] [stderr] | [INFO] [stderr] 151 | let uri_bits = topic.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/rpc/patterns.rs:157:65 [INFO] [stderr] | [INFO] [stderr] 157 | let wrapper = self.find_registrant(&procedure.uri.split(".").collect(), 0); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router/rpc/patterns.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | if uri_bit.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `uri_bit.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/rpc/patterns.rs:196:66 [INFO] [stderr] | [INFO] [stderr] 196 | let edge = self.edges.entry(uri_bit.to_string()).or_insert(RegistrationPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(RegistrationPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/router/rpc/patterns.rs:233:41 [INFO] [stderr] | [INFO] [stderr] 233 | fn find_registrant(&self, uri_bits: &Vec<&str>, depth: usize) -> Option<(&DataWrapper

, ID)> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/router/rpc/patterns.rs:253:33 [INFO] [stderr] | [INFO] [stderr] 253 | fn recurse(&self, uri_bits: &Vec<&str>, depth: usize) -> Option<(&DataWrapper

, ID)> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/rpc/mod.rs:18:113 [INFO] [stderr] | [INFO] [stderr] 18 | let procedure_id = match manager.registrations.register_with(&procedure, self.info.clone(), options.pattern_match.clone(), options.invocation_policy.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.pattern_match` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/rpc/mod.rs:18:144 [INFO] [stderr] | [INFO] [stderr] 18 | let procedure_id = match manager.registrations.register_with(&procedure, self.info.clone(), options.pattern_match.clone(), options.invocation_policy.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.invocation_policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/rpc/mod.rs:40:70 [INFO] [stderr] | [INFO] [stderr] 40 | Some(&(ref uri, ref is_prefix)) => (uri.clone(), is_prefix.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*is_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router/mod.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> Router { [INFO] [stderr] 86 | | Router{ [INFO] [stderr] 87 | | info: Arc::new(RouterInfo { [INFO] [stderr] 88 | | realms: Mutex::new(HashMap::new()), [INFO] [stderr] 89 | | }) [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | impl Default for router::Router { [INFO] [stderr] 84 | fn default() -> Self { [INFO] [stderr] 85 | Self::new() [INFO] [stderr] 86 | } [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self.realm { [INFO] [stderr] 160 | | Some(ref realm) => { [INFO] [stderr] 161 | | [INFO] [stderr] 162 | | let mut realm = realm.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 159 | if let Some(ref realm) = self.realm { [INFO] [stderr] 160 | [INFO] [stderr] 161 | let mut realm = realm.lock().unwrap(); [INFO] [stderr] 162 | { [INFO] [stderr] 163 | trace!("Removing subscriptions for client {}", self.info.lock().unwrap().id); [INFO] [stderr] 164 | let mut manager = &mut realm.subscription_manager; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router/mod.rs:168:25 [INFO] [stderr] | [INFO] [stderr] 168 | / match manager.subscription_ids_to_uris.get(&subscription_id) { [INFO] [stderr] 169 | | Some(&(ref topic_uri, is_prefix)) => { [INFO] [stderr] 170 | | trace!("Removing subscription to {:?}", topic_uri); [INFO] [stderr] 171 | | manager.subscriptions.unsubscribe_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] ... | [INFO] [stderr] 174 | | None => {} [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 168 | if let Some(&(ref topic_uri, is_prefix)) = manager.subscription_ids_to_uris.get(&subscription_id) { [INFO] [stderr] 169 | trace!("Removing subscription to {:?}", topic_uri); [INFO] [stderr] 170 | manager.subscriptions.unsubscribe_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] 171 | trace!("Subscription tree: {:?}", manager.subscriptions); [INFO] [stderr] 172 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router/mod.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | / match manager.registration_ids_to_uris.get(®istration_id) { [INFO] [stderr] 182 | | Some(&(ref topic_uri, is_prefix)) => { [INFO] [stderr] 183 | | manager.registrations.unregister_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] 184 | | }, [INFO] [stderr] 185 | | None => {} [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let Some(&(ref topic_uri, is_prefix)) = manager.registration_ids_to_uris.get(®istration_id) { [INFO] [stderr] 182 | manager.registrations.unregister_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/mod.rs:189:29 [INFO] [stderr] | [INFO] [stderr] 189 | let my_id = self.info.lock().unwrap().id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.info.lock().unwrap().id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | &ErrorKind::WSError(ref e) => e.to_string(), [INFO] [stderr] 86 | | &ErrorKind::UnexpectedMessage(s) => s.to_string(), [INFO] [stderr] 87 | | &ErrorKind::URLError(ref e) => e.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 97 | | &ErrorKind::ErrorReason(_, _, ref s) => s.to_string(), [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *self { [INFO] [stderr] 85 | ErrorKind::WSError(ref e) => e.to_string(), [INFO] [stderr] 86 | ErrorKind::UnexpectedMessage(s) => s.to_string(), [INFO] [stderr] 87 | ErrorKind::URLError(ref e) => e.to_string(), [INFO] [stderr] 88 | ErrorKind::ThreadError(ref e) => e.to_string(), [INFO] [stderr] 89 | ErrorKind::ConnectionLost => "Connection Lost".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:287:60 [INFO] [stderr] | [INFO] [stderr] 287 | return Ok(Some(try!(_serializer.serialize_struct_elt("agent", &self.value.agent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:291:60 [INFO] [stderr] | [INFO] [stderr] 291 | return Ok(Some(try!(_serializer.serialize_struct_elt("roles", &self.value.roles)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.agent) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:299:38 [INFO] [stderr] | [INFO] [stderr] 299 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 300 | | if Option::is_none(&self.value.agent) [INFO] [stderr] 301 | | { [INFO] [stderr] 302 | | 0 [INFO] [stderr] 303 | | } else { 1 } + 1) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: Could not compile `wamp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:545:60 [INFO] [stderr] | [INFO] [stderr] 545 | return Ok(Some(try!(_serializer.serialize_struct_elt("agent", &self.value.agent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:549:60 [INFO] [stderr] | [INFO] [stderr] 549 | return Ok(Some(try!(_serializer.serialize_struct_elt("roles", &self.value.roles)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.agent) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:557:38 [INFO] [stderr] | [INFO] [stderr] 557 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 558 | | if Option::is_none(&self.value.agent) [INFO] [stderr] 559 | | { [INFO] [stderr] 560 | | 0 [INFO] [stderr] 561 | | } else { 1 } + 1) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:755:60 [INFO] [stderr] | [INFO] [stderr] 755 | return Ok(Some(try!(_serializer.serialize_struct_elt("message", &self.value.message)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.message) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:763:38 [INFO] [stderr] | [INFO] [stderr] 763 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 764 | | if Option::is_none(&self.value.message) [INFO] [stderr] 765 | | { [INFO] [stderr] 766 | | 0 [INFO] [stderr] 767 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:964:60 [INFO] [stderr] | [INFO] [stderr] 964 | return Ok(Some(try!(_serializer.serialize_struct_elt("match", &self.value.pattern_match)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:972:38 [INFO] [stderr] | [INFO] [stderr] 972 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 973 | | if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] 974 | | { [INFO] [stderr] 975 | | 0 [INFO] [stderr] 976 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1168:60 [INFO] [stderr] | [INFO] [stderr] 1168 | return Ok(Some(try!(_serializer.serialize_struct_elt("acknowledge", &self.value.acknowledge)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.acknowledge) { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1176:38 [INFO] [stderr] | [INFO] [stderr] 1176 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1177 | | if is_not(&self.value.acknowledge) { [INFO] [stderr] 1178 | | 0 [INFO] [stderr] 1179 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1427:60 [INFO] [stderr] | [INFO] [stderr] 1427 | return Ok(Some(try!(_serializer.serialize_struct_elt("match", &self.value.pattern_match)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1435:60 [INFO] [stderr] | [INFO] [stderr] 1435 | return Ok(Some(try!(_serializer.serialize_struct_elt("invoke", &self.value.invocation_policy)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1443:38 [INFO] [stderr] | [INFO] [stderr] 1443 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1444 | | if MatchingPolicy::is_strict(&self.value.pattern_match) [INFO] [stderr] 1445 | | { [INFO] [stderr] 1446 | | 0 [INFO] [stderr] 1447 | | } else { 1 } + [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1753:60 [INFO] [stderr] | [INFO] [stderr] 1753 | return Ok(Some(try!(_serializer.serialize_struct_elt("publisher", &self.value.publisher)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1761:60 [INFO] [stderr] | [INFO] [stderr] 1761 | return Ok(Some(try!(_serializer.serialize_struct_elt("trustlevel", &self.value.trustlevel)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1769:60 [INFO] [stderr] | [INFO] [stderr] 1769 | return Ok(Some(try!(_serializer.serialize_struct_elt("topic", &self.value.topic)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.publisher) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1777:38 [INFO] [stderr] | [INFO] [stderr] 1777 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1778 | | if Option::is_none(&self.value.publisher) [INFO] [stderr] 1779 | | { [INFO] [stderr] 1780 | | 0 [INFO] [stderr] 1781 | | } else { 1 } + [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1986:60 [INFO] [stderr] | [INFO] [stderr] 1986 | return Ok(Some(try!(_serializer.serialize_struct_elt("procedure", &self.value.procedure)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.procedure) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:1994:38 [INFO] [stderr] | [INFO] [stderr] 1994 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1995 | | if Option::is_none(&self.value.procedure) [INFO] [stderr] 1996 | | { [INFO] [stderr] 1997 | | 0 [INFO] [stderr] 1998 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::ErrorDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2031:9 [INFO] [stderr] | [INFO] [stderr] 2031 | pub fn new() -> ErrorDetails { ErrorDetails{message: None,} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 574 | #[derive(Default)] [INFO] [stderr] 575 | pub struct ErrorDetails { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::SubscribeOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2037:9 [INFO] [stderr] | [INFO] [stderr] 2037 | / pub fn new() -> SubscribeOptions { [INFO] [stderr] 2038 | | SubscribeOptions{pattern_match: MatchingPolicy::Strict,} [INFO] [stderr] 2039 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 780 | #[derive(Default)] [INFO] [stderr] 781 | pub struct SubscribeOptions { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::RegisterOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2048:9 [INFO] [stderr] | [INFO] [stderr] 2048 | / pub fn new() -> RegisterOptions { [INFO] [stderr] 2049 | | RegisterOptions{pattern_match: MatchingPolicy::Strict, [INFO] [stderr] 2050 | | invocation_policy: InvocationPolicy::Single,} [INFO] [stderr] 2051 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1192 | #[derive(Default)] [INFO] [stderr] 1193 | pub struct RegisterOptions { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::CallOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2054:9 [INFO] [stderr] | [INFO] [stderr] 2054 | pub fn new() -> CallOptions { CallOptions{} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1464 | #[derive(Default)] [INFO] [stderr] 1465 | pub struct CallOptions; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::YieldOptions` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2057:9 [INFO] [stderr] | [INFO] [stderr] 2057 | pub fn new() -> YieldOptions { YieldOptions{} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1466 | #[derive(Default)] [INFO] [stderr] 1467 | pub struct YieldOptions; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::EventDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2060:9 [INFO] [stderr] | [INFO] [stderr] 2060 | / pub fn new() -> EventDetails { [INFO] [stderr] 2061 | | EventDetails{publisher: None, trustlevel: None, topic: None,} [INFO] [stderr] 2062 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1468 | #[derive(Default)] [INFO] [stderr] 1469 | pub struct EventDetails { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::InvocationDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2070:9 [INFO] [stderr] | [INFO] [stderr] 2070 | / pub fn new() -> InvocationDetails { [INFO] [stderr] 2071 | | InvocationDetails{procedure: None,} [INFO] [stderr] 2072 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1802 | #[derive(Default)] [INFO] [stderr] 1803 | pub struct InvocationDetails { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `messages::types::options::ResultDetails` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2075:9 [INFO] [stderr] | [INFO] [stderr] 2075 | pub fn new() -> ResultDetails { ResultDetails{} } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2011 | #[derive(Default)] [INFO] [stderr] 2012 | pub struct ResultDetails; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2124:21 [INFO] [stderr] | [INFO] [stderr] 2124 | / if let &Value::Integer(value) = value { [INFO] [stderr] 2125 | | Ok(Some(value)) [INFO] [stderr] 2126 | | } else { [INFO] [stderr] 2127 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2132 | | ) ))), None)) [INFO] [stderr] 2133 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2124 | if let Value::Integer(value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2143:21 [INFO] [stderr] | [INFO] [stderr] 2143 | / if let &Value::String(ref value) = value { [INFO] [stderr] 2144 | | Ok(Some(value)) [INFO] [stderr] 2145 | | } else { [INFO] [stderr] 2146 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2151 | | ) ))), None)) [INFO] [stderr] 2152 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2143 | if let Value::String(ref value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2175:21 [INFO] [stderr] | [INFO] [stderr] 2175 | / if let &Value::Integer(value) = value { [INFO] [stderr] 2176 | | Ok(Some(value)) [INFO] [stderr] 2177 | | } else { [INFO] [stderr] 2178 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2183 | | ) ))), None)) [INFO] [stderr] 2184 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2175 | if let Value::Integer(value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2194:21 [INFO] [stderr] | [INFO] [stderr] 2194 | / if let &Value::String(ref value) = value { [INFO] [stderr] 2195 | | Ok(Some(value)) [INFO] [stderr] 2196 | | } else { [INFO] [stderr] 2197 | | Err(CallError::new(Reason::InvalidArgument, [INFO] [stderr] ... | [INFO] [stderr] 2202 | | ) ))), None)) [INFO] [stderr] 2203 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2194 | if let Value::String(ref value) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2211:13 [INFO] [stderr] | [INFO] [stderr] 2211 | / match self { [INFO] [stderr] 2212 | | &Value::Dict(ref d) => { [INFO] [stderr] 2213 | | let mut result = String::new(); [INFO] [stderr] 2214 | | result.push('{'); [INFO] [stderr] ... | [INFO] [stderr] 2237 | | &Value::Boolean(b) => { b.to_string() } [INFO] [stderr] 2238 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2211 | match *self { [INFO] [stderr] 2212 | Value::Dict(ref d) => { [INFO] [stderr] 2213 | let mut result = String::new(); [INFO] [stderr] 2214 | result.push('{'); [INFO] [stderr] 2215 | result.push_str(&d.iter().take(50).map(|(key, value)| [INFO] [stderr] 2216 | format!("{}:{}" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2381:25 [INFO] [stderr] | [INFO] [stderr] 2381 | pub fn to_tuple(self) -> (Reason, Option, Option) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2844:33 [INFO] [stderr] | [INFO] [stderr] 2844 | / loop { [INFO] [stderr] 2845 | | match self.state { [INFO] [stderr] 2846 | | 0usize => { [INFO] [stderr] 2847 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 2863 | | } [INFO] [stderr] 2864 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2848:60 [INFO] [stderr] | [INFO] [stderr] 2848 | return Ok(Some(try!(_serializer.serialize_struct_elt("publisher", &self.value.publisher)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2852:60 [INFO] [stderr] | [INFO] [stderr] 2852 | return Ok(Some(try!(_serializer.serialize_struct_elt("subscriber", &self.value.subscriber)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2856:60 [INFO] [stderr] | [INFO] [stderr] 2856 | return Ok(Some(try!(_serializer.serialize_struct_elt("caller", &self.value.caller)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2860:60 [INFO] [stderr] | [INFO] [stderr] 2860 | return Ok(Some(try!(_serializer.serialize_struct_elt("callee", &self.value.callee)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:2868:38 [INFO] [stderr] | [INFO] [stderr] 2868 | Some(0 + 1 + 1 + 1 + 1) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3095:33 [INFO] [stderr] | [INFO] [stderr] 3095 | / loop { [INFO] [stderr] 3096 | | match self.state { [INFO] [stderr] 3097 | | 0usize => { [INFO] [stderr] 3098 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 3106 | | } [INFO] [stderr] 3107 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3099:60 [INFO] [stderr] | [INFO] [stderr] 3099 | return Ok(Some(try!(_serializer.serialize_struct_elt("dealer", &self.value.dealer)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3103:60 [INFO] [stderr] | [INFO] [stderr] 3103 | return Ok(Some(try!(_serializer.serialize_struct_elt("broker", &self.value.broker)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3110:67 [INFO] [stderr] | [INFO] [stderr] 3110 | fn len(&self) -> Option { Some(0 + 1 + 1) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3314:60 [INFO] [stderr] | [INFO] [stderr] 3314 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3322:38 [INFO] [stderr] | [INFO] [stderr] 3322 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3323 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3324 | | { [INFO] [stderr] 3325 | | 0 [INFO] [stderr] 3326 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3526:60 [INFO] [stderr] | [INFO] [stderr] 3526 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3534:38 [INFO] [stderr] | [INFO] [stderr] 3534 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3535 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3536 | | { [INFO] [stderr] 3537 | | 0 [INFO] [stderr] 3538 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3738:60 [INFO] [stderr] | [INFO] [stderr] 3738 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3746:38 [INFO] [stderr] | [INFO] [stderr] 3746 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3747 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3748 | | { [INFO] [stderr] 3749 | | 0 [INFO] [stderr] 3750 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3948:60 [INFO] [stderr] | [INFO] [stderr] 3948 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:3956:38 [INFO] [stderr] | [INFO] [stderr] 3956 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 3957 | | if Option::is_none(&self.value.features) [INFO] [stderr] 3958 | | { [INFO] [stderr] 3959 | | 0 [INFO] [stderr] 3960 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4154:60 [INFO] [stderr] | [INFO] [stderr] 4154 | return Ok(Some(try!(_serializer.serialize_struct_elt("pattern_based_subscription", [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 4155 | | &self.value.pattern_based_subscription)))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4163:38 [INFO] [stderr] | [INFO] [stderr] 4163 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4164 | | if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] 4165 | | { [INFO] [stderr] 4166 | | 0 [INFO] [stderr] 4167 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4360:60 [INFO] [stderr] | [INFO] [stderr] 4360 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4368:38 [INFO] [stderr] | [INFO] [stderr] 4368 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4369 | | if Option::is_none(&self.value.features) [INFO] [stderr] 4370 | | { [INFO] [stderr] 4371 | | 0 [INFO] [stderr] 4372 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4565:60 [INFO] [stderr] | [INFO] [stderr] 4565 | return Ok(Some(try!(_serializer.serialize_struct_elt("features", &self.value.features)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option::is_none(&self.value.features) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4573:38 [INFO] [stderr] | [INFO] [stderr] 4573 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4574 | | if Option::is_none(&self.value.features) [INFO] [stderr] 4575 | | { [INFO] [stderr] 4576 | | 0 [INFO] [stderr] 4577 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4771:60 [INFO] [stderr] | [INFO] [stderr] 4771 | return Ok(Some(try!(_serializer.serialize_struct_elt("pattern_based_registration", [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 4772 | | &self.value.pattern_based_registration)))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.pattern_based_registration) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4780:38 [INFO] [stderr] | [INFO] [stderr] 4780 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4781 | | if is_not(&self.value.pattern_based_registration) [INFO] [stderr] 4782 | | { [INFO] [stderr] 4783 | | 0 [INFO] [stderr] 4784 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4978:60 [INFO] [stderr] | [INFO] [stderr] 4978 | return Ok(Some(try!(_serializer.serialize_struct_elt("pattern_based_subscription", [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 4979 | | &self.value.pattern_based_subscription)))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] { [INFO] [stderr] 0 [INFO] [stderr] } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:4987:38 [INFO] [stderr] | [INFO] [stderr] 4987 | Some(0 + [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 4988 | | if is_not(&self.value.pattern_based_subscription) [INFO] [stderr] 4989 | | { [INFO] [stderr] 4990 | | 0 [INFO] [stderr] 4991 | | } else { 1 }) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `messages::types::roles::RouterRoles` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5005:9 [INFO] [stderr] | [INFO] [stderr] 5005 | / pub fn new() -> RouterRoles { [INFO] [stderr] 5006 | | RouterRoles{broker: [INFO] [stderr] 5007 | | BrokerRole{features: [INFO] [stderr] 5008 | | Some(BrokerFeatures{pattern_based_subscription: [INFO] [stderr] ... | [INFO] [stderr] 5013 | | true,}),},} [INFO] [stderr] 5014 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5003 | impl Default for messages::types::roles::RouterRoles { [INFO] [stderr] 5004 | fn default() -> Self { [INFO] [stderr] 5005 | Self::new() [INFO] [stderr] 5006 | } [INFO] [stderr] 5007 | } [INFO] [stderr] 5008 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `messages::types::roles::ClientRoles` [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5023:9 [INFO] [stderr] | [INFO] [stderr] 5023 | / pub fn new() -> ClientRoles { [INFO] [stderr] 5024 | | ClientRoles{publisher: [INFO] [stderr] 5025 | | PublisherRole{features: Some(HashMap::new()),}, [INFO] [stderr] 5026 | | subscriber: [INFO] [stderr] ... | [INFO] [stderr] 5031 | | callee: CalleeRole{features: Some(HashMap::new()),},} [INFO] [stderr] 5032 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5021 | impl Default for messages::types::roles::ClientRoles { [INFO] [stderr] 5022 | fn default() -> Self { [INFO] [stderr] 5023 | Self::new() [INFO] [stderr] 5024 | } [INFO] [stderr] 5025 | } [INFO] [stderr] 5026 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5051:14 [INFO] [stderr] | [INFO] [stderr] 5051 | fn is_not(b: &bool) -> bool { !*b } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5073:18 [INFO] [stderr] | [INFO] [stderr] 5073 | fn is_strict(&self) -> bool { self == &MatchingPolicy::Strict } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/wamp-3b72b5a21cd9f8c5/out/messages/types/mod.rs:5077:18 [INFO] [stderr] | [INFO] [stderr] 5077 | fn is_single(&self) -> bool { self == &InvocationPolicy::Single } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 76 | serialize_with_args!(args, kwargs, serializer, 8, ty, id, details, reason) [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 76 | serialize_with_args!(args, kwargs, serializer, 8, ty, id, details, reason) [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 76 | serialize_with_args!(args, kwargs, serializer, 8, ty, id, details, reason) [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 91 | serialize_with_args!(args, kwargs, serializer, 16, id, details, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 91 | serialize_with_args!(args, kwargs, serializer, 16, id, details, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 91 | serialize_with_args!(args, kwargs, serializer, 16, id, details, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 97 | serialize_with_args!(args, kwargs, serializer, 36, subscription_id, publication_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 97 | serialize_with_args!(args, kwargs, serializer, 36, subscription_id, publication_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 97 | serialize_with_args!(args, kwargs, serializer, 36, subscription_id, publication_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 112 | serialize_with_args!(args, kwargs, serializer, 48, id, options, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 112 | serialize_with_args!(args, kwargs, serializer, 48, id, options, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 112 | serialize_with_args!(args, kwargs, serializer, 48, id, options, topic) [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 115 | serialize_with_args!(args, kwargs, serializer, 68, id, registration_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | serialize_with_args!(args, kwargs, serializer, 68, id, registration_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | serialize_with_args!(args, kwargs, serializer, 68, id, registration_id, details) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 118 | serialize_with_args!(args, kwargs, serializer, 70, id, options) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 118 | serialize_with_args!(args, kwargs, serializer, 70, id, options) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 118 | serialize_with_args!(args, kwargs, serializer, 70, id, options) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match $kwargs { [INFO] [stderr] 42 | | &Some(ref kwargs) => { [INFO] [stderr] 43 | | match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 121 | serialize_with_args!(args, kwargs, serializer, 50, id, details) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match $args { [INFO] [stderr] 44 | | &Some(ref args) => ( $($item,)* args, kwargs).serialize($serializer), [INFO] [stderr] 45 | | &None => ( $($item,)* Vec::::new(), kwargs).serialize($serializer), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 121 | serialize_with_args!(args, kwargs, serializer, 50, id, details) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/messages/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match $args { [INFO] [stderr] 49 | | &Some(ref args) => ( $($item,)* args).serialize($serializer), [INFO] [stderr] 50 | | &None => ( $($item,)*).serialize($serializer), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 121 | serialize_with_args!(args, kwargs, serializer, 50, id, details) [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | callback: Box CallResult<(Option, Option)>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/client.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn connect<'a>(&self) -> WampResult { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | / match info.shutdown_complete.take() { [INFO] [stderr] 308 | | Some(promise) => { [INFO] [stderr] 309 | | promise.complete(()); [INFO] [stderr] 310 | | }, [INFO] [stderr] 311 | | None => {} [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | if let Some(promise) = info.shutdown_complete.take() { [INFO] [stderr] 308 | promise.complete(()); [INFO] [stderr] 309 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:392:21 [INFO] [stderr] | [INFO] [stderr] 392 | / match info.shutdown_complete.take() { [INFO] [stderr] 393 | | Some(promise) => promise.complete(()), [INFO] [stderr] 394 | | None => {} [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(promise) = info.shutdown_complete.take() { promise.complete(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:548:20 [INFO] [stderr] | [INFO] [stderr] 548 | let args = args.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:549:22 [INFO] [stderr] | [INFO] [stderr] 549 | let kwargs = kwargs.unwrap_or(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `kwargs.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/client.rs:552:21 [INFO] [stderr] | [INFO] [stderr] 552 | let ref mut callback = subscription.callback; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let callback = &mut subscription.callback;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:562:20 [INFO] [stderr] | [INFO] [stderr] 562 | let args = args.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:563:22 [INFO] [stderr] | [INFO] [stderr] 563 | let kwargs = kwargs.unwrap_or(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `kwargs.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/client.rs:566:21 [INFO] [stderr] | [INFO] [stderr] 566 | let ref mut callback = registration.callback; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let callback = &mut registration.callback;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:585:20 [INFO] [stderr] | [INFO] [stderr] 585 | let args = args.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client.rs:586:22 [INFO] [stderr] | [INFO] [stderr] 586 | let kwargs = kwargs.unwrap_or(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `kwargs.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/client.rs:616:5 [INFO] [stderr] | [INFO] [stderr] 616 | / fn handle_error(&self, info: MutexGuard, e_type: ErrorType, request_id: ID, _details: Dict, reason: Reason, args: Option, kwargs: Option) { [INFO] [stderr] 617 | | match e_type { [INFO] [stderr] 618 | | ErrorType::Subscribe => { [INFO] [stderr] 619 | | self.handle_subscribe_error(info, request_id, reason, args, kwargs) [INFO] [stderr] ... | [INFO] [stderr] 639 | | } [INFO] [stderr] 640 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client.rs:670:79 [INFO] [stderr] | [INFO] [stderr] 670 | pub fn register_with_pattern(&mut self, procedure_pattern: URI, callback: Box CallResult<(Option, Option)> >, policy: MatchingPolicy) -> WampResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client.rs:687:58 [INFO] [stderr] | [INFO] [stderr] 687 | pub fn register(&mut self, procedure: URI, callback: Box CallResult<(Option, Option)> >) -> WampResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/router/pubsub/patterns.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 98 | | &IterState::None => "None", [INFO] [stderr] 99 | | &IterState::Wildcard => "Wildcard", [INFO] [stderr] 100 | | &IterState::Strict => "Strict", [INFO] [stderr] ... | [INFO] [stderr] 104 | | &IterState::AllComplete => "AllComplete" [INFO] [stderr] 105 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | write!(f, "{}", match *self { [INFO] [stderr] 98 | IterState::None => "None", [INFO] [stderr] 99 | IterState::Wildcard => "Wildcard", [INFO] [stderr] 100 | IterState::Strict => "Strict", [INFO] [stderr] 101 | IterState::Prefix(_) => "Prefix", [INFO] [stderr] 102 | IterState::PrefixComplete => "PrefixComplete", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/pubsub/patterns.rs:134:44 [INFO] [stderr] | [INFO] [stderr] 134 | let mut uri_bits = topic.uri.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/pubsub/patterns.rs:139:58 [INFO] [stderr] | [INFO] [stderr] 139 | let edge = self.edges.entry(initial.to_string()).or_insert(SubscriptionPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(SubscriptionPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/pubsub/patterns.rs:145:36 [INFO] [stderr] | [INFO] [stderr] 145 | let uri_bits = topic.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router/pubsub/patterns.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if uri_bit.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `uri_bit.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/pubsub/patterns.rs:169:66 [INFO] [stderr] | [INFO] [stderr] 169 | let edge = self.edges.entry(uri_bit.to_string()).or_insert(SubscriptionPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(SubscriptionPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/router/pubsub/patterns.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | / pub fn filter<'a>(&'a self, topic: URI) -> MatchIterator<'a, P> { [INFO] [stderr] 218 | | MatchIterator { [INFO] [stderr] 219 | | current: Box::new(StackFrame { [INFO] [stderr] 220 | | node: self, [INFO] [stderr] ... | [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/patterns.rs:322:53 [INFO] [stderr] | [INFO] [stderr] 322 | return Some((&next.subscriber, self.current.node.prefix_id.clone(), next.policy)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.current.node.prefix_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/patterns.rs:328:52 [INFO] [stderr] | [INFO] [stderr] 328 | return Some((&next.subscriber, self.current.node.id.clone(), next.policy)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.current.node.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/mod.rs:17:106 [INFO] [stderr] | [INFO] [stderr] 17 | let topic_id = match manager.subscriptions.subscribe_with(&topic, self.info.clone(), options.pattern_match.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.pattern_match` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/mod.rs:39:70 [INFO] [stderr] | [INFO] [stderr] 39 | Some(&(ref uri, ref is_prefix)) => (uri.clone(), is_prefix.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*is_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/pubsub/mod.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | self.info.lock().unwrap().id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.info.lock().unwrap().id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router/rpc/patterns.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if self.procedures.len() == 0 || (invocation_policy == self.invocation_policy && invocation_policy != InvocationPolicy::Single) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.procedures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/rpc/patterns.rs:140:44 [INFO] [stderr] | [INFO] [stderr] 140 | let mut uri_bits = topic.uri.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/rpc/patterns.rs:145:58 [INFO] [stderr] | [INFO] [stderr] 145 | let edge = self.edges.entry(initial.to_string()).or_insert(RegistrationPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(RegistrationPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/rpc/patterns.rs:151:36 [INFO] [stderr] | [INFO] [stderr] 151 | let uri_bits = topic.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router/rpc/patterns.rs:157:65 [INFO] [stderr] | [INFO] [stderr] 157 | let wrapper = self.find_registrant(&procedure.uri.split(".").collect(), 0); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router/rpc/patterns.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | if uri_bit.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `uri_bit.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router/rpc/patterns.rs:196:66 [INFO] [stderr] | [INFO] [stderr] 196 | let edge = self.edges.entry(uri_bit.to_string()).or_insert(RegistrationPatternNode::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(RegistrationPatternNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/router/rpc/patterns.rs:233:41 [INFO] [stderr] | [INFO] [stderr] 233 | fn find_registrant(&self, uri_bits: &Vec<&str>, depth: usize) -> Option<(&DataWrapper

, ID)> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/router/rpc/patterns.rs:253:33 [INFO] [stderr] | [INFO] [stderr] 253 | fn recurse(&self, uri_bits: &Vec<&str>, depth: usize) -> Option<(&DataWrapper

, ID)> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/rpc/mod.rs:18:113 [INFO] [stderr] | [INFO] [stderr] 18 | let procedure_id = match manager.registrations.register_with(&procedure, self.info.clone(), options.pattern_match.clone(), options.invocation_policy.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.pattern_match` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/rpc/mod.rs:18:144 [INFO] [stderr] | [INFO] [stderr] 18 | let procedure_id = match manager.registrations.register_with(&procedure, self.info.clone(), options.pattern_match.clone(), options.invocation_policy.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.invocation_policy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/rpc/mod.rs:40:70 [INFO] [stderr] | [INFO] [stderr] 40 | Some(&(ref uri, ref is_prefix)) => (uri.clone(), is_prefix.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*is_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router/mod.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> Router { [INFO] [stderr] 86 | | Router{ [INFO] [stderr] 87 | | info: Arc::new(RouterInfo { [INFO] [stderr] 88 | | realms: Mutex::new(HashMap::new()), [INFO] [stderr] 89 | | }) [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | impl Default for router::Router { [INFO] [stderr] 84 | fn default() -> Self { [INFO] [stderr] 85 | Self::new() [INFO] [stderr] 86 | } [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self.realm { [INFO] [stderr] 160 | | Some(ref realm) => { [INFO] [stderr] 161 | | [INFO] [stderr] 162 | | let mut realm = realm.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 159 | if let Some(ref realm) = self.realm { [INFO] [stderr] 160 | [INFO] [stderr] 161 | let mut realm = realm.lock().unwrap(); [INFO] [stderr] 162 | { [INFO] [stderr] 163 | trace!("Removing subscriptions for client {}", self.info.lock().unwrap().id); [INFO] [stderr] 164 | let mut manager = &mut realm.subscription_manager; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router/mod.rs:168:25 [INFO] [stderr] | [INFO] [stderr] 168 | / match manager.subscription_ids_to_uris.get(&subscription_id) { [INFO] [stderr] 169 | | Some(&(ref topic_uri, is_prefix)) => { [INFO] [stderr] 170 | | trace!("Removing subscription to {:?}", topic_uri); [INFO] [stderr] 171 | | manager.subscriptions.unsubscribe_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] ... | [INFO] [stderr] 174 | | None => {} [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 168 | if let Some(&(ref topic_uri, is_prefix)) = manager.subscription_ids_to_uris.get(&subscription_id) { [INFO] [stderr] 169 | trace!("Removing subscription to {:?}", topic_uri); [INFO] [stderr] 170 | manager.subscriptions.unsubscribe_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] 171 | trace!("Subscription tree: {:?}", manager.subscriptions); [INFO] [stderr] 172 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/router/mod.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | / match manager.registration_ids_to_uris.get(®istration_id) { [INFO] [stderr] 182 | | Some(&(ref topic_uri, is_prefix)) => { [INFO] [stderr] 183 | | manager.registrations.unregister_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] 184 | | }, [INFO] [stderr] 185 | | None => {} [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let Some(&(ref topic_uri, is_prefix)) = manager.registration_ids_to_uris.get(®istration_id) { [INFO] [stderr] 182 | manager.registrations.unregister_with(topic_uri, &self.info, is_prefix).ok(); [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/router/mod.rs:189:29 [INFO] [stderr] | [INFO] [stderr] 189 | let my_id = self.info.lock().unwrap().id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.info.lock().unwrap().id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | &ErrorKind::WSError(ref e) => e.to_string(), [INFO] [stderr] 86 | | &ErrorKind::UnexpectedMessage(s) => s.to_string(), [INFO] [stderr] 87 | | &ErrorKind::URLError(ref e) => e.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 97 | | &ErrorKind::ErrorReason(_, _, ref s) => s.to_string(), [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *self { [INFO] [stderr] 85 | ErrorKind::WSError(ref e) => e.to_string(), [INFO] [stderr] 86 | ErrorKind::UnexpectedMessage(s) => s.to_string(), [INFO] [stderr] 87 | ErrorKind::URLError(ref e) => e.to_string(), [INFO] [stderr] 88 | ErrorKind::ThreadError(ref e) => e.to_string(), [INFO] [stderr] 89 | ErrorKind::ConnectionLost => "Connection Lost".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wamp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ab9051278c8571a40db9d1913edc0420dda7406fadb1dfe4c60646096b8b7072"` [INFO] running `"docker" "rm" "-f" "ab9051278c8571a40db9d1913edc0420dda7406fadb1dfe4c60646096b8b7072"` [INFO] [stdout] ab9051278c8571a40db9d1913edc0420dda7406fadb1dfe4c60646096b8b7072