[INFO] crate wal-rs 1.0.2 is already in cache [INFO] extracting crate wal-rs 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/wal-rs/1.0.2 [INFO] extracting crate wal-rs 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wal-rs/1.0.2 [INFO] validating manifest of wal-rs-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wal-rs-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wal-rs-1.0.2 [INFO] removed 1 missing examples [INFO] finished frobbing wal-rs-1.0.2 [INFO] frobbed toml for wal-rs-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/wal-rs/1.0.2/Cargo.toml [INFO] started frobbing wal-rs-1.0.2 [INFO] removed 1 missing examples [INFO] finished frobbing wal-rs-1.0.2 [INFO] frobbed toml for wal-rs-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wal-rs/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wal-rs-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/wal-rs/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b9c0015ab92f00620794c526cb8544fb751a63b342adba622f55bc657851f88 [INFO] running `"docker" "start" "-a" "1b9c0015ab92f00620794c526cb8544fb751a63b342adba622f55bc657851f88"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/wal.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking wal-rs v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | sequence: sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | entry_limit: entry_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | entry_number: entry_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | sequence: sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | sequence: sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | entry_limit: entry_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/segment/mod.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | entry_number: entry_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | sequence: sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/cursor.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/segment/overhead.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: item `wal::WAL` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/wal/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / impl WAL { [INFO] [stderr] 26 | | /// Opens a wal with given dir. [INFO] [stderr] 27 | | pub fn open + ?Sized>(dir: &S, cfg: Config) -> Result { [INFO] [stderr] 28 | | let p = Path::new(dir); [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/segment/overhead.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/segment/tests.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | seq.write(&buf[..written + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `..=written` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/segment/tests.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | seq.write(&buf[..written + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `..=written` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/wal/tests.rs:26:50 [INFO] [stderr] | [INFO] [stderr] 26 | let mut wal = WAL::open(&testhome.dir(), cfg.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `cfg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/wal/tests.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | wal.write(&buf[..i + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/wal/tests.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | assert_segment_exists(&dir, &vec![0, 1, 2], title); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/wal/tests.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | let mut wal = WAL::open(&testhome.dir(), cfg.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/wal/tests.rs:48:37 [INFO] [stderr] | [INFO] [stderr] 48 | assert_segment_exists(&dir, &vec![0, 1, 2], title); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/wal/tests.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | let mut wal = WAL::open(&testhome.dir(), cfg.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/wal/tests.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | assert_segment_exists(&dir, &vec![0, 1, 2], title); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/wal/tests.rs:67:50 [INFO] [stderr] | [INFO] [stderr] 67 | let mut wal = WAL::open(&testhome.dir(), cfg.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/wal/tests.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | assert_segment_exists(&dir, &vec![1, 2], title); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/wal/tests.rs:81:50 [INFO] [stderr] | [INFO] [stderr] 81 | let mut wal = WAL::open(&testhome.dir(), cfg.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/wal/tests.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | assert_segment_exists(&dir, &vec![2], title); [INFO] [stderr] | ^^^^^^^^ help: you can use a slice directly: `&[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/wal/tests.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | let mut wal = WAL::open(&dir, cfg.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/wal/tests.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | batch.push(&buf[0..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: item `wal::WAL` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/wal/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / impl WAL { [INFO] [stderr] 26 | | /// Opens a wal with given dir. [INFO] [stderr] 27 | | pub fn open + ?Sized>(dir: &S, cfg: Config) -> Result { [INFO] [stderr] 28 | | let p = Path::new(dir); [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "1b9c0015ab92f00620794c526cb8544fb751a63b342adba622f55bc657851f88"` [INFO] running `"docker" "rm" "-f" "1b9c0015ab92f00620794c526cb8544fb751a63b342adba622f55bc657851f88"` [INFO] [stdout] 1b9c0015ab92f00620794c526cb8544fb751a63b342adba622f55bc657851f88