[INFO] crate vulkano-glyph 0.2.0 is already in cache [INFO] extracting crate vulkano-glyph 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/vulkano-glyph/0.2.0 [INFO] extracting crate vulkano-glyph 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vulkano-glyph/0.2.0 [INFO] validating manifest of vulkano-glyph-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vulkano-glyph-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vulkano-glyph-0.2.0 [INFO] finished frobbing vulkano-glyph-0.2.0 [INFO] frobbed toml for vulkano-glyph-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/vulkano-glyph/0.2.0/Cargo.toml [INFO] started frobbing vulkano-glyph-0.2.0 [INFO] finished frobbing vulkano-glyph-0.2.0 [INFO] frobbed toml for vulkano-glyph-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vulkano-glyph/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vulkano-glyph-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vulkano-glyph/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30642c26bd739753729dbb7f698c3da8076b67bd1ea82fd54aed03d10d5f7ef0 [INFO] running `"docker" "start" "-a" "30642c26bd739753729dbb7f698c3da8076b67bd1ea82fd54aed03d10d5f7ef0"` [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling vulkano-glyph v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking rustc-hash v1.0.1 [INFO] [stderr] Checking stb_truetype v0.2.5 [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Compiling glsl-to-spirv v0.1.7 [INFO] [stderr] Compiling tempfile v3.0.5 [INFO] [stderr] Checking crossbeam-deque v0.5.2 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking vulkano v0.10.0 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking vulkano-win v0.10.0 [INFO] [stderr] Compiling vulkano-shaders v0.10.0 [INFO] [stderr] Compiling vulkano-shader-derive v0.10.0 [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | impl_vertex! { Vertex, tl, br, tex_tl, tex_br, color } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | impl_vertex! { Vertex, tl, br, tex_tl, tex_br, color } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | impl_vertex! { Vertex, tl, br, tex_tl, tex_br, color } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | impl_vertex! { Vertex, tl, br, tex_tl, tex_br, color } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | impl_vertex! { Vertex, tl, br, tex_tl, tex_br, color } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | impl_vertex! { Vertex, tl, br, tex_tl, tex_br, color } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/cache.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new<'a>(device: &Arc) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/cache.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new<'a>(device: &Arc) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/draw.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub(crate) fn draw<'font>( [INFO] [stderr] 111 | | &mut self, [INFO] [stderr] 112 | | cmd: AutoCommandBufferBuilder, [INFO] [stderr] 113 | | glyphs: &[PositionedGlyph<'font>], [INFO] [stderr] ... | [INFO] [stderr] 138 | | Ok(cmd.draw_indirect(Arc::clone(&self.pipe), dynamic_state, vbuf, ibuf, set, ())?) [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | sections.into_iter().flat_map(|section| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `sections` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/draw.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub(crate) fn draw<'font>( [INFO] [stderr] 111 | | &mut self, [INFO] [stderr] 112 | | cmd: AutoCommandBufferBuilder, [INFO] [stderr] 113 | | glyphs: &[PositionedGlyph<'font>], [INFO] [stderr] ... | [INFO] [stderr] 138 | | Ok(cmd.draw_indirect(Arc::clone(&self.pipe), dynamic_state, vbuf, ibuf, set, ())?) [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | sections.into_iter().flat_map(|section| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `sections` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> examples/basic.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | impl_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> examples/basic.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | impl_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/basic.rs:381:38 [INFO] [stderr] | [INFO] [stderr] 381 | events_loop.poll_events(|ev| match ev { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 382 | | winit::Event::WindowEvent { [INFO] [stderr] 383 | | event: winit::WindowEvent::CloseRequested, [INFO] [stderr] 384 | | .. [INFO] [stderr] 385 | | } => done = true, [INFO] [stderr] 386 | | _ => (), [INFO] [stderr] 387 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 381 | events_loop.poll_events(|ev| if let winit::Event::WindowEvent { [INFO] [stderr] 382 | event: winit::WindowEvent::CloseRequested, [INFO] [stderr] 383 | .. [INFO] [stderr] 384 | } = ev { done = true }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 39s [INFO] running `"docker" "inspect" "30642c26bd739753729dbb7f698c3da8076b67bd1ea82fd54aed03d10d5f7ef0"` [INFO] running `"docker" "rm" "-f" "30642c26bd739753729dbb7f698c3da8076b67bd1ea82fd54aed03d10d5f7ef0"` [INFO] [stdout] 30642c26bd739753729dbb7f698c3da8076b67bd1ea82fd54aed03d10d5f7ef0