[INFO] crate vulkano-glfw 0.5.0 is already in cache [INFO] extracting crate vulkano-glfw 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/vulkano-glfw/0.5.0 [INFO] extracting crate vulkano-glfw 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vulkano-glfw/0.5.0 [INFO] validating manifest of vulkano-glfw-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vulkano-glfw-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vulkano-glfw-0.5.0 [INFO] finished frobbing vulkano-glfw-0.5.0 [INFO] frobbed toml for vulkano-glfw-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/vulkano-glfw/0.5.0/Cargo.toml [INFO] started frobbing vulkano-glfw-0.5.0 [INFO] finished frobbing vulkano-glfw-0.5.0 [INFO] frobbed toml for vulkano-glfw-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vulkano-glfw/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vulkano-glfw-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vulkano-glfw/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a7bcb927d26bc874a3f6e7cd0b439c277426c410d04fdedd64f38266a405b49 [INFO] running `"docker" "start" "-a" "4a7bcb927d26bc874a3f6e7cd0b439c277426c410d04fdedd64f38266a405b49"` [INFO] [stderr] Compiling vulkano v0.8.0 [INFO] [stderr] Checking vk-sys v0.2.7 [INFO] [stderr] Checking smallvec v0.5.1 [INFO] [stderr] Compiling cmake v0.1.35 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking glfw v0.21.0 [INFO] [stderr] Checking vulkano-glfw v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn get_required_instance_extensions(glfw: &Glfw) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Glfw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:74:51 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn get_required_raw_instance_extensions(glfw: &Glfw) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Glfw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:89:55 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn get_physical_device_presentation_support(glfw: &Glfw, family: &QueueFamily) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Glfw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn get_required_instance_extensions(glfw: &Glfw) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Glfw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:74:51 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn get_required_raw_instance_extensions(glfw: &Glfw) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Glfw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:89:55 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn get_physical_device_presentation_support(glfw: &Glfw, family: &QueueFamily) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Glfw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.04s [INFO] running `"docker" "inspect" "4a7bcb927d26bc874a3f6e7cd0b439c277426c410d04fdedd64f38266a405b49"` [INFO] running `"docker" "rm" "-f" "4a7bcb927d26bc874a3f6e7cd0b439c277426c410d04fdedd64f38266a405b49"` [INFO] [stdout] 4a7bcb927d26bc874a3f6e7cd0b439c277426c410d04fdedd64f38266a405b49