[INFO] crate vulkano 0.11.1 is already in cache [INFO] extracting crate vulkano 0.11.1 into work/ex/clippy-test-run/sources/stable/reg/vulkano/0.11.1 [INFO] extracting crate vulkano 0.11.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vulkano/0.11.1 [INFO] validating manifest of vulkano-0.11.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vulkano-0.11.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vulkano-0.11.1 [INFO] finished frobbing vulkano-0.11.1 [INFO] frobbed toml for vulkano-0.11.1 written to work/ex/clippy-test-run/sources/stable/reg/vulkano/0.11.1/Cargo.toml [INFO] started frobbing vulkano-0.11.1 [INFO] finished frobbing vulkano-0.11.1 [INFO] frobbed toml for vulkano-0.11.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vulkano/0.11.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vulkano-0.11.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vulkano/0.11.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 403b2525def065a3d55b9862035daef22182a5aec3660b9c6917dcf97c1ec699 [INFO] running `"docker" "start" "-a" "403b2525def065a3d55b9862035daef22182a5aec3660b9c6917dcf97c1ec699"` [INFO] [stderr] Compiling vulkano v0.11.1 (/opt/crater/workdir) [INFO] [stderr] Checking vk-sys v0.4.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking crossbeam v0.5.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_access.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_access.rs:266:16 [INFO] [stderr] | [INFO] [stderr] 266 | lock: lock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_access.rs:299:16 [INFO] [stderr] | [INFO] [stderr] 299 | lock: lock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:386:49 [INFO] [stderr] | [INFO] [stderr] 386 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:534:16 [INFO] [stderr] | [INFO] [stderr] 534 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/device_local.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/immutable.rs:279:38 [INFO] [stderr] | [INFO] [stderr] 279 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/sys.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/sys.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/view.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/slice.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/slice.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/standard.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/standard.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | secondary: secondary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secondary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/standard.rs:157:37 [INFO] [stderr] | [INFO] [stderr] 157 | secondary: secondary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secondary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/sys.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/sys.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/base.rs:671:21 [INFO] [stderr] | [INFO] [stderr] 671 | stages: stages, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/base.rs:672:21 [INFO] [stderr] | [INFO] [stderr] 672 | access: access, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `access` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/commands.rs:860:33 [INFO] [stderr] | [INFO] [stderr] 860 | destination_layout: destination_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/commands.rs:984:33 [INFO] [stderr] | [INFO] [stderr] 984 | source_layout: source_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:350:20 [INFO] [stderr] | [INFO] [stderr] 350 | cmd_raw: cmd_raw, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cmd_raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:416:34 [INFO] [stderr] | [INFO] [stderr] 416 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:417:34 [INFO] [stderr] | [INFO] [stderr] 417 | stencil: stencil, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:1491:13 [INFO] [stderr] | [INFO] [stderr] 1491 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:1529:13 [INFO] [stderr] | [INFO] [stderr] 1529 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/copy_image_buffer.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | required_len: required_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `required_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | set_num: set_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `set_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | binding_num: binding_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binding_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | set_num: set_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `set_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | binding_num: binding_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binding_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/traits.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:319:37 [INFO] [stderr] | [INFO] [stderr] 319 | Ok(FixedSizeDescriptorSet { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | set_id: set_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `set_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:458:36 [INFO] [stderr] | [INFO] [stderr] 458 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:525:36 [INFO] [stderr] | [INFO] [stderr] 525 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:698:65 [INFO] [stderr] | [INFO] [stderr] 698 | PersistentDescriptorSetSampler { sampler: sampler }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:750:65 [INFO] [stderr] | [INFO] [stderr] 750 | PersistentDescriptorSetSampler { sampler: sampler }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/std_pool.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:311:16 [INFO] [stderr] | [INFO] [stderr] 311 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:645:53 [INFO] [stderr] | [INFO] [stderr] 645 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:653:53 [INFO] [stderr] | [INFO] [stderr] 653 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:660:52 [INFO] [stderr] | [INFO] [stderr] 660 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:667:52 [INFO] [stderr] | [INFO] [stderr] 667 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:798:13 [INFO] [stderr] | [INFO] [stderr] 798 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:809:13 [INFO] [stderr] | [INFO] [stderr] 809 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:826:13 [INFO] [stderr] | [INFO] [stderr] 826 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:849:13 [INFO] [stderr] | [INFO] [stderr] 849 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:863:13 [INFO] [stderr] | [INFO] [stderr] 863 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:925:13 [INFO] [stderr] | [INFO] [stderr] 925 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:959:13 [INFO] [stderr] | [INFO] [stderr] 959 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:991:13 [INFO] [stderr] | [INFO] [stderr] 991 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:1004:13 [INFO] [stderr] | [INFO] [stderr] 1004 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/unsafe_layout.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/unsafe_layout.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/unsafe_layout.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | descriptors_count: descriptors_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/sys.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/sys.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | layouts: layouts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `layouts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/sys.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | desc: desc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | PipelineLayoutDescUnion { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | PipelineLayoutDescUnion { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:307:26 [INFO] [stderr] | [INFO] [stderr] 307 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:308:26 [INFO] [stderr] | [INFO] [stderr] 308 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | object: object, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:593:31 [INFO] [stderr] | [INFO] [stderr] 593 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:594:31 [INFO] [stderr] | [INFO] [stderr] 594 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:230:16 [INFO] [stderr] | [INFO] [stderr] 230 | raw_ids: raw_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `raw_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:317:16 [INFO] [stderr] | [INFO] [stderr] 317 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | framebuffer: framebuffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framebuffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:320:16 [INFO] [stderr] | [INFO] [stderr] 320 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/sys.rs:356:16 [INFO] [stderr] | [INFO] [stderr] 356 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/traits.rs:266:22 [INFO] [stderr] | [INFO] [stderr] 266 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/attachment.rs:392:25 [INFO] [stderr] | [INFO] [stderr] 392 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/attachment.rs:393:25 [INFO] [stderr] | [INFO] [stderr] 393 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/attachment.rs:395:25 [INFO] [stderr] | [INFO] [stderr] 395 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:172:34 [INFO] [stderr] | [INFO] [stderr] 172 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:176:34 [INFO] [stderr] | [INFO] [stderr] 176 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/swapchain.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:330:36 [INFO] [stderr] | [INFO] [stderr] 330 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:348:36 [INFO] [stderr] | [INFO] [stderr] 348 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:353:36 [INFO] [stderr] | [INFO] [stderr] 353 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:357:21 [INFO] [stderr] | [INFO] [stderr] 357 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:358:21 [INFO] [stderr] | [INFO] [stderr] 358 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:375:36 [INFO] [stderr] | [INFO] [stderr] 375 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:380:21 [INFO] [stderr] | [INFO] [stderr] 380 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:381:21 [INFO] [stderr] | [INFO] [stderr] 381 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:389:67 [INFO] [stderr] | [INFO] [stderr] 389 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:395:75 [INFO] [stderr] | [INFO] [stderr] 395 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:402:75 [INFO] [stderr] | [INFO] [stderr] 402 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:411:73 [INFO] [stderr] | [INFO] [stderr] 411 | ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:419:75 [INFO] [stderr] | [INFO] [stderr] 419 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | extent: extent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `extent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:481:17 [INFO] [stderr] | [INFO] [stderr] 481 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:504:17 [INFO] [stderr] | [INFO] [stderr] 504 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | mipmaps: mipmaps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | format_features: format_features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `format_features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:578:13 [INFO] [stderr] | [INFO] [stderr] 578 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | samples: samples, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `samples` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | mipmaps: mipmaps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:1007:16 [INFO] [stderr] | [INFO] [stderr] 1007 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/traits.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | preinitialized: preinitialized, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preinitialized` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:282:21 [INFO] [stderr] | [INFO] [stderr] 282 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:491:26 [INFO] [stderr] | [INFO] [stderr] 491 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:507:26 [INFO] [stderr] | [INFO] [stderr] 507 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:508:26 [INFO] [stderr] | [INFO] [stderr] 508 | cubemap_compatible: cubemap_compatible, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cubemap_compatible` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | layer_prefix: layer_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `layer_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | debug_report_callback: debug_report_callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_report_callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | user_callback: user_callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:297:25 [INFO] [stderr] | [INFO] [stderr] 297 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | physical_devices: physical_devices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `physical_devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:300:25 [INFO] [stderr] | [INFO] [stderr] 300 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:301:25 [INFO] [stderr] | [INFO] [stderr] 301 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:303:25 [INFO] [stderr] | [INFO] [stderr] 303 | function_pointers: function_pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `function_pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:342:29 [INFO] [stderr] | [INFO] [stderr] 342 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:343:29 [INFO] [stderr] | [INFO] [stderr] 343 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:344:29 [INFO] [stderr] | [INFO] [stderr] 344 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:345:29 [INFO] [stderr] | [INFO] [stderr] 345 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:416:29 [INFO] [stderr] | [INFO] [stderr] 416 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:417:29 [INFO] [stderr] | [INFO] [stderr] 417 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:418:29 [INFO] [stderr] | [INFO] [stderr] 418 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:419:29 [INFO] [stderr] | [INFO] [stderr] 419 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:720:13 [INFO] [stderr] | [INFO] [stderr] 720 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:743:22 [INFO] [stderr] | [INFO] [stderr] 743 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:847:22 [INFO] [stderr] | [INFO] [stderr] 847 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:870:22 [INFO] [stderr] | [INFO] [stderr] 870 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:893:22 [INFO] [stderr] | [INFO] [stderr] 893 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:149:16 [INFO] [stderr] | [INFO] [stderr] 149 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | coherent: coherent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `coherent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/host_visible.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/host_visible.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/host_visible.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | stage: stage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | pipeline_layout: pipeline_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1096:16 [INFO] [stderr] | [INFO] [stderr] 1096 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1097:16 [INFO] [stderr] | [INFO] [stderr] 1097 | render_pass_subpass: render_pass_subpass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass_subpass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1090:20 [INFO] [stderr] | [INFO] [stderr] 1090 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1126:13 [INFO] [stderr] | [INFO] [stderr] 1126 | vertex_input: vertex_input, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1440:56 [INFO] [stderr] | [INFO] [stderr] 1440 | self.viewport = Some(ViewportsState::Dynamic { num: num }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/cache.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/instance_buffer.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/one_one.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/single.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/two.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | num_slots: num_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:415:25 [INFO] [stderr] | [INFO] [stderr] 415 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/display.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | supported_displays: supported_displays, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `supported_displays` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:289:25 [INFO] [stderr] | [INFO] [stderr] 289 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:408:25 [INFO] [stderr] | [INFO] [stderr] 408 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:447:25 [INFO] [stderr] | [INFO] [stderr] 447 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:454:38 [INFO] [stderr] | [INFO] [stderr] 454 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:455:38 [INFO] [stderr] | [INFO] [stderr] 455 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:457:38 [INFO] [stderr] | [INFO] [stderr] 457 | num_images: num_images, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:458:38 [INFO] [stderr] | [INFO] [stderr] 458 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:459:38 [INFO] [stderr] | [INFO] [stderr] 459 | color_space: color_space, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:460:38 [INFO] [stderr] | [INFO] [stderr] 460 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:461:38 [INFO] [stderr] | [INFO] [stderr] 461 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:463:38 [INFO] [stderr] | [INFO] [stderr] 463 | sharing: sharing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sharing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:464:38 [INFO] [stderr] | [INFO] [stderr] 464 | transform: transform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:465:38 [INFO] [stderr] | [INFO] [stderr] 465 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:466:38 [INFO] [stderr] | [INFO] [stderr] 466 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:467:38 [INFO] [stderr] | [INFO] [stderr] 467 | clipped: clipped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clipped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | must_put_in_pool: must_put_in_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `must_put_in_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | fence: fence, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:122:16 [INFO] [stderr] | [INFO] [stderr] 122 | must_put_in_pool: must_put_in_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `must_put_in_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/now.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | NowFuture { device: device } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/fence_signal.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/fence_signal.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | behavior: behavior, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `behavior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/join.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/join.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | second: second, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | semaphore: semaphore, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `semaphore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | must_put_in_pool: must_put_in_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `must_put_in_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_access.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_access.rs:266:16 [INFO] [stderr] | [INFO] [stderr] 266 | lock: lock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_access.rs:299:16 [INFO] [stderr] | [INFO] [stderr] 299 | lock: lock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:386:49 [INFO] [stderr] | [INFO] [stderr] 386 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/cpu_pool.rs:534:16 [INFO] [stderr] | [INFO] [stderr] 534 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/device_local.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/immutable.rs:279:38 [INFO] [stderr] | [INFO] [stderr] 279 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/sys.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/sys.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/view.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/slice.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/slice.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/standard.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/standard.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | secondary: secondary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secondary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/standard.rs:157:37 [INFO] [stderr] | [INFO] [stderr] 157 | secondary: secondary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secondary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/sys.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/pool/sys.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/base.rs:671:21 [INFO] [stderr] | [INFO] [stderr] 671 | stages: stages, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/base.rs:672:21 [INFO] [stderr] | [INFO] [stderr] 672 | access: access, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `access` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/commands.rs:860:33 [INFO] [stderr] | [INFO] [stderr] 860 | destination_layout: destination_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/synced/commands.rs:984:33 [INFO] [stderr] | [INFO] [stderr] 984 | source_layout: source_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:350:20 [INFO] [stderr] | [INFO] [stderr] 350 | cmd_raw: cmd_raw, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cmd_raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:416:34 [INFO] [stderr] | [INFO] [stderr] 416 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:417:34 [INFO] [stderr] | [INFO] [stderr] 417 | stencil: stencil, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:1491:13 [INFO] [stderr] | [INFO] [stderr] 1491 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/sys.rs:1529:13 [INFO] [stderr] | [INFO] [stderr] 1529 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/copy_image_buffer.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | required_len: required_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `required_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | set_num: set_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `set_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | binding_num: binding_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binding_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | set_num: set_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `set_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/validity/descriptor_sets.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | binding_num: binding_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binding_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command_buffer/traits.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:319:37 [INFO] [stderr] | [INFO] [stderr] 319 | Ok(FixedSizeDescriptorSet { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | set_id: set_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `set_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:458:36 [INFO] [stderr] | [INFO] [stderr] 458 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:525:36 [INFO] [stderr] | [INFO] [stderr] 525 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:698:65 [INFO] [stderr] | [INFO] [stderr] 698 | PersistentDescriptorSetSampler { sampler: sampler }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:750:65 [INFO] [stderr] | [INFO] [stderr] 750 | PersistentDescriptorSetSampler { sampler: sampler }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/std_pool.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:311:16 [INFO] [stderr] | [INFO] [stderr] 311 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:645:53 [INFO] [stderr] | [INFO] [stderr] 645 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:653:53 [INFO] [stderr] | [INFO] [stderr] 653 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:660:52 [INFO] [stderr] | [INFO] [stderr] 660 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:667:52 [INFO] [stderr] | [INFO] [stderr] 667 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:798:13 [INFO] [stderr] | [INFO] [stderr] 798 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:809:13 [INFO] [stderr] | [INFO] [stderr] 809 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:826:13 [INFO] [stderr] | [INFO] [stderr] 826 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:849:13 [INFO] [stderr] | [INFO] [stderr] 849 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:863:13 [INFO] [stderr] | [INFO] [stderr] 863 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:925:13 [INFO] [stderr] | [INFO] [stderr] 925 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:959:13 [INFO] [stderr] | [INFO] [stderr] 959 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:991:13 [INFO] [stderr] | [INFO] [stderr] 991 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:1004:13 [INFO] [stderr] | [INFO] [stderr] 1004 | binding: binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/unsafe_layout.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/unsafe_layout.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/descriptor_set/unsafe_layout.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | descriptors_count: descriptors_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/sys.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/sys.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | layouts: layouts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `layouts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/sys.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | desc: desc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | PipelineLayoutDescUnion { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | PipelineLayoutDescUnion { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:307:26 [INFO] [stderr] | [INFO] [stderr] 307 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:308:26 [INFO] [stderr] | [INFO] [stderr] 308 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | object: object, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:593:31 [INFO] [stderr] | [INFO] [stderr] 593 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device/mod.rs:594:31 [INFO] [stderr] | [INFO] [stderr] 594 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:230:16 [INFO] [stderr] | [INFO] [stderr] 230 | raw_ids: raw_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `raw_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:317:16 [INFO] [stderr] | [INFO] [stderr] 317 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | framebuffer: framebuffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framebuffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/framebuffer.rs:320:16 [INFO] [stderr] | [INFO] [stderr] 320 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/sys.rs:356:16 [INFO] [stderr] | [INFO] [stderr] 356 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer/traits.rs:266:22 [INFO] [stderr] | [INFO] [stderr] 266 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/attachment.rs:392:25 [INFO] [stderr] | [INFO] [stderr] 392 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/attachment.rs:393:25 [INFO] [stderr] | [INFO] [stderr] 393 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/attachment.rs:395:25 [INFO] [stderr] | [INFO] [stderr] 395 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:172:34 [INFO] [stderr] | [INFO] [stderr] 172 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:176:34 [INFO] [stderr] | [INFO] [stderr] 176 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/immutable.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/storage.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/swapchain.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:330:36 [INFO] [stderr] | [INFO] [stderr] 330 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:348:36 [INFO] [stderr] | [INFO] [stderr] 348 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:353:36 [INFO] [stderr] | [INFO] [stderr] 353 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:357:21 [INFO] [stderr] | [INFO] [stderr] 357 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:358:21 [INFO] [stderr] | [INFO] [stderr] 358 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:375:36 [INFO] [stderr] | [INFO] [stderr] 375 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:380:21 [INFO] [stderr] | [INFO] [stderr] 380 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:381:21 [INFO] [stderr] | [INFO] [stderr] 381 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:389:67 [INFO] [stderr] | [INFO] [stderr] 389 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:395:75 [INFO] [stderr] | [INFO] [stderr] 395 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:402:75 [INFO] [stderr] | [INFO] [stderr] 402 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:411:73 [INFO] [stderr] | [INFO] [stderr] 411 | ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:419:75 [INFO] [stderr] | [INFO] [stderr] 419 | let err = ImageCreationError::UnsupportedDimensions { dimensions: dimensions }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | extent: extent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `extent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:481:17 [INFO] [stderr] | [INFO] [stderr] 481 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:504:17 [INFO] [stderr] | [INFO] [stderr] 504 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | mipmaps: mipmaps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | format_features: format_features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `format_features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:578:13 [INFO] [stderr] | [INFO] [stderr] 578 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | samples: samples, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `samples` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | mipmaps: mipmaps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/sys.rs:1007:16 [INFO] [stderr] | [INFO] [stderr] 1007 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/traits.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | preinitialized: preinitialized, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preinitialized` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:282:21 [INFO] [stderr] | [INFO] [stderr] 282 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:491:26 [INFO] [stderr] | [INFO] [stderr] 491 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:507:26 [INFO] [stderr] | [INFO] [stderr] 507 | array_layers: array_layers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image/mod.rs:508:26 [INFO] [stderr] | [INFO] [stderr] 508 | cubemap_compatible: cubemap_compatible, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cubemap_compatible` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | layer_prefix: layer_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `layer_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | debug_report_callback: debug_report_callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_report_callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/debug.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | user_callback: user_callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:297:25 [INFO] [stderr] | [INFO] [stderr] 297 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | physical_devices: physical_devices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `physical_devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:300:25 [INFO] [stderr] | [INFO] [stderr] 300 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:301:25 [INFO] [stderr] | [INFO] [stderr] 301 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:302:25 [INFO] [stderr] | [INFO] [stderr] 302 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:303:25 [INFO] [stderr] | [INFO] [stderr] 303 | function_pointers: function_pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `function_pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:342:29 [INFO] [stderr] | [INFO] [stderr] 342 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:343:29 [INFO] [stderr] | [INFO] [stderr] 343 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:344:29 [INFO] [stderr] | [INFO] [stderr] 344 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:345:29 [INFO] [stderr] | [INFO] [stderr] 345 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:416:29 [INFO] [stderr] | [INFO] [stderr] 416 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:417:29 [INFO] [stderr] | [INFO] [stderr] 417 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:418:29 [INFO] [stderr] | [INFO] [stderr] 418 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:419:29 [INFO] [stderr] | [INFO] [stderr] 419 | queue_families: queue_families, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_families` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:720:13 [INFO] [stderr] | [INFO] [stderr] 720 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:743:22 [INFO] [stderr] | [INFO] [stderr] 743 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:847:22 [INFO] [stderr] | [INFO] [stderr] 847 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:870:22 [INFO] [stderr] | [INFO] [stderr] 870 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance/instance.rs:893:22 [INFO] [stderr] | [INFO] [stderr] 893 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:149:16 [INFO] [stderr] | [INFO] [stderr] 149 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | coherent: coherent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `coherent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | pointer: pointer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/device_memory.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/host_visible.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/host_visible.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/host_visible.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/pool/pool.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | stage: stage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | pipeline_layout: pipeline_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1096:16 [INFO] [stderr] | [INFO] [stderr] 1096 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1097:16 [INFO] [stderr] | [INFO] [stderr] 1097 | render_pass_subpass: render_pass_subpass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass_subpass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1090:20 [INFO] [stderr] | [INFO] [stderr] 1090 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1126:13 [INFO] [stderr] | [INFO] [stderr] 1126 | vertex_input: vertex_input, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1440:56 [INFO] [stderr] | [INFO] [stderr] 1440 | self.viewport = Some(ViewportsState::Dynamic { num: num }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/cache.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/shader.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/instance_buffer.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/one_one.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/single.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline/vertex/two.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/mod.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | num_slots: num_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sampler.rs:415:25 [INFO] [stderr] | [INFO] [stderr] 415 | sampler: sampler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/display.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | supported_displays: supported_displays, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `supported_displays` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:289:25 [INFO] [stderr] | [INFO] [stderr] 289 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:408:25 [INFO] [stderr] | [INFO] [stderr] 408 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/surface.rs:447:25 [INFO] [stderr] | [INFO] [stderr] 447 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:454:38 [INFO] [stderr] | [INFO] [stderr] 454 | swapchain: swapchain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `swapchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:455:38 [INFO] [stderr] | [INFO] [stderr] 455 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:457:38 [INFO] [stderr] | [INFO] [stderr] 457 | num_images: num_images, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:458:38 [INFO] [stderr] | [INFO] [stderr] 458 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:459:38 [INFO] [stderr] | [INFO] [stderr] 459 | color_space: color_space, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:460:38 [INFO] [stderr] | [INFO] [stderr] 460 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:461:38 [INFO] [stderr] | [INFO] [stderr] 461 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:463:38 [INFO] [stderr] | [INFO] [stderr] 463 | sharing: sharing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sharing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:464:38 [INFO] [stderr] | [INFO] [stderr] 464 | transform: transform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:465:38 [INFO] [stderr] | [INFO] [stderr] 465 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:466:38 [INFO] [stderr] | [INFO] [stderr] 466 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/swapchain/swapchain.rs:467:38 [INFO] [stderr] | [INFO] [stderr] 467 | clipped: clipped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clipped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/event.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | must_put_in_pool: must_put_in_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `must_put_in_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | fence: fence, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/fence.rs:122:16 [INFO] [stderr] | [INFO] [stderr] 122 | must_put_in_pool: must_put_in_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `must_put_in_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/now.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | NowFuture { device: device } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/fence_signal.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/fence_signal.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | behavior: behavior, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `behavior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/join.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/future/join.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | second: second, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | semaphore: semaphore, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `semaphore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync/semaphore.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | must_put_in_pool: must_put_in_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `must_put_in_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | major: ((value & 0xffc00000) >> 22) as u16, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffc0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | minor: ((value & 0x003ff000) >> 12) as u16, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003f_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | patch: (value & 0x00000fff) as u16, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/buffer/view.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / if buffer.usage_uniform_texel_buffer() { [INFO] [stderr] 134 | | if (format_props & vk::FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 135 | | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | if buffer.usage_uniform_texel_buffer() && (format_props & vk::FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 134 | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/buffer/view.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | / if buffer.usage_storage_texel_buffer() { [INFO] [stderr] 140 | | if (format_props & vk::FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 141 | | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | if buffer.usage_storage_texel_buffer() && (format_props & vk::FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 140 | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/command_buffer/validity/copy_image.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / if source_format_ty.is_depth_and_or_stencil() { [INFO] [stderr] 61 | | if source.format() != destination.format() { [INFO] [stderr] 62 | | return Err(CheckCopyImageError::DepthStencilFormatMismatch); [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if source_format_ty.is_depth_and_or_stencil() && source.format() != destination.format() { [INFO] [stderr] 61 | return Err(CheckCopyImageError::DepthStencilFormatMismatch); [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 33 | | if state.line_width.is_some() { [INFO] [stderr] 34 | | return Err(CheckDynamicStateValidityError::LineWidthNotDynamic); [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | } else if state.line_width.is_some() { [INFO] [stderr] 33 | return Err(CheckDynamicStateValidityError::LineWidthNotDynamic); [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 51 | | if state.viewports.is_some() { [INFO] [stderr] 52 | | return Err(CheckDynamicStateValidityError::ViewportsNotDynamic); [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | } else if state.viewports.is_some() { [INFO] [stderr] 51 | return Err(CheckDynamicStateValidityError::ViewportsNotDynamic); [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 69 | | if state.scissors.is_some() { [INFO] [stderr] 70 | | return Err(CheckDynamicStateValidityError::ScissorsNotDynamic); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | } else if state.scissors.is_some() { [INFO] [stderr] 69 | return Err(CheckDynamicStateValidityError::ScissorsNotDynamic); [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/auto.rs:540:30 [INFO] [stderr] | [INFO] [stderr] 540 | else { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 541 | | if clear_value != ClearValue::None { [INFO] [stderr] 542 | | panic!("Bad ClearValue! index: {}, attachment index: {}, expected: None, got: {:?}", [INFO] [stderr] 543 | | clear_i, atch_i, clear_value); [INFO] [stderr] 544 | | } [INFO] [stderr] 545 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 540 | else if clear_value != ClearValue::None { [INFO] [stderr] 541 | panic!("Bad ClearValue! index: {}, attachment index: {}, expected: None, got: {:?}", [INFO] [stderr] 542 | clear_i, atch_i, clear_value); [INFO] [stderr] 543 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/descriptor/mod.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | pub mod descriptor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/descriptor/descriptor_set/collection.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/framebuffer/compat_atch.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / if subpass [INFO] [stderr] 86 | | .input_attachments [INFO] [stderr] 87 | | .iter() [INFO] [stderr] 88 | | .any(|&(n, _)| n == attachment_num) [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | if subpass [INFO] [stderr] 86 | .input_attachments [INFO] [stderr] 87 | .iter() [INFO] [stderr] 88 | .any(|&(n, _)| n == attachment_num) && !image.parent().inner().image.usage_input_attachment() { [INFO] [stderr] 89 | return Err(IncompatibleRenderPassAttachmentError::MissingInputAttachmentUsage); [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/framebuffer/mod.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | mod framebuffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/framebuffer/traits.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/image/attachment.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / if expected_layout != ImageLayout::Undefined { [INFO] [stderr] 472 | | if !self.initialized.load(Ordering::SeqCst) { [INFO] [stderr] 473 | | return Err(AccessError::ImageNotInitialized { requested: expected_layout }); [INFO] [stderr] 474 | | } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 471 | if expected_layout != ImageLayout::Undefined && !self.initialized.load(Ordering::SeqCst) { [INFO] [stderr] 472 | return Err(AccessError::ImageNotInitialized { requested: expected_layout }); [INFO] [stderr] 473 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/image/sys.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | / if usage.storage && num_samples > 1 { [INFO] [stderr] 317 | | if !device.enabled_features().shader_storage_image_multisample { [INFO] [stderr] 318 | | return Err(ImageCreationError::ShaderStorageImageMultisampleFeatureNotEnabled); [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | if usage.storage && num_samples > 1 && !device.enabled_features().shader_storage_image_multisample { [INFO] [stderr] 317 | return Err(ImageCreationError::ShaderStorageImageMultisampleFeatureNotEnabled); [INFO] [stderr] 318 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/instance/mod.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | mod instance; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/memory/pool/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | mod pool; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:249:16 [INFO] [stderr] | [INFO] [stderr] 249 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 250 | | if let Some(ref geometry_shader) = self.geometry_shader { [INFO] [stderr] 251 | | if let Err(err) = geometry_shader [INFO] [stderr] 252 | | .0 [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 249 | } else if let Some(ref geometry_shader) = self.geometry_shader { [INFO] [stderr] 250 | if let Err(err) = geometry_shader [INFO] [stderr] 251 | .0 [INFO] [stderr] 252 | .input() [INFO] [stderr] 253 | .matches(self.vertex_shader.as_ref().unwrap().0.output()) [INFO] [stderr] 254 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:845:9 [INFO] [stderr] | [INFO] [stderr] 845 | / if self.multisample.alphaToOneEnable != vk::FALSE { [INFO] [stderr] 846 | | if !device.enabled_features().alpha_to_one { [INFO] [stderr] 847 | | return Err(GraphicsPipelineCreationError::AlphaToOneFeatureNotEnabled); [INFO] [stderr] 848 | | } [INFO] [stderr] 849 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 845 | if self.multisample.alphaToOneEnable != vk::FALSE && !device.enabled_features().alpha_to_one { [INFO] [stderr] 846 | return Err(GraphicsPipelineCreationError::AlphaToOneFeatureNotEnabled); [INFO] [stderr] 847 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/multisample.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | sample_mask: [0xffffffff; 4], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/pipeline/vertex/mod.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | mod vertex; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/viewport.rs:177:26 [INFO] [stderr] | [INFO] [stderr] 177 | dimensions: [0x7fffffff, 0x7fffffff], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/viewport.rs:177:38 [INFO] [stderr] | [INFO] [stderr] 177 | dimensions: [0x7fffffff, 0x7fffffff], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sampler.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / if [address_u, address_v, address_w] [INFO] [stderr] 261 | | .iter() [INFO] [stderr] 262 | | .any(|&mode| mode == SamplerAddressMode::MirrorClampToEdge) [INFO] [stderr] 263 | | { [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 260 | if [address_u, address_v, address_w] [INFO] [stderr] 261 | .iter() [INFO] [stderr] 262 | .any(|&mode| mode == SamplerAddressMode::MirrorClampToEdge) && !device.loaded_extensions().khr_sampler_mirror_clamp_to_edge { [INFO] [stderr] 263 | return Err(SamplerCreationError::SamplerMirrorClampToEdgeExtensionNotEnabled); [INFO] [stderr] 264 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/swapchain/surface.rs:532:64 [INFO] [stderr] | [INFO] [stderr] 532 | current_extent: if caps.currentExtent.width == 0xffffffff && [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/swapchain/surface.rs:533:65 [INFO] [stderr] | [INFO] [stderr] 533 | caps.currentExtent.height == 0xffffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/swapchain/mod.rs:334:1 [INFO] [stderr] | [INFO] [stderr] 334 | mod swapchain; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | major: ((value & 0xffc00000) >> 22) as u16, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffc0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | minor: ((value & 0x003ff000) >> 12) as u16, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003f_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | patch: (value & 0x00000fff) as u16, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(version.into_vulkan_version(), 0x400000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/buffer/view.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / if buffer.usage_uniform_texel_buffer() { [INFO] [stderr] 134 | | if (format_props & vk::FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 135 | | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | if buffer.usage_uniform_texel_buffer() && (format_props & vk::FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 134 | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/buffer/view.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | / if buffer.usage_storage_texel_buffer() { [INFO] [stderr] 140 | | if (format_props & vk::FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 141 | | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | if buffer.usage_storage_texel_buffer() && (format_props & vk::FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT) == 0 { [INFO] [stderr] 140 | return Err(BufferViewCreationError::UnsupportedFormat); [INFO] [stderr] 141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/command_buffer/validity/copy_image.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / if source_format_ty.is_depth_and_or_stencil() { [INFO] [stderr] 61 | | if source.format() != destination.format() { [INFO] [stderr] 62 | | return Err(CheckCopyImageError::DepthStencilFormatMismatch); [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if source_format_ty.is_depth_and_or_stencil() && source.format() != destination.format() { [INFO] [stderr] 61 | return Err(CheckCopyImageError::DepthStencilFormatMismatch); [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 33 | | if state.line_width.is_some() { [INFO] [stderr] 34 | | return Err(CheckDynamicStateValidityError::LineWidthNotDynamic); [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | } else if state.line_width.is_some() { [INFO] [stderr] 33 | return Err(CheckDynamicStateValidityError::LineWidthNotDynamic); [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 51 | | if state.viewports.is_some() { [INFO] [stderr] 52 | | return Err(CheckDynamicStateValidityError::ViewportsNotDynamic); [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | } else if state.viewports.is_some() { [INFO] [stderr] 51 | return Err(CheckDynamicStateValidityError::ViewportsNotDynamic); [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 69 | | if state.scissors.is_some() { [INFO] [stderr] 70 | | return Err(CheckDynamicStateValidityError::ScissorsNotDynamic); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | } else if state.scissors.is_some() { [INFO] [stderr] 69 | return Err(CheckDynamicStateValidityError::ScissorsNotDynamic); [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/command_buffer/validity/update_buffer.rs:128:59 [INFO] [stderr] | [INFO] [stderr] 128 | (0 .. 100000).map(|_| 0)) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/command_buffer/auto.rs:540:30 [INFO] [stderr] | [INFO] [stderr] 540 | else { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 541 | | if clear_value != ClearValue::None { [INFO] [stderr] 542 | | panic!("Bad ClearValue! index: {}, attachment index: {}, expected: None, got: {:?}", [INFO] [stderr] 543 | | clear_i, atch_i, clear_value); [INFO] [stderr] 544 | | } [INFO] [stderr] 545 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 540 | else if clear_value != ClearValue::None { [INFO] [stderr] 541 | panic!("Bad ClearValue! index: {}, attachment index: {}, expected: None, got: {:?}", [INFO] [stderr] 542 | clear_i, atch_i, clear_value); [INFO] [stderr] 543 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/descriptor/mod.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | pub mod descriptor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/descriptor/descriptor_set/collection.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/framebuffer/compat_atch.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / if subpass [INFO] [stderr] 86 | | .input_attachments [INFO] [stderr] 87 | | .iter() [INFO] [stderr] 88 | | .any(|&(n, _)| n == attachment_num) [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | if subpass [INFO] [stderr] 86 | .input_attachments [INFO] [stderr] 87 | .iter() [INFO] [stderr] 88 | .any(|&(n, _)| n == attachment_num) && !image.parent().inner().image.usage_input_attachment() { [INFO] [stderr] 89 | return Err(IncompatibleRenderPassAttachmentError::MissingInputAttachmentUsage); [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/framebuffer/mod.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | mod framebuffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer/framebuffer.rs:595:53 [INFO] [stderr] | [INFO] [stderr] 595 | let res = Framebuffer::with_dimensions(rp, [0xffffffff, 0xffffffff, 0xffffffff]).build(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer/framebuffer.rs:595:65 [INFO] [stderr] | [INFO] [stderr] 595 | let res = Framebuffer::with_dimensions(rp, [0xffffffff, 0xffffffff, 0xffffffff]).build(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer/framebuffer.rs:595:77 [INFO] [stderr] | [INFO] [stderr] 595 | let res = Framebuffer::with_dimensions(rp, [0xffffffff, 0xffffffff, 0xffffffff]).build(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/framebuffer/traits.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/image/attachment.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / if expected_layout != ImageLayout::Undefined { [INFO] [stderr] 472 | | if !self.initialized.load(Ordering::SeqCst) { [INFO] [stderr] 473 | | return Err(AccessError::ImageNotInitialized { requested: expected_layout }); [INFO] [stderr] 474 | | } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 471 | if expected_layout != ImageLayout::Undefined && !self.initialized.load(Ordering::SeqCst) { [INFO] [stderr] 472 | return Err(AccessError::ImageNotInitialized { requested: expected_layout }); [INFO] [stderr] 473 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/image/sys.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | / if usage.storage && num_samples > 1 { [INFO] [stderr] 317 | | if !device.enabled_features().shader_storage_image_multisample { [INFO] [stderr] 318 | | return Err(ImageCreationError::ShaderStorageImageMultisampleFeatureNotEnabled); [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | if usage.storage && num_samples > 1 && !device.enabled_features().shader_storage_image_multisample { [INFO] [stderr] 317 | return Err(ImageCreationError::ShaderStorageImageMultisampleFeatureNotEnabled); [INFO] [stderr] 318 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/instance/mod.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | mod instance; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory/device_memory.rs:553:59 [INFO] [stderr] | [INFO] [stderr] 553 | match DeviceMemory::alloc(device.clone(), mem_ty, 0xffffffffffffffff) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/memory/pool/mod.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | mod pool; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:967:75 [INFO] [stderr] | [INFO] [stderr] 967 | &SpecConsts { VALUE: 0x12345678 }) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:994:42 [INFO] [stderr] | [INFO] [stderr] 994 | assert_eq!(*data_buffer_content, 0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:249:16 [INFO] [stderr] | [INFO] [stderr] 249 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 250 | | if let Some(ref geometry_shader) = self.geometry_shader { [INFO] [stderr] 251 | | if let Err(err) = geometry_shader [INFO] [stderr] 252 | | .0 [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 249 | } else if let Some(ref geometry_shader) = self.geometry_shader { [INFO] [stderr] 250 | if let Err(err) = geometry_shader [INFO] [stderr] 251 | .0 [INFO] [stderr] 252 | .input() [INFO] [stderr] 253 | .matches(self.vertex_shader.as_ref().unwrap().0.output()) [INFO] [stderr] 254 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:845:9 [INFO] [stderr] | [INFO] [stderr] 845 | / if self.multisample.alphaToOneEnable != vk::FALSE { [INFO] [stderr] 846 | | if !device.enabled_features().alpha_to_one { [INFO] [stderr] 847 | | return Err(GraphicsPipelineCreationError::AlphaToOneFeatureNotEnabled); [INFO] [stderr] 848 | | } [INFO] [stderr] 849 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 845 | if self.multisample.alphaToOneEnable != vk::FALSE && !device.enabled_features().alpha_to_one { [INFO] [stderr] 846 | return Err(GraphicsPipelineCreationError::AlphaToOneFeatureNotEnabled); [INFO] [stderr] 847 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/multisample.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | sample_mask: [0xffffffff; 4], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/pipeline/vertex/mod.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | mod vertex; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/viewport.rs:177:26 [INFO] [stderr] | [INFO] [stderr] 177 | dimensions: [0x7fffffff, 0x7fffffff], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pipeline/viewport.rs:177:38 [INFO] [stderr] | [INFO] [stderr] 177 | dimensions: [0x7fffffff, 0x7fffffff], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sampler.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / if [address_u, address_v, address_w] [INFO] [stderr] 261 | | .iter() [INFO] [stderr] 262 | | .any(|&mode| mode == SamplerAddressMode::MirrorClampToEdge) [INFO] [stderr] 263 | | { [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 260 | if [address_u, address_v, address_w] [INFO] [stderr] 261 | .iter() [INFO] [stderr] 262 | .any(|&mode| mode == SamplerAddressMode::MirrorClampToEdge) && !device.loaded_extensions().khr_sampler_mirror_clamp_to_edge { [INFO] [stderr] 263 | return Err(SamplerCreationError::SamplerMirrorClampToEdgeExtensionNotEnabled); [INFO] [stderr] 264 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sampler.rs:903:39 [INFO] [stderr] | [INFO] [stderr] 903 | 100000000.0, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `100_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sampler.rs:924:39 [INFO] [stderr] | [INFO] [stderr] 924 | 100000000.0, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `100_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/swapchain/surface.rs:532:64 [INFO] [stderr] | [INFO] [stderr] 532 | current_extent: if caps.currentExtent.width == 0xffffffff && [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/swapchain/surface.rs:533:65 [INFO] [stderr] | [INFO] [stderr] 533 | caps.currentExtent.height == 0xffffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/swapchain/mod.rs:334:1 [INFO] [stderr] | [INFO] [stderr] 334 | mod swapchain; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn into_vulkan_version(&self) -> u32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/version.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn into_vulkan_version(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | (self.major as u32) << 22 | (self.minor as u32) << 12 | (self.patch as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.major)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:83:37 [INFO] [stderr] | [INFO] [stderr] 83 | (self.major as u32) << 22 | (self.minor as u32) << 12 | (self.patch as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:83:65 [INFO] [stderr] | [INFO] [stderr] 83 | (self.major as u32) << 22 | (self.minor as u32) << 12 | (self.patch as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.patch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer/cpu_pool.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | usage: usage.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `usage` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/buffer/cpu_pool.rs:477:47 [INFO] [stderr] | [INFO] [stderr] 477 | !chunks_in_use.iter().any(|c| { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 478 | | (c.index >= tentative_index && [INFO] [stderr] 479 | | c.index < tentative_index + tentative_len) || [INFO] [stderr] 480 | | (c.index <= tentative_index && [INFO] [stderr] 481 | | c.index + c.len > tentative_index) [INFO] [stderr] 482 | | }) [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer/cpu_pool.rs:553:20 [INFO] [stderr] | [INFO] [stderr] 553 | usage: self.usage.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/buffer/immutable.rs:176:12 [INFO] [stderr] | [INFO] [stderr] 176 | -> Result<(Arc>, ImmutableBufferFromBufferFuture), [INFO] [stderr] | ____________^ [INFO] [stderr] 177 | | DeviceMemoryAllocError> [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/buffer/immutable.rs:205:42 [INFO] [stderr] | [INFO] [stderr] 205 | -> Result<(Arc>, [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 206 | | ImmutableBufferInitialization<[T]>), [INFO] [stderr] 207 | | DeviceMemoryAllocError> { [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/buffer/sys.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | pub unsafe fn new<'a, I>(device: Arc, size: usize, usage: BufferUsage, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/buffer/sys.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | fn to_flags(&self) -> vk::BufferCreateFlagBits { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/buffer/slice.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | let data: &T = mem::zeroed(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] [INFO] [stderr] warning: item `buffer::slice::BufferSlice<[T], B>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer/slice.rs:169:1 [INFO] [stderr] | [INFO] [stderr] 169 | / impl BufferSlice<[T], B> { [INFO] [stderr] 170 | | /// Returns the number of elements in this slice. [INFO] [stderr] 171 | | #[inline] [INFO] [stderr] 172 | | pub fn len(&self) -> usize { [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/buffer/traits.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | self.slice(index .. (index + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `index..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: trait `TypedBufferAccess` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/buffer/traits.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / pub unsafe trait TypedBufferAccess: BufferAccess { [INFO] [stderr] 198 | | /// The type of the content. [INFO] [stderr] 199 | | type Content: ?Sized; [INFO] [stderr] 200 | | [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command_buffer/pool/sys.rs:271:30 [INFO] [stderr] | [INFO] [stderr] 271 | self.list.next().map(|cb| UnsafeCommandPoolAlloc(cb)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UnsafeCommandPoolAlloc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::bind_sparse::SubmitBindSparseBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/bind_sparse.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> SubmitBindSparseBuilder<'a> { [INFO] [stderr] 43 | | SubmitBindSparseBuilder { [INFO] [stderr] 44 | | infos: SmallVec::new(), [INFO] [stderr] 45 | | fence: 0, [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::bind_sparse::SubmitBindSparseBatchBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/bind_sparse.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | / pub fn new() -> SubmitBindSparseBatchBuilder<'a> { [INFO] [stderr] 274 | | SubmitBindSparseBatchBuilder { [INFO] [stderr] 275 | | wait_semaphores: SmallVec::new(), [INFO] [stderr] 276 | | buffer_binds: SmallVec::new(), [INFO] [stderr] ... | [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 261 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::queue_present::SubmitPresentBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/queue_present.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> SubmitPresentBuilder<'a> { [INFO] [stderr] 44 | | SubmitPresentBuilder { [INFO] [stderr] 45 | | wait_semaphores: SmallVec::new(), [INFO] [stderr] 46 | | swapchains: SmallVec::new(), [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::queue_submit::SubmitCommandBufferBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/queue_submit.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> SubmitCommandBufferBuilder<'a> { [INFO] [stderr] 45 | | SubmitCommandBufferBuilder { [INFO] [stderr] 46 | | wait_semaphores: SmallVec::new(), [INFO] [stderr] 47 | | destination_stages: SmallVec::new(), [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::semaphores_wait::SubmitSemaphoresWaitBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/semaphores_wait.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> SubmitSemaphoresWaitBuilder<'a> { [INFO] [stderr] 30 | | SubmitSemaphoresWaitBuilder { semaphores: SmallVec::new() } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/command_buffer/submit/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | BindSparse(SubmitBindSparseBuilder<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 40 | BindSparse(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_buffer/submit/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &SubmitAnyBuilder::Empty => true, [INFO] [stderr] 49 | | _ => false, [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | SubmitAnyBuilder::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/command_buffer/synced/base.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub(super) fn prev_cmd_resource(&mut self, resource_ty: KeyTy, resource_index: usize, [INFO] [stderr] 465 | | exclusive: bool, stages: PipelineStages, [INFO] [stderr] 466 | | access: AccessFlagBits, start_layout: ImageLayout, [INFO] [stderr] 467 | | end_layout: ImageLayout) [INFO] [stderr] ... | [INFO] [stderr] 682 | | Ok(()) [INFO] [stderr] 683 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/synced/base.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub(super) fn prev_cmd_resource(&mut self, resource_ty: KeyTy, resource_index: usize, [INFO] [stderr] 465 | | exclusive: bool, stages: PipelineStages, [INFO] [stderr] 466 | | access: AccessFlagBits, start_layout: ImageLayout, [INFO] [stderr] 467 | | end_layout: ImageLayout) [INFO] [stderr] ... | [INFO] [stderr] 682 | | Ok(()) [INFO] [stderr] 683 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/command_buffer/synced/base.rs:479:27 [INFO] [stderr] | [INFO] [stderr] 479 | debug_assert!(commands_lock.commands.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands_lock.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/command_buffer/synced/base.rs:616:21 [INFO] [stderr] | [INFO] [stderr] 616 | entry.stages = entry.stages | stages; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry.stages |= stages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/command_buffer/synced/base.rs:617:21 [INFO] [stderr] | [INFO] [stderr] 617 | entry.access = entry.access | access; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry.access |= access` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/command_buffer/synced/base.rs:1132:16 [INFO] [stderr] | [INFO] [stderr] 1132 | if let Err(_) = ret_value { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 1133 | | for key in self.resources.keys().take(locked_resources) { [INFO] [stderr] 1134 | | let (command_id, resource_ty, resource_index) = match *key { [INFO] [stderr] 1135 | | CbKey::Command { [INFO] [stderr] ... | [INFO] [stderr] 1163 | | } [INFO] [stderr] 1164 | | } [INFO] [stderr] | |_________- help: try this: `if ret_value.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/command_buffer/sys.rs:665:5 [INFO] [stderr] | [INFO] [stderr] 665 | / pub unsafe fn blit_image(&mut self, source: &S, source_layout: ImageLayout, [INFO] [stderr] 666 | | destination: &D, destination_layout: ImageLayout, regions: R, [INFO] [stderr] 667 | | filter: Filter) [INFO] [stderr] 668 | | where S: ?Sized + ImageAccess, [INFO] [stderr] ... | [INFO] [stderr] 763 | | filter as u32); [INFO] [stderr] 764 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/command_buffer/sys.rs:1341:23 [INFO] [stderr] | [INFO] [stderr] 1341 | debug_assert!(line_width == 1.0 || self.device().enabled_features().wide_lines); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(line_width - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/command_buffer/sys.rs:1341:23 [INFO] [stderr] | [INFO] [stderr] 1341 | debug_assert!(line_width == 1.0 || self.device().enabled_features().wide_lines); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command_buffer/sys.rs:1380:22 [INFO] [stderr] | [INFO] [stderr] 1380 | .map(|v| v.clone().into_vulkan_rect()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/command_buffer/sys.rs:1387:47 [INFO] [stderr] | [INFO] [stderr] 1387 | debug_assert!(scissors.iter().all(|s| { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 1388 | | s.extent.width < i32::max_value() as u32 && s.extent.height < i32::max_value() as u32 && [INFO] [stderr] 1389 | | s.offset.x.checked_add(s.extent.width as i32).is_some() && [INFO] [stderr] 1390 | | s.offset.y.checked_add(s.extent.height as i32).is_some() [INFO] [stderr] 1391 | | })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::sys::UnsafeCommandBufferBuilderBindVertexBuffer` [INFO] [stderr] --> src/command_buffer/sys.rs:1565:5 [INFO] [stderr] | [INFO] [stderr] 1565 | / pub fn new() -> UnsafeCommandBufferBuilderBindVertexBuffer { [INFO] [stderr] 1566 | | UnsafeCommandBufferBuilderBindVertexBuffer { [INFO] [stderr] 1567 | | raw_buffers: SmallVec::new(), [INFO] [stderr] 1568 | | offsets: SmallVec::new(), [INFO] [stderr] 1569 | | } [INFO] [stderr] 1570 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1555 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::sys::UnsafeCommandBufferBuilderExecuteCommands` [INFO] [stderr] --> src/command_buffer/sys.rs:1593:5 [INFO] [stderr] | [INFO] [stderr] 1593 | / pub fn new() -> UnsafeCommandBufferBuilderExecuteCommands { [INFO] [stderr] 1594 | | UnsafeCommandBufferBuilderExecuteCommands { raw_cbs: SmallVec::new() } [INFO] [stderr] 1595 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1585 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command_buffer/sys.rs:1622:30 [INFO] [stderr] | [INFO] [stderr] 1622 | pub(crate) fn to_vk_bits(&self) -> vk::ImageAspectFlagBits { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::sys::UnsafeCommandBufferBuilderPipelineBarrier` [INFO] [stderr] --> src/command_buffer/sys.rs:1714:5 [INFO] [stderr] | [INFO] [stderr] 1714 | / pub fn new() -> UnsafeCommandBufferBuilderPipelineBarrier { [INFO] [stderr] 1715 | | UnsafeCommandBufferBuilderPipelineBarrier { [INFO] [stderr] 1716 | | src_stage_mask: 0, [INFO] [stderr] 1717 | | dst_stage_mask: 0, [INFO] [stderr] ... | [INFO] [stderr] 1722 | | } [INFO] [stderr] 1723 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1702 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/command_buffer/sys.rs:1810:5 [INFO] [stderr] | [INFO] [stderr] 1810 | / pub unsafe fn add_buffer_memory_barrier(&mut self, buffer: &B, source_stage: PipelineStages, [INFO] [stderr] 1811 | | source_access: AccessFlagBits, [INFO] [stderr] 1812 | | destination_stage: PipelineStages, [INFO] [stderr] 1813 | | destination_access: AccessFlagBits, by_region: bool, [INFO] [stderr] ... | [INFO] [stderr] 1846 | | }); [INFO] [stderr] 1847 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/command_buffer/sys.rs:1866:5 [INFO] [stderr] | [INFO] [stderr] 1866 | / pub unsafe fn add_image_memory_barrier(&mut self, image: &I, mipmaps: Range, [INFO] [stderr] 1867 | | layers: Range, source_stage: PipelineStages, [INFO] [stderr] 1868 | | source_access: AccessFlagBits, [INFO] [stderr] 1869 | | destination_stage: PipelineStages, [INFO] [stderr] ... | [INFO] [stderr] 1926 | | }); [INFO] [stderr] 1927 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/command_buffer/validity/blit_image.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn check_blit_image(device: &Device, source: &S, source_top_left: [i32; 3], [INFO] [stderr] 29 | | source_bottom_right: [i32; 3], source_base_array_layer: u32, [INFO] [stderr] 30 | | source_mip_level: u32, destination: &D, [INFO] [stderr] 31 | | destination_top_left: [i32; 3], destination_bottom_right: [i32; 3], [INFO] [stderr] ... | [INFO] [stderr] 203 | | Ok(()) [INFO] [stderr] 204 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/command_buffer/validity/copy_image.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn check_copy_image(device: &Device, source: &S, source_offset: [i32; 3], [INFO] [stderr] 29 | | source_base_array_layer: u32, source_mip_level: u32, [INFO] [stderr] 30 | | destination: &D, destination_offset: [i32; 3], [INFO] [stderr] 31 | | destination_base_array_layer: u32, destination_mip_level: u32, [INFO] [stderr] ... | [INFO] [stderr] 163 | | Ok(()) [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/command_buffer/validity/copy_image_buffer.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn check_copy_buffer_image(device: &Device, buffer: &B, image: &I, [INFO] [stderr] 38 | | ty: CheckCopyBufferImageTy, image_offset: [u32; 3], [INFO] [stderr] 39 | | image_size: [u32; 3], image_first_layer: u32, [INFO] [stderr] 40 | | image_num_layers: u32, image_mipmap: u32) [INFO] [stderr] ... | [INFO] [stderr] 113 | | Ok(()) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if value != 1.0 && !pipeline.device().enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(value - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if value != 1.0 && !pipeline.device().enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/command_buffer/auto.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | / pub fn copy_image(mut self, source: S, source_offset: [i32; 3], [INFO] [stderr] 591 | | source_base_array_layer: u32, source_mip_level: u32, [INFO] [stderr] 592 | | destination: D, destination_offset: [i32; 3], [INFO] [stderr] 593 | | destination_base_array_layer: u32, destination_mip_level: u32, [INFO] [stderr] ... | [INFO] [stderr] 641 | | } [INFO] [stderr] 642 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/command_buffer/auto.rs:675:5 [INFO] [stderr] | [INFO] [stderr] 675 | / pub fn blit_image(mut self, source: S, source_top_left: [i32; 3], [INFO] [stderr] 676 | | source_bottom_right: [i32; 3], source_base_array_layer: u32, [INFO] [stderr] 677 | | source_mip_level: u32, destination: D, destination_top_left: [i32; 3], [INFO] [stderr] 678 | | destination_bottom_right: [i32; 3], destination_base_array_layer: u32, [INFO] [stderr] ... | [INFO] [stderr] 735 | | } [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/auto.rs:837:5 [INFO] [stderr] | [INFO] [stderr] 837 | / pub fn copy_buffer_to_image_dimensions(mut self, source: S, destination: D, [INFO] [stderr] 838 | | offset: [u32; 3], size: [u32; 3], [INFO] [stderr] 839 | | first_layer: u32, num_layers: u32, mipmap: u32) [INFO] [stderr] 840 | | -> Result [INFO] [stderr] ... | [INFO] [stderr] 884 | | } [INFO] [stderr] 885 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/auto.rs:901:5 [INFO] [stderr] | [INFO] [stderr] 901 | / pub fn copy_image_to_buffer_dimensions(mut self, source: S, destination: D, [INFO] [stderr] 902 | | offset: [u32; 3], size: [u32; 3], [INFO] [stderr] 903 | | first_layer: u32, num_layers: u32, mipmap: u32) [INFO] [stderr] 904 | | -> Result [INFO] [stderr] ... | [INFO] [stderr] 944 | | } [INFO] [stderr] 945 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/auto.rs:1150:5 [INFO] [stderr] | [INFO] [stderr] 1150 | / pub fn draw_indexed_indirect(mut self, pipeline: Gp, dynamic: &DynamicState, [INFO] [stderr] 1151 | | vertex_buffer: V, index_buffer: Ib, indirect_buffer: Inb, sets: S, constants: Pc) [INFO] [stderr] 1152 | | -> Result [INFO] [stderr] 1153 | | where Gp: GraphicsPipelineAbstract + VertexSource + Send + Sync + 'static + Clone, // TODO: meh for Clone [INFO] [stderr] ... | [INFO] [stderr] 1207 | | } [INFO] [stderr] 1208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/command_buffer/auto.rs:1371:42 [INFO] [stderr] | [INFO] [stderr] 1371 | let data = slice::from_raw_parts((&push_constants as *const Pc as *const u8) [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 1372 | | .offset(range.offset as isize), [INFO] [stderr] | |___________________________________________________________________________^ help: try: `(&push_constants as *const Pc as *const u8).add(range.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/command_buffer/auto.rs:1390:37 [INFO] [stderr] | [INFO] [stderr] 1390 | destination.set_viewport(0, viewports.iter().cloned().collect::>().into_iter()); // TODO: don't collect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/command_buffer/auto.rs:1394:36 [INFO] [stderr] | [INFO] [stderr] 1394 | destination.set_scissor(0, scissors.iter().cloned().collect::>().into_iter()); // TODO: don't collect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::state_cacher::StateCacher` [INFO] [stderr] --> src/command_buffer/state_cacher.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> StateCacher { [INFO] [stderr] 63 | | StateCacher { [INFO] [stderr] 64 | | dynamic_state: DynamicState::none(), [INFO] [stderr] 65 | | compute_pipeline: 0, [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/command_buffer/state_cacher.rs:349:33 [INFO] [stderr] | [INFO] [stderr] 349 | first .. (self.last_diff + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first..=self.last_diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/command_buffer/traits.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | submitted: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/command_buffer/traits.rs:242:33 [INFO] [stderr] | [INFO] [stderr] 242 | let mut submitted = self.submitted.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/command_buffer/traits.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | if self.finished.swap(true, Ordering::SeqCst) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.finished.swap(true, Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:640:27 [INFO] [stderr] | [INFO] [stderr] 640 | pub fn is_superset_of(&self, other: &ShaderStages) -> Result<(), ShaderStagesSupersetError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:640:41 [INFO] [stderr] | [INFO] [stderr] 640 | pub fn is_superset_of(&self, other: &ShaderStages) -> Result<(), ShaderStagesSupersetError> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `ShaderStages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:656:23 [INFO] [stderr] | [INFO] [stderr] 656 | pub fn intersects(&self, other: &ShaderStages) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:656:37 [INFO] [stderr] | [INFO] [stderr] 656 | pub fn intersects(&self, other: &ShaderStages) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `ShaderStages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn next(&mut self) -> FixedSizeDescriptorSetBuilder [INFO] [stderr] 117 | | where L: PipelineLayoutAbstract + Clone [INFO] [stderr] 118 | | { [INFO] [stderr] 119 | | let inner = PersistentDescriptorSet::start(self.pipeline_layout.clone(), self.set_id); [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:423:12 [INFO] [stderr] | [INFO] [stderr] 423 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:535:12 [INFO] [stderr] | [INFO] [stderr] 535 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:327:12 [INFO] [stderr] | [INFO] [stderr] 327 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:649:12 [INFO] [stderr] | [INFO] [stderr] 649 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/descriptor/descriptor_set/std_pool.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | if !(pool.remaining_capacity >= *layout.descriptors_count()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/descriptor/descriptor_set/std_pool.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | let count = layout.descriptors_count().clone() * 40; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*layout.descriptors_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:705:30 [INFO] [stderr] | [INFO] [stderr] 705 | Some(off) => image_descriptors.as_ptr().offset(off as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_descriptors.as_ptr().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:710:30 [INFO] [stderr] | [INFO] [stderr] 710 | Some(off) => buffer_descriptors.as_ptr().offset(off as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer_descriptors.as_ptr().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:715:30 [INFO] [stderr] | [INFO] [stderr] 715 | Some(off) => buffer_views_descriptors.as_ptr().offset(off as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer_views_descriptors.as_ptr().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:842:33 [INFO] [stderr] | [INFO] [stderr] 842 | pub fn uniform_texel_buffer<'a, F, B>(binding: u32, array_element: u32, view: &BufferView) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:856:33 [INFO] [stderr] | [INFO] [stderr] 856 | pub fn storage_texel_buffer<'a, F, B>(binding: u32, array_element: u32, view: &BufferView) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/pipeline_layout/limits_check.rs:439:47 [INFO] [stderr] | [INFO] [stderr] 439 | fn increment(&mut self, num: u32, stages: &ShaderStages) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `ShaderStages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | .or(self.b.provided_set_layout(set)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.b.provided_set_layout(set))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / (self.a.num_push_constants_ranges() ..) [INFO] [stderr] 80 | | .filter(|&n| self.push_constants_range(n).is_none()) [INFO] [stderr] 81 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|&n| self.push_constants_range(n).is_none()).next()` with `find(|&n| self.push_constants_range(n).is_none())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:591:38 [INFO] [stderr] | [INFO] [stderr] 591 | queue: Mutex::new(output), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:694:5 [INFO] [stderr] | [INFO] [stderr] 694 | queue: Mutex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:736:25 [INFO] [stderr] | [INFO] [stderr] 736 | let queue = self.queue.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:755:9 [INFO] [stderr] | [INFO] [stderr] 755 | self.queue.lock().unwrap() [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format.rs:782:36 [INFO] [stderr] | [INFO] [stderr] 782 | pub fn is_depth_and_or_stencil(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / (&self) [INFO] [stderr] 133 | | .subpass_descs() [INFO] [stderr] 134 | | .skip(subpass as usize) [INFO] [stderr] 135 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / (&self) [INFO] [stderr] 144 | | .subpass_descs() [INFO] [stderr] 145 | | .skip(subpass as usize) [INFO] [stderr] 146 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/framebuffer/desc.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | .chain(p.depth_stencil.clone().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `p.depth_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:153:37 [INFO] [stderr] | [INFO] [stderr] 153 | .filter_map(|a| (&self).attachment_descs().skip(a.0).next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / (&self) [INFO] [stderr] 164 | | .subpass_descs() [INFO] [stderr] 165 | | .skip(subpass as usize) [INFO] [stderr] 166 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 174 | | .attachment_descs() [INFO] [stderr] 175 | | .skip(atch_num) [INFO] [stderr] 176 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | / (&self) [INFO] [stderr] 192 | | .subpass_descs() [INFO] [stderr] 193 | | .skip(subpass as usize) [INFO] [stderr] 194 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:201:23 [INFO] [stderr] | [INFO] [stderr] 201 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 202 | | .attachment_descs() [INFO] [stderr] 203 | | .skip(atch_num) [INFO] [stderr] 204 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | / (&self) [INFO] [stderr] 221 | | .subpass_descs() [INFO] [stderr] 222 | | .skip(subpass as usize) [INFO] [stderr] 223 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:235:23 [INFO] [stderr] | [INFO] [stderr] 235 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 236 | | .attachment_descs() [INFO] [stderr] 237 | | .skip(atch_num) [INFO] [stderr] 238 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | / (&self) [INFO] [stderr] 254 | | .subpass_descs() [INFO] [stderr] 255 | | .skip(subpass as usize) [INFO] [stderr] 256 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:263:23 [INFO] [stderr] | [INFO] [stderr] 263 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 264 | | .attachment_descs() [INFO] [stderr] 265 | | .skip(atch_num) [INFO] [stderr] 266 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / (&self) [INFO] [stderr] 283 | | .subpass_descs() [INFO] [stderr] 284 | | .skip(subpass as usize) [INFO] [stderr] 285 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:297:23 [INFO] [stderr] | [INFO] [stderr] 297 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 298 | | .attachment_descs() [INFO] [stderr] 299 | | .skip(atch_num) [INFO] [stderr] 300 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/framebuffer/framebuffer.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / pub fn add(self, attachment: T) [INFO] [stderr] 161 | | -> Result, FramebufferCreationError> [INFO] [stderr] 162 | | where T: ImageViewAccess [INFO] [stderr] 163 | | { [INFO] [stderr] ... | [INFO] [stderr] 233 | | }) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/framebuffer/sys.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | attachment)| { [INFO] [stderr] | ________________________^ [INFO] [stderr] 75 | | if attachment.load != LoadOp::Clear { [INFO] [stderr] 76 | | return true; [INFO] [stderr] 77 | | } [INFO] [stderr] ... | [INFO] [stderr] 101 | | true [INFO] [stderr] 102 | | })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/framebuffer/sys.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | if p.color_attachments [INFO] [stderr] | ____________________^ [INFO] [stderr] 81 | | .iter() [INFO] [stderr] 82 | | .find(|&&(a, _)| a == atch_num) [INFO] [stderr] 83 | | .is_some() [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&(a, _)| a == atch_num).is_some()` with `any(|&&(a, _)| a == atch_num)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/framebuffer/sys.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | if p.input_attachments [INFO] [stderr] | ____________________^ [INFO] [stderr] 93 | | .iter() [INFO] [stderr] 94 | | .find(|&&(a, _)| a == atch_num) [INFO] [stderr] 95 | | .is_some() [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&(a, _)| a == atch_num).is_some()` with `any(|&&(a, _)| a == atch_num)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/framebuffer/sys.rs:146:53 [INFO] [stderr] | [INFO] [stderr] 146 | .all(|(r, c)| { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 147 | | attachments[r.0].format == attachments[c.0].format [INFO] [stderr] 148 | | })); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/framebuffer/sys.rs:155:49 [INFO] [stderr] | [INFO] [stderr] 155 | .all(|(a, _)| { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 156 | | pass.preserve_attachments [INFO] [stderr] 157 | | .iter() [INFO] [stderr] 158 | | .find(|&&b| a == b) [INFO] [stderr] 159 | | .is_none() [INFO] [stderr] 160 | | })); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/framebuffer/sys.rs:152:42 [INFO] [stderr] | [INFO] [stderr] 152 | .chain(pass.depth_stencil.clone().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pass.depth_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/framebuffer/sys.rs:165:32 [INFO] [stderr] | [INFO] [stderr] 165 | .chain(pass.depth_stencil.clone().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pass.depth_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | let color_attachments = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:244:41 [INFO] [stderr] | [INFO] [stderr] 244 | let input_attachments = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:246:43 [INFO] [stderr] | [INFO] [stderr] 246 | let resolve_attachments = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:249:29 [INFO] [stderr] | [INFO] [stderr] 249 | let a = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:256:44 [INFO] [stderr] | [INFO] [stderr] 256 | let preserve_attachments = preserve_attachments_references [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 257 | | .as_ptr() [INFO] [stderr] 258 | | .offset(preserve_ref_index as isize); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 256 | let preserve_attachments = preserve_attachments_references [INFO] [stderr] 257 | .as_ptr().add(preserve_ref_index); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/traits.rs:173:32 [INFO] [stderr] | [INFO] [stderr] 173 | let pass_descr = match RenderPassDesc::subpass_descs(self) [INFO] [stderr] | ________________________________^ [INFO] [stderr] 174 | | .skip(subpass as usize) [INFO] [stderr] 175 | | .next() { [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/traits.rs:187:39 [INFO] [stderr] | [INFO] [stderr] 187 | let attachment_desc = (&self) [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 188 | | .attachment_descs() [INFO] [stderr] 189 | | .skip(attachment_id) [INFO] [stderr] 190 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/image/sys.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | pub unsafe fn new<'a, Mi, I>(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/image/sys.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub unsafe fn new<'a, Mi, I>(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] 83 | | dimensions: ImageDimensions, num_samples: u32, mipmaps: Mi, [INFO] [stderr] 84 | | sharing: Sharing, linear_tiling: bool, [INFO] [stderr] 85 | | preinitialized_layout: bool) [INFO] [stderr] ... | [INFO] [stderr] 103 | | preinitialized_layout) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/image/sys.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / unsafe fn new_impl(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] 108 | | dimensions: ImageDimensions, num_samples: u32, mipmaps: MipmapsCount, [INFO] [stderr] 109 | | (sh_mode, sh_indices): (vk::SharingMode, SmallVec<[u32; 8]>), [INFO] [stderr] 110 | | linear_tiling: bool, preinitialized_layout: bool) [INFO] [stderr] ... | [INFO] [stderr] 556 | | Ok((image, mem_reqs)) [INFO] [stderr] 557 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/image/sys.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / unsafe fn new_impl(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] 108 | | dimensions: ImageDimensions, num_samples: u32, mipmaps: MipmapsCount, [INFO] [stderr] 109 | | (sh_mode, sh_indices): (vk::SharingMode, SmallVec<[u32; 8]>), [INFO] [stderr] 110 | | linear_tiling: bool, preinitialized_layout: bool) [INFO] [stderr] ... | [INFO] [stderr] 556 | | Ok((image, mem_reqs)) [INFO] [stderr] 557 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image/sys.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | ..usage.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/image/sys.rs:195:29 [INFO] [stderr] | [INFO] [stderr] 195 | let mipmaps = match mipmaps.into() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `mipmaps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/image/sys.rs:202:49 [INFO] [stderr] | [INFO] [stderr] 202 | valid_range: 1 .. max_mipmaps + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=max_mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/image/sys.rs:207:64 [INFO] [stderr] | [INFO] [stderr] 207 | valid_range: 1 .. max_mipmaps + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=max_mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/image/sys.rs:221:50 [INFO] [stderr] | [INFO] [stderr] 221 | } else if !num_samples.is_power_of_two() { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 222 | | return Err(ImageCreationError::UnsupportedSamplesCount { obtained: num_samples }); [INFO] [stderr] 223 | | [INFO] [stderr] 224 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/image/sys.rs:218:29 [INFO] [stderr] | [INFO] [stderr] 218 | if num_samples == 0 { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 219 | | return Err(ImageCreationError::UnsupportedSamplesCount { obtained: num_samples }); [INFO] [stderr] 220 | | [INFO] [stderr] 221 | | } else if !num_samples.is_power_of_two() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image/usage.rs:97:33 [INFO] [stderr] | [INFO] [stderr] 97 | pub(crate) fn to_usage_bits(&self) -> vk::ImageUsageFlagBits { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/instance/debug.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | let user_callback: &Box = &*user_callback; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `&Fn(&Message)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instance/loader.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / match DEFAULT_LOADER.deref() { [INFO] [stderr] 212 | | &Ok(ref ptr) => Ok(ptr), [INFO] [stderr] 213 | | &Err(ref err) => Err(err.clone()), [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 211 | match *DEFAULT_LOADER.deref() { [INFO] [stderr] 212 | Ok(ref ptr) => Ok(ptr), [INFO] [stderr] 213 | Err(ref err) => Err(err.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instance/instance.rs:1058:13 [INFO] [stderr] | [INFO] [stderr] 1058 | let ref granularity = self.physical_device.infos().queue_families[self.id as usize] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1058 | let granularity = &self.physical_device.infos().queue_families[self.id as usize] [INFO] [stderr] 1059 | .minImageTransferGranularity; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/memory/pool/host_visible.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | occupied: Mutex, Vec>)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | occupied: Mutex, Vec>)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/memory/pool/pool.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | Mutex>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/memory/pool/pool.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match entry.get() { [INFO] [stderr] 69 | | &Pool::HostVisible(ref pool) => { [INFO] [stderr] 70 | | let alloc = StdHostVisibleMemoryTypePool::alloc(&pool, size, alignment)?; [INFO] [stderr] 71 | | let inner = StdMemoryPoolAllocInner::HostVisible(alloc); [INFO] [stderr] ... | [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *entry.get() { [INFO] [stderr] 69 | Pool::HostVisible(ref pool) => { [INFO] [stderr] 70 | let alloc = StdHostVisibleMemoryTypePool::alloc(&pool, size, alignment)?; [INFO] [stderr] 71 | let inner = StdMemoryPoolAllocInner::HostVisible(alloc); [INFO] [stderr] 72 | Ok(StdMemoryPoolAlloc { [INFO] [stderr] 73 | inner: inner, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/memory/pool/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / first_loop [INFO] [stderr] 111 | | .chain(second_loop) [INFO] [stderr] 112 | | .filter(|&(t, _)| (requirements.memory_type_bits & (1 << t.id())) != 0) [INFO] [stderr] 113 | | .filter(|&(t, rq)| filter(t) == rq) [INFO] [stderr] 114 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|&(t, rq)| filter(t) == rq).next()` with `find(|&(t, rq)| filter(t) == rq)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn into_vulkan_version(&self) -> u32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/version.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn into_vulkan_version(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | (self.major as u32) << 22 | (self.minor as u32) << 12 | (self.patch as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.major)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:83:37 [INFO] [stderr] | [INFO] [stderr] 83 | (self.major as u32) << 22 | (self.minor as u32) << 12 | (self.patch as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:83:65 [INFO] [stderr] | [INFO] [stderr] 83 | (self.major as u32) << 22 | (self.minor as u32) << 12 | (self.patch as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.patch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/memory/mod.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | fn ref_from_ptr<'a>(ptr: *mut c_void, size: usize) -> Option<*mut Self>; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/memory/mod.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | fn ref_from_ptr<'a>(ptr: *mut c_void, size: usize) -> Option<*mut T> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/memory/mod.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | fn ref_from_ptr<'a>(ptr: *mut c_void, size: usize) -> Option<*mut [T]> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new( [INFO] [stderr] 59 | | device: Arc, shader: &Cs, specialization: &Cs::SpecializationConstants) [INFO] [stderr] 60 | | -> Result>, ComputePipelineCreationError> [INFO] [stderr] 61 | | where Cs::PipelineLayout: Clone, [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:212:43 [INFO] [stderr] | [INFO] [stderr] 212 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:245:43 [INFO] [stderr] | [INFO] [stderr] 245 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:272:43 [INFO] [stderr] | [INFO] [stderr] 272 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:295:47 [INFO] [stderr] | [INFO] [stderr] 295 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / pub fn with_pipeline_layout(mut self, device: Arc, pipeline_layout: Pl) [INFO] [stderr] 309 | | -> Result, [INFO] [stderr] 310 | | GraphicsPipelineCreationError> [INFO] [stderr] 311 | | where Pl: PipelineLayoutAbstract [INFO] [stderr] ... | [INFO] [stderr] 1110 | | }) [INFO] [stderr] 1111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer/cpu_pool.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | usage: usage.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `usage` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:588:31 [INFO] [stderr] | [INFO] [stderr] 588 | debug_assert!(binding_descriptions [INFO] [stderr] | _______________________________^ [INFO] [stderr] 589 | | .iter() [INFO] [stderr] 590 | | .find(|b| b.binding == binding) [INFO] [stderr] 591 | | .is_some()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|b| b.binding == binding).is_some()` with `any(|b| b.binding == binding)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:701:65 [INFO] [stderr] | [INFO] [stderr] 701 | .map(|e| e.1.clone().into_vulkan_rect()) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `e.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:775:16 [INFO] [stderr] | [INFO] [stderr] 775 | if line_width != 1.0 && !device.enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(line_width - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:775:16 [INFO] [stderr] | [INFO] [stderr] 775 | if line_width != 1.0 && !device.enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/buffer/cpu_pool.rs:477:47 [INFO] [stderr] | [INFO] [stderr] 477 | !chunks_in_use.iter().any(|c| { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 478 | | (c.index >= tentative_index && [INFO] [stderr] 479 | | c.index < tentative_index + tentative_len) || [INFO] [stderr] 480 | | (c.index <= tentative_index && [INFO] [stderr] 481 | | c.index + c.len > tentative_index) [INFO] [stderr] 482 | | }) [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1018:22 [INFO] [stderr] | [INFO] [stderr] 1018 | logicOp: self.blend.logic_op.unwrap_or(Default::default()) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.blend.logic_op.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer/cpu_pool.rs:553:20 [INFO] [stderr] | [INFO] [stderr] 553 | usage: self.usage.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1148:45 [INFO] [stderr] | [INFO] [stderr] 1148 | -> GraphicsPipelineBuilder, [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 1149 | | Vs, [INFO] [stderr] 1150 | | Vss, [INFO] [stderr] 1151 | | Tcs, [INFO] [stderr] ... | [INFO] [stderr] 1158 | | Fss, [INFO] [stderr] 1159 | | Rp> { [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pipeline/graphics_pipeline/mod.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn start<'a>() [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pipeline/depth_stencil.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match self { [INFO] [stderr] 195 | | &DepthBounds::Dynamic => true, [INFO] [stderr] 196 | | _ => false, [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *self { [INFO] [stderr] 195 | DepthBounds::Dynamic => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pipeline/input_assembly.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn supports_primitive_restart(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/pipeline/shader.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | Self::from_ptr(device, spirv.as_ptr() as *const _, spirv.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pipeline/shader.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | pub fn matches(&self, input: PrimitiveTopology) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/buffer/immutable.rs:176:12 [INFO] [stderr] | [INFO] [stderr] 176 | -> Result<(Arc>, ImmutableBufferFromBufferFuture), [INFO] [stderr] | ____________^ [INFO] [stderr] 177 | | DeviceMemoryAllocError> [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/buffer/immutable.rs:205:42 [INFO] [stderr] | [INFO] [stderr] 205 | -> Result<(Arc>, [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 206 | | ImmutableBufferInitialization<[T]>), [INFO] [stderr] 207 | | DeviceMemoryAllocError> { [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pipeline/vertex/bufferless.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | fn decode<'l>(&self, _: Vec) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::instance_buffer::SingleInstanceBufferDefinition` [INFO] [stderr] --> src/pipeline/vertex/instance_buffer.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> SingleInstanceBufferDefinition { [INFO] [stderr] 32 | | SingleInstanceBufferDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::one_one::OneVertexOneInstanceDefinition` [INFO] [stderr] --> src/pipeline/vertex/one_one.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> OneVertexOneInstanceDefinition { [INFO] [stderr] 32 | | OneVertexOneInstanceDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::single::SingleBufferDefinition` [INFO] [stderr] --> src/pipeline/vertex/single.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> SingleBufferDefinition { [INFO] [stderr] 32 | | SingleBufferDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::two::TwoBuffersDefinition` [INFO] [stderr] --> src/pipeline/vertex/two.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> TwoBuffersDefinition { [INFO] [stderr] 32 | | TwoBuffersDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pipeline/vertex/vertex.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn matches(&self, array_size: usize, format: Format, num_locs: u32) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/buffer/immutable.rs:528:9 [INFO] [stderr] | [INFO] [stderr] 528 | / assert_should_panic!({ [INFO] [stderr] 529 | | // TODO: check Result error instead of panicking [INFO] [stderr] 530 | | let _ = AutoCommandBufferBuilder::new(device.clone(), [INFO] [stderr] 531 | | queue.family()) [INFO] [stderr] ... | [INFO] [stderr] 540 | | .unwrap(); [INFO] [stderr] 541 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | // TODO: check Result error instead of panicking [INFO] [stderr] 96 | let _ = AutoCommandBufferBuilder::new(device.clone(), [INFO] [stderr] 97 | queue.family()) [INFO] [stderr] 98 | .unwrap() [INFO] [stderr] 99 | .fill_buffer(buffer, 50) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/sampler.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new(device: Arc, mag_filter: Filter, min_filter: Filter, [INFO] [stderr] 170 | | mipmap_mode: MipmapMode, address_u: SamplerAddressMode, [INFO] [stderr] 171 | | address_v: SamplerAddressMode, address_w: SamplerAddressMode, mip_lod_bias: f32, [INFO] [stderr] 172 | | max_anisotropy: f32, min_lod: f32, max_lod: f32) [INFO] [stderr] ... | [INFO] [stderr] 185 | | None) [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/buffer/immutable.rs:554:9 [INFO] [stderr] | [INFO] [stderr] 554 | / assert_should_panic!({ [INFO] [stderr] 555 | | // TODO: check Result error instead of panicking [INFO] [stderr] 556 | | let _ = AutoCommandBufferBuilder::new(device.clone(), [INFO] [stderr] 557 | | queue.family()) [INFO] [stderr] ... | [INFO] [stderr] 566 | | .unwrap(); [INFO] [stderr] 567 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | // TODO: check Result error instead of panicking [INFO] [stderr] 96 | let _ = AutoCommandBufferBuilder::new(device.clone(), [INFO] [stderr] 97 | queue.family()) [INFO] [stderr] 98 | .unwrap() [INFO] [stderr] 99 | .copy_buffer(source, buffer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/sampler.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn compare(device: Arc, mag_filter: Filter, min_filter: Filter, [INFO] [stderr] 206 | | mipmap_mode: MipmapMode, address_u: SamplerAddressMode, [INFO] [stderr] 207 | | address_v: SamplerAddressMode, address_w: SamplerAddressMode, [INFO] [stderr] 208 | | mip_lod_bias: f32, max_anisotropy: f32, min_lod: f32, max_lod: f32, [INFO] [stderr] ... | [INFO] [stderr] 222 | | Some(compare)) [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/sampler.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / fn new_impl(device: Arc, mag_filter: Filter, min_filter: Filter, [INFO] [stderr] 226 | | mipmap_mode: MipmapMode, address_u: SamplerAddressMode, [INFO] [stderr] 227 | | address_v: SamplerAddressMode, address_w: SamplerAddressMode, mip_lod_bias: f32, [INFO] [stderr] 228 | | max_anisotropy: f32, min_lod: f32, max_lod: f32, compare: Option) [INFO] [stderr] ... | [INFO] [stderr] 352 | | })) [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/buffer/sys.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | pub unsafe fn new<'a, I>(device: Arc, size: usize, usage: BufferUsage, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/buffer/sys.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | fn to_flags(&self) -> vk::BufferCreateFlagBits { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn supports(&self, mode: PresentMode) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn iter(&self) -> SupportedPresentModesIter { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/capabilities.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | SupportedPresentModesIter(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn supports(&self, value: CompositeAlpha) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | pub fn iter(&self) -> SupportedCompositeAlphaIter { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/capabilities.rs:281:37 [INFO] [stderr] | [INFO] [stderr] 281 | SupportedCompositeAlphaIter(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/capabilities.rs:409:40 [INFO] [stderr] | [INFO] [stderr] 409 | SupportedSurfaceTransformsIter(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/swapchain/display.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / self.supported_displays [INFO] [stderr] 145 | | .iter() [INFO] [stderr] 146 | | .find(|&&d| d == display.internal_object()) [INFO] [stderr] 147 | | .is_some() [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&d| d == display.internal_object()).is_some()` with `any(|&&d| d == display.internal_object())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/swapchain/display.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | let ref r = self.properties.physicalDimensions; [INFO] [stderr] | ----^^^^^-------------------------------------- help: try: `let r = &self.properties.physicalDimensions;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/swapchain/display.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | let ref r = self.properties.physicalResolution; [INFO] [stderr] | ----^^^^^-------------------------------------- help: try: `let r = &self.properties.physicalResolution;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/swapchain/display.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | let ref d = self.parameters.visibleRegion; [INFO] [stderr] | ----^^^^^--------------------------------- help: try: `let d = &self.parameters.visibleRegion;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/swapchain/surface.rs:520:31 [INFO] [stderr] | [INFO] [stderr] 520 | debug_assert!(modes [INFO] [stderr] | _______________________________^ [INFO] [stderr] 521 | | .iter() [INFO] [stderr] 522 | | .find(|&&m| m == vk::PRESENT_MODE_FIFO_KHR) [INFO] [stderr] 523 | | .is_some()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&m| m == vk::PRESENT_MODE_FIFO_KHR).is_some()` with `any(|&&m| m == vk::PRESENT_MODE_FIFO_KHR)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/swapchain/swapchain.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | let stale = swapchain.stale.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/swapchain/swapchain.rs:229:12 [INFO] [stderr] | [INFO] [stderr] 229 | -> Result<(Arc>, Vec>>), SwapchainCreationError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/buffer/slice.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | let data: &T = mem::zeroed(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/swapchain/swapchain.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / pub fn new( [INFO] [stderr] 225 | | device: Arc, surface: Arc>, num_images: u32, format: F, [INFO] [stderr] 226 | | dimensions: [u32; 2], layers: u32, usage: ImageUsage, sharing: S, [INFO] [stderr] 227 | | transform: SurfaceTransform, alpha: CompositeAlpha, mode: PresentMode, clipped: bool, [INFO] [stderr] ... | [INFO] [stderr] 246 | | old_swapchain.map(|s| &**s)) [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: item `buffer::slice::BufferSlice<[T], B>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer/slice.rs:169:1 [INFO] [stderr] | [INFO] [stderr] 169 | / impl BufferSlice<[T], B> { [INFO] [stderr] 170 | | /// Returns the number of elements in this slice. [INFO] [stderr] 171 | | #[inline] [INFO] [stderr] 172 | | pub fn len(&self) -> usize { [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/swapchain/swapchain.rs:252:12 [INFO] [stderr] | [INFO] [stderr] 252 | -> Result<(Arc>, Vec>>), SwapchainCreationError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/swapchain/swapchain.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | -> Result<(Arc>, Vec>>), SwapchainCreationError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/swapchain/swapchain.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | / fn new_inner(device: Arc, surface: Arc>, num_images: u32, format: Format, [INFO] [stderr] 270 | | color_space: ColorSpace, dimensions: [u32; 2], layers: u32, usage: ImageUsage, [INFO] [stderr] 271 | | sharing: SharingMode, transform: SurfaceTransform, alpha: CompositeAlpha, [INFO] [stderr] 272 | | mode: PresentMode, clipped: bool, old_swapchain: Option<&Swapchain>) [INFO] [stderr] ... | [INFO] [stderr] 478 | | Ok((swapchain, swapchain_images)) [INFO] [stderr] 479 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/buffer/traits.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | self.slice(index .. (index + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `index..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: trait `TypedBufferAccess` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/buffer/traits.rs:197:1 [INFO] [stderr] | [INFO] [stderr] 197 | / pub unsafe trait TypedBufferAccess: BufferAccess { [INFO] [stderr] 198 | | /// The type of the content. [INFO] [stderr] 199 | | type Content: ?Sized; [INFO] [stderr] 200 | | [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/swapchain/swapchain.rs:347:29 [INFO] [stderr] | [INFO] [stderr] 347 | let mut stale = old_swapchain.stale.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/swapchain/swapchain.rs:456:45 [INFO] [stderr] | [INFO] [stderr] 456 | stale: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/swapchain.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | usage: usage.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command_buffer/pool/sys.rs:271:30 [INFO] [stderr] | [INFO] [stderr] 271 | self.list.next().map(|cb| UnsafeCommandPoolAlloc(cb)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UnsafeCommandPoolAlloc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/swapchain/swapchain.rs:999:21 [INFO] [stderr] | [INFO] [stderr] 999 | let queue = self.previous.queue().map(|q| q.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.previous.queue().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/swapchain/swapchain.rs:1131:17 [INFO] [stderr] | [INFO] [stderr] 1131 | / match self.flush() { [INFO] [stderr] 1132 | | Ok(()) => { [INFO] [stderr] 1133 | | // Block until the queue finished. [INFO] [stderr] 1134 | | self.queue().unwrap().wait().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 1140 | | }, [INFO] [stderr] 1141 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1131 | if let Ok(()) = self.flush() { [INFO] [stderr] 1132 | // Block until the queue finished. [INFO] [stderr] 1133 | self.queue().unwrap().wait().unwrap(); [INFO] [stderr] 1134 | self.previous.signal_finished(); [INFO] [stderr] 1135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/swapchain/swapchain.rs:1168:29 [INFO] [stderr] | [INFO] [stderr] 1168 | .saturating_add(timeout.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::bind_sparse::SubmitBindSparseBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/bind_sparse.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> SubmitBindSparseBuilder<'a> { [INFO] [stderr] 43 | | SubmitBindSparseBuilder { [INFO] [stderr] 44 | | infos: SmallVec::new(), [INFO] [stderr] 45 | | fence: 0, [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sync/fence.rs:163:37 [INFO] [stderr] | [INFO] [stderr] 163 | .saturating_add(timeout.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sync/fence.rs:221:33 [INFO] [stderr] | [INFO] [stderr] 221 | .saturating_add(timeout.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::bind_sparse::SubmitBindSparseBatchBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/bind_sparse.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | / pub fn new() -> SubmitBindSparseBatchBuilder<'a> { [INFO] [stderr] 274 | | SubmitBindSparseBatchBuilder { [INFO] [stderr] 275 | | wait_semaphores: SmallVec::new(), [INFO] [stderr] 276 | | buffer_binds: SmallVec::new(), [INFO] [stderr] ... | [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 261 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::queue_present::SubmitPresentBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/queue_present.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> SubmitPresentBuilder<'a> { [INFO] [stderr] 44 | | SubmitPresentBuilder { [INFO] [stderr] 45 | | wait_semaphores: SmallVec::new(), [INFO] [stderr] 46 | | swapchains: SmallVec::new(), [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sync/future/fence_signal.rs:368:17 [INFO] [stderr] | [INFO] [stderr] 368 | / if state.get_prev().is_some() { [INFO] [stderr] 369 | | false [INFO] [stderr] 370 | | } else { [INFO] [stderr] 371 | | true [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!state.get_prev().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/sync/future/join.rs:155:24 [INFO] [stderr] | [INFO] [stderr] 155 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::queue_submit::SubmitCommandBufferBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/queue_submit.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> SubmitCommandBufferBuilder<'a> { [INFO] [stderr] 45 | | SubmitCommandBufferBuilder { [INFO] [stderr] 46 | | wait_semaphores: SmallVec::new(), [INFO] [stderr] 47 | | destination_stages: SmallVec::new(), [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync/future/semaphore_signal.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | wait_submitted: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync/future/semaphore_signal.rs:83:38 [INFO] [stderr] | [INFO] [stderr] 83 | let mut wait_submitted = self.wait_submitted.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync/future/semaphore_signal.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | debug_assert!(*self.wait_submitted.lock().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::submit::semaphores_wait::SubmitSemaphoresWaitBuilder<'a>` [INFO] [stderr] --> src/command_buffer/submit/semaphores_wait.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> SubmitSemaphoresWaitBuilder<'a> { [INFO] [stderr] 30 | | SubmitSemaphoresWaitBuilder { semaphores: SmallVec::new() } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/command_buffer/submit/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | BindSparse(SubmitBindSparseBuilder<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 40 | BindSparse(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_buffer/submit/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &SubmitAnyBuilder::Empty => true, [INFO] [stderr] 49 | | _ => false, [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | SubmitAnyBuilder::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/command_buffer/synced/base.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub(super) fn prev_cmd_resource(&mut self, resource_ty: KeyTy, resource_index: usize, [INFO] [stderr] 465 | | exclusive: bool, stages: PipelineStages, [INFO] [stderr] 466 | | access: AccessFlagBits, start_layout: ImageLayout, [INFO] [stderr] 467 | | end_layout: ImageLayout) [INFO] [stderr] ... | [INFO] [stderr] 682 | | Ok(()) [INFO] [stderr] 683 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/synced/base.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub(super) fn prev_cmd_resource(&mut self, resource_ty: KeyTy, resource_index: usize, [INFO] [stderr] 465 | | exclusive: bool, stages: PipelineStages, [INFO] [stderr] 466 | | access: AccessFlagBits, start_layout: ImageLayout, [INFO] [stderr] 467 | | end_layout: ImageLayout) [INFO] [stderr] ... | [INFO] [stderr] 682 | | Ok(()) [INFO] [stderr] 683 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/command_buffer/synced/base.rs:479:27 [INFO] [stderr] | [INFO] [stderr] 479 | debug_assert!(commands_lock.commands.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands_lock.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/command_buffer/synced/base.rs:616:21 [INFO] [stderr] | [INFO] [stderr] 616 | entry.stages = entry.stages | stages; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry.stages |= stages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/command_buffer/synced/base.rs:617:21 [INFO] [stderr] | [INFO] [stderr] 617 | entry.access = entry.access | access; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry.access |= access` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `BitOrAssign` impl [INFO] [stderr] --> src/sync/pipeline.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | self.$elem = self.$elem || rhs.$elem; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / pipeline_stages!{ [INFO] [stderr] 68 | | top_of_pipe => vk::PIPELINE_STAGE_TOP_OF_PIPE_BIT, [INFO] [stderr] 69 | | draw_indirect => vk::PIPELINE_STAGE_DRAW_INDIRECT_BIT, [INFO] [stderr] 70 | | vertex_input => vk::PIPELINE_STAGE_VERTEX_INPUT_BIT, [INFO] [stderr] ... | [INFO] [stderr] 84 | | all_commands => vk::PIPELINE_STAGE_ALL_COMMANDS_BIT, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `BitOrAssign` impl [INFO] [stderr] --> src/sync/pipeline.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | self.$elem = self.$elem || rhs.$elem; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / pipeline_stages!{ [INFO] [stderr] 68 | | top_of_pipe => vk::PIPELINE_STAGE_TOP_OF_PIPE_BIT, [INFO] [stderr] 69 | | draw_indirect => vk::PIPELINE_STAGE_DRAW_INDIRECT_BIT, [INFO] [stderr] 70 | | vertex_input => vk::PIPELINE_STAGE_VERTEX_INPUT_BIT, [INFO] [stderr] ... | [INFO] [stderr] 84 | | all_commands => vk::PIPELINE_STAGE_ALL_COMMANDS_BIT, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/command_buffer/synced/base.rs:1132:16 [INFO] [stderr] | [INFO] [stderr] 1132 | if let Err(_) = ret_value { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 1133 | | for key in self.resources.keys().take(locked_resources) { [INFO] [stderr] 1134 | | let (command_id, resource_ty, resource_index) = match *key { [INFO] [stderr] 1135 | | CbKey::Command { [INFO] [stderr] ... | [INFO] [stderr] 1163 | | } [INFO] [stderr] 1164 | | } [INFO] [stderr] | |_________- help: try this: `if ret_value.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `BitOrAssign` impl [INFO] [stderr] --> src/sync/pipeline.rs:143:45 [INFO] [stderr] | [INFO] [stderr] 143 | self.$elem = self.$elem || rhs.$elem; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 150 | / access_flags!{ [INFO] [stderr] 151 | | indirect_command_read => vk::ACCESS_INDIRECT_COMMAND_READ_BIT, [INFO] [stderr] 152 | | index_read => vk::ACCESS_INDEX_READ_BIT, [INFO] [stderr] 153 | | vertex_attribute_read => vk::ACCESS_VERTEX_ATTRIBUTE_READ_BIT, [INFO] [stderr] ... | [INFO] [stderr] 167 | | memory_write => vk::ACCESS_MEMORY_WRITE_BIT, [INFO] [stderr] 168 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/command_buffer/sys.rs:665:5 [INFO] [stderr] | [INFO] [stderr] 665 | / pub unsafe fn blit_image(&mut self, source: &S, source_layout: ImageLayout, [INFO] [stderr] 666 | | destination: &D, destination_layout: ImageLayout, regions: R, [INFO] [stderr] 667 | | filter: Filter) [INFO] [stderr] 668 | | where S: ?Sized + ImageAccess, [INFO] [stderr] ... | [INFO] [stderr] 763 | | filter as u32); [INFO] [stderr] 764 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `vulkano`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/command_buffer/sys.rs:1341:23 [INFO] [stderr] | [INFO] [stderr] 1341 | debug_assert!(line_width == 1.0 || self.device().enabled_features().wide_lines); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(line_width - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/command_buffer/sys.rs:1341:23 [INFO] [stderr] | [INFO] [stderr] 1341 | debug_assert!(line_width == 1.0 || self.device().enabled_features().wide_lines); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command_buffer/sys.rs:1380:22 [INFO] [stderr] | [INFO] [stderr] 1380 | .map(|v| v.clone().into_vulkan_rect()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/command_buffer/sys.rs:1387:47 [INFO] [stderr] | [INFO] [stderr] 1387 | debug_assert!(scissors.iter().all(|s| { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 1388 | | s.extent.width < i32::max_value() as u32 && s.extent.height < i32::max_value() as u32 && [INFO] [stderr] 1389 | | s.offset.x.checked_add(s.extent.width as i32).is_some() && [INFO] [stderr] 1390 | | s.offset.y.checked_add(s.extent.height as i32).is_some() [INFO] [stderr] 1391 | | })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::sys::UnsafeCommandBufferBuilderBindVertexBuffer` [INFO] [stderr] --> src/command_buffer/sys.rs:1565:5 [INFO] [stderr] | [INFO] [stderr] 1565 | / pub fn new() -> UnsafeCommandBufferBuilderBindVertexBuffer { [INFO] [stderr] 1566 | | UnsafeCommandBufferBuilderBindVertexBuffer { [INFO] [stderr] 1567 | | raw_buffers: SmallVec::new(), [INFO] [stderr] 1568 | | offsets: SmallVec::new(), [INFO] [stderr] 1569 | | } [INFO] [stderr] 1570 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1555 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::sys::UnsafeCommandBufferBuilderExecuteCommands` [INFO] [stderr] --> src/command_buffer/sys.rs:1593:5 [INFO] [stderr] | [INFO] [stderr] 1593 | / pub fn new() -> UnsafeCommandBufferBuilderExecuteCommands { [INFO] [stderr] 1594 | | UnsafeCommandBufferBuilderExecuteCommands { raw_cbs: SmallVec::new() } [INFO] [stderr] 1595 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1585 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command_buffer/sys.rs:1622:30 [INFO] [stderr] | [INFO] [stderr] 1622 | pub(crate) fn to_vk_bits(&self) -> vk::ImageAspectFlagBits { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::sys::UnsafeCommandBufferBuilderPipelineBarrier` [INFO] [stderr] --> src/command_buffer/sys.rs:1714:5 [INFO] [stderr] | [INFO] [stderr] 1714 | / pub fn new() -> UnsafeCommandBufferBuilderPipelineBarrier { [INFO] [stderr] 1715 | | UnsafeCommandBufferBuilderPipelineBarrier { [INFO] [stderr] 1716 | | src_stage_mask: 0, [INFO] [stderr] 1717 | | dst_stage_mask: 0, [INFO] [stderr] ... | [INFO] [stderr] 1722 | | } [INFO] [stderr] 1723 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1702 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/command_buffer/sys.rs:1810:5 [INFO] [stderr] | [INFO] [stderr] 1810 | / pub unsafe fn add_buffer_memory_barrier(&mut self, buffer: &B, source_stage: PipelineStages, [INFO] [stderr] 1811 | | source_access: AccessFlagBits, [INFO] [stderr] 1812 | | destination_stage: PipelineStages, [INFO] [stderr] 1813 | | destination_access: AccessFlagBits, by_region: bool, [INFO] [stderr] ... | [INFO] [stderr] 1846 | | }); [INFO] [stderr] 1847 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/command_buffer/sys.rs:1866:5 [INFO] [stderr] | [INFO] [stderr] 1866 | / pub unsafe fn add_image_memory_barrier(&mut self, image: &I, mipmaps: Range, [INFO] [stderr] 1867 | | layers: Range, source_stage: PipelineStages, [INFO] [stderr] 1868 | | source_access: AccessFlagBits, [INFO] [stderr] 1869 | | destination_stage: PipelineStages, [INFO] [stderr] ... | [INFO] [stderr] 1926 | | }); [INFO] [stderr] 1927 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/command_buffer/validity/blit_image.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn check_blit_image(device: &Device, source: &S, source_top_left: [i32; 3], [INFO] [stderr] 29 | | source_bottom_right: [i32; 3], source_base_array_layer: u32, [INFO] [stderr] 30 | | source_mip_level: u32, destination: &D, [INFO] [stderr] 31 | | destination_top_left: [i32; 3], destination_bottom_right: [i32; 3], [INFO] [stderr] ... | [INFO] [stderr] 203 | | Ok(()) [INFO] [stderr] 204 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/command_buffer/validity/copy_image.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn check_copy_image(device: &Device, source: &S, source_offset: [i32; 3], [INFO] [stderr] 29 | | source_base_array_layer: u32, source_mip_level: u32, [INFO] [stderr] 30 | | destination: &D, destination_offset: [i32; 3], [INFO] [stderr] 31 | | destination_base_array_layer: u32, destination_mip_level: u32, [INFO] [stderr] ... | [INFO] [stderr] 163 | | Ok(()) [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/command_buffer/validity/copy_image_buffer.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn check_copy_buffer_image(device: &Device, buffer: &B, image: &I, [INFO] [stderr] 38 | | ty: CheckCopyBufferImageTy, image_offset: [u32; 3], [INFO] [stderr] 39 | | image_size: [u32; 3], image_first_layer: u32, [INFO] [stderr] 40 | | image_num_layers: u32, image_mipmap: u32) [INFO] [stderr] ... | [INFO] [stderr] 113 | | Ok(()) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if value != 1.0 && !pipeline.device().enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(value - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/command_buffer/validity/dynamic_state.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if value != 1.0 && !pipeline.device().enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/command_buffer/validity/fill_buffer.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / assert_should_panic!({ [INFO] [stderr] 97 | | let _ = check_fill_buffer(&dev2, &buffer); [INFO] [stderr] 98 | | }); [INFO] [stderr] | |_________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = check_fill_buffer(&dev2, &buffer); [INFO] [stderr] 96 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/command_buffer/validity/index_buffer.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / assert_should_panic!({ [INFO] [stderr] 132 | | let _ = check_index_buffer(&dev2, &buffer); [INFO] [stderr] 133 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = check_index_buffer(&dev2, &buffer); [INFO] [stderr] 96 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/command_buffer/validity/update_buffer.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / assert_should_panic!({ [INFO] [stderr] 160 | | let _ = check_update_buffer(&dev2, &buffer, &0); [INFO] [stderr] 161 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = check_update_buffer(&dev2, &buffer, &0); [INFO] [stderr] 96 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/command_buffer/auto.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | / pub fn copy_image(mut self, source: S, source_offset: [i32; 3], [INFO] [stderr] 591 | | source_base_array_layer: u32, source_mip_level: u32, [INFO] [stderr] 592 | | destination: D, destination_offset: [i32; 3], [INFO] [stderr] 593 | | destination_base_array_layer: u32, destination_mip_level: u32, [INFO] [stderr] ... | [INFO] [stderr] 641 | | } [INFO] [stderr] 642 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/command_buffer/auto.rs:675:5 [INFO] [stderr] | [INFO] [stderr] 675 | / pub fn blit_image(mut self, source: S, source_top_left: [i32; 3], [INFO] [stderr] 676 | | source_bottom_right: [i32; 3], source_base_array_layer: u32, [INFO] [stderr] 677 | | source_mip_level: u32, destination: D, destination_top_left: [i32; 3], [INFO] [stderr] 678 | | destination_bottom_right: [i32; 3], destination_base_array_layer: u32, [INFO] [stderr] ... | [INFO] [stderr] 735 | | } [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/auto.rs:837:5 [INFO] [stderr] | [INFO] [stderr] 837 | / pub fn copy_buffer_to_image_dimensions(mut self, source: S, destination: D, [INFO] [stderr] 838 | | offset: [u32; 3], size: [u32; 3], [INFO] [stderr] 839 | | first_layer: u32, num_layers: u32, mipmap: u32) [INFO] [stderr] 840 | | -> Result [INFO] [stderr] ... | [INFO] [stderr] 884 | | } [INFO] [stderr] 885 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/auto.rs:901:5 [INFO] [stderr] | [INFO] [stderr] 901 | / pub fn copy_image_to_buffer_dimensions(mut self, source: S, destination: D, [INFO] [stderr] 902 | | offset: [u32; 3], size: [u32; 3], [INFO] [stderr] 903 | | first_layer: u32, num_layers: u32, mipmap: u32) [INFO] [stderr] 904 | | -> Result [INFO] [stderr] ... | [INFO] [stderr] 944 | | } [INFO] [stderr] 945 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/command_buffer/auto.rs:1150:5 [INFO] [stderr] | [INFO] [stderr] 1150 | / pub fn draw_indexed_indirect(mut self, pipeline: Gp, dynamic: &DynamicState, [INFO] [stderr] 1151 | | vertex_buffer: V, index_buffer: Ib, indirect_buffer: Inb, sets: S, constants: Pc) [INFO] [stderr] 1152 | | -> Result [INFO] [stderr] 1153 | | where Gp: GraphicsPipelineAbstract + VertexSource + Send + Sync + 'static + Clone, // TODO: meh for Clone [INFO] [stderr] ... | [INFO] [stderr] 1207 | | } [INFO] [stderr] 1208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/command_buffer/auto.rs:1371:42 [INFO] [stderr] | [INFO] [stderr] 1371 | let data = slice::from_raw_parts((&push_constants as *const Pc as *const u8) [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 1372 | | .offset(range.offset as isize), [INFO] [stderr] | |___________________________________________________________________________^ help: try: `(&push_constants as *const Pc as *const u8).add(range.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/command_buffer/auto.rs:1390:37 [INFO] [stderr] | [INFO] [stderr] 1390 | destination.set_viewport(0, viewports.iter().cloned().collect::>().into_iter()); // TODO: don't collect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/command_buffer/auto.rs:1394:36 [INFO] [stderr] | [INFO] [stderr] 1394 | destination.set_scissor(0, scissors.iter().cloned().collect::>().into_iter()); // TODO: don't collect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command_buffer::state_cacher::StateCacher` [INFO] [stderr] --> src/command_buffer/state_cacher.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> StateCacher { [INFO] [stderr] 63 | | StateCacher { [INFO] [stderr] 64 | | dynamic_state: DynamicState::none(), [INFO] [stderr] 65 | | compute_pipeline: 0, [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/command_buffer/state_cacher.rs:349:33 [INFO] [stderr] | [INFO] [stderr] 349 | first .. (self.last_diff + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first..=self.last_diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/command_buffer/traits.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | submitted: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/command_buffer/traits.rs:242:33 [INFO] [stderr] | [INFO] [stderr] 242 | let mut submitted = self.submitted.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/command_buffer/traits.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | if self.finished.swap(true, Ordering::SeqCst) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.finished.swap(true, Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:640:27 [INFO] [stderr] | [INFO] [stderr] 640 | pub fn is_superset_of(&self, other: &ShaderStages) -> Result<(), ShaderStagesSupersetError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:640:41 [INFO] [stderr] | [INFO] [stderr] 640 | pub fn is_superset_of(&self, other: &ShaderStages) -> Result<(), ShaderStagesSupersetError> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `ShaderStages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:656:23 [INFO] [stderr] | [INFO] [stderr] 656 | pub fn intersects(&self, other: &ShaderStages) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/descriptor.rs:656:37 [INFO] [stderr] | [INFO] [stderr] 656 | pub fn intersects(&self, other: &ShaderStages) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `ShaderStages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn next(&mut self) -> FixedSizeDescriptorSetBuilder [INFO] [stderr] 117 | | where L: PipelineLayoutAbstract + Clone [INFO] [stderr] 118 | | { [INFO] [stderr] 119 | | let inner = PersistentDescriptorSet::start(self.pipeline_layout.clone(), self.set_id); [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:423:12 [INFO] [stderr] | [INFO] [stderr] 423 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/fixed_size_pool.rs:535:12 [INFO] [stderr] | [INFO] [stderr] 535 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:327:12 [INFO] [stderr] | [INFO] [stderr] 327 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/descriptor/descriptor_set/persistent.rs:649:12 [INFO] [stderr] | [INFO] [stderr] 649 | -> Result), PersistentDescriptorSetSampler)>, PersistentDescriptorSetError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/descriptor/descriptor_set/std_pool.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | if !(pool.remaining_capacity >= *layout.descriptors_count()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/descriptor/descriptor_set/std_pool.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | let count = layout.descriptors_count().clone() * 40; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*layout.descriptors_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:705:30 [INFO] [stderr] | [INFO] [stderr] 705 | Some(off) => image_descriptors.as_ptr().offset(off as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_descriptors.as_ptr().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:710:30 [INFO] [stderr] | [INFO] [stderr] 710 | Some(off) => buffer_descriptors.as_ptr().offset(off as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer_descriptors.as_ptr().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:715:30 [INFO] [stderr] | [INFO] [stderr] 715 | Some(off) => buffer_views_descriptors.as_ptr().offset(off as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer_views_descriptors.as_ptr().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:842:33 [INFO] [stderr] | [INFO] [stderr] 842 | pub fn uniform_texel_buffer<'a, F, B>(binding: u32, array_element: u32, view: &BufferView) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/descriptor/descriptor_set/sys.rs:856:33 [INFO] [stderr] | [INFO] [stderr] 856 | pub fn storage_texel_buffer<'a, F, B>(binding: u32, array_element: u32, view: &BufferView) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor/pipeline_layout/limits_check.rs:439:47 [INFO] [stderr] | [INFO] [stderr] 439 | fn increment(&mut self, num: u32, stages: &ShaderStages) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `ShaderStages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | .or(self.b.provided_set_layout(set)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.b.provided_set_layout(set))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/descriptor/pipeline_layout/union.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / (self.a.num_push_constants_ranges() ..) [INFO] [stderr] 80 | | .filter(|&n| self.push_constants_range(n).is_none()) [INFO] [stderr] 81 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|&n| self.push_constants_range(n).is_none()).next()` with `find(|&n| self.push_constants_range(n).is_none())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:591:38 [INFO] [stderr] | [INFO] [stderr] 591 | queue: Mutex::new(output), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:694:5 [INFO] [stderr] | [INFO] [stderr] 694 | queue: Mutex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:736:25 [INFO] [stderr] | [INFO] [stderr] 736 | let queue = self.queue.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/device/mod.rs:755:9 [INFO] [stderr] | [INFO] [stderr] 755 | self.queue.lock().unwrap() [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/device/mod.rs:783:22 [INFO] [stderr] | [INFO] [stderr] 783 | let queues = (0 .. family.queues_count() + 1).map(|_| (family, 1.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=family.queues_count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format.rs:782:36 [INFO] [stderr] | [INFO] [stderr] 782 | pub fn is_depth_and_or_stencil(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / (&self) [INFO] [stderr] 133 | | .subpass_descs() [INFO] [stderr] 134 | | .skip(subpass as usize) [INFO] [stderr] 135 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / (&self) [INFO] [stderr] 144 | | .subpass_descs() [INFO] [stderr] 145 | | .skip(subpass as usize) [INFO] [stderr] 146 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/framebuffer/desc.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | .chain(p.depth_stencil.clone().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `p.depth_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:153:37 [INFO] [stderr] | [INFO] [stderr] 153 | .filter_map(|a| (&self).attachment_descs().skip(a.0).next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / (&self) [INFO] [stderr] 164 | | .subpass_descs() [INFO] [stderr] 165 | | .skip(subpass as usize) [INFO] [stderr] 166 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 174 | | .attachment_descs() [INFO] [stderr] 175 | | .skip(atch_num) [INFO] [stderr] 176 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | / (&self) [INFO] [stderr] 192 | | .subpass_descs() [INFO] [stderr] 193 | | .skip(subpass as usize) [INFO] [stderr] 194 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:201:23 [INFO] [stderr] | [INFO] [stderr] 201 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 202 | | .attachment_descs() [INFO] [stderr] 203 | | .skip(atch_num) [INFO] [stderr] 204 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | / (&self) [INFO] [stderr] 221 | | .subpass_descs() [INFO] [stderr] 222 | | .skip(subpass as usize) [INFO] [stderr] 223 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:235:23 [INFO] [stderr] | [INFO] [stderr] 235 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 236 | | .attachment_descs() [INFO] [stderr] 237 | | .skip(atch_num) [INFO] [stderr] 238 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | / (&self) [INFO] [stderr] 254 | | .subpass_descs() [INFO] [stderr] 255 | | .skip(subpass as usize) [INFO] [stderr] 256 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:263:23 [INFO] [stderr] | [INFO] [stderr] 263 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 264 | | .attachment_descs() [INFO] [stderr] 265 | | .skip(atch_num) [INFO] [stderr] 266 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / (&self) [INFO] [stderr] 283 | | .subpass_descs() [INFO] [stderr] 284 | | .skip(subpass as usize) [INFO] [stderr] 285 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/desc.rs:297:23 [INFO] [stderr] | [INFO] [stderr] 297 | match (&self) [INFO] [stderr] | _______________________^ [INFO] [stderr] 298 | | .attachment_descs() [INFO] [stderr] 299 | | .skip(atch_num) [INFO] [stderr] 300 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/framebuffer/framebuffer.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / pub fn add(self, attachment: T) [INFO] [stderr] 161 | | -> Result, FramebufferCreationError> [INFO] [stderr] 162 | | where T: ImageViewAccess [INFO] [stderr] 163 | | { [INFO] [stderr] ... | [INFO] [stderr] 233 | | }) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/framebuffer/sys.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | attachment)| { [INFO] [stderr] | ________________________^ [INFO] [stderr] 75 | | if attachment.load != LoadOp::Clear { [INFO] [stderr] 76 | | return true; [INFO] [stderr] 77 | | } [INFO] [stderr] ... | [INFO] [stderr] 101 | | true [INFO] [stderr] 102 | | })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/framebuffer/sys.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | if p.color_attachments [INFO] [stderr] | ____________________^ [INFO] [stderr] 81 | | .iter() [INFO] [stderr] 82 | | .find(|&&(a, _)| a == atch_num) [INFO] [stderr] 83 | | .is_some() [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&(a, _)| a == atch_num).is_some()` with `any(|&&(a, _)| a == atch_num)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/framebuffer/sys.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | if p.input_attachments [INFO] [stderr] | ____________________^ [INFO] [stderr] 93 | | .iter() [INFO] [stderr] 94 | | .find(|&&(a, _)| a == atch_num) [INFO] [stderr] 95 | | .is_some() [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&(a, _)| a == atch_num).is_some()` with `any(|&&(a, _)| a == atch_num)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/framebuffer/sys.rs:146:53 [INFO] [stderr] | [INFO] [stderr] 146 | .all(|(r, c)| { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 147 | | attachments[r.0].format == attachments[c.0].format [INFO] [stderr] 148 | | })); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/framebuffer/sys.rs:155:49 [INFO] [stderr] | [INFO] [stderr] 155 | .all(|(a, _)| { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 156 | | pass.preserve_attachments [INFO] [stderr] 157 | | .iter() [INFO] [stderr] 158 | | .find(|&&b| a == b) [INFO] [stderr] 159 | | .is_none() [INFO] [stderr] 160 | | })); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/framebuffer/sys.rs:152:42 [INFO] [stderr] | [INFO] [stderr] 152 | .chain(pass.depth_stencil.clone().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pass.depth_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/framebuffer/sys.rs:165:32 [INFO] [stderr] | [INFO] [stderr] 165 | .chain(pass.depth_stencil.clone().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pass.depth_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | let color_attachments = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:244:41 [INFO] [stderr] | [INFO] [stderr] 244 | let input_attachments = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:246:43 [INFO] [stderr] | [INFO] [stderr] 246 | let resolve_attachments = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:249:29 [INFO] [stderr] | [INFO] [stderr] 249 | let a = attachment_references.as_ptr().offset(ref_index as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attachment_references.as_ptr().add(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/framebuffer/sys.rs:256:44 [INFO] [stderr] | [INFO] [stderr] 256 | let preserve_attachments = preserve_attachments_references [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 257 | | .as_ptr() [INFO] [stderr] 258 | | .offset(preserve_ref_index as isize); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 256 | let preserve_attachments = preserve_attachments_references [INFO] [stderr] 257 | .as_ptr().add(preserve_ref_index); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/traits.rs:173:32 [INFO] [stderr] | [INFO] [stderr] 173 | let pass_descr = match RenderPassDesc::subpass_descs(self) [INFO] [stderr] | ________________________________^ [INFO] [stderr] 174 | | .skip(subpass as usize) [INFO] [stderr] 175 | | .next() { [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/framebuffer/traits.rs:187:39 [INFO] [stderr] | [INFO] [stderr] 187 | let attachment_desc = (&self) [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 188 | | .attachment_descs() [INFO] [stderr] 189 | | .skip(attachment_id) [INFO] [stderr] 190 | | .next() [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/image/sys.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | pub unsafe fn new<'a, Mi, I>(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/image/sys.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub unsafe fn new<'a, Mi, I>(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] 83 | | dimensions: ImageDimensions, num_samples: u32, mipmaps: Mi, [INFO] [stderr] 84 | | sharing: Sharing, linear_tiling: bool, [INFO] [stderr] 85 | | preinitialized_layout: bool) [INFO] [stderr] ... | [INFO] [stderr] 103 | | preinitialized_layout) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/image/sys.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / unsafe fn new_impl(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] 108 | | dimensions: ImageDimensions, num_samples: u32, mipmaps: MipmapsCount, [INFO] [stderr] 109 | | (sh_mode, sh_indices): (vk::SharingMode, SmallVec<[u32; 8]>), [INFO] [stderr] 110 | | linear_tiling: bool, preinitialized_layout: bool) [INFO] [stderr] ... | [INFO] [stderr] 556 | | Ok((image, mem_reqs)) [INFO] [stderr] 557 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/image/sys.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / unsafe fn new_impl(device: Arc, usage: ImageUsage, format: Format, [INFO] [stderr] 108 | | dimensions: ImageDimensions, num_samples: u32, mipmaps: MipmapsCount, [INFO] [stderr] 109 | | (sh_mode, sh_indices): (vk::SharingMode, SmallVec<[u32; 8]>), [INFO] [stderr] 110 | | linear_tiling: bool, preinitialized_layout: bool) [INFO] [stderr] ... | [INFO] [stderr] 556 | | Ok((image, mem_reqs)) [INFO] [stderr] 557 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/image/sys.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | ..usage.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/image/sys.rs:195:29 [INFO] [stderr] | [INFO] [stderr] 195 | let mipmaps = match mipmaps.into() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `mipmaps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/image/sys.rs:202:49 [INFO] [stderr] | [INFO] [stderr] 202 | valid_range: 1 .. max_mipmaps + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=max_mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/image/sys.rs:207:64 [INFO] [stderr] | [INFO] [stderr] 207 | valid_range: 1 .. max_mipmaps + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=max_mipmaps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/image/sys.rs:221:50 [INFO] [stderr] | [INFO] [stderr] 221 | } else if !num_samples.is_power_of_two() { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 222 | | return Err(ImageCreationError::UnsupportedSamplesCount { obtained: num_samples }); [INFO] [stderr] 223 | | [INFO] [stderr] 224 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/image/sys.rs:218:29 [INFO] [stderr] | [INFO] [stderr] 218 | if num_samples == 0 { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 219 | | return Err(ImageCreationError::UnsupportedSamplesCount { obtained: num_samples }); [INFO] [stderr] 220 | | [INFO] [stderr] 221 | | } else if !num_samples.is_power_of_two() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image/usage.rs:97:33 [INFO] [stderr] | [INFO] [stderr] 97 | pub(crate) fn to_usage_bits(&self) -> vk::ImageUsageFlagBits { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/instance/debug.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | let user_callback: &Box = &*user_callback; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `&Fn(&Message)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instance/loader.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / match DEFAULT_LOADER.deref() { [INFO] [stderr] 212 | | &Ok(ref ptr) => Ok(ptr), [INFO] [stderr] 213 | | &Err(ref err) => Err(err.clone()), [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 211 | match *DEFAULT_LOADER.deref() { [INFO] [stderr] 212 | Ok(ref ptr) => Ok(ptr), [INFO] [stderr] 213 | Err(ref err) => Err(err.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instance/instance.rs:1058:13 [INFO] [stderr] | [INFO] [stderr] 1058 | let ref granularity = self.physical_device.infos().queue_families[self.id as usize] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1058 | let granularity = &self.physical_device.infos().queue_families[self.id as usize] [INFO] [stderr] 1059 | .minImageTransferGranularity; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/instance/layers.rs:257:29 [INFO] [stderr] | [INFO] [stderr] 257 | while let Some(_) = list.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in list { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/memory/device_memory.rs:537:9 [INFO] [stderr] | [INFO] [stderr] 537 | / assert_should_panic!({ [INFO] [stderr] 538 | | let _ = DeviceMemory::alloc(device.clone(), mem_ty, 0); [INFO] [stderr] 539 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = DeviceMemory::alloc(device.clone(), mem_ty, 0); [INFO] [stderr] 96 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/memory/device_memory.rs:546:22 [INFO] [stderr] | [INFO] [stderr] 546 | let mem_ty = device [INFO] [stderr] | ______________________^ [INFO] [stderr] 547 | | .physical_device() [INFO] [stderr] 548 | | .memory_types() [INFO] [stderr] 549 | | .filter(|m| !m.is_lazily_allocated()) [INFO] [stderr] 550 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|m| !m.is_lazily_allocated()).next()` with `find(|m| !m.is_lazily_allocated())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/memory/device_memory.rs:563:22 [INFO] [stderr] | [INFO] [stderr] 563 | let mem_ty = device [INFO] [stderr] | ______________________^ [INFO] [stderr] 564 | | .physical_device() [INFO] [stderr] 565 | | .memory_types() [INFO] [stderr] 566 | | .filter(|m| !m.is_lazily_allocated()) [INFO] [stderr] 567 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|m| !m.is_lazily_allocated()).next()` with `find(|m| !m.is_lazily_allocated())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/memory/pool/host_visible.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | occupied: Mutex, Vec>)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/memory/pool/non_host_visible.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | occupied: Mutex, Vec>)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/memory/pool/pool.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | Mutex>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/memory/pool/pool.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match entry.get() { [INFO] [stderr] 69 | | &Pool::HostVisible(ref pool) => { [INFO] [stderr] 70 | | let alloc = StdHostVisibleMemoryTypePool::alloc(&pool, size, alignment)?; [INFO] [stderr] 71 | | let inner = StdMemoryPoolAllocInner::HostVisible(alloc); [INFO] [stderr] ... | [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *entry.get() { [INFO] [stderr] 69 | Pool::HostVisible(ref pool) => { [INFO] [stderr] 70 | let alloc = StdHostVisibleMemoryTypePool::alloc(&pool, size, alignment)?; [INFO] [stderr] 71 | let inner = StdMemoryPoolAllocInner::HostVisible(alloc); [INFO] [stderr] 72 | Ok(StdMemoryPoolAlloc { [INFO] [stderr] 73 | inner: inner, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/memory/pool/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / first_loop [INFO] [stderr] 111 | | .chain(second_loop) [INFO] [stderr] 112 | | .filter(|&(t, _)| (requirements.memory_type_bits & (1 << t.id())) != 0) [INFO] [stderr] 113 | | .filter(|&(t, rq)| filter(t) == rq) [INFO] [stderr] 114 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|&(t, rq)| filter(t) == rq).next()` with `find(|&(t, rq)| filter(t) == rq)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/memory/mod.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | fn ref_from_ptr<'a>(ptr: *mut c_void, size: usize) -> Option<*mut Self>; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/memory/mod.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | fn ref_from_ptr<'a>(ptr: *mut c_void, size: usize) -> Option<*mut T> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/memory/mod.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | fn ref_from_ptr<'a>(ptr: *mut c_void, size: usize) -> Option<*mut [T]> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/pipeline/compute_pipeline.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new( [INFO] [stderr] 59 | | device: Arc, shader: &Cs, specialization: &Cs::SpecializationConstants) [INFO] [stderr] 60 | | -> Result>, ComputePipelineCreationError> [INFO] [stderr] 61 | | where Cs::PipelineLayout: Clone, [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:212:43 [INFO] [stderr] | [INFO] [stderr] 212 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:245:43 [INFO] [stderr] | [INFO] [stderr] 245 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:272:43 [INFO] [stderr] | [INFO] [stderr] 272 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:295:47 [INFO] [stderr] | [INFO] [stderr] 295 | dynamic_buffers.into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / pub fn with_pipeline_layout(mut self, device: Arc, pipeline_layout: Pl) [INFO] [stderr] 309 | | -> Result, [INFO] [stderr] 310 | | GraphicsPipelineCreationError> [INFO] [stderr] 311 | | where Pl: PipelineLayoutAbstract [INFO] [stderr] ... | [INFO] [stderr] 1110 | | }) [INFO] [stderr] 1111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:588:31 [INFO] [stderr] | [INFO] [stderr] 588 | debug_assert!(binding_descriptions [INFO] [stderr] | _______________________________^ [INFO] [stderr] 589 | | .iter() [INFO] [stderr] 590 | | .find(|b| b.binding == binding) [INFO] [stderr] 591 | | .is_some()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|b| b.binding == binding).is_some()` with `any(|b| b.binding == binding)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:701:65 [INFO] [stderr] | [INFO] [stderr] 701 | .map(|e| e.1.clone().into_vulkan_rect()) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `e.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:775:16 [INFO] [stderr] | [INFO] [stderr] 775 | if line_width != 1.0 && !device.enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(line_width - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:775:16 [INFO] [stderr] | [INFO] [stderr] 775 | if line_width != 1.0 && !device.enabled_features().wide_lines { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1018:22 [INFO] [stderr] | [INFO] [stderr] 1018 | logicOp: self.blend.logic_op.unwrap_or(Default::default()) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.blend.logic_op.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pipeline/graphics_pipeline/builder.rs:1148:45 [INFO] [stderr] | [INFO] [stderr] 1148 | -> GraphicsPipelineBuilder, [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 1149 | | Vs, [INFO] [stderr] 1150 | | Vss, [INFO] [stderr] 1151 | | Tcs, [INFO] [stderr] ... | [INFO] [stderr] 1158 | | Fss, [INFO] [stderr] 1159 | | Rp> { [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pipeline/graphics_pipeline/mod.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn start<'a>() [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/pipeline/cache.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / assert_should_panic!({ [INFO] [stderr] 249 | | pipeline.merge(&[&pipeline]).unwrap(); [INFO] [stderr] 250 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | pipeline.merge(&[&pipeline]).unwrap(); [INFO] [stderr] 96 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pipeline/depth_stencil.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match self { [INFO] [stderr] 195 | | &DepthBounds::Dynamic => true, [INFO] [stderr] 196 | | _ => false, [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *self { [INFO] [stderr] 195 | DepthBounds::Dynamic => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pipeline/input_assembly.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn supports_primitive_restart(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/pipeline/shader.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | Self::from_ptr(device, spirv.as_ptr() as *const _, spirv.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pipeline/shader.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | pub fn matches(&self, input: PrimitiveTopology) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pipeline/vertex/bufferless.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | fn decode<'l>(&self, _: Vec) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::instance_buffer::SingleInstanceBufferDefinition` [INFO] [stderr] --> src/pipeline/vertex/instance_buffer.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> SingleInstanceBufferDefinition { [INFO] [stderr] 32 | | SingleInstanceBufferDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::one_one::OneVertexOneInstanceDefinition` [INFO] [stderr] --> src/pipeline/vertex/one_one.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> OneVertexOneInstanceDefinition { [INFO] [stderr] 32 | | OneVertexOneInstanceDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::single::SingleBufferDefinition` [INFO] [stderr] --> src/pipeline/vertex/single.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> SingleBufferDefinition { [INFO] [stderr] 32 | | SingleBufferDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pipeline::vertex::two::TwoBuffersDefinition` [INFO] [stderr] --> src/pipeline/vertex/two.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> TwoBuffersDefinition { [INFO] [stderr] 32 | | TwoBuffersDefinition(PhantomData) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pipeline/vertex/vertex.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn matches(&self, array_size: usize, format: Format, num_locs: u32) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/sampler.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new(device: Arc, mag_filter: Filter, min_filter: Filter, [INFO] [stderr] 170 | | mipmap_mode: MipmapMode, address_u: SamplerAddressMode, [INFO] [stderr] 171 | | address_v: SamplerAddressMode, address_w: SamplerAddressMode, mip_lod_bias: f32, [INFO] [stderr] 172 | | max_anisotropy: f32, min_lod: f32, max_lod: f32) [INFO] [stderr] ... | [INFO] [stderr] 185 | | None) [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/sampler.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn compare(device: Arc, mag_filter: Filter, min_filter: Filter, [INFO] [stderr] 206 | | mipmap_mode: MipmapMode, address_u: SamplerAddressMode, [INFO] [stderr] 207 | | address_v: SamplerAddressMode, address_w: SamplerAddressMode, [INFO] [stderr] 208 | | mip_lod_bias: f32, max_anisotropy: f32, min_lod: f32, max_lod: f32, [INFO] [stderr] ... | [INFO] [stderr] 222 | | Some(compare)) [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/sampler.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / fn new_impl(device: Arc, mag_filter: Filter, min_filter: Filter, [INFO] [stderr] 226 | | mipmap_mode: MipmapMode, address_u: SamplerAddressMode, [INFO] [stderr] 227 | | address_v: SamplerAddressMode, address_w: SamplerAddressMode, mip_lod_bias: f32, [INFO] [stderr] 228 | | max_anisotropy: f32, min_lod: f32, max_lod: f32, compare: Option) [INFO] [stderr] ... | [INFO] [stderr] 352 | | })) [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/sampler.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | / assert_should_panic!({ [INFO] [stderr] 814 | | let _ = sampler::Sampler::new(device, [INFO] [stderr] 815 | | sampler::Filter::Linear, [INFO] [stderr] 816 | | sampler::Filter::Linear, [INFO] [stderr] ... | [INFO] [stderr] 824 | | 2.0); [INFO] [stderr] 825 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = sampler::Sampler::new(device, [INFO] [stderr] 96 | sampler::Filter::Linear, [INFO] [stderr] 97 | sampler::Filter::Linear, [INFO] [stderr] 98 | sampler::MipmapMode::Nearest, [INFO] [stderr] 99 | sampler::SamplerAddressMode::Repeat, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/sampler.rs:832:9 [INFO] [stderr] | [INFO] [stderr] 832 | / assert_should_panic!({ [INFO] [stderr] 833 | | let _ = sampler::Sampler::new(device, [INFO] [stderr] 834 | | sampler::Filter::Linear, [INFO] [stderr] 835 | | sampler::Filter::Linear, [INFO] [stderr] ... | [INFO] [stderr] 843 | | 2.0); [INFO] [stderr] 844 | | }); [INFO] [stderr] | |________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = sampler::Sampler::new(device, [INFO] [stderr] 96 | sampler::Filter::Linear, [INFO] [stderr] 97 | sampler::Filter::Linear, [INFO] [stderr] 98 | sampler::MipmapMode::Nearest, [INFO] [stderr] 99 | sampler::SamplerAddressMode::Repeat, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match res { [INFO] [stderr] 95 | | Ok(_) => panic!("Test expected to panic but didn't"), [INFO] [stderr] 96 | | Err(_) => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/sampler.rs:854:9 [INFO] [stderr] | [INFO] [stderr] 854 | / assert_should_panic!({ [INFO] [stderr] 855 | | let _ = sampler::Sampler::new(device, [INFO] [stderr] 856 | | sampler::Filter::Linear, [INFO] [stderr] 857 | | sampler::Filter::Linear, [INFO] [stderr] ... | [INFO] [stderr] 865 | | 2.0); [INFO] [stderr] 866 | | }); [INFO] [stderr] | |___________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | if let Ok(_) = res { assert_should_panic!({ [INFO] [stderr] 95 | let _ = sampler::Sampler::new(device, [INFO] [stderr] 96 | sampler::Filter::Linear, [INFO] [stderr] 97 | sampler::Filter::Linear, [INFO] [stderr] 98 | sampler::MipmapMode::Nearest, [INFO] [stderr] 99 | sampler::SamplerAddressMode::ClampToBorder(b1), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn supports(&self, mode: PresentMode) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn iter(&self) -> SupportedPresentModesIter { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/capabilities.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | SupportedPresentModesIter(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn supports(&self, value: CompositeAlpha) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/swapchain/capabilities.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | pub fn iter(&self) -> SupportedCompositeAlphaIter { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/capabilities.rs:281:37 [INFO] [stderr] | [INFO] [stderr] 281 | SupportedCompositeAlphaIter(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/capabilities.rs:409:40 [INFO] [stderr] | [INFO] [stderr] 409 | SupportedSurfaceTransformsIter(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/swapchain/display.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / self.supported_displays [INFO] [stderr] 145 | | .iter() [INFO] [stderr] 146 | | .find(|&&d| d == display.internal_object()) [INFO] [stderr] 147 | | .is_some() [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&d| d == display.internal_object()).is_some()` with `any(|&&d| d == display.internal_object())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/swapchain/display.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | let ref r = self.properties.physicalDimensions; [INFO] [stderr] | ----^^^^^-------------------------------------- help: try: `let r = &self.properties.physicalDimensions;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/swapchain/display.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | let ref r = self.properties.physicalResolution; [INFO] [stderr] | ----^^^^^-------------------------------------- help: try: `let r = &self.properties.physicalResolution;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/swapchain/display.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | let ref d = self.parameters.visibleRegion; [INFO] [stderr] | ----^^^^^--------------------------------- help: try: `let d = &self.parameters.visibleRegion;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/swapchain/surface.rs:520:31 [INFO] [stderr] | [INFO] [stderr] 520 | debug_assert!(modes [INFO] [stderr] | _______________________________^ [INFO] [stderr] 521 | | .iter() [INFO] [stderr] 522 | | .find(|&&m| m == vk::PRESENT_MODE_FIFO_KHR) [INFO] [stderr] 523 | | .is_some()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&m| m == vk::PRESENT_MODE_FIFO_KHR).is_some()` with `any(|&&m| m == vk::PRESENT_MODE_FIFO_KHR)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/swapchain/swapchain.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | let stale = swapchain.stale.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/swapchain/swapchain.rs:229:12 [INFO] [stderr] | [INFO] [stderr] 229 | -> Result<(Arc>, Vec>>), SwapchainCreationError> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/swapchain/swapchain.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / pub fn new( [INFO] [stderr] 225 | | device: Arc, surface: Arc>, num_images: u32, format: F, [INFO] [stderr] 226 | | dimensions: [u32; 2], layers: u32, usage: ImageUsage, sharing: S, [INFO] [stderr] 227 | | transform: SurfaceTransform, alpha: CompositeAlpha, mode: PresentMode, clipped: bool, [INFO] [stderr] ... | [INFO] [stderr] 246 | | old_swapchain.map(|s| &**s)) [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/swapchain/swapchain.rs:252:12 [INFO] [stderr] | [INFO] [stderr] 252 | -> Result<(Arc>, Vec>>), SwapchainCreationError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/swapchain/swapchain.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | -> Result<(Arc>, Vec>>), SwapchainCreationError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/swapchain/swapchain.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | / fn new_inner(device: Arc, surface: Arc>, num_images: u32, format: Format, [INFO] [stderr] 270 | | color_space: ColorSpace, dimensions: [u32; 2], layers: u32, usage: ImageUsage, [INFO] [stderr] 271 | | sharing: SharingMode, transform: SurfaceTransform, alpha: CompositeAlpha, [INFO] [stderr] 272 | | mode: PresentMode, clipped: bool, old_swapchain: Option<&Swapchain>) [INFO] [stderr] ... | [INFO] [stderr] 478 | | Ok((swapchain, swapchain_images)) [INFO] [stderr] 479 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/swapchain/swapchain.rs:347:29 [INFO] [stderr] | [INFO] [stderr] 347 | let mut stale = old_swapchain.stale.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/swapchain/swapchain.rs:456:45 [INFO] [stderr] | [INFO] [stderr] 456 | stale: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/swapchain/swapchain.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | usage: usage.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/swapchain/swapchain.rs:999:21 [INFO] [stderr] | [INFO] [stderr] 999 | let queue = self.previous.queue().map(|q| q.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.previous.queue().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/swapchain/swapchain.rs:1131:17 [INFO] [stderr] | [INFO] [stderr] 1131 | / match self.flush() { [INFO] [stderr] 1132 | | Ok(()) => { [INFO] [stderr] 1133 | | // Block until the queue finished. [INFO] [stderr] 1134 | | self.queue().unwrap().wait().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 1140 | | }, [INFO] [stderr] 1141 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1131 | if let Ok(()) = self.flush() { [INFO] [stderr] 1132 | // Block until the queue finished. [INFO] [stderr] 1133 | self.queue().unwrap().wait().unwrap(); [INFO] [stderr] 1134 | self.previous.signal_finished(); [INFO] [stderr] 1135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/swapchain/swapchain.rs:1168:29 [INFO] [stderr] | [INFO] [stderr] 1168 | .saturating_add(timeout.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sync/fence.rs:163:37 [INFO] [stderr] | [INFO] [stderr] 163 | .saturating_add(timeout.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sync/fence.rs:221:33 [INFO] [stderr] | [INFO] [stderr] 221 | .saturating_add(timeout.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sync/future/fence_signal.rs:368:17 [INFO] [stderr] | [INFO] [stderr] 368 | / if state.get_prev().is_some() { [INFO] [stderr] 369 | | false [INFO] [stderr] 370 | | } else { [INFO] [stderr] 371 | | true [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!state.get_prev().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/sync/future/join.rs:155:24 [INFO] [stderr] | [INFO] [stderr] 155 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync/future/semaphore_signal.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | wait_submitted: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync/future/semaphore_signal.rs:83:38 [INFO] [stderr] | [INFO] [stderr] 83 | let mut wait_submitted = self.wait_submitted.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/sync/future/semaphore_signal.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | debug_assert!(*self.wait_submitted.lock().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `BitOrAssign` impl [INFO] [stderr] --> src/sync/pipeline.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | self.$elem = self.$elem || rhs.$elem; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / pipeline_stages!{ [INFO] [stderr] 68 | | top_of_pipe => vk::PIPELINE_STAGE_TOP_OF_PIPE_BIT, [INFO] [stderr] 69 | | draw_indirect => vk::PIPELINE_STAGE_DRAW_INDIRECT_BIT, [INFO] [stderr] 70 | | vertex_input => vk::PIPELINE_STAGE_VERTEX_INPUT_BIT, [INFO] [stderr] ... | [INFO] [stderr] 84 | | all_commands => vk::PIPELINE_STAGE_ALL_COMMANDS_BIT, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `BitOrAssign` impl [INFO] [stderr] --> src/sync/pipeline.rs:60:45 [INFO] [stderr] | [INFO] [stderr] 60 | self.$elem = self.$elem || rhs.$elem; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 67 | / pipeline_stages!{ [INFO] [stderr] 68 | | top_of_pipe => vk::PIPELINE_STAGE_TOP_OF_PIPE_BIT, [INFO] [stderr] 69 | | draw_indirect => vk::PIPELINE_STAGE_DRAW_INDIRECT_BIT, [INFO] [stderr] 70 | | vertex_input => vk::PIPELINE_STAGE_VERTEX_INPUT_BIT, [INFO] [stderr] ... | [INFO] [stderr] 84 | | all_commands => vk::PIPELINE_STAGE_ALL_COMMANDS_BIT, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `BitOrAssign` impl [INFO] [stderr] --> src/sync/pipeline.rs:143:45 [INFO] [stderr] | [INFO] [stderr] 143 | self.$elem = self.$elem || rhs.$elem; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 150 | / access_flags!{ [INFO] [stderr] 151 | | indirect_command_read => vk::ACCESS_INDIRECT_COMMAND_READ_BIT, [INFO] [stderr] 152 | | index_read => vk::ACCESS_INDEX_READ_BIT, [INFO] [stderr] 153 | | vertex_attribute_read => vk::ACCESS_VERTEX_ATTRIBUTE_READ_BIT, [INFO] [stderr] ... | [INFO] [stderr] 167 | | memory_write => vk::ACCESS_MEMORY_WRITE_BIT, [INFO] [stderr] 168 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `vulkano`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "403b2525def065a3d55b9862035daef22182a5aec3660b9c6917dcf97c1ec699"` [INFO] running `"docker" "rm" "-f" "403b2525def065a3d55b9862035daef22182a5aec3660b9c6917dcf97c1ec699"` [INFO] [stdout] 403b2525def065a3d55b9862035daef22182a5aec3660b9c6917dcf97c1ec699