[INFO] crate vtf 0.1.1 is already in cache [INFO] extracting crate vtf 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/vtf/0.1.1 [INFO] extracting crate vtf 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vtf/0.1.1 [INFO] validating manifest of vtf-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vtf-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vtf-0.1.1 [INFO] finished frobbing vtf-0.1.1 [INFO] frobbed toml for vtf-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/vtf/0.1.1/Cargo.toml [INFO] started frobbing vtf-0.1.1 [INFO] finished frobbing vtf-0.1.1 [INFO] frobbed toml for vtf-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vtf/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vtf-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vtf/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 043d97de491a766b3b7a172e9f2bd5f3fe6c5db67df8e82146d1945d35c04193 [INFO] running `"docker" "start" "-a" "043d97de491a766b3b7a172e9f2bd5f3fe6c5db67df8e82146d1945d35c04193"` [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking vtf v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::iter::Iterator` [INFO] [stderr] --> src/vtf.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::iter::Iterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vtf.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | const VTF_SIGNATURE: u32 = 0x00465456; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0046_5456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/vtf.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(header.signature, VTF_SIGNATURE, "Specified data is not VTF file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vtf.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | header.lowres_image_width as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.lowres_image_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vtf.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | header.lowres_image_height as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.lowres_image_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/image.rs:16:88 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(header: VTFHeader, format: ImageFormat, width: u16, height: u16, bytes: &'a Vec) -> VTFImage<'a> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | let frame_size = self.format.frame_size(self.width as u32, self.height as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:27:68 [INFO] [stderr] | [INFO] [stderr] 27 | let frame_size = self.format.frame_size(self.width as u32, self.height as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `width * height` [INFO] [stderr] --> src/image.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | ImageFormat::I8 => width * height * 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | for i in (mip_level+1..(header.mipmap_count) as i32).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((header.mipmap_count))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | offset *= header.frames as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.frames)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | image_format.frame_size(mip_width as u32, mip_height as u32) * mip_depth as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(mip_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:47 [INFO] [stderr] | [INFO] [stderr] 38 | image_format.frame_size(mip_width as u32, mip_height as u32) * mip_depth as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(mip_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:68 [INFO] [stderr] | [INFO] [stderr] 38 | image_format.frame_size(mip_width as u32, mip_height as u32) * mip_depth as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(mip_depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::Iterator` [INFO] [stderr] --> src/vtf.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::iter::Iterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vtf.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | const VTF_SIGNATURE: u32 = 0x00465456; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0046_5456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/vtf.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(header.signature, VTF_SIGNATURE, "Specified data is not VTF file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vtf.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | header.lowres_image_width as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.lowres_image_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vtf.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | header.lowres_image_height as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.lowres_image_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/image.rs:16:88 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(header: VTFHeader, format: ImageFormat, width: u16, height: u16, bytes: &'a Vec) -> VTFImage<'a> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | let frame_size = self.format.frame_size(self.width as u32, self.height as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:27:68 [INFO] [stderr] | [INFO] [stderr] 27 | let frame_size = self.format.frame_size(self.width as u32, self.height as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `width * height` [INFO] [stderr] --> src/image.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | ImageFormat::I8 => width * height * 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | for i in (mip_level+1..(header.mipmap_count) as i32).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((header.mipmap_count))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | offset *= header.frames as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.frames)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | image_format.frame_size(mip_width as u32, mip_height as u32) * mip_depth as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(mip_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:47 [INFO] [stderr] | [INFO] [stderr] 38 | image_format.frame_size(mip_width as u32, mip_height as u32) * mip_depth as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(mip_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:68 [INFO] [stderr] | [INFO] [stderr] 38 | image_format.frame_size(mip_width as u32, mip_height as u32) * mip_depth as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(mip_depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/png.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | vtf.highres_image.width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vtf.highres_image.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/png.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | vtf.highres_image.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vtf.highres_image.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/png.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | vtf.highres_image.width as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vtf.highres_image.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/png.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | vtf.highres_image.height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vtf.highres_image.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.84s [INFO] running `"docker" "inspect" "043d97de491a766b3b7a172e9f2bd5f3fe6c5db67df8e82146d1945d35c04193"` [INFO] running `"docker" "rm" "-f" "043d97de491a766b3b7a172e9f2bd5f3fe6c5db67df8e82146d1945d35c04193"` [INFO] [stdout] 043d97de491a766b3b7a172e9f2bd5f3fe6c5db67df8e82146d1945d35c04193