[INFO] crate vtcol 0.42.2 is already in cache [INFO] extracting crate vtcol 0.42.2 into work/ex/clippy-test-run/sources/stable/reg/vtcol/0.42.2 [INFO] extracting crate vtcol 0.42.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vtcol/0.42.2 [INFO] validating manifest of vtcol-0.42.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vtcol-0.42.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vtcol-0.42.2 [INFO] finished frobbing vtcol-0.42.2 [INFO] frobbed toml for vtcol-0.42.2 written to work/ex/clippy-test-run/sources/stable/reg/vtcol/0.42.2/Cargo.toml [INFO] started frobbing vtcol-0.42.2 [INFO] finished frobbing vtcol-0.42.2 [INFO] frobbed toml for vtcol-0.42.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vtcol/0.42.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vtcol-0.42.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vtcol/0.42.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42d497f03c90b10698b4f680b140da2efc86a368b833379c4924c1f584614749 [INFO] running `"docker" "start" "-a" "42d497f03c90b10698b4f680b140da2efc86a368b833379c4924c1f584614749"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/vtcol.rs` was erroneously implicitly accepted for binary `vtcol`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking vtcol v0.42.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vtcol.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | this : this, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `this` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vtcol.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | scheme : scheme [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `scheme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vtcol.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | let b = self.colors[i + 2_usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/vtcol.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | write!(f, ")\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vtcol.rs:536:17 [INFO] [stderr] | [INFO] [stderr] 536 | let b = self.colors[i as usize + 2_usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/vtcol.rs:537:21 [INFO] [stderr] | [INFO] [stderr] 537 | let _ = write!(f, "{} => 0x{:02.X}{:02.X}{:02.X}\n", [INFO] [stderr] | _____________________^ [INFO] [stderr] 538 | | Color::of_value(i).to_string(), r, g, b); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vtcol.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | this : this, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `this` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vtcol.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | scheme : scheme [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `scheme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vtcol.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | let b = self.colors[i + 2_usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/vtcol.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | write!(f, ")\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/vtcol.rs:536:17 [INFO] [stderr] | [INFO] [stderr] 536 | let b = self.colors[i as usize + 2_usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/vtcol.rs:537:21 [INFO] [stderr] | [INFO] [stderr] 537 | let _ = write!(f, "{} => 0x{:02.X}{:02.X}{:02.X}\n", [INFO] [stderr] | _____________________^ [INFO] [stderr] 538 | | Color::of_value(i).to_string(), r, g, b); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vtcol.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | const PIO_CMAP : libc::c_int = 0x00004B71; /* kd.h */ [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4B71` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vtcol.rs:555:15 [INFO] [stderr] | [INFO] [stderr] 555 | -1 => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vtcol.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | return Some(fd) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(fd)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vtcol.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | const PIO_CMAP : libc::c_int = 0x00004B71; /* kd.h */ [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4B71` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vtcol.rs:555:15 [INFO] [stderr] | [INFO] [stderr] 555 | -1 => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vtcol.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | return Some(fd) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(fd)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/vtcol.rs:441:53 [INFO] [stderr] | [INFO] [stderr] 441 | let str_idx = unsafe { line.slice_unchecked(0_usize, off) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/vtcol.rs:441:53 [INFO] [stderr] | [INFO] [stderr] 441 | let str_idx = unsafe { line.slice_unchecked(0_usize, off) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/vtcol.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | pick_scheme <'b> (name : &String) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 216 | pick_scheme <'b> (name : &str) [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.as_str()` to [INFO] [stderr] | [INFO] [stderr] 219 | match name { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 226 | _any => Scheme::Custom (Some(name.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/vtcol.rs:216:18 [INFO] [stderr] | [INFO] [stderr] 216 | pick_scheme <'b> (name : &String) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/vtcol.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | usage (this : &String, opts: getopts::Options) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vtcol.rs:367:32 [INFO] [stderr] | [INFO] [stderr] 367 | '0' ... '9' => { chr - '0' as u8 }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vtcol.rs:368:32 [INFO] [stderr] | [INFO] [stderr] 368 | 'a' ... 'f' => { chr - 'a' as u8 + 10 }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vtcol.rs:369:32 [INFO] [stderr] | [INFO] [stderr] 369 | 'A' ... 'F' => { chr - 'A' as u8 + 10 }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `idx` [INFO] [stderr] --> src/vtcol.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | pal[idx + 0_usize] = r; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | idx = idx + 3_usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += 3_usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/vtcol.rs:444:25 [INFO] [stderr] | [INFO] [stderr] 444 | / match parse_res { [INFO] [stderr] 445 | | Ok(new_idx) => { [INFO] [stderr] 446 | | if new_idx < PALETTE_SIZE { pal_idx = new_idx * 3_usize; } [INFO] [stderr] 447 | | }, [INFO] [stderr] 448 | | _ => () [INFO] [stderr] 449 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 444 | if let Ok(new_idx) = parse_res { [INFO] [stderr] 445 | if new_idx < PALETTE_SIZE { pal_idx = new_idx * 3_usize; } [INFO] [stderr] 446 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pal_idx` [INFO] [stderr] --> src/vtcol.rs:458:25 [INFO] [stderr] | [INFO] [stderr] 458 | pal[pal_idx + 0_usize] = r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/vtcol.rs:471:24 [INFO] [stderr] | [INFO] [stderr] 471 | from_file (fname : &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/vtcol.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | pick_scheme <'b> (name : &String) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 216 | pick_scheme <'b> (name : &str) [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.as_str()` to [INFO] [stderr] | [INFO] [stderr] 219 | match name { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 226 | _any => Scheme::Custom (Some(name.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/vtcol.rs:216:18 [INFO] [stderr] | [INFO] [stderr] 216 | pick_scheme <'b> (name : &String) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/vtcol.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | usage (this : &String, opts: getopts::Options) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/vtcol.rs:514:33 [INFO] [stderr] | [INFO] [stderr] 514 | let r = self.colors[i + 0_usize]; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vtcol.rs:367:32 [INFO] [stderr] | [INFO] [stderr] 367 | '0' ... '9' => { chr - '0' as u8 }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vtcol.rs:368:32 [INFO] [stderr] | [INFO] [stderr] 368 | 'a' ... 'f' => { chr - 'a' as u8 + 10 }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vtcol.rs:369:32 [INFO] [stderr] | [INFO] [stderr] 369 | 'A' ... 'F' => { chr - 'A' as u8 + 10 }, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | i = i + 3_usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `i += 3_usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i as usize` [INFO] [stderr] --> src/vtcol.rs:534:33 [INFO] [stderr] | [INFO] [stderr] 534 | let r = self.colors[i as usize + 0_usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `idx` [INFO] [stderr] --> src/vtcol.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | pal[idx + 0_usize] = r; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | idx = idx + 3_usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += 3_usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | i = i + 3_u8; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `i += 3_u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vtcol.rs:568:38 [INFO] [stderr] | [INFO] [stderr] 568 | std::mem::transmute(&mut tty_type)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut tty_type as *mut i8 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/vtcol.rs:444:25 [INFO] [stderr] | [INFO] [stderr] 444 | / match parse_res { [INFO] [stderr] 445 | | Ok(new_idx) => { [INFO] [stderr] 446 | | if new_idx < PALETTE_SIZE { pal_idx = new_idx * 3_usize; } [INFO] [stderr] 447 | | }, [INFO] [stderr] 448 | | _ => () [INFO] [stderr] 449 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 444 | if let Ok(new_idx) = parse_res { [INFO] [stderr] 445 | if new_idx < PALETTE_SIZE { pal_idx = new_idx * 3_usize; } [INFO] [stderr] 446 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pal_idx` [INFO] [stderr] --> src/vtcol.rs:458:25 [INFO] [stderr] | [INFO] [stderr] 458 | pal[pal_idx + 0_usize] = r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/vtcol.rs:471:24 [INFO] [stderr] | [INFO] [stderr] 471 | from_file (fname : &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/vtcol.rs:600:38 [INFO] [stderr] | [INFO] [stderr] 600 | while let Some (&path) = it.next() [INFO] [stderr] | ^^^^^^^^^ help: try: `for &path in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/vtcol.rs:514:33 [INFO] [stderr] | [INFO] [stderr] 514 | let r = self.colors[i + 0_usize]; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | i = i + 3_usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `i += 3_usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i as usize` [INFO] [stderr] --> src/vtcol.rs:534:33 [INFO] [stderr] | [INFO] [stderr] 534 | let r = self.colors[i as usize + 0_usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vtcol.rs:654:37 [INFO] [stderr] | [INFO] [stderr] 654 | if unsafe { ioctl(fd, PIO_CMAP, std::mem::transmute(&mut pal)) } < 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut pal as *mut Palette as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vtcol.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | i = i + 3_u8; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `i += 3_u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vtcol.rs:568:38 [INFO] [stderr] | [INFO] [stderr] 568 | std::mem::transmute(&mut tty_type)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut tty_type as *mut i8 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/vtcol.rs:600:38 [INFO] [stderr] | [INFO] [stderr] 600 | while let Some (&path) = it.next() [INFO] [stderr] | ^^^^^^^^^ help: try: `for &path in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vtcol.rs:654:37 [INFO] [stderr] | [INFO] [stderr] 654 | if unsafe { ioctl(fd, PIO_CMAP, std::mem::transmute(&mut pal)) } < 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut pal as *mut Palette as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "42d497f03c90b10698b4f680b140da2efc86a368b833379c4924c1f584614749"` [INFO] running `"docker" "rm" "-f" "42d497f03c90b10698b4f680b140da2efc86a368b833379c4924c1f584614749"` [INFO] [stdout] 42d497f03c90b10698b4f680b140da2efc86a368b833379c4924c1f584614749