[INFO] crate voxel_worldgen 0.1.0 is already in cache [INFO] extracting crate voxel_worldgen 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/voxel_worldgen/0.1.0 [INFO] extracting crate voxel_worldgen 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voxel_worldgen/0.1.0 [INFO] validating manifest of voxel_worldgen-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of voxel_worldgen-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing voxel_worldgen-0.1.0 [INFO] finished frobbing voxel_worldgen-0.1.0 [INFO] frobbed toml for voxel_worldgen-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/voxel_worldgen/0.1.0/Cargo.toml [INFO] started frobbing voxel_worldgen-0.1.0 [INFO] finished frobbing voxel_worldgen-0.1.0 [INFO] frobbed toml for voxel_worldgen-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voxel_worldgen/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting voxel_worldgen-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/voxel_worldgen/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bea039cca691cefb59be92f835be695318c49f64a54a93bf188ca443003d1cea [INFO] running `"docker" "start" "-a" "bea039cca691cefb59be92f835be695318c49f64a54a93bf188ca443003d1cea"` [INFO] [stderr] Checking nalgebra v0.5.1 [INFO] [stderr] Checking noise v0.2.0 [INFO] [stderr] Checking voxel_worldgen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/lcg.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | base_seed: base_seed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_island.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_island.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | island_chance: island_chance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `island_chance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_zoom.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_zoom.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_zoom.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | zoom_type: zoom_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zoom_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simplex.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simplex.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | noise_type: noise_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `noise_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simplex.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | fun: fun [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | fun: fun, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fun: fun, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | source1: source1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `source1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | source2: source2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `source2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rnd/simplex_octaves.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | octaves: octaves, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `octaves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/lcg.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | base_seed: base_seed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_island.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_island.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | island_chance: island_chance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `island_chance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_zoom.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_zoom.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_zoom.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | zoom_type: zoom_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zoom_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simplex.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simplex.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | noise_type: noise_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `noise_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simplex.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | fun: fun [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | fun: fun, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fun: fun, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | source1: source1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `source1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/layer/layer_simple_fn.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | source2: source2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `source2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rnd/simplex_octaves.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | octaves: octaves, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `octaves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/unit.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `6.523_029_87e-01` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.729_034_89e+01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.121_222_37e+00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `2.770_987_05e+01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `6.834_479_08e-01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.384_104_86e+01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.549_702_18e-01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:55 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `4.017_387_91e-01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `3.722_745_65e-03` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `2.290_258_65e+00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `4.935_431_17e-03` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layer/lcg.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | const LCG_MULT: i64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layer/lcg.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | const LCG_ADD: i64 = 1442695040888963407; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Rand` [INFO] [stderr] --> src/generators/vanilla/mod.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | use ::rand::{ Rng, Rand }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `chunk_data_idx`, `height_field_idx` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use super::util::{ chunk_data_idx, height_field_idx }; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `GenUnit2` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:3:20 [INFO] [stderr] | [INFO] [stderr] 3 | use ::gen::unit::{ GenUnit2, GenUnit3 }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOME_BLOCK_MUTATE_SEED: u32 = 77236476; [INFO] [stderr] | ^^^^^^^^ help: consider: `77_236_476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Rand`, `SeedableRng` [INFO] [stderr] --> src/generators/vanilla/caves.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use ::rand::{ Rng, Rand, XorShiftRng, SeedableRng }; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `norm` [INFO] [stderr] --> src/generators/vanilla/caves.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | use ::nalgebra::{ cast, norm }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Vec3` [INFO] [stderr] --> src/generators/vanilla/caves.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | use ::nalgebra::{ Pnt2, Pnt3, Vec2, Vec3 }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generators/vanilla/caves.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | const CAVE_GEN_RAND_SALT: u64 = 87462348731267; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `87_462_348_731_267` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/generators/vanilla/caves.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | let range_blocks = (RANGE_CHUNKS*16 - 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Rand` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use ::rand::{ Rng, Rand }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rnd/mod.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | const LCG_MULT: u64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rnd/mod.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const LCG_ADD: u64 = 1442695040888963407; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rnd/mod.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const INIT_VAL: u64 = 781637684348; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `781_637_684_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `::num::Float` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use ::num::Float; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `size` [INFO] [stderr] --> src/generators/vanilla/height_field.rs:50:50 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn sample_biome_range(biomes: &GenUnit2, size: Vec2, pos: Pnt2) -> (f64, f64) { [INFO] [stderr] | ^^^^ help: consider using `_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | fn make_biome_index(pos: Pnt2, temp: f32, wet: f32) -> (u8, u8) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wet` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | let (temp, wet) = data; [INFO] [stderr] | ^^^ help: consider using `_wet` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | fn make_biome_val(pos: Pnt2, data: (u8, u8)) -> u8 { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_source` [INFO] [stderr] --> src/generators/vanilla/caves.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | for current_source in 0..source_num { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_current_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_cave` [INFO] [stderr] --> src/generators/vanilla/caves.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | for current_cave in 0..num_caves { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_current_cave` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr` [INFO] [stderr] --> src/generators/vanilla/caves.rs:262:22 [INFO] [stderr] | [INFO] [stderr] 262 | fn block_is_carvable(curr: u8, above: u8) -> bool { [INFO] [stderr] | ^^^^ help: consider using `_curr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | for num in 0..octaves { [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_pos` [INFO] [stderr] --> src/gen/unit.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | for x_pos in 0..size.x { [INFO] [stderr] | ^^^^^ help: consider using `_x_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z_pos` [INFO] [stderr] --> src/gen/unit.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | for z_pos in 0..size.z { [INFO] [stderr] | ^^^^^ help: consider using `_z_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_pos` [INFO] [stderr] --> src/gen/unit.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | for y_pos in 0..size.y { [INFO] [stderr] | ^^^^^ help: consider using `_y_pos` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/generators/vanilla/biomes.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let mut temp_src = GenSimplex::new(1, 16.0, SimplexNoiseType::Normalized); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/generators/vanilla/biomes.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let mut wet_src = GenSimplex::new(2, 16.0, SimplexNoiseType::Normalized); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/generators/vanilla/biomes.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let mut biome_idx = GenSimpleFnMixer::new(make_biome_index, temp_src, wet_src); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLOCK_STONE` [INFO] [stderr] --> src/generators/vanilla/caves.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | const BLOCK_STONE: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLOCK_FLOWING_LAVA` [INFO] [stderr] --> src/generators/vanilla/caves.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const BLOCK_FLOWING_LAVA: u8 = 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `fillin_noise` [INFO] [stderr] --> src/generators/vanilla/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fillin_noise: OctavesSeed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `topsoil_depth_noise` [INFO] [stderr] --> src/generators/vanilla/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | topsoil_depth_noise: OctavesSeed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `octaves` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | octaves: u32, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.523_03e-1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.729_034_8e1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.121_222_4e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.770_987_1e1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.834_479e-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.384_104_8e1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.549_702_1e-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:55 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4.017_388e-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.722_745_7e-3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.290_258_6e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4.935_431_3e-3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/lcg.rs:49:61 [INFO] [stderr] | [INFO] [stderr] 49 | let mut number = (self.pos_seed >> 24).wrapping_rem(max as i64) as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_island.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | lcg.seed_pos((pos.x+x as i32) as i64, (pos.y+y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.x+x as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_island.rs:26:55 [INFO] [stderr] | [INFO] [stderr] 26 | lcg.seed_pos((pos.x+x as i32) as i64, (pos.y+y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.y+y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/layer/layer_zoom.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | else if i1 == i2 && i2 == i4 { i1 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/layer/layer_zoom.rs:8:34 [INFO] [stderr] | [INFO] [stderr] 8 | else if i1 == i2 && i2 == i3 { i1 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((sink_sample_y+0) * source_w)` [INFO] [stderr] --> src/layer/layer_zoom.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | source_buf[(0+0 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0` [INFO] [stderr] --> src/layer/layer_zoom.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | source_buf[(0+0 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `sink_sample_y` [INFO] [stderr] --> src/layer/layer_zoom.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | source_buf[(0+0 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((sink_sample_y+1) * source_w)` [INFO] [stderr] --> src/layer/layer_zoom.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | source_buf[(0+0 + ((sink_sample_y+1) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0` [INFO] [stderr] --> src/layer/layer_zoom.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | source_buf[(0+0 + ((sink_sample_y+1) * source_w)) as usize]; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_zoom.rs:76:30 [INFO] [stderr] | [INFO] [stderr] 76 | lcg.seed_pos((sink_sample_x as i32 + (source_x << 1)) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sink_sample_x as i32 + (source_x << 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_zoom.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | ((sink_sample_y as i32 + source_y) << 1) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((sink_sample_y as i32 + source_y) << 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `sink_sample_y` [INFO] [stderr] --> src/layer/layer_zoom.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | (sink_sample_x+1 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | lcg.seed_pos((pos.x + x as i32) as i64, (pos.y + y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.x + x as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:35:57 [INFO] [stderr] | [INFO] [stderr] 35 | lcg.seed_pos((pos.x + x as i32) as i64, (pos.y + y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.y + y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/lerp.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | let RANGE_INV_Y: f64 = 1.0/(scale[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `RANGE_INV_Y` should have a snake case name such as `range_inv_y` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let RANGE_INV_Y: f64 = 1.0/(scale[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/lerp.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | let RANGE_INV_Z: f64 = 1.0/(scale[2] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `RANGE_INV_Z` should have a snake case name such as `range_inv_z` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let RANGE_INV_Z: f64 = 1.0/(scale[2] as f64); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/lerp.rs:75:52 [INFO] [stderr] | [INFO] [stderr] 75 | let RANGE_INV_X: f64 = 1.0/(scale[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `RANGE_INV_X` should have a snake case name such as `range_inv_x` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | let RANGE_INV_X: f64 = 1.0/(scale[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let fillin_noise_pos = [pos[0] as f64, 0.0, pos[1] as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:128:49 [INFO] [stderr] | [INFO] [stderr] 128 | let fillin_noise_pos = [pos[0] as f64, 0.0, pos[1] as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:182:39 [INFO] [stderr] | [INFO] [stderr] 182 | let mut val = ((((out_buf_height as f64 - depth_noise_abs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(out_buf_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | let factor = (out_buf_height as f64 - 29.0) / 3.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(out_buf_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | let x_f = x as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | let y_f = y as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | &[(scaled[0]+(x_pos as f64*scale[0]))/8192.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | (scaled[1]+(y_pos as f64*scale[1]))/8192.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(y_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | (scaled[2]+(z_pos as f64*scale[2]))/8192.0]) * mult; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(z_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:14:86 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn mutate_chunk(world_state: &WorldGeneratorState, blocks: &mut [u8], chunk_pos: &[i32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[i32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | glob_pos: &[i32; 2], pos: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[i32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:26:54 [INFO] [stderr] | [INFO] [stderr] 26 | glob_pos: &[i32; 2], pos: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/generators/vanilla/caves.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | for current_x in (chunk_pos[0]-range)..(chunk_pos[0]+range+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((chunk_pos[0]-range)..=chunk_pos[0]+range)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/generators/vanilla/caves.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | for current_y in (chunk_pos[1]-range)..(chunk_pos[1]+range+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((chunk_pos[1]-range)..=chunk_pos[1]+range)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | .mix(world_seed as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(world_seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generators/vanilla/caves.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / let mut source_num = { [INFO] [stderr] 47 | | let t1 = rand.gen_range(0, 15); [INFO] [stderr] 48 | | let t2 = rand.gen_range(0, t1 + 1); [INFO] [stderr] 49 | | rand.gen_range(0, t2 + 1) [INFO] [stderr] ... | [INFO] [stderr] 52 | | source_num = 0; [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 46 | let source_num = if !rand.gen_weighted_bool(7) { 0 } else { { [INFO] [stderr] 47 | let t1 = rand.gen_range(0, 15); [INFO] [stderr] 48 | let t2 = rand.gen_range(0, t1 + 1); [INFO] [stderr] 49 | rand.gen_range(0, t2 + 1) [INFO] [stderr] 50 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/generators/vanilla/caves.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn carve_cave(chunk_data: &mut GenUnit3, rand: &mut R, chunk_pos: Pnt2, [INFO] [stderr] 94 | | cave_pos_start: Pnt3, cave_angle_start: &[f32; 2], [INFO] [stderr] 95 | | mut cave_len_progress: i32, mut cave_len_total: i32, [INFO] [stderr] 96 | | horizontal_stretch: f32, vertical_stretch: f32) where R: Rng { [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/caves.rs:94:67 [INFO] [stderr] | [INFO] [stderr] 94 | cave_pos_start: Pnt3, cave_angle_start: &[f32; 2], [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generators/vanilla/caves.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / let mut unforkable_cave = false; [INFO] [stderr] 110 | | if cave_len_progress == -1 { [INFO] [stderr] 111 | | cave_len_progress = cave_len_total / 2; [INFO] [stderr] 112 | | unforkable_cave = true; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let unforkable_cave = if cave_len_progress == -1 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | pos[0] += (ang[1].cos() * pitch_value_x) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ang[1].cos() * pitch_value_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pos[1] += pitch_value_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pitch_value_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | pos[2] += (ang[1].sin() * pitch_value_x) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ang[1].sin() * pitch_value_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:162:66 [INFO] [stderr] | [INFO] [stderr] 162 | if center_dist[0].powi(2) + center_dist[1].powi(2) - (cave_len_left as f64).powi(2) > (max_carve_size as f64).powi(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cave_len_left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:162:99 [INFO] [stderr] | [INFO] [stderr] 162 | if center_dist[0].powi(2) + center_dist[1].powi(2) - (cave_len_left as f64).powi(2) > (max_carve_size as f64).powi(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_carve_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:167:27 [INFO] [stderr] | [INFO] [stderr] 167 | - 16.0 - (horizontal_scale_factor as f64 * 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:169:27 [INFO] [stderr] | [INFO] [stderr] 169 | + 16.0 + (horizontal_scale_factor as f64 * 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | (pos.x - horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:173:28 [INFO] [stderr] | [INFO] [stderr] 173 | - (chunk_pos[0] as i64 * 16) - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:174:30 [INFO] [stderr] | [INFO] [stderr] 174 | (pos.y - vertical_scale_factor as f64).floor() as i64 - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertical_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | (pos.z - horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | - (chunk_pos[1] as i64 * 16) - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:178:30 [INFO] [stderr] | [INFO] [stderr] 178 | (pos.x + horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:179:28 [INFO] [stderr] | [INFO] [stderr] 179 | - (chunk_pos[0] as i64 * 16) + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:180:30 [INFO] [stderr] | [INFO] [stderr] 180 | (pos.y + vertical_scale_factor as f64).floor() as i64 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertical_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:181:30 [INFO] [stderr] | [INFO] [stderr] 181 | (pos.z + horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:182:28 [INFO] [stderr] | [INFO] [stderr] 182 | - (chunk_pos[1] as i64 * 16) + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:211:42 [INFO] [stderr] | [INFO] [stderr] 211 | let x_norm_pos_dist = ((curr_x + chunk_pos[0] as i64 * 16) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:212:50 [INFO] [stderr] | [INFO] [stderr] 212 | + 0.5 - pos[0]) / horizontal_scale_factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:215:46 [INFO] [stderr] | [INFO] [stderr] 215 | let z_norm_pos_dist = ((curr_z + chunk_pos[1] as i64 * 16) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:216:54 [INFO] [stderr] | [INFO] [stderr] 216 | + 0.5 - pos[2]) / horizontal_scale_factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:223:61 [INFO] [stderr] | [INFO] [stderr] 223 | + 0.5 - pos[1]) / vertical_scale_factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertical_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/mod.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn test_generate_chunk(chunk_pos: &[i32; 2]) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[i32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | seeds: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: item `gen::unit::GenUnit` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/gen/unit.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / impl GenUnit { [INFO] [stderr] 17 | | pub fn new3(size: Vec3, default: N) -> GenUnit where N: Clone { [INFO] [stderr] 18 | | let capacity: usize = cast(size.x * size.y * size.z); [INFO] [stderr] 19 | | GenUnit { [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/gen/unit.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn from_idx(&self, mut idx: usize) -> Pnt3 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `voxel_worldgen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `6.523_029_87e-01` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.729_034_89e+01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.121_222_37e+00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `2.770_987_05e+01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `6.834_479_08e-01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.384_104_86e+01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1.549_702_18e-01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:28:55 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `4.017_387_91e-01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `3.722_745_65e-03` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `2.290_258_65e+00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simplex_normalized.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `4.935_431_17e-03` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layer/lcg.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | const LCG_MULT: i64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layer/lcg.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | const LCG_ADD: i64 = 1442695040888963407; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Rand` [INFO] [stderr] --> src/generators/vanilla/mod.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | use ::rand::{ Rng, Rand }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `chunk_data_idx`, `height_field_idx` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use super::util::{ chunk_data_idx, height_field_idx }; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `GenUnit2` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:3:20 [INFO] [stderr] | [INFO] [stderr] 3 | use ::gen::unit::{ GenUnit2, GenUnit3 }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | const BIOME_BLOCK_MUTATE_SEED: u32 = 77236476; [INFO] [stderr] | ^^^^^^^^ help: consider: `77_236_476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Rand`, `SeedableRng` [INFO] [stderr] --> src/generators/vanilla/caves.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use ::rand::{ Rng, Rand, XorShiftRng, SeedableRng }; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `norm` [INFO] [stderr] --> src/generators/vanilla/caves.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | use ::nalgebra::{ cast, norm }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Vec3` [INFO] [stderr] --> src/generators/vanilla/caves.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | use ::nalgebra::{ Pnt2, Pnt3, Vec2, Vec3 }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generators/vanilla/caves.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | const CAVE_GEN_RAND_SALT: u64 = 87462348731267; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `87_462_348_731_267` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/generators/vanilla/caves.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | let range_blocks = (RANGE_CHUNKS*16 - 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Rand` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use ::rand::{ Rng, Rand }; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rnd/mod.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | const LCG_MULT: u64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rnd/mod.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const LCG_ADD: u64 = 1442695040888963407; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rnd/mod.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const INIT_VAL: u64 = 781637684348; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `781_637_684_348` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `::num::Float` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use ::num::Float; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `size` [INFO] [stderr] --> src/generators/vanilla/height_field.rs:50:50 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn sample_biome_range(biomes: &GenUnit2, size: Vec2, pos: Pnt2) -> (f64, f64) { [INFO] [stderr] | ^^^^ help: consider using `_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | fn make_biome_index(pos: Pnt2, temp: f32, wet: f32) -> (u8, u8) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wet` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | let (temp, wet) = data; [INFO] [stderr] | ^^^ help: consider using `_wet` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/generators/vanilla/biomes.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | fn make_biome_val(pos: Pnt2, data: (u8, u8)) -> u8 { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_source` [INFO] [stderr] --> src/generators/vanilla/caves.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | for current_source in 0..source_num { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_current_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_cave` [INFO] [stderr] --> src/generators/vanilla/caves.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | for current_cave in 0..num_caves { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_current_cave` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr` [INFO] [stderr] --> src/generators/vanilla/caves.rs:262:22 [INFO] [stderr] | [INFO] [stderr] 262 | fn block_is_carvable(curr: u8, above: u8) -> bool { [INFO] [stderr] | ^^^^ help: consider using `_curr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | for num in 0..octaves { [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_pos` [INFO] [stderr] --> src/gen/unit.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | for x_pos in 0..size.x { [INFO] [stderr] | ^^^^^ help: consider using `_x_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z_pos` [INFO] [stderr] --> src/gen/unit.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | for z_pos in 0..size.z { [INFO] [stderr] | ^^^^^ help: consider using `_z_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_pos` [INFO] [stderr] --> src/gen/unit.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | for y_pos in 0..size.y { [INFO] [stderr] | ^^^^^ help: consider using `_y_pos` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/generators/vanilla/biomes.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let mut temp_src = GenSimplex::new(1, 16.0, SimplexNoiseType::Normalized); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/generators/vanilla/biomes.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let mut wet_src = GenSimplex::new(2, 16.0, SimplexNoiseType::Normalized); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/generators/vanilla/biomes.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let mut biome_idx = GenSimpleFnMixer::new(make_biome_index, temp_src, wet_src); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLOCK_STONE` [INFO] [stderr] --> src/generators/vanilla/caves.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | const BLOCK_STONE: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLOCK_FLOWING_LAVA` [INFO] [stderr] --> src/generators/vanilla/caves.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | const BLOCK_FLOWING_LAVA: u8 = 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `fillin_noise` [INFO] [stderr] --> src/generators/vanilla/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fillin_noise: OctavesSeed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `topsoil_depth_noise` [INFO] [stderr] --> src/generators/vanilla/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | topsoil_depth_noise: OctavesSeed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `octaves` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | octaves: u32, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.523_03e-1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.729_034_8e1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.121_222_4e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:27:55 [INFO] [stderr] | [INFO] [stderr] 27 | 6.52302987e-01, -1.72903489e+01, -1.12122237e+00, 2.77098705e+01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.770_987_1e1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.834_479e-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.384_104_8e1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.549_702_1e-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:28:55 [INFO] [stderr] | [INFO] [stderr] 28 | 6.83447908e-01, -1.38410486e+01, -1.54970218e-01, 4.01738791e-01, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4.017_388e-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.722_745_7e-3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.290_258_6e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/simplex_normalized.rs:29:38 [INFO] [stderr] | [INFO] [stderr] 29 | -3.72274565e-03, 2.29025865e+00, 4.93543117e-03]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4.935_431_3e-3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/lcg.rs:49:61 [INFO] [stderr] | [INFO] [stderr] 49 | let mut number = (self.pos_seed >> 24).wrapping_rem(max as i64) as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_island.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | lcg.seed_pos((pos.x+x as i32) as i64, (pos.y+y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.x+x as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_island.rs:26:55 [INFO] [stderr] | [INFO] [stderr] 26 | lcg.seed_pos((pos.x+x as i32) as i64, (pos.y+y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.y+y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/layer/layer_zoom.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | else if i1 == i2 && i2 == i4 { i1 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/layer/layer_zoom.rs:8:34 [INFO] [stderr] | [INFO] [stderr] 8 | else if i1 == i2 && i2 == i3 { i1 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((sink_sample_y+0) * source_w)` [INFO] [stderr] --> src/layer/layer_zoom.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | source_buf[(0+0 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0` [INFO] [stderr] --> src/layer/layer_zoom.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | source_buf[(0+0 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `sink_sample_y` [INFO] [stderr] --> src/layer/layer_zoom.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | source_buf[(0+0 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((sink_sample_y+1) * source_w)` [INFO] [stderr] --> src/layer/layer_zoom.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | source_buf[(0+0 + ((sink_sample_y+1) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0` [INFO] [stderr] --> src/layer/layer_zoom.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | source_buf[(0+0 + ((sink_sample_y+1) * source_w)) as usize]; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_zoom.rs:76:30 [INFO] [stderr] | [INFO] [stderr] 76 | lcg.seed_pos((sink_sample_x as i32 + (source_x << 1)) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sink_sample_x as i32 + (source_x << 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_zoom.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | ((sink_sample_y as i32 + source_y) << 1) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((sink_sample_y as i32 + source_y) << 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `sink_sample_y` [INFO] [stderr] --> src/layer/layer_zoom.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | (sink_sample_x+1 + ((sink_sample_y+0) * source_w)) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | lcg.seed_pos((pos.x + x as i32) as i64, (pos.y + y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.x + x as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/layer/layer_remove_ocean.rs:35:57 [INFO] [stderr] | [INFO] [stderr] 35 | lcg.seed_pos((pos.x + x as i32) as i64, (pos.y + y as i32) as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pos.y + y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/lerp.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | let RANGE_INV_Y: f64 = 1.0/(scale[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `RANGE_INV_Y` should have a snake case name such as `range_inv_y` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let RANGE_INV_Y: f64 = 1.0/(scale[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/lerp.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | let RANGE_INV_Z: f64 = 1.0/(scale[2] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `RANGE_INV_Z` should have a snake case name such as `range_inv_z` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let RANGE_INV_Z: f64 = 1.0/(scale[2] as f64); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/lerp.rs:75:52 [INFO] [stderr] | [INFO] [stderr] 75 | let RANGE_INV_X: f64 = 1.0/(scale[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `RANGE_INV_X` should have a snake case name such as `range_inv_x` [INFO] [stderr] --> src/generators/vanilla/lerp.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | let RANGE_INV_X: f64 = 1.0/(scale[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let fillin_noise_pos = [pos[0] as f64, 0.0, pos[1] as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:128:49 [INFO] [stderr] | [INFO] [stderr] 128 | let fillin_noise_pos = [pos[0] as f64, 0.0, pos[1] as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:182:39 [INFO] [stderr] | [INFO] [stderr] 182 | let mut val = ((((out_buf_height as f64 - depth_noise_abs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(out_buf_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/height_field.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | let factor = (out_buf_height as f64 - 29.0) / 3.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(out_buf_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | let x_f = x as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | let y_f = y as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | &[(scaled[0]+(x_pos as f64*scale[0]))/8192.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | (scaled[1]+(y_pos as f64*scale[1]))/8192.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(y_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/util.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | (scaled[2]+(z_pos as f64*scale[2]))/8192.0]) * mult; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(z_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:14:86 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn mutate_chunk(world_state: &WorldGeneratorState, blocks: &mut [u8], chunk_pos: &[i32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[i32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | glob_pos: &[i32; 2], pos: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[i32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/biome_block_mutate.rs:26:54 [INFO] [stderr] | [INFO] [stderr] 26 | glob_pos: &[i32; 2], pos: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/generators/vanilla/caves.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | for current_x in (chunk_pos[0]-range)..(chunk_pos[0]+range+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((chunk_pos[0]-range)..=chunk_pos[0]+range)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/generators/vanilla/caves.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | for current_y in (chunk_pos[1]-range)..(chunk_pos[1]+range+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((chunk_pos[1]-range)..=chunk_pos[1]+range)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | .mix(world_seed as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(world_seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generators/vanilla/caves.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / let mut source_num = { [INFO] [stderr] 47 | | let t1 = rand.gen_range(0, 15); [INFO] [stderr] 48 | | let t2 = rand.gen_range(0, t1 + 1); [INFO] [stderr] 49 | | rand.gen_range(0, t2 + 1) [INFO] [stderr] ... | [INFO] [stderr] 52 | | source_num = 0; [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 46 | let source_num = if !rand.gen_weighted_bool(7) { 0 } else { { [INFO] [stderr] 47 | let t1 = rand.gen_range(0, 15); [INFO] [stderr] 48 | let t2 = rand.gen_range(0, t1 + 1); [INFO] [stderr] 49 | rand.gen_range(0, t2 + 1) [INFO] [stderr] 50 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/generators/vanilla/caves.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn carve_cave(chunk_data: &mut GenUnit3, rand: &mut R, chunk_pos: Pnt2, [INFO] [stderr] 94 | | cave_pos_start: Pnt3, cave_angle_start: &[f32; 2], [INFO] [stderr] 95 | | mut cave_len_progress: i32, mut cave_len_total: i32, [INFO] [stderr] 96 | | horizontal_stretch: f32, vertical_stretch: f32) where R: Rng { [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/caves.rs:94:67 [INFO] [stderr] | [INFO] [stderr] 94 | cave_pos_start: Pnt3, cave_angle_start: &[f32; 2], [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generators/vanilla/caves.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / let mut unforkable_cave = false; [INFO] [stderr] 110 | | if cave_len_progress == -1 { [INFO] [stderr] 111 | | cave_len_progress = cave_len_total / 2; [INFO] [stderr] 112 | | unforkable_cave = true; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let unforkable_cave = if cave_len_progress == -1 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:127:23 [INFO] [stderr] | [INFO] [stderr] 127 | pos[0] += (ang[1].cos() * pitch_value_x) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ang[1].cos() * pitch_value_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pos[1] += pitch_value_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pitch_value_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | pos[2] += (ang[1].sin() * pitch_value_x) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ang[1].sin() * pitch_value_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:162:66 [INFO] [stderr] | [INFO] [stderr] 162 | if center_dist[0].powi(2) + center_dist[1].powi(2) - (cave_len_left as f64).powi(2) > (max_carve_size as f64).powi(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cave_len_left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:162:99 [INFO] [stderr] | [INFO] [stderr] 162 | if center_dist[0].powi(2) + center_dist[1].powi(2) - (cave_len_left as f64).powi(2) > (max_carve_size as f64).powi(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_carve_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:167:27 [INFO] [stderr] | [INFO] [stderr] 167 | - 16.0 - (horizontal_scale_factor as f64 * 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:169:27 [INFO] [stderr] | [INFO] [stderr] 169 | + 16.0 + (horizontal_scale_factor as f64 * 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:172:30 [INFO] [stderr] | [INFO] [stderr] 172 | (pos.x - horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:173:28 [INFO] [stderr] | [INFO] [stderr] 173 | - (chunk_pos[0] as i64 * 16) - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:174:30 [INFO] [stderr] | [INFO] [stderr] 174 | (pos.y - vertical_scale_factor as f64).floor() as i64 - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertical_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | (pos.z - horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | - (chunk_pos[1] as i64 * 16) - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:178:30 [INFO] [stderr] | [INFO] [stderr] 178 | (pos.x + horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:179:28 [INFO] [stderr] | [INFO] [stderr] 179 | - (chunk_pos[0] as i64 * 16) + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:180:30 [INFO] [stderr] | [INFO] [stderr] 180 | (pos.y + vertical_scale_factor as f64).floor() as i64 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertical_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:181:30 [INFO] [stderr] | [INFO] [stderr] 181 | (pos.z + horizontal_scale_factor as f64).floor() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:182:28 [INFO] [stderr] | [INFO] [stderr] 182 | - (chunk_pos[1] as i64 * 16) + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:211:42 [INFO] [stderr] | [INFO] [stderr] 211 | let x_norm_pos_dist = ((curr_x + chunk_pos[0] as i64 * 16) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:212:50 [INFO] [stderr] | [INFO] [stderr] 212 | + 0.5 - pos[0]) / horizontal_scale_factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:215:46 [INFO] [stderr] | [INFO] [stderr] 215 | let z_norm_pos_dist = ((curr_z + chunk_pos[1] as i64 * 16) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(chunk_pos[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:216:54 [INFO] [stderr] | [INFO] [stderr] 216 | + 0.5 - pos[2]) / horizontal_scale_factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(horizontal_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generators/vanilla/caves.rs:223:61 [INFO] [stderr] | [INFO] [stderr] 223 | + 0.5 - pos[1]) / vertical_scale_factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertical_scale_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generators/vanilla/mod.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn test_generate_chunk(chunk_pos: &[i32; 2]) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[i32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/rnd/simplex_octaves.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | seeds: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: item `gen::unit::GenUnit` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/gen/unit.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / impl GenUnit { [INFO] [stderr] 17 | | pub fn new3(size: Vec3, default: N) -> GenUnit where N: Clone { [INFO] [stderr] 18 | | let capacity: usize = cast(size.x * size.y * size.z); [INFO] [stderr] 19 | | GenUnit { [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/gen/unit.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn from_idx(&self, mut idx: usize) -> Pnt3 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `voxel_worldgen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bea039cca691cefb59be92f835be695318c49f64a54a93bf188ca443003d1cea"` [INFO] running `"docker" "rm" "-f" "bea039cca691cefb59be92f835be695318c49f64a54a93bf188ca443003d1cea"` [INFO] [stdout] bea039cca691cefb59be92f835be695318c49f64a54a93bf188ca443003d1cea