[INFO] crate voronoi 0.1.4 is already in cache [INFO] extracting crate voronoi 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/voronoi/0.1.4 [INFO] extracting crate voronoi 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voronoi/0.1.4 [INFO] validating manifest of voronoi-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of voronoi-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing voronoi-0.1.4 [INFO] finished frobbing voronoi-0.1.4 [INFO] frobbed toml for voronoi-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/voronoi/0.1.4/Cargo.toml [INFO] started frobbing voronoi-0.1.4 [INFO] finished frobbing voronoi-0.1.4 [INFO] frobbed toml for voronoi-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voronoi/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting voronoi-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/voronoi/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91341487480f23d4fb17df73490a22a320249ec52d41b3da0f3ab18bd1d508e0 [INFO] running `"docker" "start" "-a" "91341487480f23d4fb17df73490a22a320249ec52d41b3da0f3ab18bd1d508e0"` [INFO] [stderr] Checking voronoi v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometry.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let t = numer_a / denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geometry.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let u = numer_c / denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:41:72 [INFO] [stderr] | [INFO] [stderr] 41 | BeachNode { parent: None, left_child: None, right_child: None, item: item} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | BeachNode { parent: parent, left_child: None, right_child: None, item: item} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:46:78 [INFO] [stderr] | [INFO] [stderr] 46 | BeachNode { parent: parent, left_child: None, right_child: None, item: item} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | Arc { site: site, site_event: site_event } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | Arc { site: site, site_event: site_event } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `site_event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | BreakPoint { left_site: left_site, right_site: right_site, halfedge: halfedge } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | BreakPoint { left_site: left_site, right_site: right_site, halfedge: halfedge } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:98:68 [INFO] [stderr] | [INFO] [stderr] 98 | BreakPoint { left_site: left_site, right_site: right_site, halfedge: halfedge } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `halfedge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voronoi.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | let node_AB = BeachNode { parent: parent, left_child: Some(ind_A1), right_child: Some(ind_BA), item: internal_AB}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometry.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let t = numer_a / denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geometry.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let u = numer_c / denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:41:72 [INFO] [stderr] | [INFO] [stderr] 41 | BeachNode { parent: None, left_child: None, right_child: None, item: item} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | BeachNode { parent: parent, left_child: None, right_child: None, item: item} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:46:78 [INFO] [stderr] | [INFO] [stderr] 46 | BeachNode { parent: parent, left_child: None, right_child: None, item: item} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | Arc { site: site, site_event: site_event } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | Arc { site: site, site_event: site_event } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `site_event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | BreakPoint { left_site: left_site, right_site: right_site, halfedge: halfedge } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | BreakPoint { left_site: left_site, right_site: right_site, halfedge: halfedge } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/beachline.rs:98:68 [INFO] [stderr] | [INFO] [stderr] 98 | BreakPoint { left_site: left_site, right_site: right_site, halfedge: halfedge } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `halfedge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/voronoi.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | let node_AB = BeachNode { parent: parent, left_child: Some(ind_A1), right_child: Some(ind_BA), item: internal_AB}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return Some(a + r * t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(a + r * t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return Some(OrderedFloat::(y_cen - r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(OrderedFloat::(y_cen - r))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(Point::new(x_cen, y_cen)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Point::new(x_cen, y_cen))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return x_bp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `x_bp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return numer / denom + (py + yl) / 2.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numer / denom + (py + yl) / 2.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | if self.y > other.y { return Ordering::Greater; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | if self.x < other.x { return Ordering::Greater; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | else if self.x == other.x { return Ordering::Equal; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | else { return Ordering::Less; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Less` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | } else { return Ordering::Less; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Less` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return self.vertices[origin_ind].coordinates; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.vertices[origin_ind].coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:317:5 [INFO] [stderr] | [INFO] [stderr] 317 | return intersections; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `intersections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dcel.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / if halfedge.origin != NIL && halfedge.next != NIL && halfedge.alive { [INFO] [stderr] 325 | | if dcel.halfedges[halfedge.next].origin != NIL { [INFO] [stderr] 326 | | result.push([dcel.vertices[halfedge.origin].coordinates, [INFO] [stderr] 327 | | dcel.get_origin(halfedge.next)]) [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 324 | if halfedge.origin != NIL && halfedge.next != NIL && halfedge.alive && dcel.halfedges[halfedge.next].origin != NIL { [INFO] [stderr] 325 | result.push([dcel.vertices[halfedge.origin].coordinates, [INFO] [stderr] 326 | dcel.get_origin(halfedge.next)]) [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/beachline.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return current_parent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/voronoi.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/voronoi.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | return ind_B; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ind_B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return Some(a + r * t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(a + r * t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return Some(OrderedFloat::(y_cen - r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(OrderedFloat::(y_cen - r))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(Point::new(x_cen, y_cen)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Point::new(x_cen, y_cen))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return x_bp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `x_bp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return numer / denom + (py + yl) / 2.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numer / denom + (py + yl) / 2.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | if self.y > other.y { return Ordering::Greater; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | if self.x < other.x { return Ordering::Greater; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | else if self.x == other.x { return Ordering::Equal; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | else { return Ordering::Less; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Less` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/point.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | } else { return Ordering::Less; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Less` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return self.vertices[origin_ind].coordinates; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.vertices[origin_ind].coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:317:5 [INFO] [stderr] | [INFO] [stderr] 317 | return intersections; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `intersections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dcel.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / if halfedge.origin != NIL && halfedge.next != NIL && halfedge.alive { [INFO] [stderr] 325 | | if dcel.halfedges[halfedge.next].origin != NIL { [INFO] [stderr] 326 | | result.push([dcel.vertices[halfedge.origin].coordinates, [INFO] [stderr] 327 | | dcel.get_origin(halfedge.next)]) [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 324 | if halfedge.origin != NIL && halfedge.next != NIL && halfedge.alive && dcel.halfedges[halfedge.next].origin != NIL { [INFO] [stderr] 325 | result.push([dcel.vertices[halfedge.origin].coordinates, [INFO] [stderr] 326 | dcel.get_origin(halfedge.next)]) [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dcel.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/beachline.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return current_parent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/voronoi.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/voronoi.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | return ind_B; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ind_B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/geometry.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let None = circle_center { return None; } [INFO] [stderr] | -------^^^^--------------------------------- help: try this: `if circle_center.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dcel::DCEL` [INFO] [stderr] --> src/dcel.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | DCEL {vertices: vec![], [INFO] [stderr] 21 | | halfedges: vec![], [INFO] [stderr] 22 | | faces: vec![]} [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/dcel.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | seen_edges[current_ind]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seen_edges;current_ind;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dcel::HalfEdge` [INFO] [stderr] --> src/dcel.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new() -> Self { [INFO] [stderr] 170 | | HalfEdge {origin: NIL, twin: NIL, next: NIL, face: NIL, prev: NIL, alive: true} [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 149 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lloyd.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn polygon_centroid(pts: &Vec) -> Point { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/geometry.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let None = circle_center { return None; } [INFO] [stderr] | -------^^^^--------------------------------- help: try this: `if circle_center.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dcel::DCEL` [INFO] [stderr] --> src/dcel.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | DCEL {vertices: vec![], [INFO] [stderr] 21 | | halfedges: vec![], [INFO] [stderr] 22 | | faces: vec![]} [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/dcel.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | seen_edges[current_ind]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seen_edges;current_ind;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dcel::HalfEdge` [INFO] [stderr] --> src/dcel.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new() -> Self { [INFO] [stderr] 170 | | HalfEdge {origin: NIL, twin: NIL, next: NIL, face: NIL, prev: NIL, alive: true} [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 149 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lloyd.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn polygon_centroid(pts: &Vec) -> Point { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/genvoronoi.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `voronoi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "91341487480f23d4fb17df73490a22a320249ec52d41b3da0f3ab18bd1d508e0"` [INFO] running `"docker" "rm" "-f" "91341487480f23d4fb17df73490a22a320249ec52d41b3da0f3ab18bd1d508e0"` [INFO] [stdout] 91341487480f23d4fb17df73490a22a320249ec52d41b3da0f3ab18bd1d508e0