[INFO] crate voluntary-servitude 3.0.8 is already in cache [INFO] extracting crate voluntary-servitude 3.0.8 into work/ex/clippy-test-run/sources/stable/reg/voluntary-servitude/3.0.8 [INFO] extracting crate voluntary-servitude 3.0.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voluntary-servitude/3.0.8 [INFO] validating manifest of voluntary-servitude-3.0.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of voluntary-servitude-3.0.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing voluntary-servitude-3.0.8 [INFO] finished frobbing voluntary-servitude-3.0.8 [INFO] frobbed toml for voluntary-servitude-3.0.8 written to work/ex/clippy-test-run/sources/stable/reg/voluntary-servitude/3.0.8/Cargo.toml [INFO] started frobbing voluntary-servitude-3.0.8 [INFO] finished frobbing voluntary-servitude-3.0.8 [INFO] frobbed toml for voluntary-servitude-3.0.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voluntary-servitude/3.0.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting voluntary-servitude-3.0.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/voluntary-servitude/3.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5670055653b932920da658c2d5132061177597317caf31b76c558c867ee2316 [INFO] running `"docker" "start" "-a" "f5670055653b932920da658c2d5132061177597317caf31b76c558c867ee2316"` [INFO] [stderr] Checking parking_lot v0.2.8 [INFO] [stderr] Checking voluntary-servitude v3.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/voluntary_servitude.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | nn [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/voluntary_servitude.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | let nn = NonNull::new(self.first_node.get_raw(Ordering::SeqCst)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/voluntary_servitude.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | len [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/voluntary_servitude.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | let len = self.size.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/voluntary_servitude.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | nn [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/voluntary_servitude.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | let nn = NonNull::new(self.first_node.get_raw(Ordering::SeqCst)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/voluntary_servitude.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | len [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/voluntary_servitude.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | let len = self.size.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/iterator.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | drop(iter); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &mut iterator::Iter [INFO] [stderr] --> src/iterator.rs:287:14 [INFO] [stderr] | [INFO] [stderr] 287 | drop(iter); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/iterator.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | drop(iter); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut iterator::Iter [INFO] [stderr] --> src/iterator.rs:291:14 [INFO] [stderr] | [INFO] [stderr] 291 | drop(iter); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/iterator.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | drop(iter2); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut iterator::Iter [INFO] [stderr] --> src/iterator.rs:307:14 [INFO] [stderr] | [INFO] [stderr] 307 | drop(iter2); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/iterator.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | drop(iter); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut iterator::Iter [INFO] [stderr] --> src/iterator.rs:309:14 [INFO] [stderr] | [INFO] [stderr] 309 | drop(iter); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/iterator.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | drop(iter1); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut iterator::Iter [INFO] [stderr] --> src/iterator.rs:310:14 [INFO] [stderr] | [INFO] [stderr] 310 | drop(iter1); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/iterator.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | drop(iter3); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut iterator::Iter [INFO] [stderr] --> src/iterator.rs:313:14 [INFO] [stderr] | [INFO] [stderr] 313 | drop(iter3); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `voluntary-servitude`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "f5670055653b932920da658c2d5132061177597317caf31b76c558c867ee2316"` [INFO] running `"docker" "rm" "-f" "f5670055653b932920da658c2d5132061177597317caf31b76c558c867ee2316"` [INFO] [stdout] f5670055653b932920da658c2d5132061177597317caf31b76c558c867ee2316