[INFO] crate volume 0.4.0 is already in cache [INFO] extracting crate volume 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/volume/0.4.0 [INFO] extracting crate volume 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/volume/0.4.0 [INFO] validating manifest of volume-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of volume-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing volume-0.4.0 [INFO] finished frobbing volume-0.4.0 [INFO] frobbed toml for volume-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/volume/0.4.0/Cargo.toml [INFO] started frobbing volume-0.4.0 [INFO] finished frobbing volume-0.4.0 [INFO] frobbed toml for volume-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/volume/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting volume-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/volume/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e88779fda598ac2fa5ea4df39e1d8ae6fe00ddd9300d24e30d40822e5c5fd774 [INFO] running `"docker" "start" "-a" "e88779fda598ac2fa5ea4df39e1d8ae6fe00ddd9300d24e30d40822e5c5fd774"` [INFO] [stderr] Checking petgraph v0.2.10 [INFO] [stderr] Checking time_calc v0.11.1 [INFO] [stderr] Checking daggy v0.4.1 [INFO] [stderr] Checking dsp-chain v0.13.1 [INFO] [stderr] Checking volume v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Frame` [INFO] [stderr] --> src/lib.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | use dsp::{Frame, Sample}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Volume` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Volume { [INFO] [stderr] 21 | | Volume { [INFO] [stderr] 22 | | maybe_prev: None, [INFO] [stderr] 23 | | current: 1.0, [INFO] [stderr] 24 | | interpolation_ms: 10.0, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | Some(prev) if prev != self.current && self.interpolation_ms > 0.0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(prev - self.current).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | Some(prev) if prev != self.current && self.interpolation_ms > 0.0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buffer`. [INFO] [stderr] --> src/lib.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | for idx in 0..interpolation_frames { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in buffer.iter_mut().take(interpolation_frames) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buffer`. [INFO] [stderr] --> src/lib.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | for idx in interpolation_frames..buffer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for in buffer.iter_mut().skip(interpolation_frames) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `volume`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `Frame` [INFO] [stderr] --> src/lib.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | use dsp::{Frame, Sample}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Volume` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Volume { [INFO] [stderr] 21 | | Volume { [INFO] [stderr] 22 | | maybe_prev: None, [INFO] [stderr] 23 | | current: 1.0, [INFO] [stderr] 24 | | interpolation_ms: 10.0, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | Some(prev) if prev != self.current && self.interpolation_ms > 0.0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(prev - self.current).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | Some(prev) if prev != self.current && self.interpolation_ms > 0.0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buffer`. [INFO] [stderr] --> src/lib.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | for idx in 0..interpolation_frames { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in buffer.iter_mut().take(interpolation_frames) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buffer`. [INFO] [stderr] --> src/lib.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | for idx in interpolation_frames..buffer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for in buffer.iter_mut().skip(interpolation_frames) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `volume`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e88779fda598ac2fa5ea4df39e1d8ae6fe00ddd9300d24e30d40822e5c5fd774"` [INFO] running `"docker" "rm" "-f" "e88779fda598ac2fa5ea4df39e1d8ae6fe00ddd9300d24e30d40822e5c5fd774"` [INFO] [stdout] e88779fda598ac2fa5ea4df39e1d8ae6fe00ddd9300d24e30d40822e5c5fd774