[INFO] crate voc-perturb 0.1.2 is already in cache [INFO] extracting crate voc-perturb 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/voc-perturb/0.1.2 [INFO] extracting crate voc-perturb 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voc-perturb/0.1.2 [INFO] validating manifest of voc-perturb-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of voc-perturb-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing voc-perturb-0.1.2 [INFO] finished frobbing voc-perturb-0.1.2 [INFO] frobbed toml for voc-perturb-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/voc-perturb/0.1.2/Cargo.toml [INFO] started frobbing voc-perturb-0.1.2 [INFO] finished frobbing voc-perturb-0.1.2 [INFO] frobbed toml for voc-perturb-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/voc-perturb/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting voc-perturb-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/voc-perturb/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8acb445ab57c1e4ffcfe9b7ab9f3aaa68538a4dcfa3260efc9e77cbf543f3824 [INFO] running `"docker" "start" "-a" "8acb445ab57c1e4ffcfe9b7ab9f3aaa68538a4dcfa3260efc9e77cbf543f3824"` [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking generic-array v0.2.1 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking clap v2.28.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking nalgebra v0.11.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quick-xml v0.10.1 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking imageproc v0.13.0 [INFO] [stderr] Checking voc-perturb v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser_state::ParserState` [INFO] [stderr] --> src/parser_state.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> ParserState { [INFO] [stderr] 13 | | ParserState::NoInterest [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for parser_state::ParserState { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | .expect(&format!("Failed to read xml file")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read xml file"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | .expect(&format!("Failed to read xml file")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to read xml file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match reader.read_event(&mut buf) { [INFO] [stderr] 44 | | Ok(Event::Text(bytes_text)) => { [INFO] [stderr] 45 | | let text = bytes_text [INFO] [stderr] 46 | | .unescape_and_decode(&reader) [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Ok(Event::Text(bytes_text)) = reader.read_event(&mut buf) { [INFO] [stderr] 44 | let text = bytes_text [INFO] [stderr] 45 | .unescape_and_decode(&reader) [INFO] [stderr] 46 | .expect("Failed to convert bytes to string"); [INFO] [stderr] 47 | let coordinate: i32 = text [INFO] [stderr] 48 | .parse() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | .expect(&format!("Failed to parse this: {}, are you sure it's a number?", &text)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse this: {}, are you sure it's a number?", &text))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match ps { [INFO] [stderr] 85 | | &ParserState::Xmin => v + delta_x, [INFO] [stderr] 86 | | &ParserState::Ymin => v + delta_y, [INFO] [stderr] 87 | | &ParserState::Xmax => v + delta_x, [INFO] [stderr] 88 | | &ParserState::Ymax => v + delta_y, [INFO] [stderr] 89 | | _ => v, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *ps { [INFO] [stderr] 85 | ParserState::Xmin => v + delta_x, [INFO] [stderr] 86 | ParserState::Ymin => v + delta_y, [INFO] [stderr] 87 | ParserState::Xmax => v + delta_x, [INFO] [stderr] 88 | ParserState::Ymax => v + delta_y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser_state::ParserState` [INFO] [stderr] --> src/parser_state.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> ParserState { [INFO] [stderr] 13 | | ParserState::NoInterest [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for parser_state::ParserState { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | .expect(&format!("Failed to read xml file")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read xml file"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | .expect(&format!("Failed to read xml file")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to read xml file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match reader.read_event(&mut buf) { [INFO] [stderr] 44 | | Ok(Event::Text(bytes_text)) => { [INFO] [stderr] 45 | | let text = bytes_text [INFO] [stderr] 46 | | .unescape_and_decode(&reader) [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Ok(Event::Text(bytes_text)) = reader.read_event(&mut buf) { [INFO] [stderr] 44 | let text = bytes_text [INFO] [stderr] 45 | .unescape_and_decode(&reader) [INFO] [stderr] 46 | .expect("Failed to convert bytes to string"); [INFO] [stderr] 47 | let coordinate: i32 = text [INFO] [stderr] 48 | .parse() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | .expect(&format!("Failed to parse this: {}, are you sure it's a number?", &text)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse this: {}, are you sure it's a number?", &text))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match ps { [INFO] [stderr] 85 | | &ParserState::Xmin => v + delta_x, [INFO] [stderr] 86 | | &ParserState::Ymin => v + delta_y, [INFO] [stderr] 87 | | &ParserState::Xmax => v + delta_x, [INFO] [stderr] 88 | | &ParserState::Ymax => v + delta_y, [INFO] [stderr] 89 | | _ => v, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *ps { [INFO] [stderr] 85 | ParserState::Xmin => v + delta_x, [INFO] [stderr] 86 | ParserState::Ymin => v + delta_y, [INFO] [stderr] 87 | ParserState::Xmax => v + delta_x, [INFO] [stderr] 88 | ParserState::Ymax => v + delta_y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `counter` is used as a loop counter. Consider using `for (counter, item) in dir_content.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | for entry in dir_content { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `counter` is used as a loop counter. Consider using `for (counter, item) in dir_content.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | for entry in dir_content { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.06s [INFO] running `"docker" "inspect" "8acb445ab57c1e4ffcfe9b7ab9f3aaa68538a4dcfa3260efc9e77cbf543f3824"` [INFO] running `"docker" "rm" "-f" "8acb445ab57c1e4ffcfe9b7ab9f3aaa68538a4dcfa3260efc9e77cbf543f3824"` [INFO] [stdout] 8acb445ab57c1e4ffcfe9b7ab9f3aaa68538a4dcfa3260efc9e77cbf543f3824